Files
msd-core/tests/ingest-docs.test.cjs
Tom Boucher 463cffd894 chore(#604): rename get-shit-done/ runtime directory to gsd-core/ (#615)
* chore(#604): rename get-shit-done/ runtime directory to gsd-core/

Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the
on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary
(`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers
are unaffected.

Mechanical (bulk, ~90% of the diff):
- `git mv get-shit-done gsd-core`
- Swept path/identifier references across the repo via
  `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead
  preserves the five legitimate slug variants that are NOT the directory:
  get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names).
- Build/manifest wiring: package.json (bin, files, coverage globs),
  tsconfig.build.json (outDir), ~86 .gitignore build-output entries,
  stryker.config.mjs, scan-ignore files, install.js path strings.
- Frozen (not rewritten): CHANGELOG.md history; translated docs
  (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/).

New logic (review here):
- src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper
  ADR-0008 installer migration. On upgrade it walks the legacy
  `~/.claude/get-shit-done/` tree, classifies each file via the prior install
  manifest, and emits remove-managed / backup-and-remove for managed files
  while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked
  root and symlinked entries; bounds-checks every path under configDir). The
  framework rolls back on install failure. Emptied dirs may remain (framework
  has no recursive dir-removal primitive) — documented.
- scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare
  `get-shit-done` directory token (split token to avoid self-match; case-
  insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists
  CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines).
  Wired into the lint-tests CI job.
- Restored scripts/lint-package-identity-drift.cjs detection regexes (the
  mechanical sweep had wrongly rewritten the old-name patterns it exists to
  detect) and marked them as intentional legacy references.
- TDD tests for the migration and the guard; do.md slash-command guard regex
  tightened so a `/gsd-core/bin` path segment is not mistaken for a command;
  changeset + docs/installer-migrations.md row added.

Breaking: the installed runtime path moves `~/.claude/get-shit-done/` ->
`~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed
files (preserving user files) on upgrade. Users with custom hooks/configs
hardcoding the old path must update them.

Closes #604

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): unsweep pending changesets + allowlist injection-example docs

CI fixes for the rename PR:
- Do not sweep pending .changeset/*.md (ephemeral release-note fragments,
  like CHANGELOG); reverted those body edits so 5 pre-existing malformed
  fragments (missing type/pr) no longer enter the PR diff and trip docs-lint.
  Allowlisted .changeset/ in the legacy-name guard accordingly.
- Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in
  prompt-injection-scan.sh: they contain intentional injection examples /
  security-model prose; the path-reference rewrites are kept.

CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR;
none in the new migration/guard) and are out of scope for the rename.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): resolve CodeQL alerts surfaced on this PR

The rename diff touched files carrying pre-existing CodeQL findings; per the
no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving
them off. All behavior-preserving:

- scripts/ci-test-scope.cjs: build the config-path match from string
  .includes() instead of a RegExp over an arg-derived value (js/regex-injection).
- src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName
  so the table-cell escape is complete (js/incomplete-sanitization).
- tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment
  strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization).
- tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace,
  keep the meaningful POSIX-class conversion (js/identity-replacement).

Verified: build:lib green; the touched test files + ci-test-scope + profile-output
suites pass; lint:legacy-name clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization)

The prior commit's fixes for two alerts were ineffective:
- ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file`
  reaching static regex `.test(file)` calls (not the config rule). Removed ALL
  regex over file/t — startsWith/includes/=== string checks + an isWindowsHint
  helper — so there is no regex sink for the tainted value.
- js/incomplete-multi-character-sanitization (3 test files): a single
  `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint
  loop (replace until stable) plus a final bare-opener strip.

Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass;
lint:legacy-name clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL

CodeQL flags the regex PATTERNS syntactically (regex-injection on the
--files arg split; incomplete-multi-character-sanitization on the <!--...-->
replace), so loop fixes do not satisfy it. Made these paths regex-free:
- ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/).
- 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)).
Behavior preserved; ci-test-scope + the 3 suites pass; guard clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): unblock security base64 scan on the large rename diff

The security job hit its 10m timeout: base64-scan.sh choked on the binary
test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/
non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings),
and the ~800-file rename diff is slow to scan regardless.

- scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they
  can't carry base64-obfuscated *text* and feeding NUL bytes through the
  per-line scanner is pathologically slow. collect_files already filtered
  binary *extensions*; this catches binary *content* in text extensions.
- .github/workflows/security-scan.yml: raise the security job timeout 10m->30m
  to accommodate very large diffs (the scan itself is unchanged).

Verified locally: scan skips the fixture, 0 "ignored null byte" warnings,
0 findings, exit 0.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): sweep get-shit-done refs introduced by merging next

The branch was updated with next (#614/#384/#618 etc.), which reference the
get-shit-done/ dir (still named that on next). Swept the stale references in
the merged files to gsd-core so the rename stays consistent and lint:legacy-name
passes:
- commands/gsd/discuss-phase.md (runtime-launcher shim paths)
- src/core.cts (getAgentsDir layout comments)
- tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib)

Verified: guard 0 violations; build green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant

The #614 runtime-launcher shim added to discuss-phase.md references
`${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y
refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it
mis-read the directory path as a dangling `/gsd-core` command ref (same class as
the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path
segments are not treated as slash-command references.

Verified locally on BOTH platforms before pushing:
- mac (node 26) full suite: 0 failures
- gsd-test-runner (linux, node22 image) full suite: 0 failures
- bug-3683 + bug-2954 pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI)

CI intermittently failed state.test's gsd-tools subprocess with
"findProjectRoot is not a function" (flip-flopping across legs; not reproducible
on mac full suite, gsd-test linux full suite, test:unit, or state.test x8).
findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs);
binding it via destructure at module-load can be undefined under a load-ordering
edge. Resolve it lazily at call time via a small wrapper so the lookup happens
after core.cjs is fully initialized.

Verified green on BOTH platforms before pushing:
- mac (node 26) full suite: 0 failures
- gsd-test-runner (linux, node22) full suite: 0 failures
- state.test.cjs: 106/106; gsd-tools loads cleanly.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): allowlist verification-patterns.md placeholder examples in secret scan

The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling
it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var
examples (illustrative Stripe test-key / database-URL / API-key placeholders) —
not real credentials. Added it to .secretscanignore with the strict annotation,
mirroring the existing gsd-core/workflows/plan-phase.md exception.

Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next
exits 0 with 0 findings.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-02 18:35:29 -04:00

315 lines
13 KiB
JavaScript

// allow-test-rule: source-text-is-the-product
// Reads .md/.json/.yml product files whose deployed text IS what the
// runtime loads — testing text content tests the deployed contract.
/**
* Ingest Docs Tests — ingest-docs.test.cjs
*
* Structural assertions for /gsd-ingest-docs (#2387). Agents and workflows
* are prompt-based; these tests guard the contract (files exist, frontmatter
* present, required references wired up, safety semantics preserved).
*/
const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('fs');
const path = require('path');
const { extractFrontmatter } = require('../gsd-core/bin/lib/frontmatter.cjs');
const ROOT = path.join(__dirname, '..');
const CMD_PATH = path.join(ROOT, 'commands', 'gsd', 'ingest-docs.md');
const WF_PATH = path.join(ROOT, 'gsd-core', 'workflows', 'ingest-docs.md');
const CLASSIFIER_PATH = path.join(ROOT, 'agents', 'gsd-doc-classifier.md');
const SYNTHESIZER_PATH = path.join(ROOT, 'agents', 'gsd-doc-synthesizer.md');
const CONFLICT_ENGINE_PATH = path.join(ROOT, 'gsd-core', 'references', 'doc-conflict-engine.md');
// ─── File Existence ────────────────────────────────────────────────────────────
describe('ingest-docs file structure (#2387)', () => {
test('command file exists', () => {
assert.ok(fs.existsSync(CMD_PATH), 'commands/gsd/ingest-docs.md should exist');
});
test('workflow file exists', () => {
assert.ok(fs.existsSync(WF_PATH), 'gsd-core/workflows/ingest-docs.md should exist');
});
test('classifier agent exists', () => {
assert.ok(fs.existsSync(CLASSIFIER_PATH), 'agents/gsd-doc-classifier.md should exist');
});
test('synthesizer agent exists', () => {
assert.ok(fs.existsSync(SYNTHESIZER_PATH), 'agents/gsd-doc-synthesizer.md should exist');
});
test('shared conflict-engine reference exists', () => {
assert.ok(fs.existsSync(CONFLICT_ENGINE_PATH), 'references/doc-conflict-engine.md should exist');
});
});
// ─── Command Frontmatter ───────────────────────────────────────────────────────
describe('ingest-docs command frontmatter', () => {
const content = fs.readFileSync(CMD_PATH, 'utf-8');
test('has name field', () => {
assert.match(content, /^name:\s*gsd:ingest-docs$/m);
});
test('has description field', () => {
assert.match(content, /^description:\s*.+$/m);
});
test('argument-hint mentions --mode, --manifest, --resolve', () => {
const m = content.match(/^argument-hint:\s*"(.+)"$/m);
assert.ok(m, 'argument-hint should be present');
assert.ok(m[1].includes('--mode'), 'argument-hint should mention --mode');
assert.ok(m[1].includes('--manifest'), 'argument-hint should mention --manifest');
assert.ok(m[1].includes('--resolve'), 'argument-hint should mention --resolve');
});
test('allowed-tools include AskUserQuestion and Agent', () => {
const frontmatter = extractFrontmatter(content);
const allowedTools = frontmatter['allowed-tools'];
assert.ok(Array.isArray(allowedTools), 'allowed-tools should be a frontmatter array');
assert.ok(allowedTools.includes('AskUserQuestion'), 'command needs AskUserQuestion for gates');
assert.ok(allowedTools.includes('Agent'), 'command needs Agent for agent spawns');
});
});
// ─── Command References ─────────────────────────────────────────────────────────
describe('ingest-docs command references', () => {
const content = fs.readFileSync(CMD_PATH, 'utf-8');
test('references the ingest-docs workflow', () => {
assert.ok(
content.includes('@~/.claude/gsd-core/workflows/ingest-docs.md'),
'command must @-reference its workflow'
);
});
test('references the doc-conflict-engine', () => {
assert.ok(
content.includes('@~/.claude/gsd-core/references/doc-conflict-engine.md'),
'command must load the shared conflict-engine contract'
);
});
test('references gate-prompts', () => {
assert.ok(
content.includes('@~/.claude/gsd-core/references/gate-prompts.md'),
'command must load gate-prompts for AskUserQuestion patterns'
);
});
});
// ─── Workflow Content ───────────────────────────────────────────────────────────
describe('ingest-docs workflow content', () => {
const content = fs.readFileSync(WF_PATH, 'utf-8');
test('parses --mode, --manifest, --resolve, and a positional path', () => {
assert.ok(content.includes('--mode'), '--mode flag must be parsed');
assert.ok(content.includes('--manifest'), '--manifest flag must be parsed');
assert.ok(content.includes('--resolve'), '--resolve flag must be parsed');
assert.ok(content.includes('SCAN_PATH'), 'positional scan path must be parsed');
});
test('validates paths for traversal sequences', () => {
assert.ok(
content.includes('traversal') || content.match(/case\s+".*\*\.\.\*/),
'workflow must reject traversal sequences in user-supplied paths'
);
});
test('enforces 50-doc cap in v1', () => {
assert.ok(
content.includes('50'),
'workflow must enforce the v1 doc cap'
);
assert.ok(
content.toLowerCase().includes('cap') || content.toLowerCase().includes('limit'),
'workflow must describe the cap/limit'
);
});
test('auto-detects MODE from .planning/ presence', () => {
assert.ok(
content.includes('planning_exists'),
'workflow must check planning_exists from init to auto-detect mode'
);
});
test('discovers via directory conventions', () => {
assert.ok(content.includes('adr'), 'workflow must match ADR directory convention');
assert.ok(content.includes('prd'), 'workflow must match PRD directory convention');
assert.ok(content.includes('spec'), 'workflow must match SPEC/RFC directory convention');
});
test('spawns gsd-doc-classifier and gsd-doc-synthesizer', () => {
assert.ok(
content.includes('gsd-doc-classifier'),
'workflow must spawn gsd-doc-classifier'
);
assert.ok(
content.includes('gsd-doc-synthesizer'),
'workflow must spawn gsd-doc-synthesizer'
);
});
test('conflict gate honors BLOCKER/WARNING/INFO semantics from doc-conflict-engine', () => {
assert.ok(content.includes('BLOCKER'), 'workflow must reference BLOCKER severity');
assert.ok(content.includes('WARNING'), 'workflow must reference WARNING severity');
assert.ok(content.includes('INFO'), 'workflow must reference INFO severity');
assert.ok(
content.includes('doc-conflict-engine'),
'workflow must cite the shared conflict-engine reference'
);
});
test('hard-blocks writes when BLOCKERs exist', () => {
// Must contain language that prevents writing destination files on blocker
assert.ok(
content.toLowerCase().includes('without writing') ||
content.toLowerCase().includes('no destination files'),
'workflow must forbid writes when BLOCKERs exist (safety gate)'
);
});
test('routes to gsd-roadmapper in new mode', () => {
assert.ok(
content.includes('gsd-roadmapper'),
'new mode must delegate to gsd-roadmapper'
);
});
test('rejects --resolve interactive in v1', () => {
const lower = content.toLowerCase();
assert.ok(
lower.includes('interactive') && lower.includes('future'),
'workflow must reject --resolve interactive with a future-release message'
);
});
test('references INGEST-CONFLICTS.md as the conflicts report location', () => {
assert.ok(
content.includes('INGEST-CONFLICTS.md'),
'workflow must write/read INGEST-CONFLICTS.md'
);
});
});
// ─── Classifier Agent ───────────────────────────────────────────────────────────
describe('gsd-doc-classifier agent', () => {
const content = fs.readFileSync(CLASSIFIER_PATH, 'utf-8');
test('has Read and Write tools', () => {
assert.match(content, /^tools:\s*.*Read.*Write.*/m);
});
test('produces JSON output schema', () => {
assert.ok(content.includes('"type"'), 'schema must include type field');
assert.ok(content.includes('"confidence"'), 'schema must include confidence field');
assert.ok(content.includes('"locked"'), 'schema must include locked field for ADRs');
});
test('documents all five classification types', () => {
assert.ok(content.includes('ADR'), 'classifier must handle ADR type');
assert.ok(content.includes('PRD'), 'classifier must handle PRD type');
assert.ok(content.includes('SPEC'), 'classifier must handle SPEC type');
assert.ok(content.includes('DOC'), 'classifier must handle DOC type');
assert.ok(content.includes('UNKNOWN'), 'classifier must handle UNKNOWN type');
});
test('only marks Accepted ADRs as locked', () => {
assert.ok(
content.includes('Accepted'),
'classifier must tie locked status to Accepted ADR status'
);
});
});
// ─── Synthesizer Agent ──────────────────────────────────────────────────────────
describe('gsd-doc-synthesizer agent', () => {
const content = fs.readFileSync(SYNTHESIZER_PATH, 'utf-8');
test('has Read/Write/Bash tools', () => {
assert.match(content, /^tools:\s*.*Read.*Write.*Bash.*/m);
});
test('documents default precedence ADR > SPEC > PRD > DOC', () => {
const precedenceBlock = content.match(/ADR[^.]*SPEC[^.]*PRD[^.]*DOC/);
assert.ok(precedenceBlock, 'default precedence ordering must be documented');
});
test('hard-blocks LOCKED vs LOCKED in both modes', () => {
assert.ok(
content.includes('LOCKED') && content.toLowerCase().includes('both'),
'LOCKED-vs-LOCKED must be a hard block in both modes'
);
});
test('produces three-bucket conflicts report', () => {
assert.ok(content.includes('auto-resolved'), 'report must have auto-resolved bucket');
assert.ok(content.includes('competing-variants'), 'report must have competing-variants bucket');
assert.ok(content.includes('unresolved-blockers'), 'report must have unresolved-blockers bucket');
});
test('performs cycle detection', () => {
assert.ok(
content.toLowerCase().includes('cycle'),
'synthesizer must run cycle detection on cross-ref graph'
);
});
test('preserves competing PRD acceptance variants (no naive merge)', () => {
assert.ok(
content.toLowerCase().includes('variant'),
'synthesizer must preserve competing acceptance variants'
);
});
test('writes SYNTHESIS.md as entry point for downstream consumers', () => {
assert.ok(
content.includes('SYNTHESIS.md'),
'synthesizer must write SYNTHESIS.md'
);
});
});
// ─── Shared Conflict Engine Contract ────────────────────────────────────────────
describe('doc-conflict-engine shared reference', () => {
const content = fs.readFileSync(CONFLICT_ENGINE_PATH, 'utf-8');
test('defines all three severity labels', () => {
assert.ok(content.includes('[BLOCKER]'));
assert.ok(content.includes('[WARNING]'));
assert.ok(content.includes('[INFO]'));
});
test('forbids markdown tables in conflict reports', () => {
assert.ok(
content.toLowerCase().includes('never markdown tables') ||
content.toLowerCase().includes('no markdown tables') ||
content.toLowerCase().includes('never use markdown tables'),
'reference must forbid markdown tables'
);
});
test('defines the BLOCKER safety gate', () => {
assert.ok(
content.toLowerCase().includes('exit without writing'),
'safety gate must forbid destination writes when BLOCKERs exist'
);
});
});
// ─── Import command still consumes the shared reference (#2387 refactor) ───────
describe('import command adopts shared conflict-engine', () => {
const cmdContent = fs.readFileSync(path.join(ROOT, 'commands', 'gsd', 'import.md'), 'utf-8');
const wfContent = fs.readFileSync(path.join(ROOT, 'gsd-core', 'workflows', 'import.md'), 'utf-8');
test('import command loads doc-conflict-engine reference', () => {
assert.ok(
cmdContent.includes('@~/.claude/gsd-core/references/doc-conflict-engine.md'),
'/gsd-import must load the shared conflict-engine contract'
);
});
test('import workflow cites the shared reference', () => {
assert.ok(
wfContent.includes('doc-conflict-engine'),
'import workflow must cite the shared conflict-engine'
);
});
test('import workflow retains BLOCKER/WARNING/INFO labels', () => {
assert.ok(wfContent.includes('[BLOCKER]'));
assert.ok(wfContent.includes('[WARNING]'));
assert.ok(wfContent.includes('[INFO]'));
});
});