* enhance(#4107): sequence external review after internal fixes
Teach the planner to finish internal review and accepted fixes before opening a PR known to trigger automatic external review. If an open-time property exists, re-check it immediately before opening with nothing intervening; post-open CI, review, changeset, and tracking work may follow.
Emitted-Drift-Ack-Growth: gsd-planner.md — issue #4107 adds the review-before-publish ordering rule
* chore(#4107): add PR #11 changeset
* chore(changeset): link upstream PR 4206
* fix(#4107): ground external-review terms and tighten ordering test
Addresses trek-e review on PR #4206:
- Ground 'known automatic external review' and 'open-time property' with
concrete anchors (CodeRabbit App / .coderabbit.yaml, not-behind-base).
- Suffix the antipatterns heading with (#4107), matching sibling sections.
- Replace vacuous negative assertion with inverted-order fixtures that
prove the ordering regexes reject bad phrasing, not just co-occurrence.
* fix(#4107): make directionality fixtures genuinely adversarial
agy (gemini-3.8-flash-high) adversarial review found the two negative
fixtures added in 584ec1cda were vacuous: they proved the ordering regexes
require certain keywords, not that they reject inverted order — the bad
strings simply omitted required tokens rather than reordering them.
- Rebuild both fixtures to contain every required token, reordered/negated,
so a real reordering would still slip past a weaker regex.
- Drop the unsupported 'changeset' mention from the Wave 4+ antipatterns
example — gsd-core/workflows/ship.md never references changeset work,
so naming it here implied a step this rule doesn't actually govern.
* fix(#4107): make the full review-then-fix-then-open sequence explicit
CodeRabbit (fork PR #11) flagged that the planner prose only ordered
accepted fixes before PR open, without explicitly naming 'run internal
review' as its own earlier step, and that no fixture tested the planner
text's own wording for inversion (only the antipatterns example had one).
- Prose now reads 'run internal review and apply the accepted
internal-review fixes before the final open'.
- Added a planner-text-specific inverted-order fixture alongside the
existing antipatterns-example one.
---------
Co-authored-by: Test <test@test.com>
Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
eedb6b5431