* test(#4153): cover unresolved update target
* fix(#4153): fail closed unresolved update target
* test(#4153): require a concrete recovery installer
* fix(#4153): use concrete unresolved recovery command
* chore(#4153): bind changeset to fork PR
* test(#4153): cover portable update diagnostics
* fix(#4153): keep update diagnostics portable
* fix(#4153): harden update version diagnostics
* test(#4153): reject jq in update version checks
* test(#4153): expose step-local parser gap
* fix(#4153): keep JSON parsing step-local
* docs(#4153): align update target guidance
* test(#4153): expose workflow runtime fallback
* test(#4153): expose resolver runtime fallback
* fix(#4153): leave unknown workflow runtime empty
* fix(#4153): stop inferring Claude for unknown targets
* test(#4153): preserve Claude workflow targeting
* test(#4153): preserve known runtime directory identity
* fix(#4153): recognize Claude workflow paths
* fix(#4153): reuse known runtime directory identities
* chore(#4153): acknowledge emitted workflow growth
The fail-closed diagnostic and known-runtime preservation deliberately add 48 emitted bytes.
Emitted-Drift-Ack-Growth: update.md — explicit unresolved-target diagnostics and known-runtime preservation
* test(#4153): expose missing Windsurf workflow contract
* docs(#4153): document Windsurf update targets
* chore(#4153): bind changeset to upstream PR
* fix(#4153): gate unresolved-target exit before the VERSION-missing fallback
The VERSION-missing bullet in get_installed_version sat before the
UPDATE_TARGET_UNRESOLVED exit and shared its trigger condition (version
0.0.0). An LLM agent reading the workflow top-to-bottom could satisfy
"proceed to install" without ever reaching the fail-closed exit this
PR adds, reopening the ill-defined mutating path #4153 closes. Reorder
so the unresolved-target gate runs first and scope the VERSION-missing
bullet to require an already-resolved target.
Also drop two vacuous mutationSpies entries: they checked '--sync'/
'--reapply' (commands/gsd/update.md content) against `step`, a slice of
workflows/update.md — always -1 regardless of correctness. Those routes
bypass get_installed_version entirely and are already covered by
install.test.cjs, reapply-patches.test.cjs, and
skill-frontmatter-contract.test.cjs.
* chore(#4153): point changeset pr field at fork PR #10 for fork CI
* test(#4153): guard RUNTIME_DIRS/update.md table parity, confirm narrowing intent
Nit 1: update.md's PREFERRED_RUNTIME prose and RUNTIME_DIRS
(src/update-context.cts) are two independently maintained copies of the
same runtime->dir mapping with no parity check; add one so a future
edit to either surface without the other fails loudly instead of
silently drifting.
Nit 2: call out in the changeset that a custom --config-dir matching no
known runtime, marker file, or env var now resolves unresolved instead
of silently defaulting to claude -- this narrowing is intentional, it's
the fail-closed behavior #4153 asks for.
* fix(#4153): drop dead $UC fallback in check_latest_version's uc_field, cover unresolved-runtime fast path
agy (gemini-3.8-flash-high) adversarial review of the full PR:
1. check_latest_version's uc_field() copy-pasted get_installed_version's
`${2:-$UC}` fallback, but every call site here passes $2 explicitly and
$UC does not exist in this step's scope -- dead, misleading reference.
Use $2 directly.
2. No unit test covered resolveUpdateContext's preferredConfigDir fast path
returning runtime: '' for a custom --config-dir matching no RUNTIME_DIRS
suffix, marker file, or env var (the exact fail-closed case #4153 adds).
Added.
A third finding (update.md:90 using /gsd:update vs docs using /gsd-update)
was investigated and rejected: /gsd:update is the actual registered
Claude Code command name (commands/gsd/update.md name: gsd:update) and is
locked by this PR's own test (tests/update-workflow.test.cjs); /gsd-update
is a separate, pre-existing, intentional prose convention used in
audience-facing docs (README/INVENTORY/FEATURES). Not a defect.
* chore(#4153): backfill changeset pr field to upstream PR #4237
---------
Co-authored-by: CI Rebase Check <ci@gsd-redux>
Co-authored-by: Test <test@test.com>
Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
e8800287d5