Files
msd-core/scripts/changeset/cli.cjs
Tom Boucher 463cffd894 chore(#604): rename get-shit-done/ runtime directory to gsd-core/ (#615)
* chore(#604): rename get-shit-done/ runtime directory to gsd-core/

Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the
on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary
(`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers
are unaffected.

Mechanical (bulk, ~90% of the diff):
- `git mv get-shit-done gsd-core`
- Swept path/identifier references across the repo via
  `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead
  preserves the five legitimate slug variants that are NOT the directory:
  get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names).
- Build/manifest wiring: package.json (bin, files, coverage globs),
  tsconfig.build.json (outDir), ~86 .gitignore build-output entries,
  stryker.config.mjs, scan-ignore files, install.js path strings.
- Frozen (not rewritten): CHANGELOG.md history; translated docs
  (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/).

New logic (review here):
- src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper
  ADR-0008 installer migration. On upgrade it walks the legacy
  `~/.claude/get-shit-done/` tree, classifies each file via the prior install
  manifest, and emits remove-managed / backup-and-remove for managed files
  while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked
  root and symlinked entries; bounds-checks every path under configDir). The
  framework rolls back on install failure. Emptied dirs may remain (framework
  has no recursive dir-removal primitive) — documented.
- scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare
  `get-shit-done` directory token (split token to avoid self-match; case-
  insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists
  CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines).
  Wired into the lint-tests CI job.
- Restored scripts/lint-package-identity-drift.cjs detection regexes (the
  mechanical sweep had wrongly rewritten the old-name patterns it exists to
  detect) and marked them as intentional legacy references.
- TDD tests for the migration and the guard; do.md slash-command guard regex
  tightened so a `/gsd-core/bin` path segment is not mistaken for a command;
  changeset + docs/installer-migrations.md row added.

Breaking: the installed runtime path moves `~/.claude/get-shit-done/` ->
`~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed
files (preserving user files) on upgrade. Users with custom hooks/configs
hardcoding the old path must update them.

Closes #604

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): unsweep pending changesets + allowlist injection-example docs

CI fixes for the rename PR:
- Do not sweep pending .changeset/*.md (ephemeral release-note fragments,
  like CHANGELOG); reverted those body edits so 5 pre-existing malformed
  fragments (missing type/pr) no longer enter the PR diff and trip docs-lint.
  Allowlisted .changeset/ in the legacy-name guard accordingly.
- Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in
  prompt-injection-scan.sh: they contain intentional injection examples /
  security-model prose; the path-reference rewrites are kept.

CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR;
none in the new migration/guard) and are out of scope for the rename.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): resolve CodeQL alerts surfaced on this PR

The rename diff touched files carrying pre-existing CodeQL findings; per the
no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving
them off. All behavior-preserving:

- scripts/ci-test-scope.cjs: build the config-path match from string
  .includes() instead of a RegExp over an arg-derived value (js/regex-injection).
- src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName
  so the table-cell escape is complete (js/incomplete-sanitization).
- tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment
  strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization).
- tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace,
  keep the meaningful POSIX-class conversion (js/identity-replacement).

Verified: build:lib green; the touched test files + ci-test-scope + profile-output
suites pass; lint:legacy-name clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization)

The prior commit's fixes for two alerts were ineffective:
- ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file`
  reaching static regex `.test(file)` calls (not the config rule). Removed ALL
  regex over file/t — startsWith/includes/=== string checks + an isWindowsHint
  helper — so there is no regex sink for the tainted value.
- js/incomplete-multi-character-sanitization (3 test files): a single
  `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint
  loop (replace until stable) plus a final bare-opener strip.

Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass;
lint:legacy-name clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL

CodeQL flags the regex PATTERNS syntactically (regex-injection on the
--files arg split; incomplete-multi-character-sanitization on the <!--...-->
replace), so loop fixes do not satisfy it. Made these paths regex-free:
- ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/).
- 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)).
Behavior preserved; ci-test-scope + the 3 suites pass; guard clean.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): unblock security base64 scan on the large rename diff

The security job hit its 10m timeout: base64-scan.sh choked on the binary
test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/
non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings),
and the ~800-file rename diff is slow to scan regardless.

- scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they
  can't carry base64-obfuscated *text* and feeding NUL bytes through the
  per-line scanner is pathologically slow. collect_files already filtered
  binary *extensions*; this catches binary *content* in text extensions.
- .github/workflows/security-scan.yml: raise the security job timeout 10m->30m
  to accommodate very large diffs (the scan itself is unchanged).

Verified locally: scan skips the fixture, 0 "ignored null byte" warnings,
0 findings, exit 0.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): sweep get-shit-done refs introduced by merging next

The branch was updated with next (#614/#384/#618 etc.), which reference the
get-shit-done/ dir (still named that on next). Swept the stale references in
the merged files to gsd-core so the rename stays consistent and lint:legacy-name
passes:
- commands/gsd/discuss-phase.md (runtime-launcher shim paths)
- src/core.cts (getAgentsDir layout comments)
- tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib)

Verified: guard 0 violations; build green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant

The #614 runtime-launcher shim added to discuss-phase.md references
`${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y
refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it
mis-read the directory path as a dangling `/gsd-core` command ref (same class as
the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path
segments are not treated as slash-command references.

Verified locally on BOTH platforms before pushing:
- mac (node 26) full suite: 0 failures
- gsd-test-runner (linux, node22 image) full suite: 0 failures
- bug-3683 + bug-2954 pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI)

CI intermittently failed state.test's gsd-tools subprocess with
"findProjectRoot is not a function" (flip-flopping across legs; not reproducible
on mac full suite, gsd-test linux full suite, test:unit, or state.test x8).
findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs);
binding it via destructure at module-load can be undefined under a load-ordering
edge. Resolve it lazily at call time via a small wrapper so the lookup happens
after core.cjs is fully initialized.

Verified green on BOTH platforms before pushing:
- mac (node 26) full suite: 0 failures
- gsd-test-runner (linux, node22) full suite: 0 failures
- state.test.cjs: 106/106; gsd-tools loads cleanly.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(#604): allowlist verification-patterns.md placeholder examples in secret scan

The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling
it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var
examples (illustrative Stripe test-key / database-URL / API-key placeholders) —
not real credentials. Added it to .secretscanignore with the strict annotation,
mirroring the existing gsd-core/workflows/plan-phase.md exception.

Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next
exits 0 with 0 findings.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-02 18:35:29 -04:00

393 lines
13 KiB
JavaScript
Executable File

#!/usr/bin/env node
'use strict';
/**
* CLI wrapper for the changeset-fragment workflow (#2975).
*
* Subcommands:
* render --repo <dir> --version V --date D [--json] Fold .changeset/*.md
* into CHANGELOG.md;
* delete consumed fragments.
*
* `--json` emits a structured report on stdout — the only contract tests
* assert against. Per CONTRIBUTING.md "Prohibited: Raw Text Matching on
* Test Outputs", the human formatter is operator-only.
*/
const fs = require('node:fs');
const path = require('node:path');
const { parseFragment, FRAGMENT_ERROR } = require('./parse.cjs');
const { renderChangelog } = require('./render.cjs');
const { serializeChangelog, parseChangelog } = require('./serialize.cjs');
const { renderGithubReleaseNotes } = require('./github-release-notes.cjs');
const {
compareSemverCore,
isStableTripletSemver,
} = require('../../gsd-core/bin/lib/semver-compare.cjs');
const { packageName, repoSlug: defaultRepoSlug } = require('../../gsd-core/bin/lib/package-identity.cjs');
function parseArgs(argv) {
const opts = {
cmd: null,
repo: process.cwd(),
version: null,
date: null,
fromRef: null,
toRef: null,
changelog: null,
output: null,
repoSlug: defaultRepoSlug,
installCommand: `npx ${packageName}@latest`,
json: false,
};
if (argv.length === 0) return { ok: true, opts };
opts.cmd = argv[0];
// Pull a value for a value-taking flag, validating that the next token
// exists and is not itself another flag (which is the silently-misparsed
// case CR called out: e.g. `--repo --json` would consume `--json` as the
// repo path).
const requireValue = (flag, i) => {
const v = argv[i + 1];
if (v === undefined || v.startsWith('--')) {
return { ok: false, error: `missing value for ${flag}` };
}
return { ok: true, value: v };
};
for (let i = 1; i < argv.length; i++) {
const a = argv[i];
if (a === '--json') { opts.json = true; continue; }
if (
a === '--repo' ||
a === '--version' ||
a === '--date' ||
a === '--from' ||
a === '--to' ||
a === '--changelog' ||
a === '--output' ||
a === '--repo-slug' ||
a === '--install-command'
) {
const r = requireValue(a, i);
if (!r.ok) return { ok: false, error: r.error };
if (a === '--repo') opts.repo = r.value;
else if (a === '--version') opts.version = r.value;
else if (a === '--date') opts.date = r.value;
else if (a === '--from') opts.fromRef = r.value;
else if (a === '--to') opts.toRef = r.value;
else if (a === '--changelog') opts.changelog = r.value;
else if (a === '--output') opts.output = r.value;
else if (a === '--repo-slug') opts.repoSlug = r.value;
else if (a === '--install-command') opts.installCommand = r.value;
i++;
continue;
}
return { ok: false, error: `unknown argument: ${a}` };
}
return { ok: true, opts };
}
function listFragmentFiles(changesetDir) {
if (!fs.existsSync(changesetDir)) return [];
return fs.readdirSync(changesetDir)
.filter((f) => f.endsWith('.md') && f !== 'README.md')
.map((f) => path.join(changesetDir, f));
}
function splitChangelog(text) {
// Split off the top-level "# Changelog" heading + lead matter (everything
// before the first "## [version]" block) from the rest. The rest is the
// priorChangelog passed into renderChangelog. The "## [Unreleased]" block,
// if present, is dropped (the new release replaces it).
const lines = text.split(/\r?\n/);
const firstReleaseIdx = lines.findIndex((l) => /^##\s+\[/.test(l));
if (firstReleaseIdx === -1) {
return { lead: text.replace(/\s+$/, ''), prior: '' };
}
const lead = lines.slice(0, firstReleaseIdx).join('\n').replace(/\s+$/, '');
let priorStart = firstReleaseIdx;
// Skip the [Unreleased] block if present — it's a placeholder, not a release.
if (/^##\s+\[Unreleased\]/i.test(lines[firstReleaseIdx])) {
let j = firstReleaseIdx + 1;
while (j < lines.length && !/^##\s+\[/.test(lines[j])) j++;
priorStart = j;
}
const prior = lines.slice(priorStart).join('\n').trimStart();
return { lead, prior };
}
function cmdRender(opts) {
const repo = path.resolve(opts.repo);
const changesetDir = path.join(repo, '.changeset');
const changelogPath = path.join(repo, 'CHANGELOG.md');
const fragmentFiles = listFragmentFiles(changesetDir);
const fragments = [];
const failures = [];
for (const file of fragmentFiles) {
const src = fs.readFileSync(file, 'utf8');
const r = parseFragment(src);
if (r.ok) fragments.push({ ...r.fragment, file });
else failures.push({ file: path.relative(repo, file), reason: r.reason, detail: r.detail || null });
}
if (failures.length > 0) {
return { exitCode: 1, report: { consumed: 0, failures } };
}
if (fragments.length === 0) {
return { exitCode: 0, report: { consumed: 0, failures: [] } };
}
const priorText = fs.existsSync(changelogPath) ? fs.readFileSync(changelogPath, 'utf8') : '';
const { lead, prior } = splitChangelog(priorText);
const ir = renderChangelog({
fragments,
version: opts.version,
date: opts.date,
priorChangelog: prior || null,
});
const releaseBlock = serializeChangelog(ir);
const out = [
lead || '# Changelog',
'',
'## [Unreleased]',
'',
releaseBlock.replace(/\s+$/, ''),
'',
].join('\n');
fs.writeFileSync(changelogPath, out);
// Delete consumed fragments. If any unlink fails the changelog is written
// but the fragment is still on disk, so a re-run would double-consume it.
// Surface the partial-failure as exitCode=1 with structured detail so the
// operator can manually clean up before retrying.
const deleteFailures = [];
for (const f of fragments) {
try {
fs.unlinkSync(f.file);
} catch (e) {
deleteFailures.push({
file: path.relative(repo, f.file),
reason: 'fail_fragment_delete',
detail: e.code || e.message,
});
}
}
return {
exitCode: deleteFailures.length > 0 ? 1 : 0,
report: {
consumed: fragments.length - deleteFailures.length,
failures: deleteFailures,
release: { version: opts.version, date: opts.date },
},
};
}
/**
* extract subcommand: extracts all changelog release blocks strictly after
* `--from` (exclusive) up to and including `--to` (inclusive). Both
* arguments accept `v`-prefixed semver (e.g. `v1.5.13`).
*
* Exit codes:
* 0 — one or more releases matched, output written.
* 2 — no releases fall in the specified range (matches nothing).
* 1 — I/O error or missing required flags.
*
* Fix for #3496: provides a deterministic range-aware helper so the
* `/gsd:update` show_changes_and_confirm step no longer relies on
* vague/manual extraction that can silently skip intermediate versions.
*/
function cmdExtract(opts) {
const stripV = (v) => (typeof v === 'string' ? v.replace(/^v/, '') : v);
const from = stripV(opts.fromRef);
const to = stripV(opts.toRef);
// Validate that both bounds are strict semver (N.N.N, digits only).
// Coercing a malformed bound like "1.41.x" to "1.41.0" makes range
// selection silently wrong; reject early with a structured error.
if (!isStableTripletSemver(from)) {
return {
exitCode: 1,
report: { error: `invalid semver for --from: "${from}" (expected N.N.N)`, releases: [] },
textOutput: null,
};
}
if (!isStableTripletSemver(to)) {
return {
exitCode: 1,
report: { error: `invalid semver for --to: "${to}" (expected N.N.N)`, releases: [] },
textOutput: null,
};
}
const changelogPath = opts.changelog
? path.resolve(opts.changelog)
: path.join(path.resolve(opts.repo), 'CHANGELOG.md');
if (!fs.existsSync(changelogPath)) {
return {
exitCode: 1,
report: { error: `CHANGELOG not found: ${changelogPath}`, releases: [] },
textOutput: null,
};
}
const text = fs.readFileSync(changelogPath, 'utf8');
const { releases } = parseChangelog(text);
const matched = releases.filter((rel) => {
if (rel.version === 'Unreleased') return false;
// Extract mode intentionally operates on stable releases only.
if (!isStableTripletSemver(rel.version)) {
process.stderr.write(`[extract] skipping pre-release/non-semver entry: ${rel.version}\n`);
return false;
}
// from is exclusive: cmp > 0 means rel.version > from
const afterFrom = compareSemverCore(rel.version, from) > 0;
// to is inclusive: cmp <= 0 means rel.version <= to
const upToTo = compareSemverCore(rel.version, to) <= 0;
return afterFrom && upToTo;
});
if (matched.length === 0) {
return {
exitCode: 2,
report: { releases: [], from, to },
textOutput: null,
};
}
return {
exitCode: 0,
report: { releases: matched, from, to },
textOutput: matched
.map((rel) => {
const header = `## [${rel.version}]${rel.date ? ` - ${rel.date}` : ''}`;
const sections = (rel.sections || [])
.map((s) => {
const bullets = s.bullets
.map((b) => (b.pr !== null ? `- ${b.body} (#${b.pr})` : `- ${b.body}`))
.join('\n');
return `### ${s.type}\n\n${bullets}`;
})
.join('\n\n');
return sections ? `${header}\n\n${sections}` : header;
})
.join('\n\n'),
};
}
function cmdGithubReleaseNotes(opts) {
const repo = path.resolve(opts.repo);
const report = renderGithubReleaseNotes({
repo,
fromRef: opts.fromRef,
toRef: opts.toRef,
repoSlug: opts.repoSlug,
installCommand: opts.installCommand,
});
if (!report.ok) {
return {
exitCode: 1,
report: {
consumed: 0,
failures: report.failures,
release: { from: opts.fromRef, to: opts.toRef },
},
};
}
if (opts.output) {
fs.writeFileSync(path.resolve(opts.output), report.body);
}
return {
exitCode: 0,
report: {
consumed: report.fragments.length,
failures: [],
release: { from: opts.fromRef, to: opts.toRef },
output: opts.output || null,
body: opts.output ? null : report.body,
},
};
}
function usage() {
return [
'usage:',
' changeset/cli.cjs render --repo <dir> --version V --date D [--json]',
' changeset/cli.cjs github-release-notes --repo <dir> --from REF --to REF [--output FILE] [--repo-slug OWNER/REPO] [--install-command CMD] [--json]',
' changeset/cli.cjs extract --from VERSION --to VERSION [--changelog FILE] [--repo <dir>] [--json]',
' Extracts changelog entries strictly after --from (exclusive) and up to',
' and including --to (inclusive). Accepts v-prefixed versions.',
' Exit 2 when no releases fall in range.',
'',
].join('\n');
}
function main() {
const parsed = parseArgs(process.argv.slice(2));
if (!parsed.ok) {
process.stderr.write(`${parsed.error}\n`);
process.stderr.write(usage());
process.exit(2);
}
const { opts } = parsed;
if (opts.cmd !== 'render' && opts.cmd !== 'github-release-notes' && opts.cmd !== 'extract') {
process.stderr.write(usage());
process.exit(1);
}
if (opts.cmd === 'render' && (!opts.version || !opts.date)) {
process.stderr.write('--version and --date are required for render\n');
process.exit(2);
}
if (opts.cmd === 'github-release-notes' && (!opts.fromRef || !opts.toRef)) {
process.stderr.write('--from and --to are required for github-release-notes\n');
process.exit(2);
}
if (opts.cmd === 'extract' && (!opts.fromRef || !opts.toRef)) {
process.stderr.write('--from and --to are required for extract\n');
process.stderr.write(usage());
process.exit(1);
}
if (opts.cmd === 'extract') {
const { exitCode, report, textOutput } = cmdExtract(opts);
if (opts.json) {
process.stdout.write(JSON.stringify(report, null, 2) + '\n');
} else if (textOutput) {
process.stdout.write(textOutput + '\n');
} else if (exitCode === 2) {
process.stderr.write(`no releases found in range (from=${report.from}, to=${report.to})\n`);
}
process.exit(exitCode);
}
const { exitCode, report } = opts.cmd === 'render' ? cmdRender(opts) : cmdGithubReleaseNotes(opts);
if (opts.json) {
process.stdout.write(JSON.stringify(report, null, 2) + '\n');
} else if (opts.cmd === 'github-release-notes' && report.body) {
process.stdout.write(report.body);
} else {
process.stdout.write(`Consumed: ${report.consumed} fragment(s)\n`);
if (report.failures.length > 0) {
process.stdout.write(`Failures: ${report.failures.length}\n`);
for (const f of report.failures) {
process.stdout.write(` ${f.file}: ${f.reason}${f.detail ? ` (${f.detail})` : ''}\n`);
}
}
}
process.exit(exitCode);
}
if (require.main === module) main();
module.exports = { cmdRender, cmdExtract, cmdGithubReleaseNotes, parseArgs, splitChangelog, listFragmentFiles, usage };