ed8f4c9a31
Phase 3 of the CJS↔SDK hard-seam migration (parent #3524). Introduces the Builder/Reader pattern for paired Modules with mixed pure-and-I/O concerns — the template for Phase 4 and follow-up enhancements that migrate other paired Modules. Phase 1 and Phase 2 migrated Modules where both sides used character-equivalent logic. Phase 3 introduces the case where the pure logic is shareable but the I/O is legitimately per-side. The Builder/Reader split resolves this: - The Builder is pure — accepts pre-collected data (BuilderInputs struct), returns the typed projection. One source of truth; one generator-emitted CJS mirror. Drift is structurally impossible. - The Readers are per-side hand-authored Adapters that do the fs reads in their native idiom (currently both sync; either side can go async later without touching the Builder), then delegate to the Builder. - sdk/src/workstream-inventory/builder.ts — Builder source. 170 lines. Pure. Exports buildWorkstreamInventory(inputs), isCompletedInventory(status), plus the three typed inventory interfaces (WorkstreamPhaseInventory, WorkstreamInventory, WorkstreamInventoryList). - sdk/src/workstream-inventory/builder.test.ts — 18 vitest pinning fixtures across all status branches, progress-percent clamping, active-marker projection, and isCompletedInventory classifier. - sdk/scripts/gen-workstream-inventory-builder.mjs — generator. Captures function bodies via Function.prototype.toString(); emits with the standard GENERATED FILE banner. Includes a small `const relative = path.relative;` preamble in the output to handle ESM destructured imports in the compiled source. - sdk/scripts/check-workstream-inventory-builder-fresh.mjs — freshness check. Imports the generator function directly (rather than duplicating logic) — a cleaner pattern than Phase 1/2's approach. - get-shit-done/bin/lib/workstream-inventory-builder.generated.cjs — generator-emitted CJS mirror. - tests/workstream-inventory-builder-generator.test.cjs — 16 parity assertions confirming CJS-generated output == SDK source output for every fixture. - bin/lib/workstream-inventory.cjs: 159 → 132 lines. Projection logic gone. `inspectWorkstream` and `listWorkstreamInventories` collect BuilderInputs via the existing sync fs functions and delegate to the Builder. `isCompletedInventory` re-exported from the Builder (its signature changed from object→string, but no external callers exist so the change is safe). - sdk/src/query/workstream-inventory.ts: 196 → 143 lines. Same shape, sync fs (the SDK was already sync — surprise from recon). Types re-exported from the Builder. - sdk/package.json: gen:workstream-inventory-builder and check:workstream-inventory-builder-fresh scripts. - package.json: proxy for the freshness check. - .githooks/pre-commit: drift block. - .github/workflows/test.yml: drift check step. - CONTEXT.md: amended "Workstream Inventory Module" entry to document the Builder/Reader split. - docs/INVENTORY.md, docs/INVENTORY-MANIFEST.json: +1 module count, +1 row for the generated builder. - Full suite: 9229/9229 pass (baseline 9215 + 14 net new from the parity assertions). - Vitest: 18 Builder fixtures pass. - Reader shrink: -27 lines on CJS, -53 lines on SDK. - Net diff (modified files only): +68 / -133 = 65-line reduction. New files (Builder, generator, freshness check, parity test) add ~600 lines of new structured code. 1. `isCompletedInventory` signature changed from isCompletedInventory(inventory: object) to isCompletedInventory(status: string). Original CJS exported the object form but no external caller passed an object — they all passed inventory.status. Verified by grep before committing. 2. Generator preamble. The compiled ESM uses `import { relative } from 'node:path'`, making `relative` a free variable in `buildWorkstreamInventory`. The generator emits `const relative = path.relative;` so the captured function body works in CJS. 3. Freshness check imports the generator. The freshness check imports the generator's buildWorkstreamInventoryBuilderCjs() function directly rather than duplicating generation logic. Cleaner than Phase 1/2; future generators should follow this. Shareable via the Builder/Reader pattern in future enhancements: - frontmatter (pure YAML/markdown parsing) - plan-scan (pure PLAN.md structure parsing) - decisions (pure decision-record parsing) - secrets (regex-based detection in text) - uat (UAT-criteria parsing) Structural divergence — different approach needed: - state — sync vs async file ops; mutation paths differ. - workstream — lifecycle ops; per-side API surface differs. - phase, roadmap, init, profile-output, template — large surfaces; each its own potential enhancement. None of these is in scope for Phase 3. Closes #3544.
340 lines
8.6 KiB
JSON
340 lines
8.6 KiB
JSON
{
|
|
"generated": "2026-05-15",
|
|
"families": {
|
|
"agents": [
|
|
"gsd-advisor-researcher",
|
|
"gsd-ai-researcher",
|
|
"gsd-assumptions-analyzer",
|
|
"gsd-code-fixer",
|
|
"gsd-code-reviewer",
|
|
"gsd-codebase-mapper",
|
|
"gsd-debug-session-manager",
|
|
"gsd-debugger",
|
|
"gsd-doc-classifier",
|
|
"gsd-doc-synthesizer",
|
|
"gsd-doc-verifier",
|
|
"gsd-doc-writer",
|
|
"gsd-domain-researcher",
|
|
"gsd-eval-auditor",
|
|
"gsd-eval-planner",
|
|
"gsd-executor",
|
|
"gsd-framework-selector",
|
|
"gsd-integration-checker",
|
|
"gsd-intel-updater",
|
|
"gsd-nyquist-auditor",
|
|
"gsd-pattern-mapper",
|
|
"gsd-phase-researcher",
|
|
"gsd-plan-checker",
|
|
"gsd-planner",
|
|
"gsd-project-researcher",
|
|
"gsd-research-synthesizer",
|
|
"gsd-roadmapper",
|
|
"gsd-security-auditor",
|
|
"gsd-ui-auditor",
|
|
"gsd-ui-checker",
|
|
"gsd-ui-researcher",
|
|
"gsd-user-profiler",
|
|
"gsd-verifier"
|
|
],
|
|
"commands": [
|
|
"/gsd-add-tests",
|
|
"/gsd-ai-integration-phase",
|
|
"/gsd-audit-fix",
|
|
"/gsd-audit-milestone",
|
|
"/gsd-audit-uat",
|
|
"/gsd-autonomous",
|
|
"/gsd-capture",
|
|
"/gsd-cleanup",
|
|
"/gsd-code-review",
|
|
"/gsd-complete-milestone",
|
|
"/gsd-config",
|
|
"/gsd-debug",
|
|
"/gsd-discuss-phase",
|
|
"/gsd-docs-update",
|
|
"/gsd-eval-review",
|
|
"/gsd-execute-phase",
|
|
"/gsd-explore",
|
|
"/gsd-extract-learnings",
|
|
"/gsd-fast",
|
|
"/gsd-forensics",
|
|
"/gsd-graphify",
|
|
"/gsd-health",
|
|
"/gsd-help",
|
|
"/gsd-import",
|
|
"/gsd-inbox",
|
|
"/gsd-ingest-docs",
|
|
"/gsd-manager",
|
|
"/gsd-map-codebase",
|
|
"/gsd-milestone-summary",
|
|
"/gsd-mvp-phase",
|
|
"/gsd-new-milestone",
|
|
"/gsd-new-project",
|
|
"/gsd-ns-context",
|
|
"/gsd-ns-ideate",
|
|
"/gsd-ns-manage",
|
|
"/gsd-ns-project",
|
|
"/gsd-ns-review",
|
|
"/gsd-ns-workflow",
|
|
"/gsd-pause-work",
|
|
"/gsd-phase",
|
|
"/gsd-plan-phase",
|
|
"/gsd-plan-review-convergence",
|
|
"/gsd-pr-branch",
|
|
"/gsd-profile-user",
|
|
"/gsd-progress",
|
|
"/gsd-quick",
|
|
"/gsd-resume-work",
|
|
"/gsd-review",
|
|
"/gsd-review-backlog",
|
|
"/gsd-secure-phase",
|
|
"/gsd-settings",
|
|
"/gsd-ship",
|
|
"/gsd-sketch",
|
|
"/gsd-spec-phase",
|
|
"/gsd-spike",
|
|
"/gsd-stats",
|
|
"/gsd-surface",
|
|
"/gsd-thread",
|
|
"/gsd-ui-phase",
|
|
"/gsd-ui-review",
|
|
"/gsd-ultraplan-phase",
|
|
"/gsd-undo",
|
|
"/gsd-update",
|
|
"/gsd-validate-phase",
|
|
"/gsd-verify-work",
|
|
"/gsd-workspace",
|
|
"/gsd-workstreams"
|
|
],
|
|
"workflows": [
|
|
"add-backlog.md",
|
|
"add-phase.md",
|
|
"add-tests.md",
|
|
"add-todo.md",
|
|
"ai-integration-phase.md",
|
|
"analyze-dependencies.md",
|
|
"audit-fix.md",
|
|
"audit-milestone.md",
|
|
"audit-uat.md",
|
|
"autonomous.md",
|
|
"check-todos.md",
|
|
"cleanup.md",
|
|
"code-review-fix.md",
|
|
"code-review.md",
|
|
"complete-milestone.md",
|
|
"debug.md",
|
|
"diagnose-issues.md",
|
|
"discovery-phase.md",
|
|
"discuss-phase-assumptions.md",
|
|
"discuss-phase-power.md",
|
|
"discuss-phase.md",
|
|
"do.md",
|
|
"docs-update.md",
|
|
"edit-phase.md",
|
|
"eval-review.md",
|
|
"execute-phase.md",
|
|
"execute-plan.md",
|
|
"explore.md",
|
|
"extract-learnings.md",
|
|
"fast.md",
|
|
"forensics.md",
|
|
"graduation.md",
|
|
"health.md",
|
|
"help.md",
|
|
"import.md",
|
|
"inbox.md",
|
|
"ingest-docs.md",
|
|
"insert-phase.md",
|
|
"list-phase-assumptions.md",
|
|
"list-workspaces.md",
|
|
"manager.md",
|
|
"map-codebase.md",
|
|
"milestone-summary.md",
|
|
"mvp-phase.md",
|
|
"new-milestone.md",
|
|
"new-project.md",
|
|
"new-workspace.md",
|
|
"next.md",
|
|
"node-repair.md",
|
|
"note.md",
|
|
"pause-work.md",
|
|
"plan-milestone-gaps.md",
|
|
"plan-phase.md",
|
|
"plan-review-convergence.md",
|
|
"plant-seed.md",
|
|
"pr-branch.md",
|
|
"profile-user.md",
|
|
"progress.md",
|
|
"quick.md",
|
|
"reapply-patches.md",
|
|
"remove-phase.md",
|
|
"remove-workspace.md",
|
|
"resume-project.md",
|
|
"review.md",
|
|
"scan.md",
|
|
"secure-phase.md",
|
|
"session-report.md",
|
|
"settings-advanced.md",
|
|
"settings-integrations.md",
|
|
"settings.md",
|
|
"ship.md",
|
|
"sketch-wrap-up.md",
|
|
"sketch.md",
|
|
"spec-phase.md",
|
|
"spike-wrap-up.md",
|
|
"spike.md",
|
|
"stats.md",
|
|
"sync-skills.md",
|
|
"thread.md",
|
|
"transition.md",
|
|
"ui-phase.md",
|
|
"ui-review.md",
|
|
"ultraplan-phase.md",
|
|
"undo.md",
|
|
"update.md",
|
|
"validate-phase.md",
|
|
"verify-phase.md",
|
|
"verify-work.md"
|
|
],
|
|
"references": [
|
|
"agent-contracts.md",
|
|
"ai-evals.md",
|
|
"ai-frameworks.md",
|
|
"artifact-types.md",
|
|
"autonomous-smart-discuss.md",
|
|
"checkpoints.md",
|
|
"common-bug-patterns.md",
|
|
"context-budget.md",
|
|
"continuation-format.md",
|
|
"debugger-philosophy.md",
|
|
"decimal-phase-calculation.md",
|
|
"doc-conflict-engine.md",
|
|
"domain-probes.md",
|
|
"execute-mvp-tdd.md",
|
|
"executor-examples.md",
|
|
"gate-prompts.md",
|
|
"gates.md",
|
|
"git-integration.md",
|
|
"git-planning-commit.md",
|
|
"ios-scaffold.md",
|
|
"mandatory-initial-read.md",
|
|
"model-profile-resolution.md",
|
|
"model-profiles.md",
|
|
"mvp-concepts.md",
|
|
"phase-argument-parsing.md",
|
|
"planner-antipatterns.md",
|
|
"planner-chunked.md",
|
|
"planner-gap-closure.md",
|
|
"planner-human-verify-mode.md",
|
|
"planner-mvp-mode.md",
|
|
"planner-reviews.md",
|
|
"planner-revision.md",
|
|
"planner-source-audit.md",
|
|
"planning-config.md",
|
|
"project-skills-discovery.md",
|
|
"questioning.md",
|
|
"revision-loop.md",
|
|
"scout-codebase.md",
|
|
"skeleton-template.md",
|
|
"sketch-interactivity.md",
|
|
"sketch-theme-system.md",
|
|
"sketch-tooling.md",
|
|
"sketch-variant-patterns.md",
|
|
"spidr-splitting.md",
|
|
"tdd.md",
|
|
"thinking-models-debug.md",
|
|
"thinking-models-execution.md",
|
|
"thinking-models-planning.md",
|
|
"thinking-models-research.md",
|
|
"thinking-models-verification.md",
|
|
"thinking-partner.md",
|
|
"ui-brand.md",
|
|
"universal-anti-patterns.md",
|
|
"user-profiling.md",
|
|
"user-story-template.md",
|
|
"verification-overrides.md",
|
|
"verification-patterns.md",
|
|
"verify-mvp-mode.md",
|
|
"workstream-flag.md",
|
|
"worktree-path-safety.md"
|
|
],
|
|
"cli_modules": [
|
|
"active-workstream-store.cjs",
|
|
"adr-parser.cjs",
|
|
"artifacts.cjs",
|
|
"audit.cjs",
|
|
"cjs-command-router-adapter.cjs",
|
|
"clusters.cjs",
|
|
"command-aliases.generated.cjs",
|
|
"commands.cjs",
|
|
"config-schema.cjs",
|
|
"config.cjs",
|
|
"configuration.generated.cjs",
|
|
"context-utilization.cjs",
|
|
"core.cjs",
|
|
"decisions.cjs",
|
|
"docs.cjs",
|
|
"drift.cjs",
|
|
"fallow-runner.cjs",
|
|
"frontmatter.cjs",
|
|
"gap-checker.cjs",
|
|
"graphify.cjs",
|
|
"gsd2-import.cjs",
|
|
"init-command-router.cjs",
|
|
"init.cjs",
|
|
"install-profiles.cjs",
|
|
"installer-migration-authoring.cjs",
|
|
"installer-migration-report.cjs",
|
|
"installer-migrations.cjs",
|
|
"intel.cjs",
|
|
"learnings.cjs",
|
|
"milestone.cjs",
|
|
"model-catalog.cjs",
|
|
"model-profiles.cjs",
|
|
"phase-command-router.cjs",
|
|
"phase.cjs",
|
|
"phases-command-router.cjs",
|
|
"plan-scan.cjs",
|
|
"planning-workspace.cjs",
|
|
"profile-output.cjs",
|
|
"profile-pipeline.cjs",
|
|
"review-reviewer-selection.cjs",
|
|
"roadmap-command-router.cjs",
|
|
"roadmap.cjs",
|
|
"runtime-homes.cjs",
|
|
"schema-detect.cjs",
|
|
"secrets.cjs",
|
|
"security.cjs",
|
|
"shell-command-projection.cjs",
|
|
"state-command-router.cjs",
|
|
"state-document.cjs",
|
|
"state-document.generated.cjs",
|
|
"state.cjs",
|
|
"surface.cjs",
|
|
"template.cjs",
|
|
"uat.cjs",
|
|
"validate-command-router.cjs",
|
|
"verify-command-router.cjs",
|
|
"verify.cjs",
|
|
"workstream-inventory-builder.generated.cjs",
|
|
"workstream-inventory.cjs",
|
|
"workstream-name-policy.cjs",
|
|
"workstream.cjs",
|
|
"worktree-safety.cjs"
|
|
],
|
|
"hooks": [
|
|
"gsd-check-update-worker.js",
|
|
"gsd-check-update.js",
|
|
"gsd-context-monitor.js",
|
|
"gsd-phase-boundary.sh",
|
|
"gsd-prompt-guard.js",
|
|
"gsd-read-guard.js",
|
|
"gsd-read-injection-scanner.js",
|
|
"gsd-session-state.sh",
|
|
"gsd-statusline.js",
|
|
"gsd-update-banner.js",
|
|
"gsd-validate-commit.sh",
|
|
"gsd-workflow-guard.js"
|
|
]
|
|
}
|
|
}
|