eb45fc0e8c
* fix(#2415): close_phase_todos stages the pending/ deletion alongside completed/ Bug: the workflow step moved resolved todos from .planning/todos/pending/ to .planning/todos/completed/ with a plain 'mv', then committed listing ONLY the destination directory in --files: mv "$TODO_FILE" "$COMPLETED_DIR/" gsd_run query commit '...' --files .planning/todos/completed/ .planning/STATE.md Git's index still tracked the moved file at its old pending/<name>.md path. The commit therefore only staged the new completed/<name>.md copy — the deletion at pending/ was never staged, never committed, and lingered as an unstaged deletion in git status indefinitely until some later broad 'git add -A' caught it. The phase genuinely closed the todo, but the working tree was never clean. Fix: add .planning/todos/pending/ to the --files list. 'git add' of that directory (since git 2.0) stages deletions of tracked files in the pathspec, so the moved-away file is staged as a deletion atomically with the new completed/ copy in the same commit. Chose plain mv + two-dir --files over 'git mv' because git mv FAILS on: - untracked todos (new todo file not yet committed) - non-git .planning dirs (worktree safety / pre-init projects) Plain mv has neither failure mode. Regression tests in tests/close-phase-todos-stage-deletion.test.cjs (source-text-is-the-product: workflow .md text IS what the runtime loads) cover: - the commit --files list includes BOTH completed/ AND pending/ - the move uses plain 'mv' (not 'git mv') so untracked + non-git cases work * chore(#2415): trim commit subject to keep execute-phase.md under byte ceiling The fix added '.planning/todos/pending/' (~26 bytes) to the commit --files list. To stay under the ADR-857 Phase 6 pre-phase-6 byte ceiling margin (93400 bytes, hard ceiling 93600), shortened the commit subject from 'auto-close N todo(s) resolved by this phase' to 'close N resolved todo(s)'. Net change vs origin/next: +6 bytes (93384 → 93390), well under the margin. Also regenerates the golden-install-parity fixtures (execute-phase.md content-hash update across all runtimes). * chore(#2415): bump execute-phase.md workflow-size baseline (93384 → 93390) The +pending/ fix added 6 net bytes (93384 → 93390), still well under the ADR-857 Phase 6 pre-phase-6 byte ceiling margin (93400). * chore(changeset): backfill pr:2447 in .changeset/sturdy-wasps-run.md * fix(#2415): add issue ref to allow-test-rule annotation (ADR-456) CI lint-allow-test-rule-refs failed on the prior commit — ADR-456 requires '// allow-test-rule: <category> see #NNNN' so every exemption is traceable to an issue. Added 'see #2415' to the source-text-is-the-product annotation.
94 lines
2.4 KiB
JSON
94 lines
2.4 KiB
JSON
{
|
|
"add-backlog.md": 7176,
|
|
"add-phase.md": 7578,
|
|
"add-tests.md": 16961,
|
|
"add-todo.md": 10734,
|
|
"ai-integration-phase.md": 15134,
|
|
"analyze-dependencies.md": 3887,
|
|
"audit-fix.md": 11743,
|
|
"audit-milestone.md": 18448,
|
|
"audit-uat.md": 7469,
|
|
"autonomous.md": 42474,
|
|
"check-todos.md": 9475,
|
|
"cleanup.md": 9941,
|
|
"code-review-fix.md": 24320,
|
|
"code-review.md": 32524,
|
|
"complete-milestone.md": 31071,
|
|
"debug.md": 19370,
|
|
"diagnose-issues.md": 12858,
|
|
"discovery-phase.md": 8651,
|
|
"discuss-phase-assumptions.md": 27302,
|
|
"discuss-phase-power.md": 11273,
|
|
"discuss-phase.md": 31986,
|
|
"do.md": 10353,
|
|
"docs-update.md": 55706,
|
|
"edit-phase.md": 12927,
|
|
"eval-review.md": 9967,
|
|
"execute-phase.md": 93390,
|
|
"execute-plan.md": 34262,
|
|
"explore.md": 10541,
|
|
"extract-learnings.md": 12893,
|
|
"fast.md": 7613,
|
|
"forensics.md": 12531,
|
|
"graduation.md": 11622,
|
|
"health.md": 11868,
|
|
"help.md": 1722,
|
|
"import.md": 14636,
|
|
"inbox.md": 14407,
|
|
"ingest-docs.md": 18870,
|
|
"insert-phase.md": 8987,
|
|
"list-phase-assumptions.md": 4305,
|
|
"list-seeds.md": 6987,
|
|
"list-workspaces.md": 5699,
|
|
"manager.md": 27302,
|
|
"map-codebase.md": 20817,
|
|
"milestone-summary.md": 11842,
|
|
"mvp-phase.md": 13626,
|
|
"new-milestone.md": 37624,
|
|
"new-project.md": 66184,
|
|
"new-workspace.md": 11298,
|
|
"next.md": 20138,
|
|
"node-repair.md": 4173,
|
|
"note.md": 6563,
|
|
"onboard.md": 8590,
|
|
"pause-work.md": 14441,
|
|
"plan-milestone-gaps.md": 11809,
|
|
"plan-phase.md": 94391,
|
|
"plan-review-convergence.md": 23713,
|
|
"plant-seed.md": 11785,
|
|
"pr-branch.md": 15963,
|
|
"profile-user.md": 21246,
|
|
"progress.md": 32632,
|
|
"quick.md": 50993,
|
|
"reapply-patches.md": 20312,
|
|
"remove-phase.md": 8513,
|
|
"remove-workspace.md": 7551,
|
|
"resume-project.md": 17270,
|
|
"review.md": 50497,
|
|
"scan.md": 7728,
|
|
"secure-phase.md": 13622,
|
|
"session-report.md": 4044,
|
|
"settings-advanced.md": 40019,
|
|
"settings-integrations.md": 15892,
|
|
"settings.md": 33467,
|
|
"ship.md": 27945,
|
|
"sketch-wrap-up.md": 14267,
|
|
"sketch.md": 20004,
|
|
"smart-entry.md": 11124,
|
|
"spec-phase.md": 31987,
|
|
"spike-wrap-up.md": 15136,
|
|
"spike.md": 24561,
|
|
"stats.md": 6762,
|
|
"sync-skills.md": 6125,
|
|
"thread.md": 12508,
|
|
"transition.md": 22070,
|
|
"ui-phase.md": 26054,
|
|
"ui-review.md": 11216,
|
|
"ultraplan-phase.md": 10512,
|
|
"undo.md": 10431,
|
|
"update.md": 20914,
|
|
"validate-phase.md": 10849,
|
|
"verify-phase.md": 40949,
|
|
"verify-work.md": 40265
|
|
}
|