* test(#3147): bound the lint/changeset/docs cluster onto the process seam Migrates 69 unbounded sync spawn sites across 24 files. Allowlist 73 to 49. Two shared helpers move: tests/helpers/graphify.cjs (6 importing suites) and tests/fixtures/index.cjs, whose three quoted-argument shell strings became single argv elements rather than whitespace splits. changeset-lint's throw-native git() helper routes to gitOrThrow; migrating it to bare runGit would have silently swallowed a failure that is loud today. ingest-docs goes the other way -- its catch never rethrew, it degraded failure into data every call site asserts on, so throwIfFailed would have thrown where the original returned. The design doc said otherwise and was corrected. tsconfig-noemit runs a real tsc --noEmit and takes a bespoke 180000ms per the ensure-runtime-build precedent, not the 30000ms build-hooks norm -- that norm is for a file copy, and sizing against a label rather than the work is the same error in the opposite direction. * test(#3147): add toLegacyResult and settle review findings The seam exposed a throwing adapter (throwIfFailed) but no non-throwing one, so eight files independently re-derived the same unwrap back to the legacy {status, stdout, stderr} shape. That is the third time this epic produced N copies of one mechanism -- seven throw wrappers in Wave 1, fifty-two timeout constants in Wave 2, eight result adapters here. The pattern is that whenever the seam does not expose a mechanism, every suite re-derives it. toLegacyResult now sits beside throwIfFailed, with its own tests. Two sites are deliberately NOT converted: changeset-cli's runRender and runRenderIn return {status, report, stderr} from parsed JSON and never a raw stdout, so they are a different shape family. lint-legacy-dir-name keeps its local GUARD_TIMEOUT_MS: 30000 matches the build norm numerically but bounds a lint probe, not hooks bundling, and importing it would encode a coincidence as a relationship. --------- Co-authored-by: sim <sim@local>
113 lines
3.9 KiB
JavaScript
113 lines
3.9 KiB
JavaScript
'use strict';
|
|
|
|
// Shared test helpers for graphify test suite.
|
|
// Extracted from graphify.test.cjs to serve graphify*.test.cjs split files.
|
|
// Refs #3761.
|
|
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const os = require('node:os');
|
|
const { gitOrThrow } = require('./git-fixture.cjs');
|
|
|
|
function enableGraphify(planningDir) {
|
|
const configPath = path.join(planningDir, 'config.json');
|
|
const config = fs.existsSync(configPath)
|
|
? JSON.parse(fs.readFileSync(configPath, 'utf8'))
|
|
: {};
|
|
config.graphify = { enabled: true };
|
|
fs.writeFileSync(configPath, JSON.stringify(config, null, 2), 'utf8');
|
|
}
|
|
|
|
function writeGraphJson(planningDir, data) {
|
|
const graphsDir = path.join(planningDir, 'graphs');
|
|
fs.mkdirSync(graphsDir, { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(graphsDir, 'graph.json'),
|
|
JSON.stringify(data, null, 2),
|
|
'utf8'
|
|
);
|
|
}
|
|
|
|
function writeSnapshotJson(planningDir, data) {
|
|
const graphsDir = path.join(planningDir, 'graphs');
|
|
fs.mkdirSync(graphsDir, { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(graphsDir, '.last-build-snapshot.json'),
|
|
JSON.stringify(data, null, 2),
|
|
'utf8'
|
|
);
|
|
}
|
|
|
|
function gitHead(cwd) {
|
|
return gitOrThrow(['rev-parse', 'HEAD'], { cwd }).trim();
|
|
}
|
|
|
|
function commitEmpty(cwd, message) {
|
|
gitOrThrow(['commit', '--allow-empty', '-m', message], { cwd });
|
|
}
|
|
|
|
// Helper for auto-update status tests: builds a temp git project with
|
|
// optional .last-build-status.json written as autoUpdateValue.
|
|
// autoUpdateValue === null means no status file is written.
|
|
function makeStatusProject(autoUpdateValue) {
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gsd-3347-status-'));
|
|
gitOrThrow(['init', '-q', '-b', 'main'], { cwd: tmpDir });
|
|
gitOrThrow(['config', 'user.email', 'test@example.com'], { cwd: tmpDir });
|
|
gitOrThrow(['config', 'user.name', 'Test'], { cwd: tmpDir });
|
|
fs.writeFileSync(path.join(tmpDir, 'README.md'), '# t\n');
|
|
gitOrThrow(['add', '.'], { cwd: tmpDir });
|
|
gitOrThrow(['commit', '-qm', 'init'], { cwd: tmpDir });
|
|
fs.mkdirSync(path.join(tmpDir, '.planning/graphs'), { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(tmpDir, '.planning/config.json'),
|
|
JSON.stringify({ graphify: { enabled: true } }),
|
|
);
|
|
// Write a fresh (current-mtime) graph so age-based stale is false; only the
|
|
// auto-update status field can set stale: true.
|
|
fs.writeFileSync(
|
|
path.join(tmpDir, '.planning/graphs/graph.json'),
|
|
JSON.stringify({ nodes: [], edges: [] }),
|
|
);
|
|
if (autoUpdateValue !== null) {
|
|
fs.writeFileSync(
|
|
path.join(tmpDir, '.planning/graphs/.last-build-status.json'),
|
|
JSON.stringify(autoUpdateValue),
|
|
);
|
|
}
|
|
return tmpDir;
|
|
}
|
|
|
|
const SAMPLE_GRAPH = {
|
|
nodes: [
|
|
{ id: 'n1', label: 'AuthService', description: 'Handles user authentication and token validation', type: 'service' },
|
|
{ id: 'n2', label: 'UserModel', description: 'User database model for storing credentials', type: 'model' },
|
|
{ id: 'n3', label: 'SessionManager', description: 'Manages active user sessions', type: 'service' },
|
|
{ id: 'n4', label: 'EmailService', description: 'Sends notification emails', type: 'service' },
|
|
{ id: 'n5', label: 'Logger', description: 'Centralized logging utility', type: 'utility' },
|
|
],
|
|
edges: [
|
|
{ source: 'n1', target: 'n2', label: 'reads_from', confidence: 'EXTRACTED' },
|
|
{ source: 'n1', target: 'n3', label: 'creates', confidence: 'INFERRED' },
|
|
{ source: 'n2', target: 'n3', label: 'triggers', confidence: 'AMBIGUOUS' },
|
|
{ source: 'n3', target: 'n4', label: 'notifies', confidence: 'INFERRED' },
|
|
{ source: 'n4', target: 'n5', label: 'logs_via', confidence: 'EXTRACTED' },
|
|
],
|
|
hyperedges: [],
|
|
};
|
|
|
|
const SAMPLE_NODES_MINIMAL = [
|
|
{ id: 'n1', label: 'A', description: '', type: 'service' },
|
|
{ id: 'n2', label: 'B', description: '', type: 'model' },
|
|
];
|
|
|
|
module.exports = {
|
|
enableGraphify,
|
|
writeGraphJson,
|
|
writeSnapshotJson,
|
|
gitHead,
|
|
commitEmpty,
|
|
makeStatusProject,
|
|
SAMPLE_GRAPH,
|
|
SAMPLE_NODES_MINIMAL,
|
|
};
|