* feat(sdk): golden parity harness and query handler CJS alignment (#2302 Track A) Golden/read-only parity tests and registry alignment, query handler fixes (check-completion, state-mutation, commit, validate, summary, etc.), and WAITING.json dual-write for .gsd/.planning readers. Refs gsd-build/get-shit-done#2341 * fix(sdk): getMilestoneInfo matches GSD ROADMAP (🟡, last bold, STATE fallback) - Recognize in-flight 🟡 milestone bullets like 🚧. - Derive from last **vX.Y Title** before ## Phases when emoji absent. - Fall back to STATE.md milestone when ROADMAP is missing; use last bare vX.Y in cleaned text instead of first (avoids v1.0 from shipped list). - Fixes init.execute-phase milestone_version and buildStateFrontmatter after state.begin-phase (syncStateFrontmatter). * feat(sdk): phase list, plan task structure, requirements extract handlers - Register phase.list-plans, phase.list-artifacts, plan.task-structure, requirements.extract-from-plans (SDK-only; golden-policy exceptions). - Add unit tests; document in QUERY-HANDLERS.md. - writeProfile: honor --output, render dimensions, return profile_path and dimensions_scored. * feat(sdk): centralize getGsdAgentsDir in query helpers Extract agent directory resolution to helpers (GSD_AGENTS_DIR, primary ~/.claude/agents, legacy path). Use from init and docs-init init bundles. docs(15): add 15-CONTEXT for autonomous phase-15 run. * feat(sdk): query CLI CJS fallback and session correlation - createRegistry(eventStream, sessionId) threads correlation into mutation events - gsd-sdk query falls back to gsd-tools.cjs when no native handler matches (disable with GSD_QUERY_FALLBACK=off); stderr bridge warnings - Export createRegistry from @gsd-build/sdk; add sdk/README.md - Update QUERY-HANDLERS.md and registry module docs for fallback + sessionId - Agents: prefer node dist/cli.js query over cat/grep for STATE and plans * fix(sdk): init phase_found parity, docs-init agents path, state field extract - Normalize findPhase not-found to null before roadmap fallback (matches findPhaseInternal) - docs-init: use detectRuntime + resolveAgentsDir for checkAgentsInstalled - state.cjs stateExtractField: horizontal whitespace only after colon (YAML progress guard) - Tests: commit_docs default true; config-get golden uses temp config; golden integration green Refs: #2302 * refactor(sdk): share SessionJsonlRecord in profile-extract-messages CodeRabbit nit: dedupe JSONL record shape for isGenuineUserMessage and streamExtractMessages. * fix(sdk): address CodeRabbit major threads (paths, gates, audit, verify) - Resolve @file: and CLI JSON indirection relative to projectDir; guard empty normalized query command - plan.task-structure + intel extract/patch-meta: resolvePathUnderProject containment - check.config-gates: safe string booleans; plan_checker alias precedence over plan_check default - state.validate/sync: phaseTokenMatches + comparePhaseNum ordering - verify.schema-drift: token match phase dirs; files_modified from parsed frontmatter - audit-open: has_scan_errors, unreadable rows, human report when scans fail - requirements PLANNED key PLAN for root PLAN.md; gsd-tools timeout note - ingest-docs: repo-root path containment; classifier output slug-hash Golden parity test strips has_scan_errors until CJS adds field. * fix: Resolve CodeRabbit security and quality findings - Secure intel.ts and cli.ts against path traversal - Catch and validate git add status in commit.ts - Expand roadmap milestone marker extraction - Fix parsing array-of-objects in frontmatter YAML - Fix unhandled config evaluations - Improve coverage test parity mapping * test: raise planner character extraction limit to 48K * fix(sdk): resolve TS build error in docs-init passing config
215 lines
6.7 KiB
TypeScript
215 lines
6.7 KiB
TypeScript
/**
|
||
* Skill manifest — multi-root skill discovery scan.
|
||
*
|
||
* Full port of `buildSkillManifest` / `cmdSkillManifest` from
|
||
* `get-shit-done/bin/lib/init.cjs` (lines 1640–1847).
|
||
* Uses {@link extractFrontmatterLeading} — same as CJS `frontmatter.cjs` `extractFrontmatter`
|
||
* (first `---` block only; skills with later `---` rules must not use TS `extractFrontmatter`'s last-block rule).
|
||
*/
|
||
|
||
import { existsSync, readdirSync, readFileSync, writeFileSync, type Dirent } from 'node:fs';
|
||
import { join, resolve } from 'node:path';
|
||
import { homedir } from 'node:os';
|
||
|
||
import { extractFrontmatterLeading } from './frontmatter.js';
|
||
import type { QueryHandler } from './utils.js';
|
||
|
||
export interface SkillManifestSkill {
|
||
name: string;
|
||
description: string;
|
||
triggers: string[];
|
||
path: string;
|
||
file_path: string;
|
||
root: string;
|
||
scope: string;
|
||
installed: boolean;
|
||
deprecated: boolean;
|
||
}
|
||
|
||
export interface SkillManifestRoot {
|
||
root: string;
|
||
path: string;
|
||
scope: string;
|
||
present: boolean;
|
||
deprecated?: boolean;
|
||
skill_count?: number;
|
||
command_count?: number;
|
||
}
|
||
|
||
export interface SkillManifestJson {
|
||
skills: SkillManifestSkill[];
|
||
roots: SkillManifestRoot[];
|
||
installation: {
|
||
gsd_skills_installed: boolean;
|
||
legacy_claude_commands_installed: boolean;
|
||
};
|
||
counts: { skills: number; roots: number };
|
||
}
|
||
|
||
/**
|
||
* Scan canonical skill roots and build manifest JSON (same shape as gsd-tools.cjs).
|
||
*/
|
||
export function buildSkillManifest(cwd: string, skillsDir: string | null = null): SkillManifestJson {
|
||
const canonicalRoots = skillsDir
|
||
? [{
|
||
root: resolve(skillsDir),
|
||
path: resolve(skillsDir),
|
||
scope: 'custom',
|
||
present: existsSync(skillsDir),
|
||
kind: 'skills' as const,
|
||
}]
|
||
: [
|
||
{ root: '.claude/skills', path: join(cwd, '.claude', 'skills'), scope: 'project', kind: 'skills' as const },
|
||
{ root: '.agents/skills', path: join(cwd, '.agents', 'skills'), scope: 'project', kind: 'skills' as const },
|
||
{ root: '.cursor/skills', path: join(cwd, '.cursor', 'skills'), scope: 'project', kind: 'skills' as const },
|
||
{ root: '.github/skills', path: join(cwd, '.github', 'skills'), scope: 'project', kind: 'skills' as const },
|
||
{ root: '.codex/skills', path: join(cwd, '.codex', 'skills'), scope: 'project', kind: 'skills' as const },
|
||
{ root: '~/.claude/skills', path: join(homedir(), '.claude', 'skills'), scope: 'global', kind: 'skills' as const },
|
||
{ root: '~/.codex/skills', path: join(homedir(), '.codex', 'skills'), scope: 'global', kind: 'skills' as const },
|
||
{
|
||
root: '.claude/get-shit-done/skills',
|
||
path: join(homedir(), '.claude', 'get-shit-done', 'skills'),
|
||
scope: 'import-only',
|
||
kind: 'skills' as const,
|
||
deprecated: true,
|
||
},
|
||
{
|
||
root: '.claude/commands/gsd',
|
||
path: join(homedir(), '.claude', 'commands', 'gsd'),
|
||
scope: 'legacy-commands',
|
||
kind: 'commands' as const,
|
||
deprecated: true,
|
||
},
|
||
];
|
||
|
||
const skills: SkillManifestSkill[] = [];
|
||
const roots: SkillManifestRoot[] = [];
|
||
let legacyClaudeCommandsInstalled = false;
|
||
|
||
for (const rootInfo of canonicalRoots) {
|
||
const rootPath = rootInfo.path;
|
||
const rootSummary: SkillManifestRoot = {
|
||
root: rootInfo.root,
|
||
path: rootPath,
|
||
scope: rootInfo.scope,
|
||
present: existsSync(rootPath),
|
||
deprecated: 'deprecated' in rootInfo ? !!rootInfo.deprecated : false,
|
||
};
|
||
|
||
if (!rootSummary.present) {
|
||
roots.push(rootSummary);
|
||
continue;
|
||
}
|
||
|
||
if (rootInfo.kind === 'commands') {
|
||
let entries: Dirent[];
|
||
try {
|
||
entries = readdirSync(rootPath, { withFileTypes: true });
|
||
} catch {
|
||
roots.push(rootSummary);
|
||
continue;
|
||
}
|
||
const commandFiles = entries.filter(e => e.isFile() && e.name.endsWith('.md'));
|
||
rootSummary.command_count = commandFiles.length;
|
||
if (rootSummary.command_count > 0) legacyClaudeCommandsInstalled = true;
|
||
roots.push(rootSummary);
|
||
continue;
|
||
}
|
||
|
||
let entries: Dirent[];
|
||
try {
|
||
entries = readdirSync(rootPath, { withFileTypes: true });
|
||
} catch {
|
||
roots.push(rootSummary);
|
||
continue;
|
||
}
|
||
|
||
let skillCount = 0;
|
||
for (const entry of entries) {
|
||
if (!entry.isDirectory()) continue;
|
||
const entryName = entry.name.toString();
|
||
const skillMdPath = join(rootPath, entryName, 'SKILL.md');
|
||
if (!existsSync(skillMdPath)) continue;
|
||
|
||
let content: string;
|
||
try {
|
||
content = readFileSync(skillMdPath, 'utf-8');
|
||
} catch {
|
||
continue;
|
||
}
|
||
|
||
const frontmatter = extractFrontmatterLeading(content);
|
||
const name = (frontmatter.name as string) || entryName;
|
||
const description = (frontmatter.description as string) || '';
|
||
|
||
const triggers: string[] = [];
|
||
const bodyMatch = content.match(/^---[\s\S]*?---\s*\n([\s\S]*)$/);
|
||
if (bodyMatch) {
|
||
const body = bodyMatch[1];
|
||
const triggerLines = body.match(/^TRIGGER\s+when:\s*(.+)$/gim);
|
||
if (triggerLines) {
|
||
for (const line of triggerLines) {
|
||
const m = line.match(/^TRIGGER\s+when:\s*(.+)$/i);
|
||
if (m) triggers.push(m[1].trim());
|
||
}
|
||
}
|
||
}
|
||
|
||
skills.push({
|
||
name,
|
||
description,
|
||
triggers,
|
||
path: entryName,
|
||
file_path: `${entryName}/SKILL.md`,
|
||
root: rootInfo.root,
|
||
scope: rootInfo.scope,
|
||
installed: rootInfo.scope !== 'import-only',
|
||
deprecated: !!('deprecated' in rootInfo && rootInfo.deprecated),
|
||
});
|
||
skillCount++;
|
||
}
|
||
|
||
rootSummary.skill_count = skillCount;
|
||
roots.push(rootSummary);
|
||
}
|
||
|
||
skills.sort((a, b) => {
|
||
const rootCmp = a.root.localeCompare(b.root);
|
||
return rootCmp !== 0 ? rootCmp : a.name.localeCompare(b.name);
|
||
});
|
||
|
||
const gsdSkillsInstalled = skills.some(skill => skill.name.startsWith('gsd-'));
|
||
|
||
return {
|
||
skills,
|
||
roots,
|
||
installation: {
|
||
gsd_skills_installed: gsdSkillsInstalled,
|
||
legacy_claude_commands_installed: legacyClaudeCommandsInstalled,
|
||
},
|
||
counts: {
|
||
skills: skills.length,
|
||
roots: roots.length,
|
||
},
|
||
};
|
||
}
|
||
|
||
/**
|
||
* `skill-manifest` — same flags as gsd-tools: `--skills-dir`, `--write`.
|
||
*/
|
||
export const skillManifest: QueryHandler = async (args, projectDir) => {
|
||
const skillsDirIdx = args.indexOf('--skills-dir');
|
||
const skillsDir = skillsDirIdx >= 0 && args[skillsDirIdx + 1] ? args[skillsDirIdx + 1] : null;
|
||
const manifest = buildSkillManifest(projectDir, skillsDir);
|
||
|
||
if (args.includes('--write')) {
|
||
const planningDir = join(projectDir, '.planning');
|
||
if (existsSync(planningDir)) {
|
||
const manifestPath = join(planningDir, 'skill-manifest.json');
|
||
writeFileSync(manifestPath, JSON.stringify(manifest, null, 2), 'utf-8');
|
||
}
|
||
}
|
||
|
||
return { data: manifest };
|
||
};
|