* feat(#4401): register workflow.compact_content as a validated config key
- Add compact_content: false to the nested workflow object in
gsd-core/bin/shared/config-defaults.manifest.json
- Add 'workflow.compact_content': false to SCHEMA_DEFAULTS in src/config.cts
so an absent key resolves to false via config-get --raw
- validKeys entry in config-schema.manifest.json already present
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* test(#4401): behavioral and boundary tests for workflow.compact_content
- 19 behavioral tests covering config-set/config-get round trip, invalid-shape
rejection (banana, 42, empty string), the corrected null-unset semantics
(#2046), absent-key resolution against config-defaults.manifest.json,
config-new-project wiring, and doc-row shape assertions
- Drops the install-tree fixture-parity block (and its docstring item) that
asserted gsd-core/references/compact-content-gate.md and
gsd-core/workflows/compact/map-codebase.md fixture entries — those paths
belong to #4402 and do not exist on this filtered branch
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* docs(#4401): document workflow.compact_content in both config references
- One 4-cell row in docs/CONFIGURATION.md (workflow.* run)
- One 5-cell row under Workflow Fields in gsd-core/references/planning-config.md
- Both cross-reference ADR-4139
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* chore(#4401): add changeset
- Added-type fragment, pr: 4401 (issue number; backfill to the real PR number
is a required follow-up once the PR is opened, per D-08 and CHANGESET-PR-
FIELD-DRIFT)
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* chore(#4401): backfill changeset pr field to #4441
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(#4401): derive workflow.compact_content default from CONFIG_DEFAULTS
SCHEMA_DEFAULTS['workflow.compact_content'] hardcoded the literal false
instead of deriving it from CONFIG_DEFAULTS the way 3 of its 8 sibling
entries do (smart_zone_tokens, pr_strict, inline_plan_threshold), leaving
a single-source-of-truth drift risk: a future manifest-only edit to the
default could silently diverge from this literal, only caught later by
the D-03 test if it ever happened to manifest.
Adds compact_content to CONFIG_DEFAULTS in src/config-loader.cts and
derives SCHEMA_DEFAULTS from it in src/config.cts, matching the majority
sibling pattern. Found during maintainer review (review-open-prs) of
this PR.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* fix(#4401): map compact_content in config-field-docs NAMESPACE_MAP
The previous commit added compact_content to CONFIG_DEFAULTS in
src/config-loader.cts but missed the matching entry in
tests/config-field-docs.test.cjs's NAMESPACE_MAP, which maps flat
CONFIG_DEFAULTS keys to their namespaced doc form before checking
gsd-core/references/planning-config.md for a match. Without it, the
test looked for a bare `compact_content` doc reference instead of the
actual `workflow.compact_content` row, and failed:
"CONFIG_DEFAULTS keys missing from planning-config.md: compact_content".
Found by actually running gsd-test against the branch rather than
trusting the plausible-looking fix.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* test(#4401): register compact-content-4139 test in the docs-guard lane
tests/compact-content-4139.test.cjs's D-06 tests read docs/CONFIGURATION.md
directly (fs.readFileSync) to assert the workflow.compact_content doc row's
shape, which makes it a doc-reading test file under the #3753 docs-guard
lane. It was never added to scripts/docs-guard-registry.cjs's
DOCS_GUARD_TESTS map and carries no docs-guard-exempt marker, so
tests/ci-docs-guard-registry.test.cjs's registration lint correctly failed:
"compact-content-4139.test.cjs reads a docs/ path but is not registered in
the docs-guard lane and carries no docs-guard-exempt marker".
Registers it with ['docs/CONFIGURATION.md'] (the only real docs/-prefixed
path it reads; gsd-core/references/planning-config.md is outside this
registry's docs/ scope, matching the sibling config-field-docs.test.cjs
entry's existing convention).
Found by actually running gsd-test against the branch — this gap predates
the maintainer's config-loader.cts fix and was already present in the
original PR.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Tom Boucher <trekkie@nomorestars.com>
Co-authored-by: sim <sim@local>
e54d3aa159