* chore(#604): rename get-shit-done/ runtime directory to gsd-core/ Renames the installed runtime directory `get-shit-done/` to `gsd-core/` so the on-disk name matches the package (`@opengsd/gsd-core`), repo, and binary (`gsd-tools`). The npm package name and binary are unchanged; npx/npm consumers are unaffected. Mechanical (bulk, ~90% of the diff): - `git mv get-shit-done gsd-core` - Swept path/identifier references across the repo via `perl -pe 's/get-shit-done(?!-\w)/gsd-core/g'`. The negative lookahead preserves the five legitimate slug variants that are NOT the directory: get-shit-done-{OLD,cc,classic,cli,redux} (old package/repo names). - Build/manifest wiring: package.json (bin, files, coverage globs), tsconfig.build.json (outDir), ~86 .gitignore build-output entries, stryker.config.mjs, scan-ignore files, install.js path strings. - Frozen (not rewritten): CHANGELOG.md history; translated docs (README.<locale>.md and docs/{ja-JP,ko-KR,pt-BR,zh-CN}/). New logic (review here): - src/installer-migrations/003-rename-get-shit-done-to-gsd-core.cts: a proper ADR-0008 installer migration. On upgrade it walks the legacy `~/.claude/get-shit-done/` tree, classifies each file via the prior install manifest, and emits remove-managed / backup-and-remove for managed files while PRESERVING unknown user-added files. Symlink-safe (skips a symlinked root and symlinked entries; bounds-checks every path under configDir). The framework rolls back on install failure. Emptied dirs may remain (framework has no recursive dir-removal primitive) — documented. - scripts/lint-legacy-dir-name.cjs: CI regression guard forbidding the bare `get-shit-done` directory token (split token to avoid self-match; case- insensitive; `(?!-\w)` lookahead allows the slug variants; allowlists CHANGELOG, translated docs, and `gsd-allow-legacy-name` marker lines). Wired into the lint-tests CI job. - Restored scripts/lint-package-identity-drift.cjs detection regexes (the mechanical sweep had wrongly rewritten the old-name patterns it exists to detect) and marked them as intentional legacy references. - TDD tests for the migration and the guard; do.md slash-command guard regex tightened so a `/gsd-core/bin` path segment is not mistaken for a command; changeset + docs/installer-migrations.md row added. Breaking: the installed runtime path moves `~/.claude/get-shit-done/` -> `~/.claude/gsd-core/`. Migration 003 removes the stale legacy dir's managed files (preserving user files) on upgrade. Users with custom hooks/configs hardcoding the old path must update them. Closes #604 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unsweep pending changesets + allowlist injection-example docs CI fixes for the rename PR: - Do not sweep pending .changeset/*.md (ephemeral release-note fragments, like CHANGELOG); reverted those body edits so 5 pre-existing malformed fragments (missing type/pr) no longer enter the PR diff and trip docs-lint. Allowlisted .changeset/ in the legacy-name guard accordingly. - Allowlisted TEST-EXAMPLES.md and docs/explanation/security-model.md in prompt-injection-scan.sh: they contain intentional injection examples / security-model prose; the path-reference rewrites are kept. CodeQL alerts on this PR are pre-existing (alert lines unchanged by this PR; none in the new migration/guard) and are out of scope for the rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): resolve CodeQL alerts surfaced on this PR The rename diff touched files carrying pre-existing CodeQL findings; per the no-pre-existing-dismissal rule, fixing every surfaced alert rather than waving them off. All behavior-preserving: - scripts/ci-test-scope.cjs: build the config-path match from string .includes() instead of a RegExp over an arg-derived value (js/regex-injection). - src/profile-output.cts: escape backslashes before pipe-escaping desc/safeName so the table-cell escape is complete (js/incomplete-sanitization). - tests/{bug-2643,bug-2808,docs-parity-live-registry}: two-pass HTML-comment strip so a bare/unclosed `<!--` cannot survive (js/incomplete-multi-character-sanitization). - tests/inline-plan-threshold: drop the no-op `\s`->`\s` identity replace, keep the meaningful POSIX-class conversion (js/identity-replacement). Verified: build:lib green; the touched test files + ci-test-scope + profile-output suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): correctly resolve remaining CodeQL alerts (regex-injection + sanitization) The prior commit's fixes for two alerts were ineffective: - ci-test-scope.cjs js/regex-injection: the alert is the CLI-arg-derived `file` reaching static regex `.test(file)` calls (not the config rule). Removed ALL regex over file/t — startsWith/includes/=== string checks + an isWindowsHint helper — so there is no regex sink for the tainted value. - js/incomplete-multi-character-sanitization (3 test files): a single `.replace(/<!--...-->/g,'')` can let `<!--` re-form. Replaced with a fixpoint loop (replace until stable) plus a final bare-opener strip. Verified: no regex over file/t remains; ci-test-scope + the 3 test suites pass; lint:legacy-name clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): make ci-test-scope + comment-strippers regex-free to clear CodeQL CodeQL flags the regex PATTERNS syntactically (regex-injection on the --files arg split; incomplete-multi-character-sanitization on the <!--...--> replace), so loop fixes do not satisfy it. Made these paths regex-free: - ci-test-scope.cjs splitFiles: char-by-char separator tokenizer (no /[,\\s]+/). - 3 test files: indexOf/slice HTML-comment stripper (no .replace(/<!--/)). Behavior preserved; ci-test-scope + the 3 suites pass; guard clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): unblock security base64 scan on the large rename diff The security job hit its 10m timeout: base64-scan.sh choked on the binary test fixture tests/feat-3594-parser-property-style.test.cjs (embedded NUL/ non-UTF8 bytes -> thousands of bogus blobs + "ignored null byte" warnings), and the ~800-file rename diff is slow to scan regardless. - scripts/base64-scan.sh: skip binary-by-content files (grep -Iq .) — they can't carry base64-obfuscated *text* and feeding NUL bytes through the per-line scanner is pathologically slow. collect_files already filtered binary *extensions*; this catches binary *content* in text extensions. - .github/workflows/security-scan.yml: raise the security job timeout 10m->30m to accommodate very large diffs (the scan itself is unchanged). Verified locally: scan skips the fixture, 0 "ignored null byte" warnings, 0 findings, exit 0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): sweep get-shit-done refs introduced by merging next The branch was updated with next (#614/#384/#618 etc.), which reference the get-shit-done/ dir (still named that on next). Swept the stale references in the merged files to gsd-core so the rename stays consistent and lint:legacy-name passes: - commands/gsd/discuss-phase.md (runtime-launcher shim paths) - src/core.cts (getAgentsDir layout comments) - tests/bug-384-agents-runtime-aware.test.cjs (require path to runtime lib) Verified: guard 0 violations; build green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): exclude gsd-core/ path segments from bug-3683 command cross-ref invariant The #614 runtime-launcher shim added to discuss-phase.md references `${_GSD_RUNTIME_ROOT}/gsd-core/bin/...`. bug-3683's REF_PATTERN excluded path-y refs only via lookbehind, but `}` precedes `/gsd-core/` in the shim, so it mis-read the directory path as a dangling `/gsd-core` command ref (same class as the #604 bug-2954 fix). Added a trailing `(?![\w-]*\/)` so `/gsd-<x>/...` path segments are not treated as slash-command references. Verified locally on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22 image) full suite: 0 failures - bug-3683 + bug-2954 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): lazily resolve findProjectRoot in gsd-tools (harden flaky CI) CI intermittently failed state.test's gsd-tools subprocess with "findProjectRoot is not a function" (flip-flopping across legs; not reproducible on mac full suite, gsd-test linux full suite, test:unit, or state.test x8). findProjectRoot is a re-export from core.cjs (sourced from project-root.cjs); binding it via destructure at module-load can be undefined under a load-ordering edge. Resolve it lazily at call time via a small wrapper so the lookup happens after core.cjs is fully initialized. Verified green on BOTH platforms before pushing: - mac (node 26) full suite: 0 failures - gsd-test-runner (linux, node22) full suite: 0 failures - state.test.cjs: 106/106; gsd-tools loads cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(#604): allowlist verification-patterns.md placeholder examples in secret scan The rename git-mv'd references/verification-patterns.md into gsd-core/, pulling it into the secret-scan diff. It documents stub/placeholder RED-FLAG env-var examples (illustrative Stripe test-key / database-URL / API-key placeholders) — not real credentials. Added it to .secretscanignore with the strict annotation, mirroring the existing gsd-core/workflows/plan-phase.md exception. Verified locally: secret-scan-lint --strict OK; secret-scan --diff origin/next exits 0 with 0 findings. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
227 lines
8.1 KiB
TypeScript
227 lines
8.1 KiB
TypeScript
/**
|
|
* Model catalog — typed access to model-catalog.json.
|
|
*
|
|
* ADR-457 build-at-publish: the hand-written bin/lib/model-catalog.cjs
|
|
* collapsed to a TypeScript source of truth. Behaviour is preserved
|
|
* byte-for-behaviour from the prior hand-written .cjs; only types are added.
|
|
*/
|
|
|
|
import path from 'node:path';
|
|
|
|
// In .cts (CommonJS output) files, `require` is available as a global;
|
|
// we use it directly to load JSON candidates.
|
|
const _require: NodeRequire = require;
|
|
|
|
// Resolve model-catalog.json via a prioritised candidate list so the module
|
|
// works in every layout:
|
|
//
|
|
// 1. Co-located install path — gsd-core/bin/shared/model-catalog.json
|
|
// 2. Source-repo dev path — sdk/shared/model-catalog.json
|
|
// 3. GSD_MODEL_CATALOG env override
|
|
const _catalogCandidates: string[] = [
|
|
path.resolve(__dirname, '..', 'shared', 'model-catalog.json'),
|
|
path.resolve(__dirname, '..', '..', '..', 'sdk', 'shared', 'model-catalog.json'),
|
|
...(process.env['GSD_MODEL_CATALOG'] ? [path.resolve(process.env['GSD_MODEL_CATALOG'])] : []),
|
|
];
|
|
|
|
/** Typed tier entry from model-catalog.json (model + optional reasoning_effort). */
|
|
export interface TierEntry {
|
|
model: string;
|
|
reasoning_effort?: string;
|
|
}
|
|
|
|
/** Per-agent model mapping in the catalog. */
|
|
export interface AgentMeta {
|
|
golden: string;
|
|
balanced: string;
|
|
budget: string;
|
|
phaseType: string;
|
|
routingTier: string;
|
|
}
|
|
|
|
/** The shape of model-catalog.json. */
|
|
export interface ModelCatalog {
|
|
profiles: string[];
|
|
phaseTypes: string[];
|
|
adaptiveTierMap: Record<string, string>;
|
|
runtimeTierDefaults: Record<string, Record<string, TierEntry | null>>;
|
|
providerPresets: Record<string, Record<string, Record<string, TierEntry | null>>>;
|
|
agents: Record<string, AgentMeta>;
|
|
}
|
|
|
|
let catalog: ModelCatalog | null = null;
|
|
let _catalogLastErr: Error | null = null;
|
|
for (const _p of _catalogCandidates) {
|
|
try {
|
|
catalog = _require(_p) as ModelCatalog;
|
|
break;
|
|
} catch (e) {
|
|
const isMissingCandidate =
|
|
(e && (e as NodeJS.ErrnoException).code === 'MODULE_NOT_FOUND' && String((e as Error).message || '').includes(_p)) ||
|
|
(e && (e as NodeJS.ErrnoException).code === 'ENOENT');
|
|
if (!isMissingCandidate) throw e;
|
|
_catalogLastErr = e as Error;
|
|
}
|
|
}
|
|
if (!catalog) {
|
|
throw new Error(
|
|
`model-catalog.json not found. Tried:\n${_catalogCandidates.map((p) => ` ${p}`).join('\n')}\nLast error: ${_catalogLastErr?.message}`
|
|
);
|
|
}
|
|
|
|
// After the throw guard above, catalog is guaranteed non-null.
|
|
const _catalog = catalog;
|
|
|
|
export { _catalog as catalog };
|
|
|
|
export const VALID_PROFILES: string[] = [..._catalog.profiles];
|
|
export const VALID_PHASE_TYPES: Set<string> = new Set(_catalog.phaseTypes);
|
|
export const VALID_AGENT_TIERS: Set<string> = new Set(Object.keys(_catalog.adaptiveTierMap));
|
|
|
|
/** Per-profile model slots for each agent. */
|
|
export interface AgentModelProfiles {
|
|
quality: string;
|
|
balanced: string;
|
|
budget: string;
|
|
adaptive: string;
|
|
}
|
|
|
|
export const MODEL_PROFILES: Record<string, AgentModelProfiles> = Object.fromEntries(
|
|
Object.entries(_catalog.agents).map(([agent, meta]) => [agent, {
|
|
quality: meta.golden,
|
|
balanced: meta.balanced,
|
|
budget: meta.budget,
|
|
adaptive: _catalog.adaptiveTierMap[meta.routingTier],
|
|
}])
|
|
);
|
|
|
|
export const AGENT_TO_PHASE_TYPE: Record<string, string> = Object.fromEntries(
|
|
Object.entries(_catalog.agents).map(([agent, meta]) => [agent, meta.phaseType])
|
|
);
|
|
|
|
export const AGENT_DEFAULT_TIERS: Record<string, string> = Object.fromEntries(
|
|
Object.entries(_catalog.agents).map(([agent, meta]) => [agent, meta.routingTier])
|
|
);
|
|
|
|
export const MODEL_ALIAS_MAP: Record<string, string | undefined> = Object.fromEntries(
|
|
Object.entries(_catalog.runtimeTierDefaults['claude'] ?? {}).map(([tier, entry]) => [tier, entry?.model])
|
|
);
|
|
|
|
export const RUNTIME_PROFILE_MAP: Record<string, Record<string, TierEntry>> = (() => {
|
|
const result: Record<string, Record<string, TierEntry>> = {};
|
|
for (const [runtime, tiers] of Object.entries(_catalog.runtimeTierDefaults)) {
|
|
const filtered: Record<string, TierEntry> = {};
|
|
for (const [tier, entry] of Object.entries(tiers)) {
|
|
if (entry) filtered[tier] = entry;
|
|
}
|
|
if (Object.keys(filtered).length > 0) result[runtime] = filtered;
|
|
}
|
|
return result;
|
|
})();
|
|
|
|
export const KNOWN_RUNTIMES: Set<string> = new Set(Object.keys(_catalog.runtimeTierDefaults));
|
|
export const RUNTIMES_WITH_REASONING_EFFORT: Set<string> = new Set(
|
|
Object.entries(_catalog.runtimeTierDefaults)
|
|
.filter(([, tiers]) => Object.values(tiers).some((entry) => entry && entry.reasoning_effort))
|
|
.map(([runtime]) => runtime)
|
|
);
|
|
|
|
export const PROVIDER_PRESETS: Record<string, Record<string, Record<string, TierEntry | null>>> =
|
|
_catalog.providerPresets ?? {};
|
|
|
|
// KNOWN_PROVIDERS excludes 'generic' — it is a sentinel (all null entries) that
|
|
// forces users to supply model IDs via model_profile_overrides. It is not a
|
|
// real catalog-backed provider (#49).
|
|
export const KNOWN_PROVIDERS: Set<string> = new Set(
|
|
Object.entries(PROVIDER_PRESETS)
|
|
.filter(([, tiers]) =>
|
|
Object.values(tiers).some((budgets) =>
|
|
budgets && Object.values(budgets).some((entry) => entry && entry.model)
|
|
)
|
|
)
|
|
.map(([name]) => name)
|
|
);
|
|
|
|
export function nextTier(currentTier: string): string | null {
|
|
const order = ['light', 'standard', 'heavy'];
|
|
const idx = order.indexOf(String(currentTier));
|
|
if (idx === -1) return null;
|
|
return order[Math.min(idx + 1, order.length - 1)];
|
|
}
|
|
|
|
export function formatAgentToModelMapAsTable(agentToModelMap: Record<string, string>): string {
|
|
const agentWidth = Math.max('Agent'.length, ...Object.keys(agentToModelMap).map((a) => a.length));
|
|
const modelWidth = Math.max('Model'.length, ...Object.values(agentToModelMap).map((m) => m.length));
|
|
const sep = '─'.repeat(agentWidth + 2) + '┼' + '─'.repeat(modelWidth + 2);
|
|
const header = ` ${'Agent'.padEnd(agentWidth)} │ ${'Model'.padEnd(modelWidth)}`;
|
|
let out = `${header}\n${sep}\n`;
|
|
for (const [agent, model] of Object.entries(agentToModelMap)) {
|
|
out += ` ${agent.padEnd(agentWidth)} │ ${model.padEnd(modelWidth)}\n`;
|
|
}
|
|
return out;
|
|
}
|
|
|
|
export function getAgentToModelMapForProfile(normalizedProfile: string): Record<string, string> {
|
|
const profile = VALID_PROFILES.includes(normalizedProfile) ? normalizedProfile : 'balanced';
|
|
const out: Record<string, string> = {};
|
|
for (const [agent, profiles] of Object.entries(MODEL_PROFILES)) {
|
|
const profilesRec = profiles as unknown as Record<string, string>;
|
|
out[agent] = profile === 'inherit' ? 'inherit' : (profilesRec[profile] ?? profiles.balanced);
|
|
}
|
|
return out;
|
|
}
|
|
|
|
// ─── Effort rendering ────────────────────────────────────────────────────────
|
|
|
|
export interface EffortSpec {
|
|
param: string;
|
|
channel: string;
|
|
supported: Set<string>;
|
|
clamp(level: string): string;
|
|
}
|
|
|
|
export const EFFORT_RENDERING: Record<string, EffortSpec> = {
|
|
claude: {
|
|
param: 'output_config.effort',
|
|
channel: 'frontmatter',
|
|
supported: new Set(['low', 'medium', 'high', 'xhigh', 'max']),
|
|
clamp(level: string): string {
|
|
if (level === 'minimal') return 'low';
|
|
return level;
|
|
},
|
|
},
|
|
codex: {
|
|
param: 'model_reasoning_effort',
|
|
channel: 'api',
|
|
supported: new Set(['minimal', 'low', 'medium', 'high', 'xhigh']),
|
|
clamp(level: string): string {
|
|
if (level === 'max') return 'xhigh';
|
|
return level;
|
|
},
|
|
},
|
|
};
|
|
|
|
export interface RenderedEffort {
|
|
value: string;
|
|
param: string | null;
|
|
channel: string | null;
|
|
}
|
|
|
|
/**
|
|
* Render a universal effort string for a specific runtime.
|
|
*/
|
|
export function renderEffortForRuntime(runtime: string, universalEffort: string): RenderedEffort {
|
|
const spec = EFFORT_RENDERING[runtime];
|
|
if (!spec) {
|
|
return { value: universalEffort, param: null, channel: null };
|
|
}
|
|
return {
|
|
value: spec.clamp(universalEffort),
|
|
param: spec.param,
|
|
channel: spec.channel,
|
|
};
|
|
}
|
|
|
|
// ─── Fast mode propagation ───────────────────────────────────────────────────
|
|
export const RUNTIMES_WITH_FAST_MODE: Set<string> = new Set(['api']);
|