Fold Claude Code's install/uninstall onto the Embeddable Orchestration System
(ADR-1239 Phase D). claude is GSD's tier-1 reference host, but its install path
was still driven by 13 hardcoded `runtime === 'claude'` string-equality branches
scattered across bin/install.js rather than the public Host-Integration Interface.
- Route install()/uninstall() through `createImperativeAdapter({runtime})` — the
adapter delegates to the SAME installRuntimeArtifacts/uninstallRuntimeArtifacts
engine calls, so output is byte-identical (proven pre/post, both scopes).
- Replace all 13 `runtime === 'claude'` / `runtime !== 'claude'` branches with
descriptor-driven `runtime.hostBehaviors` lookups on capabilities/claude/
capability.json (attributionSource, authorsCanonicalWorkflow, localInstallStyle,
permissionsSchema, settingsFileByScope, sourceMarkerFile, agentFrontmatterExtensions,
ownsClaudePaths, nativeModelAliases, skillsGlobalOnboarding). Behavior is
identical; the brittle string-equality coupling (the add-a-host tax) is gone.
- Single-source the scattered literal 'claude' defaults/rosters behind DEFAULT_RUNTIME.
- Extend golden-install-parity to assert the claude LOCAL legacy layout is
byte-identical too (AC1 "both scopes"); exclude the platform-varying
settings.local.json (same reason settings.json is excluded).
- New tests/claude-imperative-reference.test.cjs: adapter kind, programmatic-cli
profile, fail-closed negotiation on a corrupted/partial descriptor, and an AC2
source guard that no `runtime === 'claude'` branch remains.
No user-visible install-output change (internal architecture only).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
139 lines
7.2 KiB
JavaScript
139 lines
7.2 KiB
JavaScript
// allow-test-rule: AC2 requires asserting no `runtime === 'claude'` string-equality branch remains in bin/install.js — the descriptor-migration contract is a property of the source text, so a source-grep is the only faithful check (#2086)
|
|
'use strict';
|
|
|
|
/**
|
|
* claude imperative reference host — ADR-1239 Phase D / #2086 (EoS/claude).
|
|
*
|
|
* claude is GSD's tier-1 reference host — "golden parity vs. the Claude reference
|
|
* host" (ADR-1239 line 146). This proves claude is driven through the PUBLIC
|
|
* Host-Integration Interface (the imperative adapter), that its negotiated axes
|
|
* classify + negotiate correctly, that negotiation FAILS CLOSED on a corrupted
|
|
* descriptor, and that the migration retired the hardcoded `runtime === 'claude'`
|
|
* string-equality branches in bin/install.js (folded into descriptor-driven
|
|
* `runtime.hostBehaviors`).
|
|
*
|
|
* Mirrors tests/pi-imperative-reference.test.cjs + tests/vscode-ide-reference.test.cjs
|
|
* but binds against the REAL descriptor + the REAL installer source, since claude
|
|
* (unlike pi/vscode) has a real production install being folded in.
|
|
*/
|
|
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const { createImperativeAdapter } = require('../gsd-core/bin/lib/adapter-imperative.cjs');
|
|
const {
|
|
profileOf,
|
|
negotiateHostCapabilities,
|
|
PROTOCOL_VERSION,
|
|
PROFILE_BASELINES,
|
|
UNDOCUMENTED,
|
|
} = require('../gsd-core/bin/lib/host-integration.cjs');
|
|
|
|
const CLAUDE_CAP = JSON.parse(
|
|
fs.readFileSync(path.join(__dirname, '..', 'capabilities', 'claude', 'capability.json'), 'utf8'),
|
|
);
|
|
const CLAUDE_AXES = CLAUDE_CAP.runtime.hostIntegration;
|
|
|
|
// -- AC2: driven through the public interface (imperative adapter) -----------
|
|
|
|
test('createImperativeAdapter classifies claude as imperative + composes the registry', () => {
|
|
const adapter = createImperativeAdapter({ runtime: 'claude' });
|
|
assert.equal(adapter.kind, 'imperative', "claude embeddingMode is imperative -> adapter kind must be 'imperative'");
|
|
assert.equal(adapter.runtime, 'claude');
|
|
assert.ok(adapter.registry && typeof adapter.registry === 'object', 'imperative adapter exposes the composed capability registry');
|
|
assert.equal(typeof adapter.install, 'function');
|
|
assert.equal(typeof adapter.uninstall, 'function');
|
|
});
|
|
|
|
test('claude descriptor embeddingMode agrees with the imperative adapter kind', () => {
|
|
assert.equal(CLAUDE_AXES.embeddingMode, 'imperative', 'capability.json must declare embeddingMode: imperative for the imperative binding');
|
|
});
|
|
|
|
test('claude axes classify as the programmatic-cli reference profile', () => {
|
|
assert.equal(profileOf(CLAUDE_AXES), 'programmatic-cli');
|
|
assert.notEqual(profileOf(CLAUDE_AXES), 'ide');
|
|
});
|
|
|
|
// -- AC3: every negotiated axis populated, negotiation is clean ---------------
|
|
|
|
test('claude negotiates its declared axes verbatim (no degradation of documented values)', () => {
|
|
const result = negotiateHostCapabilities({ ...CLAUDE_AXES, protocolVersion: PROTOCOL_VERSION });
|
|
assert.equal(result.protocolVersion, PROTOCOL_VERSION);
|
|
// Every declared scalar axis survives negotiation unchanged (all are known+documented).
|
|
assert.equal(result.effective.embeddingMode, 'imperative');
|
|
assert.equal(result.effective.commandSurface, CLAUDE_AXES.commandSurface);
|
|
assert.equal(result.effective.modelMode, CLAUDE_AXES.modelMode);
|
|
assert.equal(result.effective.hookBus, CLAUDE_AXES.hookBus);
|
|
assert.equal(result.effective.stateIO, CLAUDE_AXES.stateIO);
|
|
assert.equal(result.effective.transport, CLAUDE_AXES.transport);
|
|
assert.equal(result.effective.runtime, CLAUDE_AXES.runtime);
|
|
// No `undocumented` sentinel anywhere in claude's declared axes.
|
|
assert.ok(
|
|
!JSON.stringify(CLAUDE_AXES).includes(UNDOCUMENTED),
|
|
'claude descriptor must carry no `undocumented` sentinel (fully doc-sourced)',
|
|
);
|
|
});
|
|
|
|
// -- AC5: negotiation fails CLOSED on a corrupted / partial descriptor --------
|
|
|
|
test('negotiateHostCapabilities never throws for claude — even fully corrupted input', () => {
|
|
assert.doesNotThrow(() => negotiateHostCapabilities({}));
|
|
assert.doesNotThrow(() => negotiateHostCapabilities({ embeddingMode: UNDOCUMENTED }));
|
|
assert.doesNotThrow(() => negotiateHostCapabilities({ embeddingMode: 'wildly-unknown-future-value' }));
|
|
});
|
|
|
|
test('a partial/empty claude descriptor degrades to the safe floor — NOT the full programmatic-cli baseline', () => {
|
|
const result = negotiateHostCapabilities({});
|
|
// Fail-closed floor (SAFE_DEFAULTS), not the rich profile baseline.
|
|
assert.equal(result.effective.embeddingMode, 'declarative', 'omitted embeddingMode degrades closed to declarative');
|
|
assert.equal(result.effective.hookBus, 'none', 'omitted hookBus degrades closed to none');
|
|
assert.equal(result.effective.commandSurface, 'prose-only', 'omitted commandSurface degrades closed to prose-only');
|
|
assert.equal(result.effective.dispatch.namedDispatch, false, 'omitted dispatch degrades closed (no named dispatch)');
|
|
assert.notDeepEqual(
|
|
result.effective,
|
|
PROFILE_BASELINES['programmatic-cli'],
|
|
'a corrupted descriptor MUST NOT silently reuse the full programmatic-cli baseline',
|
|
);
|
|
assert.ok(result.warnings.length > 0, 'degrade-closed must surface warnings');
|
|
});
|
|
|
|
test('an undocumented/unknown claude axis value is not trusted (degraded closed per-axis)', () => {
|
|
const corrupted = { ...CLAUDE_AXES, embeddingMode: UNDOCUMENTED, hookBus: 'unknown-bus-kind' };
|
|
const result = negotiateHostCapabilities(corrupted);
|
|
assert.equal(result.effective.embeddingMode, 'declarative', 'undocumented embeddingMode -> safe floor');
|
|
assert.equal(result.effective.hookBus, 'none', 'unknown hookBus value -> safe floor');
|
|
// Untouched axes still negotiate to their declared (documented) values.
|
|
assert.equal(result.effective.stateIO, CLAUDE_AXES.stateIO);
|
|
});
|
|
|
|
// -- AC2: the hardcoded string-equality branches are retired ------------------
|
|
|
|
test('claude descriptor declares runtime.hostBehaviors (the folded-in host behaviors)', () => {
|
|
const hb = CLAUDE_CAP.runtime.hostBehaviors;
|
|
assert.ok(hb && typeof hb === 'object', 'capabilities/claude/capability.json must declare runtime.hostBehaviors');
|
|
// The behaviors that replaced the 13 `runtime === 'claude'` branches.
|
|
assert.equal(hb.permissionsSchema, 'claude');
|
|
assert.equal(hb.localInstallStyle, 'legacy-flat');
|
|
assert.equal(hb.sourceMarkerFile, '.gsd-source');
|
|
assert.equal(hb.authorsCanonicalWorkflow, true);
|
|
assert.equal(hb.ownsClaudePaths, true);
|
|
assert.equal(hb.nativeModelAliases, true);
|
|
assert.equal(hb.skillsGlobalOnboarding, true);
|
|
assert.equal(hb.attributionSource, 'settings-json-commit');
|
|
assert.deepEqual(hb.agentFrontmatterExtensions, ['effort']);
|
|
assert.equal(hb.settingsFileByScope.local, 'settings.local.json');
|
|
assert.equal(hb.settingsFileByScope.global, 'settings.json');
|
|
});
|
|
|
|
test('bin/install.js contains no `runtime === "claude"` / `runtime !== "claude"` string-equality branches (AC2)', () => {
|
|
const src = fs.readFileSync(path.join(__dirname, '..', 'bin', 'install.js'), 'utf8');
|
|
const offenders = src.match(/runtime\s*[!=]==\s*'claude'/g) || [];
|
|
assert.deepEqual(
|
|
offenders,
|
|
[],
|
|
`AC2: every hardcoded runtime==='claude'/!=='claude' branch must be descriptor-driven; found: ${offenders.join(', ')}`,
|
|
);
|
|
});
|