fe3ed06691
Some checks failed
Tests / PR mergeability (push) Successful in 18s
Tests / Base branch health (push) Successful in 9s
Tests / Detect test scope (push) Successful in 16s
Tests / lint-tests (push) Failing after 1m43s
Tests / plugin-validate (push) Successful in 58s
Tests / test (ubuntu-latest, 24, shard 1/3) (push) Failing after 19s
Tests / test (ubuntu-latest, 24, shard 2/3) (push) Failing after 20s
Tests / test (ubuntu-latest, 24, shard 3/3) (push) Failing after 20s
Tests / test (ubuntu-latest, 24) (push) Failing after 18s
Tests / test (inert CI) (push) Has been skipped
Tests / QA loop walk (smell ratchet) (push) Failing after 19s
Tests / Coverage gate (merged shards) (push) Has been skipped
Tests / Publish emitted-baseline artifact (push) Has been skipped
Duplicate auto-close sweep / sweep (push) Successful in 19s
CI timeout budget report / report (push) Failing after 14s
Close Draft PRs (sweep) / Sweep open draft PRs (push) Successful in 9s
Dismiss Unauthorized PR Approvals / dismiss-unauthorized-approval (push) Successful in 9s
Tests / conformance test (macos-latest, 24) (push) Has been cancelled
Tests / conformance test (windows-latest, 24, shard 1/3) (push) Has been cancelled
Tests / conformance test (windows-latest, 24, shard 2/3) (push) Has been cancelled
Tests / conformance test (windows-latest, 24, shard 3/3) (push) Has been cancelled
Tests / Required tests (push) Has been cancelled
3008 lines
125 KiB
JavaScript
3008 lines
125 KiB
JavaScript
// docs-guard-exempt: docs/... substrings are external URL citations (code.claude.com) in comments, not repo paths.
|
||
/**
|
||
* Installer Module — Sections 9–11 + 13.
|
||
*
|
||
* Covers: install-profiles unit tests (MINIMAL_SKILL_ALLOWLIST, isMinimalMode,
|
||
* shouldInstallSkill, stageSkillsForMode, cleanupStagedSkills),
|
||
* --minimal per-runtime E2E (spawned), --minimal manifest mode + downgrade,
|
||
* and hooks copy / manifest / uninstall settings cleanup.
|
||
*
|
||
* Consolidates (original sources from #3758):
|
||
* install-minimal.test.cjs
|
||
* install-minimal-all-runtimes.test.cjs
|
||
* install-minimal-backcompat.test.cjs
|
||
* install-hooks-copy.test.cjs
|
||
*
|
||
* Closes #3758
|
||
*/
|
||
|
||
'use strict';
|
||
|
||
process.env.MSD_TEST_MODE = '1';
|
||
|
||
const { test, describe, beforeEach, afterEach, before, after } = require('node:test');
|
||
const assert = require('node:assert/strict');
|
||
const fs = require('node:fs');
|
||
const path = require('node:path');
|
||
const os = require('node:os');
|
||
|
||
const { runNode } = require('./helpers/process-seam.cjs');
|
||
const { throwIfFailed } = require('./helpers/git-fixture.cjs');
|
||
|
||
const {
|
||
PROBE_TIMEOUT_MS,
|
||
INSTALL_TIMEOUT_MS,
|
||
FIXTURE_HOOK_TIMEOUT_SECONDS,
|
||
} = require('./helpers/timeouts.cjs');
|
||
|
||
const { createTempDir, cleanup } = require('./helpers.cjs');
|
||
|
||
const {
|
||
writeManifest,
|
||
MSD_UNINSTALL_HOOKS,
|
||
resolveSharedHooksDirName,
|
||
stripStaleMsdHookBlocks,
|
||
} = require('../bin/install.js');
|
||
|
||
const {
|
||
MINIMAL_SKILL_ALLOWLIST,
|
||
PROFILES,
|
||
isMinimalMode,
|
||
shouldInstallSkill,
|
||
stageSkillsForMode,
|
||
cleanupStagedSkills,
|
||
} = require('../msd-core/bin/lib/install-profiles.cjs');
|
||
|
||
const {
|
||
INSTALL_SCRIPT,
|
||
MANIFEST_NAME,
|
||
BUILD_SCRIPT,
|
||
HOOKS_DIST,
|
||
EXPECTED_SH_HOOKS,
|
||
EXPECTED_ALL_HOOKS,
|
||
SKILL_RUNTIMES,
|
||
walk,
|
||
simulateHookCopy,
|
||
installerEnv,
|
||
runMinimalInstall,
|
||
manifestSkillSet,
|
||
manifestAgentCount,
|
||
collectSkillBasenamesOnDisk,
|
||
} = require('./helpers/install-shared.cjs');
|
||
|
||
/**
|
||
* collectSkillBasenamesOnDisk(configDir, runtime, scope) re-resolves the
|
||
* runtime's skills-kind layout via os.homedir(). runMinimalInstall() already
|
||
* sandboxes HOME/USERPROFILE to `root` for the spawned install subprocess,
|
||
* but that sandboxing does not persist into this (parent) process — without
|
||
* re-sandboxing here, Codex's skills-kind `home: ".agents"` override
|
||
* (ADR-1239 upgrade 3, #2088) would resolve against the developer's REAL
|
||
* $HOME/.agents/skills instead of the sandboxed install root. Sandbox
|
||
* HOME/USERPROFILE to `root` for the synchronous duration of the on-disk scan.
|
||
*/
|
||
function collectSkillBasenamesOnDiskSandboxed(configDir, runtime, scope, root) {
|
||
const savedHome = process.env.HOME;
|
||
const savedUserProfile = process.env.USERPROFILE;
|
||
process.env.HOME = root;
|
||
process.env.USERPROFILE = root;
|
||
try {
|
||
return collectSkillBasenamesOnDisk(configDir, runtime, scope);
|
||
} finally {
|
||
if (savedHome === undefined) delete process.env.HOME;
|
||
else process.env.HOME = savedHome;
|
||
if (savedUserProfile === undefined) delete process.env.USERPROFILE;
|
||
else process.env.USERPROFILE = savedUserProfile;
|
||
}
|
||
}
|
||
|
||
// ─── Section 9: install-profiles — MINIMAL_SKILL_ALLOWLIST ───────────────────
|
||
|
||
describe('install-profiles: MINIMAL_SKILL_ALLOWLIST', () => {
|
||
test('contains exactly the main-loop core (frozen)', () => {
|
||
assert.deepStrictEqual(
|
||
[...MINIMAL_SKILL_ALLOWLIST].sort(),
|
||
['discuss-phase', 'execute-phase', 'help', 'new-project', 'phase', 'plan-phase', 'surface', 'update'],
|
||
);
|
||
assert.ok(Object.isFrozen(MINIMAL_SKILL_ALLOWLIST));
|
||
});
|
||
|
||
test('every allowlisted skill exists in commands/msd/', () => {
|
||
const commandsDir = path.join(__dirname, '..', 'commands', 'msd');
|
||
for (const name of MINIMAL_SKILL_ALLOWLIST) {
|
||
assert.ok(
|
||
fs.existsSync(path.join(commandsDir, `${name}.md`)),
|
||
`${name} is allowlisted but commands/msd/${name}.md does not exist`,
|
||
);
|
||
}
|
||
});
|
||
});
|
||
|
||
// ─── #834: --help profile skill counts must track PROFILES ───────────────────
|
||
|
||
describe('install: --help profile counts match PROFILES (#834)', () => {
|
||
function helpText() {
|
||
const r = runNode([INSTALL_SCRIPT, '--help'], { env: installerEnv(), timeoutMs: PROBE_TIMEOUT_MS });
|
||
throwIfFailed(r, `node ${INSTALL_SCRIPT} --help`);
|
||
return r.stdout;
|
||
}
|
||
|
||
test('core/standard/full lines advertise correct, drift-tracked skill counts', () => {
|
||
const out = helpText();
|
||
|
||
const mCore = out.match(/core\s+—\s+~?(\d+)\s+main-loop skills/);
|
||
assert.ok(mCore, `--help must advertise a core profile skill count; got:\n${out}`);
|
||
assert.strictEqual(
|
||
Number(mCore[1]),
|
||
PROFILES.core.length,
|
||
`--help core count (${mCore[1]}) must equal PROFILES.core.length (${PROFILES.core.length})`,
|
||
);
|
||
|
||
const mStandard = out.match(/standard\s+—\s+~?(\d+)\s+skills/);
|
||
assert.ok(mStandard, `--help must advertise a standard profile skill count; got:\n${out}`);
|
||
assert.strictEqual(
|
||
Number(mStandard[1]),
|
||
PROFILES.standard.length,
|
||
`--help standard count (${mStandard[1]}) must equal PROFILES.standard.length (${PROFILES.standard.length})`,
|
||
);
|
||
|
||
const mFull = out.match(/full\s+—\s+([^\n]*?)\s+\(default\)/);
|
||
assert.ok(mFull, `--help must advertise a full profile line; got:\n${out}`);
|
||
assert.doesNotMatch(
|
||
mFull[1],
|
||
/\d/,
|
||
`--help full line must not hardcode a numeric skill count (drifts); got: "${mFull[1]}"`,
|
||
);
|
||
});
|
||
});
|
||
|
||
describe('install-profiles: isMinimalMode', () => {
|
||
test('returns true only for "minimal"', () => {
|
||
assert.strictEqual(isMinimalMode('minimal'), true);
|
||
assert.strictEqual(isMinimalMode('full'), false);
|
||
assert.strictEqual(isMinimalMode(''), false);
|
||
assert.strictEqual(isMinimalMode(undefined), false);
|
||
assert.strictEqual(isMinimalMode(null), false);
|
||
assert.strictEqual(isMinimalMode('MINIMAL'), false);
|
||
});
|
||
});
|
||
|
||
describe('install-profiles: shouldInstallSkill', () => {
|
||
test('full mode admits every skill', () => {
|
||
assert.strictEqual(shouldInstallSkill('plan-phase', 'full'), true);
|
||
assert.strictEqual(shouldInstallSkill('autonomous', 'full'), true);
|
||
assert.strictEqual(shouldInstallSkill('arbitrary-future-name', 'full'), true);
|
||
});
|
||
|
||
test('minimal mode admits only allowlisted skills', () => {
|
||
for (const name of MINIMAL_SKILL_ALLOWLIST) {
|
||
assert.strictEqual(shouldInstallSkill(name, 'minimal'), true, name);
|
||
}
|
||
for (const denied of ['autonomous', 'do', 'progress', 'next', 'fast', 'quick']) {
|
||
assert.strictEqual(shouldInstallSkill(denied, 'minimal'), false, denied);
|
||
}
|
||
});
|
||
|
||
test('minimal mode rejects .md-suffixed names (callers must strip)', () => {
|
||
assert.strictEqual(shouldInstallSkill('plan-phase.md', 'minimal'), false);
|
||
});
|
||
|
||
test('unknown mode falls through to full behavior', () => {
|
||
for (const unknownMode of ['compact', 'tier2', 'CORE', 'Minimal', 'mini']) {
|
||
assert.ok(shouldInstallSkill('autonomous', unknownMode),
|
||
`unknown mode "${unknownMode}" should admit all skills`);
|
||
}
|
||
});
|
||
});
|
||
|
||
describe('install-profiles: stageSkillsForMode', () => {
|
||
function createFixtureSkillsDir() {
|
||
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-stage-fixture-'));
|
||
for (const name of ['plan-phase', 'execute-phase', 'autonomous', 'do', 'help',
|
||
'new-project', 'phase', 'discuss-phase', 'update', 'progress', 'surface']) {
|
||
fs.writeFileSync(path.join(tmp, `${name}.md`), `# ${name}\n`);
|
||
}
|
||
return tmp;
|
||
}
|
||
|
||
test('full mode returns original src dir unchanged', () => {
|
||
const src = createFixtureSkillsDir();
|
||
try {
|
||
assert.strictEqual(stageSkillsForMode(src, 'full'), src);
|
||
} finally {
|
||
cleanup(src);
|
||
}
|
||
});
|
||
|
||
test('minimal mode returns new dir with only allowlisted skills', () => {
|
||
const src = createFixtureSkillsDir();
|
||
let staged;
|
||
try {
|
||
staged = stageSkillsForMode(src, 'minimal');
|
||
assert.notStrictEqual(staged, src);
|
||
assert.deepStrictEqual(
|
||
fs.readdirSync(staged).sort(),
|
||
['discuss-phase.md', 'execute-phase.md', 'help.md', 'new-project.md',
|
||
'phase.md', 'plan-phase.md', 'surface.md', 'update.md'],
|
||
);
|
||
} finally {
|
||
cleanup(src);
|
||
cleanup(staged);
|
||
}
|
||
});
|
||
|
||
test('minimal mode preserves file content byte-for-byte', () => {
|
||
const src = createFixtureSkillsDir();
|
||
let staged;
|
||
try {
|
||
staged = stageSkillsForMode(src, 'minimal');
|
||
const original = fs.readFileSync(path.join(src, 'plan-phase.md'), 'utf8');
|
||
const copied = fs.readFileSync(path.join(staged, 'plan-phase.md'), 'utf8');
|
||
assert.strictEqual(copied, original);
|
||
} finally {
|
||
cleanup(src);
|
||
cleanup(staged);
|
||
}
|
||
});
|
||
|
||
test('minimal mode against non-existent source returns source path', () => {
|
||
const ghost = path.join(os.tmpdir(), 'msd-stage-does-not-exist-' + Date.now());
|
||
assert.strictEqual(stageSkillsForMode(ghost, 'minimal'), ghost);
|
||
});
|
||
|
||
test('minimal mode skips non-md files and subdirectories', () => {
|
||
const src = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-stage-mixed-'));
|
||
let staged;
|
||
try {
|
||
fs.writeFileSync(path.join(src, 'plan-phase.md'), '# plan\n');
|
||
fs.writeFileSync(path.join(src, 'README.txt'), 'not a skill\n');
|
||
fs.mkdirSync(path.join(src, 'nested-dir'));
|
||
fs.writeFileSync(path.join(src, 'nested-dir', 'plan-phase.md'), '# nested\n');
|
||
staged = stageSkillsForMode(src, 'minimal');
|
||
assert.deepStrictEqual(fs.readdirSync(staged), ['plan-phase.md']);
|
||
} finally {
|
||
cleanup(src);
|
||
cleanup(staged);
|
||
}
|
||
});
|
||
});
|
||
|
||
describe('install-profiles: cleanupStagedSkills', () => {
|
||
test('removes staged dirs created during process', () => {
|
||
const src = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-stage-cleanup-'));
|
||
fs.writeFileSync(path.join(src, 'plan-phase.md'), '# plan\n');
|
||
try {
|
||
const a = stageSkillsForMode(src, 'minimal');
|
||
const b = stageSkillsForMode(src, 'minimal');
|
||
assert.notStrictEqual(a, b);
|
||
assert.ok(fs.existsSync(a));
|
||
assert.ok(fs.existsSync(b));
|
||
cleanupStagedSkills();
|
||
assert.ok(!fs.existsSync(a));
|
||
assert.ok(!fs.existsSync(b));
|
||
} finally {
|
||
cleanup(src);
|
||
}
|
||
});
|
||
|
||
test('is idempotent', () => {
|
||
cleanupStagedSkills();
|
||
cleanupStagedSkills();
|
||
});
|
||
|
||
test('exit handler registers at most once across many calls', () => {
|
||
cleanupStagedSkills();
|
||
const src = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-stage-exit-handler-'));
|
||
fs.writeFileSync(path.join(src, 'plan-phase.md'), '# plan\n');
|
||
try {
|
||
const before = process.listenerCount('exit');
|
||
for (let i = 0; i < 5; i++) stageSkillsForMode(src, 'minimal');
|
||
const after = process.listenerCount('exit');
|
||
assert.ok(after - before <= 1, `expected <=1 new exit listener, got ${after - before}`);
|
||
} finally {
|
||
cleanup(src);
|
||
cleanupStagedSkills();
|
||
}
|
||
});
|
||
|
||
test('mid-copy failure removes partial staged dir and re-throws', () => {
|
||
cleanupStagedSkills();
|
||
const src = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-stage-fail-'));
|
||
fs.writeFileSync(path.join(src, 'plan-phase.md'), '# plan\n');
|
||
fs.writeFileSync(path.join(src, 'execute-phase.md'), '# x\n');
|
||
const realCopy = fs.copyFileSync;
|
||
const realMkdtemp = fs.mkdtempSync;
|
||
let stagedDir = null;
|
||
fs.mkdtempSync = (prefix, ...rest) => {
|
||
const out = realMkdtemp(prefix, ...rest);
|
||
if (typeof prefix === 'string' && prefix.endsWith('msd-minimal-skills-')) stagedDir = out;
|
||
return out;
|
||
};
|
||
let copyCount = 0;
|
||
fs.copyFileSync = (s, d) => {
|
||
copyCount++;
|
||
if (copyCount === 2) throw new Error('synthetic disk full');
|
||
return realCopy(s, d);
|
||
};
|
||
try {
|
||
assert.throws(() => stageSkillsForMode(src, 'minimal'), /synthetic disk full/);
|
||
assert.notStrictEqual(stagedDir, null);
|
||
assert.equal(fs.existsSync(stagedDir), false);
|
||
} finally {
|
||
fs.copyFileSync = realCopy;
|
||
fs.mkdtempSync = realMkdtemp;
|
||
cleanup(src);
|
||
cleanupStagedSkills();
|
||
}
|
||
});
|
||
});
|
||
|
||
describe('install-profiles: allowlist scope guards', () => {
|
||
test('every main-loop command is in the allowlist', () => {
|
||
for (const required of ['new-project', 'discuss-phase', 'plan-phase', 'execute-phase']) {
|
||
assert.ok(shouldInstallSkill(required, 'minimal'), `"${required}" must be in allowlist`);
|
||
}
|
||
});
|
||
|
||
test('off-loop commands are NOT in the allowlist', () => {
|
||
for (const offLoop of ['autonomous', 'ship', 'do', 'progress', 'next', 'fast', 'quick', 'debug', 'code-review', 'verify-work']) {
|
||
assert.ok(!shouldInstallSkill(offLoop, 'minimal'), `"${offLoop}" must NOT be in allowlist`);
|
||
}
|
||
});
|
||
});
|
||
|
||
// ─── Section 10: --minimal install — per-runtime E2E (spawned) ───────────────
|
||
|
||
describe('install: --minimal honoured for every runtime, on-disk matches manifest', () => {
|
||
for (const runtime of SKILL_RUNTIMES) {
|
||
for (const scope of ['global', 'local']) {
|
||
test(`${runtime} --${scope} --minimal: mode, skills, zero agents, on-disk matches manifest`, () => {
|
||
const { manifest, configDir, root } = runMinimalInstall({ runtime, scope, extraArgs: ['--minimal'] });
|
||
try {
|
||
assert.ok(manifest, `${runtime} ${scope} must produce manifest`);
|
||
assert.strictEqual(manifest.mode, 'minimal');
|
||
assert.deepStrictEqual(
|
||
[...manifestSkillSet(manifest)].sort(),
|
||
[...MINIMAL_SKILL_ALLOWLIST].sort(),
|
||
);
|
||
assert.strictEqual(manifestAgentCount(manifest), 0);
|
||
|
||
const onDisk = collectSkillBasenamesOnDiskSandboxed(configDir, runtime, scope, root);
|
||
const inManifest = manifestSkillSet(manifest);
|
||
assert.deepStrictEqual([...onDisk].sort(), [...inManifest].sort());
|
||
// Not the shared listAgentFiles() helper: asserts on the INSTALLED
|
||
// dest dir (must be empty in --minimal mode), not the source roster.
|
||
const agentsDir = path.join(configDir, 'agents');
|
||
if (fs.existsSync(agentsDir)) {
|
||
const msdAgents = fs.readdirSync(agentsDir)
|
||
.filter(f => f.startsWith('msd-') && f.endsWith('.md'));
|
||
assert.deepStrictEqual(msdAgents, []);
|
||
}
|
||
} finally {
|
||
cleanup(root);
|
||
}
|
||
});
|
||
}
|
||
}
|
||
});
|
||
|
||
// ─── Section 11: --minimal manifest mode + downgrade ─────────────────────────
|
||
|
||
// Shared across "manifest records mode" and "install-minimal-backcompat": both
|
||
// describe blocks below independently re-installed the IDENTICAL
|
||
// `--claude --global --minimal` configuration just to check different fields
|
||
// of the same manifest/profile-marker output. Install it once and derive
|
||
// everything both sets of tests need.
|
||
let _sharedMinimalManifestInstall;
|
||
function sharedMinimalManifestInstall() {
|
||
if (_sharedMinimalManifestInstall) return _sharedMinimalManifestInstall;
|
||
const targetDir = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-minimal-shared-'));
|
||
runNode(
|
||
[INSTALL_SCRIPT, '--claude', '--global', '--config-dir', targetDir, '--minimal'],
|
||
{ env: installerEnv(), timeoutMs: INSTALL_TIMEOUT_MS },
|
||
);
|
||
const manifestPath = path.join(targetDir, MANIFEST_NAME);
|
||
const m = fs.existsSync(manifestPath) ? JSON.parse(fs.readFileSync(manifestPath, 'utf8')) : {};
|
||
const skillCount = Object.keys(m.files || {}).filter(
|
||
k => k.startsWith('skills/') && k.endsWith('/SKILL.md'),
|
||
).length;
|
||
const markerPath = path.join(targetDir, '.msd-profile');
|
||
const profileMarker = fs.existsSync(markerPath) ? fs.readFileSync(markerPath, 'utf8').trim() : null;
|
||
const agentCount = Object.keys(m.files || {}).filter(k => k.startsWith('agents/')).length;
|
||
_sharedMinimalManifestInstall = { targetDir, mode: m.mode, skillCount, agentCount, profileMarker };
|
||
return _sharedMinimalManifestInstall;
|
||
}
|
||
after(() => {
|
||
if (_sharedMinimalManifestInstall) cleanup(_sharedMinimalManifestInstall.targetDir);
|
||
});
|
||
|
||
describe('install: manifest records mode for both profiles', () => {
|
||
function manifestModeAfterInstall(extraArgs) {
|
||
const targetDir = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-manifest-mode-'));
|
||
try {
|
||
runNode(
|
||
[INSTALL_SCRIPT, '--claude', '--global', '--config-dir', targetDir, ...extraArgs],
|
||
{ env: installerEnv(), timeoutMs: INSTALL_TIMEOUT_MS },
|
||
);
|
||
const manifestPath = path.join(targetDir, MANIFEST_NAME);
|
||
if (!fs.existsSync(manifestPath)) return { mode: '<no manifest>', skillCount: 0, agentCount: 0 };
|
||
const m = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));
|
||
// Count SKILL.md files under skills/ (works for both flat and ns-nested layouts).
|
||
const skillCount = Object.keys(m.files || {}).filter(
|
||
k => k.startsWith('skills/') && k.endsWith('/SKILL.md'),
|
||
).length;
|
||
const agentCount = Object.keys(m.files || {}).filter(k => k.startsWith('agents/')).length;
|
||
return { mode: m.mode, skillCount, agentCount };
|
||
} finally {
|
||
cleanup(targetDir);
|
||
}
|
||
}
|
||
|
||
test('default install records mode: "full" with full skill+agent count', () => {
|
||
const r = manifestModeAfterInstall([]);
|
||
assert.strictEqual(r.mode, 'full');
|
||
assert.ok(r.skillCount > 7);
|
||
assert.ok(r.agentCount > 0);
|
||
});
|
||
|
||
test('--minimal records mode: "minimal" with exactly 8 skills and 0 agents', () => {
|
||
const r = sharedMinimalManifestInstall();
|
||
assert.strictEqual(r.mode, 'minimal');
|
||
assert.strictEqual(r.skillCount, 8);
|
||
assert.strictEqual(r.agentCount, 0);
|
||
});
|
||
|
||
test('--core-only is an alias for --minimal', () => {
|
||
const r = manifestModeAfterInstall(['--core-only']);
|
||
assert.strictEqual(r.mode, 'minimal');
|
||
assert.strictEqual(r.skillCount, 8);
|
||
assert.strictEqual(r.agentCount, 0);
|
||
});
|
||
});
|
||
|
||
describe('install-minimal-backcompat: PROFILES.core matches MINIMAL_SKILL_ALLOWLIST', () => {
|
||
test('PROFILES.core contains the same 8 skills as MINIMAL_SKILL_ALLOWLIST', () => {
|
||
assert.deepStrictEqual(
|
||
[...PROFILES.core].sort(),
|
||
[...MINIMAL_SKILL_ALLOWLIST].sort(),
|
||
);
|
||
});
|
||
});
|
||
|
||
describe('install-minimal-backcompat: --minimal and --profile=core produce same manifest', () => {
|
||
function installAndGetManifest(extraArgs) {
|
||
const targetDir = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-backcompat-'));
|
||
try {
|
||
runNode(
|
||
[INSTALL_SCRIPT, '--claude', '--global', '--config-dir', targetDir, ...extraArgs],
|
||
{ env: installerEnv(), timeoutMs: INSTALL_TIMEOUT_MS },
|
||
);
|
||
const manifestPath = path.join(targetDir, MANIFEST_NAME);
|
||
if (!fs.existsSync(manifestPath)) return { mode: null, skillCount: 0, profileMarker: null };
|
||
const m = JSON.parse(fs.readFileSync(manifestPath, 'utf8'));
|
||
// Count SKILL.md files under skills/ (works for both flat and ns-nested layouts).
|
||
const skillCount = Object.keys(m.files || {}).filter(
|
||
k => k.startsWith('skills/') && k.endsWith('/SKILL.md'),
|
||
).length;
|
||
const markerPath = path.join(targetDir, '.msd-profile');
|
||
const profileMarker = fs.existsSync(markerPath) ? fs.readFileSync(markerPath, 'utf8').trim() : null;
|
||
return { mode: m.mode, skillCount, profileMarker };
|
||
} finally {
|
||
cleanup(targetDir);
|
||
}
|
||
}
|
||
|
||
test('--minimal produces mode "minimal" with exactly 8 skills', () => {
|
||
const r = sharedMinimalManifestInstall();
|
||
assert.strictEqual(r.mode, 'minimal');
|
||
assert.strictEqual(r.skillCount, 8);
|
||
});
|
||
|
||
test('--minimal writes .msd-profile marker "core"', () => {
|
||
const r = sharedMinimalManifestInstall();
|
||
assert.strictEqual(r.profileMarker, 'core');
|
||
});
|
||
|
||
test('default install writes .msd-profile marker "full"', () => {
|
||
const r = installAndGetManifest([]);
|
||
assert.strictEqual(r.profileMarker, 'full');
|
||
});
|
||
|
||
test('--profile=core writes .msd-profile marker "core"', () => {
|
||
const r = installAndGetManifest(['--profile=core']);
|
||
assert.strictEqual(r.profileMarker, 'core');
|
||
});
|
||
|
||
test('--profile=standard writes .msd-profile marker "standard"', () => {
|
||
const r = installAndGetManifest(['--profile=standard']);
|
||
assert.strictEqual(r.profileMarker, 'standard');
|
||
});
|
||
});
|
||
|
||
describe('install: Codex full → minimal downgrade cleans stale agent state', () => {
|
||
test('--minimal removes stale .toml agents and strips [agents.msd-*] from config.toml', () => {
|
||
const targetDir = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-codex-downgrade-'));
|
||
try {
|
||
const agentsDir = path.join(targetDir, 'agents');
|
||
fs.mkdirSync(agentsDir, { recursive: true });
|
||
fs.writeFileSync(path.join(agentsDir, 'msd-executor.md'), 'stale\n');
|
||
fs.writeFileSync(path.join(agentsDir, 'msd-planner.md'), 'stale\n');
|
||
fs.writeFileSync(path.join(agentsDir, 'msd-executor.toml'), 'name = "msd-executor"\n');
|
||
fs.writeFileSync(path.join(agentsDir, 'msd-planner.toml'), 'name = "msd-planner"\n');
|
||
fs.writeFileSync(path.join(agentsDir, 'my-custom-agent.md'), 'user owns this\n');
|
||
const codexConfig = [
|
||
'# user-owned setting',
|
||
'model = "gpt-5"',
|
||
'',
|
||
'# MSD Agent Configuration — managed by msd-core installer',
|
||
'[agents.msd-executor]',
|
||
'cmd = "stale"',
|
||
'',
|
||
'[agents.msd-planner]',
|
||
'cmd = "stale"',
|
||
'',
|
||
].join('\n');
|
||
fs.writeFileSync(path.join(targetDir, 'config.toml'), codexConfig);
|
||
|
||
// Sandbox HOME/USERPROFILE to targetDir: Codex's skills-kind `home: ".agents"`
|
||
// override (ADR-1239 upgrade 3, #2088) resolves via os.homedir(), so an
|
||
// unsandboxed spawn here would write msd-* skill dirs into the developer's
|
||
// real $HOME/.agents/skills. This test only asserts on agents/ and
|
||
// config.toml (both under targetDir), so the sandbox has no effect on intent.
|
||
const result = runNode(
|
||
[INSTALL_SCRIPT, '--codex', '--global', '--config-dir', targetDir, '--minimal'],
|
||
{ env: installerEnv({ HOME: targetDir, USERPROFILE: targetDir }), timeoutMs: INSTALL_TIMEOUT_MS },
|
||
);
|
||
assert.ok(result.stdout || result.stderr);
|
||
|
||
const remaining = fs.existsSync(agentsDir) ? fs.readdirSync(agentsDir) : [];
|
||
assert.ok(!remaining.includes('msd-executor.md'));
|
||
assert.ok(!remaining.includes('msd-planner.md'));
|
||
assert.ok(!remaining.includes('msd-executor.toml'));
|
||
assert.ok(!remaining.includes('msd-planner.toml'));
|
||
assert.ok(remaining.includes('my-custom-agent.md'));
|
||
|
||
const configPath = path.join(targetDir, 'config.toml');
|
||
if (fs.existsSync(configPath)) {
|
||
const config = fs.readFileSync(configPath, 'utf8');
|
||
assert.ok(!config.includes('[agents.msd-executor]'));
|
||
assert.ok(!config.includes('[agents.msd-planner]'));
|
||
assert.ok(config.includes('model = "gpt-5"'));
|
||
}
|
||
assert.ok(fs.existsSync(configPath));
|
||
} finally {
|
||
cleanup(targetDir);
|
||
}
|
||
});
|
||
});
|
||
|
||
describe('install: Claude full → minimal downgrade removes stale agents', () => {
|
||
test('--minimal removes stale msd-*.md agents but preserves user-owned agents', () => {
|
||
const targetDir = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-claude-downgrade-'));
|
||
try {
|
||
const agentsDir = path.join(targetDir, 'agents');
|
||
fs.mkdirSync(agentsDir, { recursive: true });
|
||
fs.writeFileSync(path.join(agentsDir, 'msd-executor.md'), 'stale\n');
|
||
fs.writeFileSync(path.join(agentsDir, 'msd-planner.md'), 'stale\n');
|
||
fs.writeFileSync(path.join(agentsDir, 'my-custom-agent.md'), 'user owns this\n');
|
||
|
||
runNode(
|
||
[INSTALL_SCRIPT, '--claude', '--global', '--config-dir', targetDir, '--minimal'],
|
||
{ env: installerEnv(), timeoutMs: INSTALL_TIMEOUT_MS },
|
||
);
|
||
|
||
const remaining = fs.existsSync(agentsDir) ? fs.readdirSync(agentsDir) : [];
|
||
assert.ok(!remaining.includes('msd-executor.md'));
|
||
assert.ok(!remaining.includes('msd-planner.md'));
|
||
assert.ok(remaining.includes('my-custom-agent.md'));
|
||
assert.deepStrictEqual(remaining.filter(f => f.startsWith('msd-')), []);
|
||
} finally {
|
||
cleanup(targetDir);
|
||
}
|
||
});
|
||
});
|
||
|
||
// ─── Section 13: Hooks copy, manifest, uninstall settings cleanup ─────────────
|
||
|
||
// #3145: class-norm timeout, not a per-suite value — see helpers/timeouts.cjs.
|
||
const { BUILD_TIMEOUT_MS: SECTION13_BUILD_TIMEOUT_MS } = require('./helpers/timeouts.cjs');
|
||
|
||
before(() => {
|
||
throwIfFailed(runNode([BUILD_SCRIPT], { timeoutMs: SECTION13_BUILD_TIMEOUT_MS }), `node ${BUILD_SCRIPT}`);
|
||
});
|
||
|
||
const isWindows = process.platform === 'win32';
|
||
|
||
describe('#1755: .sh hooks are copied and executable after install', () => {
|
||
let tmpDir;
|
||
beforeEach(() => { tmpDir = createTempDir('msd-hook-copy-'); });
|
||
afterEach(() => { cleanup(tmpDir); });
|
||
|
||
test('all expected hooks are copied from hooks/dist/ to target', () => {
|
||
const hooksDest = path.join(tmpDir, 'hooks');
|
||
simulateHookCopy(HOOKS_DIST, hooksDest);
|
||
for (const hook of EXPECTED_ALL_HOOKS) {
|
||
assert.ok(fs.existsSync(path.join(hooksDest, hook)), `${hook} should exist`);
|
||
}
|
||
});
|
||
|
||
test('.sh hooks are executable after copy', {
|
||
skip: isWindows ? 'Windows has no POSIX file permissions' : false,
|
||
}, () => {
|
||
const hooksDest = path.join(tmpDir, 'hooks');
|
||
simulateHookCopy(HOOKS_DIST, hooksDest);
|
||
for (const sh of EXPECTED_SH_HOOKS) {
|
||
const stat = fs.statSync(path.join(hooksDest, sh));
|
||
assert.ok((stat.mode & 0o111) !== 0, `${sh} should be executable`);
|
||
}
|
||
});
|
||
|
||
test('.js hooks are executable after copy', {
|
||
skip: isWindows ? 'Windows has no POSIX file permissions' : false,
|
||
}, () => {
|
||
const hooksDest = path.join(tmpDir, 'hooks');
|
||
simulateHookCopy(HOOKS_DIST, hooksDest);
|
||
for (const js of EXPECTED_ALL_HOOKS.filter(h => h.endsWith('.js'))) {
|
||
const stat = fs.statSync(path.join(hooksDest, js));
|
||
assert.ok((stat.mode & 0o111) !== 0, `${js} should be executable`);
|
||
}
|
||
});
|
||
});
|
||
|
||
// ─── #1821/#2305: hooks staged iff a surface consumes them ─────────────────────
|
||
//
|
||
// #1821 reported dead hook scripts staged for runtimes with hooksSurface:'none'.
|
||
// OpenCode ALSO declares hooksSurface:'none', but has a native plugin adapter
|
||
// that spawns the staged hooks/*.js scripts as subprocesses (OpenCode's #1914
|
||
// plugins/msd-core.js via OpenCode's event bus) — so its hooks are LIVE and
|
||
// must keep being copied. ZCode has no plugin surface at all, so its staged
|
||
// hooks are genuinely dead: that is the case #1821's fix removes. These tests
|
||
// assert the split: ZCode gets no hooks; OpenCode (and Claude) do.
|
||
|
||
describe('#1821/#2305: ZCode receives no dead hook files; OpenCode/Claude keep their hooks', () => {
|
||
function msdHookFilesUnder(configDir, hooksDirName) {
|
||
const hooksDir = path.join(configDir, hooksDirName);
|
||
if (!fs.existsSync(hooksDir)) return [];
|
||
return walk(hooksDir).filter((f) => {
|
||
const base = path.basename(f);
|
||
return /^msd-.*\.(js|sh)$/.test(base);
|
||
});
|
||
}
|
||
|
||
function installAndCollect(runtime, opts = {}) {
|
||
const targetDir = fs.mkdtempSync(path.join(os.tmpdir(), `msd-1821-${runtime}-`));
|
||
try {
|
||
const result = runNode(
|
||
[INSTALL_SCRIPT, `--${runtime}`, '--global', '--config-dir', targetDir],
|
||
{ env: installerEnv(), timeoutMs: INSTALL_TIMEOUT_MS },
|
||
);
|
||
assert.strictEqual(result.exitCode, 0,
|
||
`installer exited with status ${result.exitCode} for --${runtime} --global\nstdout: ${result.stdout}\nstderr: ${result.stderr}`);
|
||
// Collect results while targetDir still exists — cleanup() below removes it.
|
||
const pluginRelPath = opts.pluginRelPath || path.join('plugins', 'msd-core.js');
|
||
// #3023: the shared hooks bundle's staged directory name is per-runtime
|
||
// (hostBehaviors.sharedHooksDirName) —
|
||
// resolve it the same way the installer does rather than hardcoding
|
||
// 'hooks', or every non-default runtime would look hookless.
|
||
const hooksDirName = resolveSharedHooksDirName(runtime);
|
||
return {
|
||
hookFiles: msdHookFilesUnder(targetDir, hooksDirName),
|
||
hooksLibExists: fs.existsSync(path.join(targetDir, hooksDirName, 'lib')),
|
||
gitCmdExists: fs.existsSync(path.join(targetDir, hooksDirName, 'lib', 'git-cmd.js')),
|
||
pluginExists: fs.existsSync(path.join(targetDir, pluginRelPath)),
|
||
};
|
||
} finally {
|
||
cleanup(targetDir);
|
||
}
|
||
}
|
||
|
||
// ZCode declares hooksSurface:'none' with no plugin surface, so its staged
|
||
// hooks are genuinely dead weight (#1821) — this is the case the fix
|
||
// removes.
|
||
for (const runtime of ['zcode']) {
|
||
test(`${runtime} --global install creates no msd-*.js/.sh hook files or hooks/lib`, () => {
|
||
const { hookFiles, hooksLibExists } = installAndCollect(runtime);
|
||
assert.deepStrictEqual(hookFiles, [], `${runtime} install must not copy any msd-*.js/.sh hook files, found: ${hookFiles.join(', ')}`);
|
||
assert.ok(!hooksLibExists, `${runtime} install must not create hooks/lib/`);
|
||
});
|
||
}
|
||
|
||
// Regression guard for #1914: OpenCode's plugin adapter spawns the staged
|
||
// hooks, so excluding OpenCode from the hook copy would break it. OpenCode
|
||
// must KEEP its hooks and receive the plugin.
|
||
test('opencode --global install still copies hooks and installs the #1914 plugin', () => {
|
||
const { hookFiles, pluginExists } = installAndCollect('opencode');
|
||
const basenames = hookFiles.map((f) => path.basename(f));
|
||
assert.ok(
|
||
basenames.includes('msd-context-monitor.js'),
|
||
`opencode install must still copy msd-*.js hooks (spawned by the #1914 plugin), found: ${basenames.join(', ')}`,
|
||
);
|
||
assert.ok(pluginExists, 'opencode install must install plugins/msd-core.js (#1914 hook bridge)');
|
||
});
|
||
|
||
// Positive control: guards against over-exclusion breaking runtimes that
|
||
// legitimately need hooks (hooksSurface !== 'none').
|
||
test('claude --global install still copies msd-*.js hooks', () => {
|
||
const { hookFiles } = installAndCollect('claude');
|
||
const basenames = hookFiles.map((f) => path.basename(f));
|
||
assert.ok(
|
||
basenames.includes('msd-context-monitor.js'),
|
||
`claude install must still copy msd-context-monitor.js, found: ${basenames.join(', ')}`,
|
||
);
|
||
});
|
||
});
|
||
|
||
// Migrated (#455): uses typed export MSD_UNINSTALL_HOOKS instead of
|
||
// source-grep assertions on bin/install.js for the uninstall hook list tests.
|
||
describe('install.js uninstall hooks registry (typed assertions)', () => {
|
||
test('MSD_UNINSTALL_HOOKS is a non-empty array', () => {
|
||
assert.ok(Array.isArray(MSD_UNINSTALL_HOOKS), 'MSD_UNINSTALL_HOOKS must be an array');
|
||
assert.ok(MSD_UNINSTALL_HOOKS.length > 0, 'MSD_UNINSTALL_HOOKS must not be empty');
|
||
});
|
||
|
||
test('msd-workflow-guard.js is in MSD_UNINSTALL_HOOKS', () => {
|
||
assert.ok(
|
||
MSD_UNINSTALL_HOOKS.includes('msd-workflow-guard.js'),
|
||
'MSD_UNINSTALL_HOOKS must include msd-workflow-guard.js'
|
||
);
|
||
});
|
||
|
||
test('phantom msd-check-update.sh is NOT in MSD_UNINSTALL_HOOKS', () => {
|
||
assert.ok(
|
||
!MSD_UNINSTALL_HOOKS.includes('msd-check-update.sh'),
|
||
'MSD_UNINSTALL_HOOKS must not include the phantom msd-check-update.sh entry'
|
||
);
|
||
});
|
||
|
||
test('MSD_UNINSTALL_HOOKS covers all 3 opt-in bash hooks', () => {
|
||
const required = ['msd-session-state.sh', 'msd-validate-commit.sh', 'msd-phase-boundary.sh'];
|
||
for (const hook of required) {
|
||
assert.ok(
|
||
MSD_UNINSTALL_HOOKS.includes(hook),
|
||
`MSD_UNINSTALL_HOOKS must include ${hook}`
|
||
);
|
||
}
|
||
});
|
||
|
||
test('MSD_UNINSTALL_HOOKS covers core JS hooks', () => {
|
||
const coreJsHooks = [
|
||
'msd-check-update.js', 'msd-statusline.js', 'msd-session-state.sh',
|
||
'msd-context-monitor.js', 'msd-phase-boundary.sh', 'msd-prompt-guard.js',
|
||
'msd-read-guard.js', 'msd-validate-commit.sh', 'msd-workflow-guard.js',
|
||
];
|
||
for (const hook of coreJsHooks) {
|
||
assert.ok(
|
||
MSD_UNINSTALL_HOOKS.includes(hook),
|
||
`MSD_UNINSTALL_HOOKS must include ${hook}`
|
||
);
|
||
}
|
||
});
|
||
});
|
||
|
||
describe('writeManifest includes .sh hooks', () => {
|
||
let tmpDir;
|
||
beforeEach(() => {
|
||
tmpDir = createTempDir('msd-manifest-');
|
||
const hooksDir = path.join(tmpDir, 'hooks');
|
||
simulateHookCopy(HOOKS_DIST, hooksDir);
|
||
});
|
||
afterEach(() => { cleanup(tmpDir); });
|
||
|
||
test('manifest contains .sh hook entries', () => {
|
||
writeManifest(tmpDir, 'claude');
|
||
const manifest = JSON.parse(fs.readFileSync(path.join(tmpDir, 'msd-file-manifest.json'), 'utf8'));
|
||
for (const sh of EXPECTED_SH_HOOKS) {
|
||
assert.ok(manifest.files['hooks/' + sh], `manifest should contain hash for ${sh}`);
|
||
}
|
||
});
|
||
|
||
test('manifest contains .js hook entries', () => {
|
||
writeManifest(tmpDir, 'claude');
|
||
const manifest = JSON.parse(fs.readFileSync(path.join(tmpDir, 'msd-file-manifest.json'), 'utf8'));
|
||
for (const js of EXPECTED_ALL_HOOKS.filter(h => h.endsWith('.js'))) {
|
||
assert.ok(manifest.files['hooks/' + js], `manifest should contain hash for ${js}`);
|
||
}
|
||
});
|
||
});
|
||
|
||
describe('uninstall settings cleanup preserves user hooks', () => {
|
||
const isMsdHook = (cmd) =>
|
||
cmd && (cmd.includes('msd-check-update') || cmd.includes('msd-statusline') ||
|
||
cmd.includes('msd-session-state') || cmd.includes('msd-context-monitor') ||
|
||
cmd.includes('msd-phase-boundary') || cmd.includes('msd-prompt-guard') ||
|
||
cmd.includes('msd-read-guard') || cmd.includes('msd-validate-commit') ||
|
||
cmd.includes('msd-workflow-guard'));
|
||
|
||
function filterMsdHooks(entries) {
|
||
return entries
|
||
.map(e => {
|
||
if (!e.hooks || !Array.isArray(e.hooks)) return e;
|
||
e.hooks = e.hooks.filter(h => !isMsdHook(h.command));
|
||
return e.hooks.length > 0 ? e : null;
|
||
})
|
||
.filter(Boolean);
|
||
}
|
||
|
||
test('mixed entry preserves user hooks', () => {
|
||
const entries = [{
|
||
matcher: 'Bash',
|
||
hooks: [
|
||
{ type: 'command', command: 'node /path/msd-prompt-guard.js' },
|
||
{ type: 'command', command: 'bash /my/custom-lint.sh' },
|
||
],
|
||
}];
|
||
const result = filterMsdHooks(entries);
|
||
assert.strictEqual(result.length, 1);
|
||
assert.strictEqual(result[0].hooks.length, 1);
|
||
assert.ok(result[0].hooks[0].command.includes('custom-lint'));
|
||
});
|
||
|
||
test('entry with only MSD hooks is fully removed', () => {
|
||
const entries = [{
|
||
hooks: [
|
||
{ type: 'command', command: 'node /path/msd-check-update.js' },
|
||
{ type: 'command', command: 'node /path/msd-statusline.js' },
|
||
],
|
||
}];
|
||
assert.strictEqual(filterMsdHooks(entries).length, 0);
|
||
});
|
||
|
||
test('entry with only user hooks is untouched', () => {
|
||
const entries = [{ matcher: 'Bash', hooks: [{ type: 'command', command: 'bash /my/pre-check.sh' }] }];
|
||
const result = filterMsdHooks(entries);
|
||
assert.strictEqual(result.length, 1);
|
||
assert.strictEqual(result[0].hooks.length, 1);
|
||
});
|
||
|
||
test('non-array hook entries are preserved (#1825)', () => {
|
||
const entries = [
|
||
{ type: 'custom', command: 'echo hello' },
|
||
{ matcher: 'Bash', hooks: [{ type: 'command', command: 'node /path/msd-prompt-guard.js' }] },
|
||
{ url: 'https://example.com/webhook' },
|
||
];
|
||
const result = filterMsdHooks(JSON.parse(JSON.stringify(entries)));
|
||
assert.strictEqual(result.length, 2);
|
||
assert.deepStrictEqual(result[0], { type: 'custom', command: 'echo hello' });
|
||
assert.deepStrictEqual(result[1], { url: 'https://example.com/webhook' });
|
||
});
|
||
|
||
test('all MSD hook names are recognised', () => {
|
||
const cmds = [
|
||
'node /path/msd-check-update.js', 'node /path/msd-statusline.js',
|
||
'bash /path/msd-session-state.sh', 'node /path/msd-context-monitor.js',
|
||
'bash /path/msd-phase-boundary.sh', 'node /path/msd-prompt-guard.js',
|
||
'node /path/msd-read-guard.js', 'bash /path/msd-validate-commit.sh',
|
||
'node /path/msd-workflow-guard.js',
|
||
];
|
||
for (const cmd of cmds) {
|
||
assert.ok(isMsdHook(cmd), `should recognise: ${cmd}`);
|
||
}
|
||
});
|
||
});
|
||
|
||
describe('Codex legacy msd-update-check migration', () => {
|
||
// #3508: behavioral replacement for a source-grep that used to check
|
||
// install.js's own text for the literal strings 'msd-update-check' and
|
||
// 'replace(' -- i.e. it asserted characteristics of the SOURCE CODE, not
|
||
// an observable effect. `stripStaleMsdHookBlocks` (bin/install.js) is the
|
||
// REAL exported function that performs this migration; drive it directly
|
||
// with a legacy Shape-1 config.toml block (same shape the two tests below
|
||
// already exercise) and assert the stale hook block is actually removed.
|
||
test('install.js strips legacy msd-update-check hook blocks', () => {
|
||
const legacyToml = ['[features]', 'codex_hooks = true', '',
|
||
'# MSD Hooks', '[[hooks]]', 'event = "SessionStart"',
|
||
'command = "node /old/path/msd-update-check.js"', ''].join('\n');
|
||
const stripped = stripStaleMsdHookBlocks(legacyToml);
|
||
assert.ok(!stripped.includes('msd-update-check'), 'legacy msd-update-check hook block must be stripped');
|
||
assert.ok(stripped.includes('[features]'), 'unrelated config content must survive stripping');
|
||
});
|
||
|
||
test('migration regex removes LF legacy hook block', () => {
|
||
const legacyBlock = ['[features]', 'codex_hooks = true', '',
|
||
'# MSD Hooks', '[[hooks]]', 'event = "SessionStart"',
|
||
'command = "node /old/path/msd-update-check.js"', ''].join('\n');
|
||
let content = legacyBlock.replace(
|
||
/\n# MSD Hooks\n\[\[hooks\]\]\nevent = "SessionStart"\ncommand = "node [^\n]*msd-update-check\.js"\n/g, '\n',
|
||
);
|
||
assert.ok(!content.includes('msd-update-check'));
|
||
assert.ok(content.includes('[features]'));
|
||
});
|
||
|
||
test('migration regex removes CRLF legacy hook block', () => {
|
||
const legacyBlock = ['[features]', 'codex_hooks = true', '',
|
||
'# MSD Hooks', '[[hooks]]', 'event = "SessionStart"',
|
||
'command = "node /old/path/msd-update-check.js"', ''].join('\r\n');
|
||
let content = legacyBlock.replace(
|
||
/\r\n# MSD Hooks\r\n\[\[hooks\]\]\r\nevent = "SessionStart"\r\ncommand = "node [^\r\n]*msd-update-check\.js"\r\n/g, '\r\n',
|
||
);
|
||
assert.ok(!content.includes('msd-update-check'));
|
||
assert.ok(content.includes('[features]'));
|
||
});
|
||
});
|
||
|
||
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
// Folded from tests/bug-1754-js-hook-guard.test.cjs — consolidation epic #1969 (B1 #1970)
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
{
|
||
const { describe: __foldDescribe } = require('node:test');
|
||
__foldDescribe("folded:bug-1754-js-hook-guard (consolidation epic #1969 B1 #1970)", () => {
|
||
/**
|
||
* Regression tests for bug #1754
|
||
*
|
||
* The installer must NOT register .js hook entries in settings.json when the
|
||
* corresponding .js file does not exist at the target path. The original bug:
|
||
* on fresh installs where hooks/dist/ was missing from the npm package (as in
|
||
* v1.32.0), the hook copy step produced no files, yet the registration step
|
||
* ran unconditionally for .js hooks — leaving users with "PreToolUse:Bash
|
||
* hook error" on every tool invocation.
|
||
*
|
||
* The .sh hooks already had fs.existsSync() guards (added in #1817). This
|
||
* test verifies the same defensive pattern exists for all .js hooks.
|
||
*
|
||
* Behavioral (#3466): drives the real `applySettingsJsonHooks` (the exported
|
||
* function `bin/install.js` calls at finishInstall time) against a temp
|
||
* target dir, rather than grepping install.js's source text for
|
||
* `fs.existsSync`. A missing hook file must produce NO settings.json entry
|
||
* plus a skip warning; a present hook file (positive control) must be
|
||
* registered — proving the guard discriminates per-file, not wholesale.
|
||
*/
|
||
|
||
'use strict';
|
||
|
||
const { describe, test, beforeEach, afterEach } = require('node:test');
|
||
const assert = require('node:assert/strict');
|
||
const fs = require('fs');
|
||
const path = require('path');
|
||
const { createTempDir, cleanup, captureConsole } = require('./helpers.cjs');
|
||
const { applySettingsJsonHooks } = require('../msd-core/bin/lib/runtime-hooks-surface.cjs');
|
||
|
||
const JS_HOOKS = [
|
||
'msd-check-update.js',
|
||
'msd-context-monitor.js',
|
||
'msd-prompt-guard.js',
|
||
'msd-read-guard.js',
|
||
'msd-workflow-guard.js',
|
||
'msd-worktree-path-guard.js',
|
||
'msd-write-guard.js',
|
||
'msd-secret-read-guard.js',
|
||
];
|
||
|
||
// Drives the real guarded registration function directly (local-install
|
||
// shape: isGlobal=false routes every *Command through the supplied
|
||
// localCmd/localShellCmd, so no real node/bash-path resolution is needed).
|
||
// `presentHooks` controls which hook basenames actually exist on disk under
|
||
// targetDir/hooks/ before the call — every other referenced hook file is
|
||
// left absent, exercising the fs.existsSync guard for that hook.
|
||
function runApplySettingsJsonHooks(targetDir, presentHooks) {
|
||
fs.mkdirSync(path.join(targetDir, 'hooks'), { recursive: true });
|
||
for (const hook of presentHooks) {
|
||
fs.writeFileSync(path.join(targetDir, 'hooks', hook), '// stub\n');
|
||
}
|
||
const settings = {};
|
||
const localCmd = (hookFile) => `node ${path.join(targetDir, 'hooks', hookFile)}`;
|
||
const localShellCmd = (hookFile) => `bash ${path.join(targetDir, 'hooks', hookFile)}`;
|
||
const { stdout, stderr } = captureConsole(() => {
|
||
applySettingsJsonHooks(settings, {
|
||
runtime: 'claude',
|
||
isGlobal: false,
|
||
targetDir,
|
||
postToolEvent: 'PostToolUse',
|
||
hookEvents: 'claude',
|
||
extendedHookEvents: [],
|
||
hooksSurface: 'settings-json',
|
||
updateCheckCommand: localCmd('msd-check-update.js'),
|
||
contextMonitorCommand: localCmd('msd-context-monitor.js'),
|
||
promptGuardCommand: localCmd('msd-prompt-guard.js'),
|
||
readGuardCommand: localCmd('msd-read-guard.js'),
|
||
readInjectionScannerCommand: localCmd('msd-read-injection-scanner.js'),
|
||
configReloadCommand: null,
|
||
hookOpts: { portableHooks: false, runtime: 'claude' },
|
||
localCmd,
|
||
localShellCmd,
|
||
});
|
||
});
|
||
return { settings, stdout, stderr };
|
||
}
|
||
|
||
function settingsReferencesHook(settings, hookBaseName) {
|
||
const events = Object.values(settings.hooks || {});
|
||
return events.some((entries) =>
|
||
Array.isArray(entries) && entries.some((entry) =>
|
||
Array.isArray(entry.hooks) && entry.hooks.some((h) => h.command && h.command.includes(hookBaseName))
|
||
)
|
||
);
|
||
}
|
||
|
||
describe('bug #1754: .js hook registration guards', () => {
|
||
let targetDir;
|
||
beforeEach(() => { targetDir = createTempDir('msd-hook-guard-js-'); });
|
||
afterEach(() => { cleanup(targetDir); });
|
||
|
||
for (const hookName of JS_HOOKS) {
|
||
test(`${hookName} is NOT registered in settings.json when its file is missing at the target path`, () => {
|
||
// Every OTHER JS hook is present (positive control keeps the guard
|
||
// honest — a wholesale skip of all hooks would falsely satisfy the
|
||
// negative assertion below).
|
||
const present = JS_HOOKS.filter((h) => h !== hookName);
|
||
const { settings, stderr } = runApplySettingsJsonHooks(targetDir, present);
|
||
|
||
assert.equal(
|
||
settingsReferencesHook(settings, hookName), false,
|
||
`settings.json must NOT register ${hookName} when its file was never copied (root cause of #1754)`,
|
||
);
|
||
assert.ok(
|
||
stderr.includes(hookName.replace('.js', '')),
|
||
`install must emit a skip warning naming ${hookName} when it is missing (stderr: ${stderr})`,
|
||
);
|
||
|
||
for (const otherHook of present) {
|
||
assert.equal(
|
||
settingsReferencesHook(settings, otherHook), true,
|
||
`${otherHook} (present on disk) must still be registered — the guard must be per-file, not wholesale`,
|
||
);
|
||
}
|
||
});
|
||
}
|
||
});
|
||
});
|
||
}
|
||
|
||
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
// Folded from tests/bug-1817-sh-hook-guard.test.cjs — consolidation epic #1969 (B1 #1970)
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
{
|
||
const { describe: __foldDescribe } = require('node:test');
|
||
__foldDescribe("folded:bug-1817-sh-hook-guard (consolidation epic #1969 B1 #1970)", () => {
|
||
/**
|
||
* Regression tests for bug #1817
|
||
*
|
||
* The installer must NOT register .sh hook entries in settings.json when the
|
||
* corresponding .sh file does not exist at the target path. The original bug:
|
||
* v1.32.0's npm package omitted the .sh files from hooks/dist/, so the copy
|
||
* step produced no files, yet the registration step ran unconditionally —
|
||
* leaving users with hook errors on every tool invocation.
|
||
*
|
||
* Defensive guard: before registering each .sh hook in settings.json,
|
||
* install.js must verify the target file exists. If it doesn't, skip
|
||
* registration and emit a warning.
|
||
*
|
||
* Behavioral (#3466): see the bug-1754 block above — same
|
||
* `applySettingsJsonHooks` seam, applied to the three opt-in `.sh` hooks.
|
||
*/
|
||
|
||
'use strict';
|
||
|
||
const { describe, test, beforeEach, afterEach } = require('node:test');
|
||
const assert = require('node:assert/strict');
|
||
const fs = require('fs');
|
||
const path = require('path');
|
||
const { createTempDir, cleanup, captureConsole } = require('./helpers.cjs');
|
||
const { applySettingsJsonHooks } = require('../msd-core/bin/lib/runtime-hooks-surface.cjs');
|
||
|
||
const SH_HOOKS = [
|
||
'msd-validate-commit.sh',
|
||
'msd-session-state.sh',
|
||
'msd-phase-boundary.sh',
|
||
];
|
||
|
||
// Same seam as the bug-1754 block above, duplicated locally rather than
|
||
// imported across the fold boundary — each folded block is a standalone
|
||
// module scope (see the __foldDescribe wrapper), matching this file's
|
||
// existing folding convention.
|
||
function runApplySettingsJsonHooksForSh(targetDir, presentHooks) {
|
||
fs.mkdirSync(path.join(targetDir, 'hooks'), { recursive: true });
|
||
for (const hook of presentHooks) {
|
||
fs.writeFileSync(path.join(targetDir, 'hooks', hook), '#!/bin/sh\n');
|
||
}
|
||
const settings = {};
|
||
const localCmd = (hookFile) => `node ${path.join(targetDir, 'hooks', hookFile)}`;
|
||
const localShellCmd = (hookFile) => `bash ${path.join(targetDir, 'hooks', hookFile)}`;
|
||
const { stdout, stderr } = captureConsole(() => {
|
||
applySettingsJsonHooks(settings, {
|
||
runtime: 'claude',
|
||
isGlobal: false,
|
||
targetDir,
|
||
postToolEvent: 'PostToolUse',
|
||
hookEvents: 'claude',
|
||
extendedHookEvents: [],
|
||
hooksSurface: 'settings-json',
|
||
updateCheckCommand: localCmd('msd-check-update.js'),
|
||
contextMonitorCommand: localCmd('msd-context-monitor.js'),
|
||
promptGuardCommand: localCmd('msd-prompt-guard.js'),
|
||
readGuardCommand: localCmd('msd-read-guard.js'),
|
||
readInjectionScannerCommand: localCmd('msd-read-injection-scanner.js'),
|
||
configReloadCommand: null,
|
||
hookOpts: { portableHooks: false, runtime: 'claude' },
|
||
localCmd,
|
||
localShellCmd,
|
||
});
|
||
});
|
||
return { settings, stdout, stderr };
|
||
}
|
||
|
||
function shSettingsReferencesHook(settings, hookBaseName) {
|
||
const events = Object.values(settings.hooks || {});
|
||
return events.some((entries) =>
|
||
Array.isArray(entries) && entries.some((entry) =>
|
||
Array.isArray(entry.hooks) && entry.hooks.some((h) => h.command && h.command.includes(hookBaseName))
|
||
)
|
||
);
|
||
}
|
||
|
||
describe('bug #1817: .sh hook registration guards', () => {
|
||
let targetDir;
|
||
beforeEach(() => { targetDir = createTempDir('msd-hook-guard-sh-'); });
|
||
afterEach(() => { cleanup(targetDir); });
|
||
|
||
for (const hookName of SH_HOOKS) {
|
||
test(`${hookName} is NOT registered in settings.json when its file is missing at the target path`, () => {
|
||
const present = SH_HOOKS.filter((h) => h !== hookName);
|
||
const { settings, stderr } = runApplySettingsJsonHooksForSh(targetDir, present);
|
||
|
||
assert.equal(
|
||
shSettingsReferencesHook(settings, hookName), false,
|
||
`settings.json must NOT register ${hookName} when its file was never copied (root cause of #1817)`,
|
||
);
|
||
assert.ok(
|
||
stderr.includes(hookName.replace('.sh', '')),
|
||
`install must emit a skip warning naming ${hookName} when it is missing (stderr: ${stderr})`,
|
||
);
|
||
|
||
for (const otherHook of present) {
|
||
assert.equal(
|
||
shSettingsReferencesHook(settings, otherHook), true,
|
||
`${otherHook} (present on disk) must still be registered — the guard must be per-file, not wholesale`,
|
||
);
|
||
}
|
||
});
|
||
}
|
||
});
|
||
});
|
||
}
|
||
|
||
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
// Folded from tests/enh-1076-extended-hook-events-drive.test.cjs — consolidation epic #1969 (B1 #1970)
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
{
|
||
const { describe: __foldDescribe } = require('node:test');
|
||
__foldDescribe("folded:enh-1076-extended-hook-events-drive (consolidation epic #1969 B1 #1970)", () => {
|
||
'use strict';
|
||
|
||
process.env.MSD_TEST_MODE = '1';
|
||
|
||
/**
|
||
* ADR-857 phase 5f-3: extended hook event guards are driven by the
|
||
* extendedHookEvents descriptor field, not hardcoded runtime-name checks.
|
||
*
|
||
* Before this change:
|
||
* - SubagentStop/Stop/PreCompact were wired only when (runtime==='claude')
|
||
* - FileChanged was wired only when (runtime === 'claude')
|
||
* - BeforeAgent/AfterAgent/BeforeModel were wired only when (isGemini)
|
||
*
|
||
* After this change:
|
||
* - All three guard blocks are driven purely by extendedEvents.includes(eventName)
|
||
* - Any runtime (or arbitrary string) that passes the right extendedHookEvents
|
||
* array gets exactly those events registered, regardless of its runtime name.
|
||
*
|
||
* This suite proves descriptor-drive by calling applySettingsJsonHooks directly
|
||
* with a controlled extendedHookEvents array and asserting on settings.hooks.
|
||
* No source-grep; purely behavioral.
|
||
*/
|
||
|
||
const { test, describe, before } = require('node:test');
|
||
const assert = require('node:assert/strict');
|
||
const fs = require('node:fs');
|
||
const path = require('node:path');
|
||
const { ensureHooksDist } = require('./helpers/hooks-dist.cjs');
|
||
|
||
const REPO_ROOT = path.resolve(__dirname, '..');
|
||
|
||
before(() => {
|
||
ensureHooksDist();
|
||
});
|
||
|
||
const { applySettingsJsonHooks } = require('../msd-core/bin/lib/runtime-hooks-surface.cjs');
|
||
const { cleanup } = require('./helpers.cjs');
|
||
|
||
// ─── Helpers ─────────────────────────────────────────────────────────────────
|
||
|
||
/** Return all hook commands registered under an event key. */
|
||
function hooksForEvent(settings, eventName) {
|
||
if (!settings || !settings.hooks || !Array.isArray(settings.hooks[eventName])) return [];
|
||
return settings.hooks[eventName].flatMap(entry =>
|
||
(entry && Array.isArray(entry.hooks) ? entry.hooks : [])
|
||
.map(h => h && h.command)
|
||
.filter(Boolean)
|
||
);
|
||
}
|
||
|
||
/** True if any hook is registered under eventName. */
|
||
function hasHooksFor(settings, eventName) {
|
||
return hooksForEvent(settings, eventName).length > 0;
|
||
}
|
||
|
||
/**
|
||
* Create a temporary directory with stub hook files so fs.existsSync guards pass.
|
||
* Returns the targetDir path.
|
||
*/
|
||
function createStubTargetDir() {
|
||
const tmpDir = fs.mkdtempSync(path.join(require('node:os').tmpdir(), 'msd-1076-'));
|
||
const hooksDir = path.join(tmpDir, 'hooks');
|
||
fs.mkdirSync(hooksDir, { recursive: true });
|
||
// Stubs for the hooks applySettingsJsonHooks existsSync-checks
|
||
const stubs = [
|
||
'msd-check-update.js',
|
||
'msd-context-monitor.js',
|
||
'msd-prompt-guard.js',
|
||
'msd-read-guard.js',
|
||
'msd-read-injection-scanner.js',
|
||
'msd-config-reload.js',
|
||
'msd-workflow-guard.js',
|
||
'msd-worktree-path-guard.js',
|
||
'msd-validate-commit.sh',
|
||
'msd-session-state.sh',
|
||
'msd-phase-boundary.sh',
|
||
'msd-graphify-update.sh',
|
||
];
|
||
const hooksDistDir = path.join(REPO_ROOT, 'hooks', 'dist');
|
||
for (const stub of stubs) {
|
||
const dest = path.join(hooksDir, stub);
|
||
const distSrc = path.join(hooksDistDir, stub);
|
||
if (fs.existsSync(distSrc)) {
|
||
fs.copyFileSync(distSrc, dest);
|
||
} else {
|
||
// Minimal stub so existsSync passes
|
||
const ext = path.extname(stub);
|
||
fs.writeFileSync(dest, ext === '.sh' ? '#!/bin/bash\n# stub\n' : '#!/usr/bin/env node\n// stub\n');
|
||
}
|
||
try { fs.chmodSync(dest, 0o755); } catch { /* Windows */ }
|
||
}
|
||
return tmpDir;
|
||
}
|
||
|
||
function cleanupDir(dir) {
|
||
cleanup(dir);
|
||
}
|
||
|
||
/**
|
||
* Build the minimal opts bag for applySettingsJsonHooks.
|
||
* postToolEvent: 'PostToolUse' (default dialect).
|
||
* All commands: non-null strings so the "command truthy" guard passes.
|
||
*/
|
||
function buildOpts(targetDir, { runtime, extendedHookEvents }) {
|
||
const hookOpts = { platform: process.platform, runtime };
|
||
const node = process.execPath;
|
||
return {
|
||
runtime,
|
||
isGlobal: true,
|
||
targetDir,
|
||
postToolEvent: 'PostToolUse',
|
||
hookEvents: undefined, // not the hookEvents dialect — we're testing extendedHookEvents
|
||
extendedHookEvents,
|
||
updateCheckCommand: `${node} "${path.join(targetDir, 'hooks', 'msd-check-update.js')}"`,
|
||
contextMonitorCommand: `${node} "${path.join(targetDir, 'hooks', 'msd-context-monitor.js')}"`,
|
||
promptGuardCommand: `${node} "${path.join(targetDir, 'hooks', 'msd-prompt-guard.js')}"`,
|
||
readGuardCommand: `${node} "${path.join(targetDir, 'hooks', 'msd-read-guard.js')}"`,
|
||
readInjectionScannerCommand: `${node} "${path.join(targetDir, 'hooks', 'msd-read-injection-scanner.js')}"`,
|
||
configReloadCommand: `${node} "${path.join(targetDir, 'hooks', 'msd-config-reload.js')}"`,
|
||
hookOpts,
|
||
localCmd: () => null,
|
||
localShellCmd: () => null,
|
||
};
|
||
}
|
||
|
||
// ─── Suite 1: claude shape (SubagentStop+Stop+PreCompact+FileChanged) ─────────
|
||
|
||
describe('enh-1076 phase 5f-3: claude extendedHookEvents → SubagentStop/Stop/PreCompact/FileChanged', () => {
|
||
let targetDir;
|
||
let settings;
|
||
|
||
before(() => {
|
||
targetDir = createStubTargetDir();
|
||
settings = { hooks: {} };
|
||
const opts = buildOpts(targetDir, {
|
||
runtime: 'claude',
|
||
extendedHookEvents: ['SubagentStop', 'Stop', 'PreCompact', 'FileChanged'],
|
||
});
|
||
applySettingsJsonHooks(settings, opts);
|
||
});
|
||
|
||
test('SubagentStop is wired (descriptor-driven)', () => {
|
||
assert.ok(
|
||
hasHooksFor(settings, 'SubagentStop'),
|
||
`Expected SubagentStop hooks; hooks keys: ${JSON.stringify(Object.keys(settings.hooks || {}))}`
|
||
);
|
||
});
|
||
|
||
test('Stop is wired (descriptor-driven)', () => {
|
||
assert.ok(
|
||
hasHooksFor(settings, 'Stop'),
|
||
`Expected Stop hooks; hooks keys: ${JSON.stringify(Object.keys(settings.hooks || {}))}`
|
||
);
|
||
});
|
||
|
||
test('PreCompact is wired (descriptor-driven)', () => {
|
||
assert.ok(
|
||
hasHooksFor(settings, 'PreCompact'),
|
||
`Expected PreCompact hooks; hooks keys: ${JSON.stringify(Object.keys(settings.hooks || {}))}`
|
||
);
|
||
});
|
||
|
||
test('FileChanged is wired (descriptor-driven)', () => {
|
||
assert.ok(
|
||
hasHooksFor(settings, 'FileChanged'),
|
||
`Expected FileChanged hooks; hooks keys: ${JSON.stringify(Object.keys(settings.hooks || {}))}`
|
||
);
|
||
});
|
||
|
||
test('cleanup', () => {
|
||
cleanupDir(targetDir);
|
||
});
|
||
});
|
||
|
||
// ─── Suite 2: SubagentStop+Stop+PreCompact shape (no FileChanged) ─────────────
|
||
|
||
describe('enh-1076 phase 5f-3: extendedHookEvents → SubagentStop/Stop/PreCompact only', () => {
|
||
let targetDir;
|
||
let settings;
|
||
|
||
before(() => {
|
||
targetDir = createStubTargetDir();
|
||
settings = { hooks: {} };
|
||
const opts = buildOpts(targetDir, {
|
||
runtime: 'hypothetical-stop-shape',
|
||
extendedHookEvents: ['SubagentStop', 'Stop', 'PreCompact'],
|
||
});
|
||
applySettingsJsonHooks(settings, opts);
|
||
});
|
||
|
||
test('SubagentStop is wired', () => {
|
||
assert.ok(hasHooksFor(settings, 'SubagentStop'));
|
||
});
|
||
|
||
test('Stop is wired', () => {
|
||
assert.ok(hasHooksFor(settings, 'Stop'));
|
||
});
|
||
|
||
test('PreCompact is wired', () => {
|
||
assert.ok(hasHooksFor(settings, 'PreCompact'));
|
||
});
|
||
|
||
test('FileChanged is NOT wired (not in extendedHookEvents)', () => {
|
||
assert.strictEqual(
|
||
hasHooksFor(settings, 'FileChanged'),
|
||
false,
|
||
`FileChanged must NOT be wired for the SubagentStop/Stop/PreCompact shape; hooks keys: ${JSON.stringify(Object.keys(settings.hooks || {}))}`
|
||
);
|
||
});
|
||
|
||
test('cleanup', () => {
|
||
cleanupDir(targetDir);
|
||
});
|
||
});
|
||
|
||
// ─── Suite 3: gemini shape (BeforeAgent+AfterAgent+BeforeModel) ───────────────
|
||
|
||
describe('enh-1076 phase 5f-3: extendedHookEvents → BeforeAgent/AfterAgent/BeforeModel (Gemini-3 backend dialect)', () => {
|
||
let targetDir;
|
||
let settings;
|
||
|
||
before(() => {
|
||
targetDir = createStubTargetDir();
|
||
settings = { hooks: {} };
|
||
const opts = buildOpts(targetDir, {
|
||
runtime: 'antigravity',
|
||
extendedHookEvents: ['BeforeAgent', 'AfterAgent', 'BeforeModel'],
|
||
});
|
||
applySettingsJsonHooks(settings, opts);
|
||
});
|
||
|
||
test('BeforeAgent is wired', () => {
|
||
assert.ok(
|
||
hasHooksFor(settings, 'BeforeAgent'),
|
||
`Expected BeforeAgent hooks; hooks keys: ${JSON.stringify(Object.keys(settings.hooks || {}))}`
|
||
);
|
||
});
|
||
|
||
test('AfterAgent is wired', () => {
|
||
assert.ok(hasHooksFor(settings, 'AfterAgent'));
|
||
});
|
||
|
||
test('BeforeModel is wired', () => {
|
||
assert.ok(hasHooksFor(settings, 'BeforeModel'));
|
||
});
|
||
|
||
test('SubagentStop is NOT wired (not in extendedHookEvents)', () => {
|
||
assert.strictEqual(
|
||
hasHooksFor(settings, 'SubagentStop'),
|
||
false,
|
||
'SubagentStop must NOT be wired for gemini shape'
|
||
);
|
||
});
|
||
|
||
test('FileChanged is NOT wired (not in extendedHookEvents)', () => {
|
||
assert.strictEqual(
|
||
hasHooksFor(settings, 'FileChanged'),
|
||
false,
|
||
'FileChanged must NOT be wired for gemini shape'
|
||
);
|
||
});
|
||
|
||
test('cleanup', () => {
|
||
cleanupDir(targetDir);
|
||
});
|
||
});
|
||
|
||
// ─── Suite 4: empty extendedHookEvents → none of the extended events ──────────
|
||
|
||
describe('enh-1076 phase 5f-3: empty extendedHookEvents → no extended events wired', () => {
|
||
let targetDir;
|
||
let settings;
|
||
|
||
before(() => {
|
||
targetDir = createStubTargetDir();
|
||
settings = { hooks: {} };
|
||
// Use runtime='someruntime' to prove it's the descriptor, not the name, that matters
|
||
const opts = buildOpts(targetDir, {
|
||
runtime: 'someruntime',
|
||
extendedHookEvents: [],
|
||
});
|
||
applySettingsJsonHooks(settings, opts);
|
||
});
|
||
|
||
const EXTENDED_EVENTS = [
|
||
'SubagentStop', 'Stop', 'PreCompact', 'FileChanged',
|
||
'BeforeAgent', 'AfterAgent', 'BeforeModel',
|
||
];
|
||
|
||
for (const event of EXTENDED_EVENTS) {
|
||
test(`${event} is NOT wired when extendedHookEvents is empty`, () => {
|
||
assert.strictEqual(
|
||
hasHooksFor(settings, event),
|
||
false,
|
||
`${event} must not be wired when extendedHookEvents=[] (runtime=someruntime); hooks keys: ${JSON.stringify(Object.keys(settings.hooks || {}))}`
|
||
);
|
||
});
|
||
}
|
||
|
||
test('cleanup', () => {
|
||
cleanupDir(targetDir);
|
||
});
|
||
});
|
||
|
||
// ─── Suite 5: descriptor-drive is runtime-name-agnostic ───────────────────────
|
||
// Pass an arbitrary runtime name ('hypothetical') with SubagentStop in its
|
||
// extendedHookEvents. This could NEVER have worked under the old hardcoded check.
|
||
// Under the new descriptor-driven guard it MUST work.
|
||
|
||
describe('enh-1076 phase 5f-3: arbitrary runtime with SubagentStop in descriptor gets it wired', () => {
|
||
let targetDir;
|
||
let settings;
|
||
|
||
before(() => {
|
||
targetDir = createStubTargetDir();
|
||
settings = { hooks: {} };
|
||
const opts = buildOpts(targetDir, {
|
||
runtime: 'hypothetical', // NOT 'claude' — would have been skipped before
|
||
extendedHookEvents: ['SubagentStop'],
|
||
});
|
||
applySettingsJsonHooks(settings, opts);
|
||
});
|
||
|
||
test('SubagentStop IS wired for a hypothetical runtime when descriptor includes it', () => {
|
||
assert.ok(
|
||
hasHooksFor(settings, 'SubagentStop'),
|
||
`SubagentStop must be wired via descriptor even for unknown runtime names; hooks keys: ${JSON.stringify(Object.keys(settings.hooks || {}))}`
|
||
);
|
||
});
|
||
|
||
test('Stop is NOT wired (not in extendedHookEvents)', () => {
|
||
assert.strictEqual(hasHooksFor(settings, 'Stop'), false);
|
||
});
|
||
|
||
test('cleanup', () => {
|
||
cleanupDir(targetDir);
|
||
});
|
||
});
|
||
|
||
// ─── Suite 6: hooksSurface drive (ADR-857 phase 5g drive 3) ──────────────────
|
||
//
|
||
// applySettingsJsonHooks is gated by opts.hooksSurface !== 'none'.
|
||
// - hooksSurface:'none' → entire body is skipped; no hooks written
|
||
// - hooksSurface:'settings-json'→ hooks are written (even for a runtime whose
|
||
// name was previously hardcoded to skip, e.g. 'opencode')
|
||
//
|
||
// This proves the skip is driven by the descriptor field, not the runtime name.
|
||
|
||
describe('enh-1076 phase 5g drive 3: hooksSurface:none skips all hooks regardless of runtime', () => {
|
||
let targetDir;
|
||
let settings;
|
||
|
||
before(() => {
|
||
targetDir = createStubTargetDir();
|
||
settings = { hooks: {} };
|
||
// 'claude' would normally write hooks, but hooksSurface:'none' must skip entirely.
|
||
const opts = {
|
||
...buildOpts(targetDir, { runtime: 'claude', extendedHookEvents: ['SubagentStop'] }),
|
||
hooksSurface: 'none',
|
||
};
|
||
applySettingsJsonHooks(settings, opts);
|
||
});
|
||
|
||
test('SessionStart is NOT written when hooksSurface is "none"', () => {
|
||
assert.strictEqual(
|
||
hasHooksFor(settings, 'SessionStart'),
|
||
false,
|
||
`SessionStart must not be written when hooksSurface="none"; hooks keys: ${JSON.stringify(Object.keys(settings.hooks || {}))}`
|
||
);
|
||
});
|
||
|
||
test('PostToolUse is NOT written when hooksSurface is "none"', () => {
|
||
assert.strictEqual(hasHooksFor(settings, 'PostToolUse'), false);
|
||
});
|
||
|
||
test('PreToolUse is NOT written when hooksSurface is "none"', () => {
|
||
assert.strictEqual(hasHooksFor(settings, 'PreToolUse'), false);
|
||
});
|
||
|
||
test('cleanup', () => {
|
||
cleanupDir(targetDir);
|
||
});
|
||
});
|
||
|
||
describe('enh-1076 phase 5g drive 3: hooksSurface:settings-json writes hooks even for previously-skipped runtime name', () => {
|
||
let targetDir;
|
||
let settings;
|
||
|
||
before(() => {
|
||
targetDir = createStubTargetDir();
|
||
settings = { hooks: {} };
|
||
// 'opencode' previously was hardcoded to skip hooks; with descriptor drive it
|
||
// should write hooks whenever hooksSurface !== 'none'.
|
||
const opts = {
|
||
...buildOpts(targetDir, { runtime: 'opencode', extendedHookEvents: [] }),
|
||
hooksSurface: 'settings-json',
|
||
};
|
||
applySettingsJsonHooks(settings, opts);
|
||
});
|
||
|
||
test('SessionStart IS written with at least one command when hooksSurface is "settings-json" (even for opencode name)', () => {
|
||
// ensureHooksDist() in before() guarantees hooks/dist is built, so the
|
||
// existsSync guards inside applySettingsJsonHooks pass and commands are registered.
|
||
assert.ok(
|
||
settings.hooks && typeof settings.hooks === 'object',
|
||
`settings.hooks must be initialized when hooksSurface="settings-json"`,
|
||
);
|
||
assert.ok(
|
||
hasHooksFor(settings, 'SessionStart'),
|
||
`settings.hooks.SessionStart must contain at least one registered command when hooksSurface="settings-json"; ` +
|
||
`keys: ${JSON.stringify(Object.keys(settings.hooks))}`,
|
||
);
|
||
});
|
||
|
||
test('cleanup', () => {
|
||
cleanupDir(targetDir);
|
||
});
|
||
});
|
||
});
|
||
}
|
||
|
||
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
// Folded from tests/enh-1077-install-hook-events-dialect-drive.test.cjs — consolidation epic #1969 (B1 #1970)
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
{
|
||
const { describe: __foldDescribe } = require('node:test');
|
||
__foldDescribe("folded:enh-1077-install-hook-events-dialect-drive (consolidation epic #1969 B1 #1970)", () => {
|
||
'use strict';
|
||
|
||
process.env.MSD_TEST_MODE = '1';
|
||
|
||
/**
|
||
* ADR-857 phase 5f-2: hook-events dialect is driven from the registry descriptor.
|
||
*
|
||
* Before this change, postToolEvent and preToolEvent were hardcoded strings
|
||
* derived from runtime-name checks:
|
||
*
|
||
* (runtime === 'gemini' || runtime === 'antigravity') ? 'AfterTool' : 'PostToolUse'
|
||
* (runtime === 'gemini' || runtime === 'antigravity') ? 'BeforeTool' : 'PreToolUse'
|
||
*
|
||
* After phase 5f-2, both are driven by the registry descriptor's
|
||
* `hookEvents` field: hookEvents === 'gemini' → AfterTool/BeforeTool;
|
||
* any other value (or missing) → PostToolUse/PreToolUse.
|
||
*
|
||
* Equivalence (i.e. identical observable behaviour for all runtimes):
|
||
* hookEvents === 'gemini' iff runtime ∈ {gemini, antigravity}
|
||
*
|
||
* This suite asserts the equivalence and the registry-parity invariant:
|
||
* any runtime whose descriptor carries hookEvents='gemini' gets the
|
||
* AfterTool/BeforeTool dialect; all others get PostToolUse/PreToolUse.
|
||
*/
|
||
|
||
const { test, describe, before, beforeEach, afterEach } = require('node:test');
|
||
const assert = require('node:assert/strict');
|
||
const fs = require('node:fs');
|
||
const path = require('node:path');
|
||
const { ensureHooksDist } = require('./helpers/hooks-dist.cjs');
|
||
|
||
const { install } = require('../bin/install.js');
|
||
const { createTempDir, cleanup } = require('./helpers.cjs');
|
||
|
||
// ─── hooks/dist build guard ───────────────────────────────────────────────────
|
||
//
|
||
// hooks/dist/ is gitignored and only produced by `npm run build:hooks`.
|
||
// In CI the scoped/windows test jobs do NOT run build:hooks before running
|
||
// tests, so install() finds no hook files → event arrays come back empty →
|
||
// every "expected AfterTool/PostToolUse/BeforeTool/PreToolUse hooks" assertion
|
||
// fails. This mirrors the pattern in bug-376-claude-js-hook-msd-rewriter.test.cjs.
|
||
|
||
before(() => {
|
||
ensureHooksDist();
|
||
});
|
||
|
||
// ─── Registry lookup ──────────────────────────────────────────────────────────
|
||
|
||
const REGISTRY_PATH = path.join(__dirname, '..', 'msd-core', 'bin', 'lib', 'capability-registry.cjs');
|
||
const registry = (() => {
|
||
try { return require(REGISTRY_PATH); } catch { return undefined; }
|
||
})();
|
||
|
||
/**
|
||
* Return the hookEvents dialect for a runtime ID from the live registry.
|
||
* Returns undefined when the registry is absent or the runtime has no descriptor.
|
||
*/
|
||
function registryHookEvents(runtimeId) {
|
||
return registry?.runtimes?.[runtimeId]?.runtime?.hookEvents;
|
||
}
|
||
|
||
// ─── Helpers ──────────────────────────────────────────────────────────────────
|
||
|
||
/** Collect all hook commands registered under a settings event key. */
|
||
function hooksForEvent(settings, eventName) {
|
||
if (!settings || !settings.hooks || !Array.isArray(settings.hooks[eventName])) return [];
|
||
return settings.hooks[eventName].flatMap(entry =>
|
||
(entry && Array.isArray(entry.hooks) ? entry.hooks : [])
|
||
.map(h => h && h.command)
|
||
.filter(Boolean)
|
||
);
|
||
}
|
||
|
||
/** True if at least one hook is registered under eventName. */
|
||
function hasHooksFor(settings, eventName) {
|
||
return hooksForEvent(settings, eventName).length > 0;
|
||
}
|
||
|
||
// ─── Suite 1: Gemini-dialect runtimes use AfterTool/BeforeTool ───────────────
|
||
//
|
||
// Registry runtimes with hookEvents='gemini': gemini, antigravity
|
||
|
||
describe('enh-1077 phase 5f-2: gemini hookEvents dialect → AfterTool/BeforeTool', () => {
|
||
// #1928: the gemini runtime was removed (Google sunset Gemini CLI
|
||
// 2026-06-18). antigravity — the Gemini-backend successor — is the only
|
||
// remaining runtime whose descriptor carries hookEvents='gemini'.
|
||
|
||
describe('antigravity install uses AfterTool/BeforeTool (gemini dialect)', () => {
|
||
let tmpDir;
|
||
let previousCwd;
|
||
let settings;
|
||
|
||
beforeEach(() => {
|
||
tmpDir = createTempDir('msd-1077-antigrav-');
|
||
previousCwd = process.cwd();
|
||
process.chdir(tmpDir);
|
||
|
||
const agDir = path.join(tmpDir, '.gemini', 'antigravity');
|
||
fs.mkdirSync(agDir, { recursive: true });
|
||
const result = install(false, 'antigravity');
|
||
settings = result && result.settings;
|
||
});
|
||
|
||
afterEach(() => {
|
||
process.chdir(previousCwd);
|
||
cleanup(tmpDir);
|
||
});
|
||
|
||
test('registry confirms antigravity hookEvents is "gemini"', () => {
|
||
const he = registryHookEvents('antigravity');
|
||
if (he !== undefined) {
|
||
assert.strictEqual(he, 'gemini',
|
||
'Registry descriptor for antigravity must declare hookEvents="gemini"');
|
||
}
|
||
});
|
||
|
||
test('antigravity install returns a settings object', () => {
|
||
assert.ok(settings !== null && typeof settings === 'object',
|
||
'antigravity install must return a non-null settings object');
|
||
});
|
||
|
||
test('antigravity install registers at least one hook under AfterTool', () => {
|
||
assert.ok(hasHooksFor(settings, 'AfterTool'),
|
||
`Expected AfterTool hooks on antigravity; got hooks keys: ${JSON.stringify(Object.keys((settings && settings.hooks) || {}))}`);
|
||
});
|
||
|
||
test('antigravity install does NOT register context-monitor under PostToolUse', () => {
|
||
const cmds = hooksForEvent(settings, 'PostToolUse');
|
||
const hasMonitor = cmds.some(c => c && c.includes('msd-context-monitor'));
|
||
assert.strictEqual(hasMonitor, false,
|
||
`antigravity must NOT use PostToolUse for context-monitor; got: ${JSON.stringify(cmds)}`);
|
||
});
|
||
|
||
test('antigravity install registers at least one pre-tool hook (prompt-guard) under BeforeTool', () => {
|
||
const cmds = hooksForEvent(settings, 'BeforeTool');
|
||
const hasPromptGuard = cmds.some(c => c && c.includes('msd-prompt-guard'));
|
||
assert.ok(hasPromptGuard,
|
||
`Expected prompt-guard hook under BeforeTool on antigravity; BeforeTool commands: ${JSON.stringify(cmds)}; hooks keys: ${JSON.stringify(Object.keys((settings && settings.hooks) || {}))}`);
|
||
});
|
||
|
||
test('antigravity install does NOT register prompt-guard under PreToolUse (wrong pre-tool dialect)', () => {
|
||
const cmds = hooksForEvent(settings, 'PreToolUse');
|
||
const hasPromptGuard = cmds.some(c => c && c.includes('msd-prompt-guard'));
|
||
assert.strictEqual(hasPromptGuard, false,
|
||
`antigravity must NOT use PreToolUse for prompt-guard; got PreToolUse commands: ${JSON.stringify(cmds)}`);
|
||
});
|
||
});
|
||
});
|
||
|
||
// ─── Suite 2: Claude-dialect runtimes use PostToolUse/PreToolUse ──────────────
|
||
//
|
||
// Registry runtimes with hookEvents='claude': claude
|
||
|
||
describe('enh-1077 phase 5f-2: claude hookEvents dialect → PostToolUse/PreToolUse', () => {
|
||
// ── claude ──
|
||
|
||
describe('claude install uses PostToolUse for post-tool hooks', () => {
|
||
let tmpDir;
|
||
let previousCwd;
|
||
let settings;
|
||
|
||
beforeEach(() => {
|
||
tmpDir = createTempDir('msd-1077-claude-');
|
||
previousCwd = process.cwd();
|
||
process.chdir(tmpDir);
|
||
|
||
const claudeDir = path.join(tmpDir, '.claude');
|
||
fs.mkdirSync(claudeDir, { recursive: true });
|
||
const result = install(false, 'claude');
|
||
settings = result && result.settings;
|
||
});
|
||
|
||
afterEach(() => {
|
||
process.chdir(previousCwd);
|
||
cleanup(tmpDir);
|
||
});
|
||
|
||
test('registry confirms claude hookEvents is "claude"', () => {
|
||
const he = registryHookEvents('claude');
|
||
if (he !== undefined) {
|
||
assert.strictEqual(he, 'claude',
|
||
'Registry descriptor for claude must declare hookEvents="claude"');
|
||
}
|
||
});
|
||
|
||
test('claude install returns a settings object', () => {
|
||
assert.ok(settings !== null && typeof settings === 'object',
|
||
'claude install must return a non-null settings object');
|
||
});
|
||
|
||
test('claude install registers at least one hook under PostToolUse', () => {
|
||
assert.ok(hasHooksFor(settings, 'PostToolUse'),
|
||
`Expected PostToolUse hooks on claude; got hooks keys: ${JSON.stringify(Object.keys((settings && settings.hooks) || {}))}`);
|
||
});
|
||
|
||
test('claude install does NOT register context-monitor under AfterTool (wrong dialect)', () => {
|
||
const cmds = hooksForEvent(settings, 'AfterTool');
|
||
const hasMonitor = cmds.some(c => c && c.includes('msd-context-monitor'));
|
||
assert.strictEqual(hasMonitor, false,
|
||
`claude must NOT use AfterTool for context-monitor; got AfterTool commands: ${JSON.stringify(cmds)}`);
|
||
});
|
||
|
||
test('claude install registers at least one pre-tool hook (prompt-guard) under PreToolUse', () => {
|
||
const cmds = hooksForEvent(settings, 'PreToolUse');
|
||
const hasPromptGuard = cmds.some(c => c && c.includes('msd-prompt-guard'));
|
||
assert.ok(hasPromptGuard,
|
||
`Expected prompt-guard hook under PreToolUse on claude; PreToolUse commands: ${JSON.stringify(cmds)}; hooks keys: ${JSON.stringify(Object.keys((settings && settings.hooks) || {}))}`);
|
||
});
|
||
|
||
test('claude install does NOT register prompt-guard under BeforeTool (wrong pre-tool dialect)', () => {
|
||
const cmds = hooksForEvent(settings, 'BeforeTool');
|
||
const hasPromptGuard = cmds.some(c => c && c.includes('msd-prompt-guard'));
|
||
assert.strictEqual(hasPromptGuard, false,
|
||
`claude must NOT use BeforeTool for prompt-guard; got BeforeTool commands: ${JSON.stringify(cmds)}`);
|
||
});
|
||
});
|
||
|
||
});
|
||
|
||
// ─── Suite 3: Registry-parity invariant ──────────────────────────────────────
|
||
//
|
||
// For every runtime in the registry that exposes a settings.json surface
|
||
// (i.e. hookEvents is defined), assert that the installed hook dialect matches
|
||
// the registry value. This is the generative-fix parity assertion
|
||
// (DEFECT.GENERATIVE-FIX): adding a new runtime with hookEvents to the
|
||
// registry automatically requires a passing install test for that runtime.
|
||
|
||
describe('enh-1077 phase 5f-2: registry-parity — hookEvents descriptor drives install dialect', () => {
|
||
test('all registry runtimes with hookEvents use the matching install dialect', () => {
|
||
if (!registry || !registry.runtimes) {
|
||
// Registry absent — skip parity check (equivalence still verified above)
|
||
return;
|
||
}
|
||
|
||
// Runtimes that have settings.json surfaces and a hookEvents descriptor
|
||
const SETTINGS_JSON_RUNTIMES = ['claude', 'antigravity'];
|
||
|
||
const failures = [];
|
||
|
||
for (const runtimeId of SETTINGS_JSON_RUNTIMES) {
|
||
const he = registryHookEvents(runtimeId);
|
||
if (he === undefined) continue; // no hookEvents in descriptor — skip
|
||
|
||
const expectedPostEvent = he === 'gemini' ? 'AfterTool' : 'PostToolUse';
|
||
const unexpectedPostEvent = he === 'gemini' ? 'PostToolUse' : 'AfterTool';
|
||
const expectedPreEvent = he === 'gemini' ? 'BeforeTool' : 'PreToolUse';
|
||
const unexpectedPreEvent = he === 'gemini' ? 'PreToolUse' : 'BeforeTool';
|
||
|
||
const previousCwd = process.cwd();
|
||
const tmpDir = createTempDir(`msd-1077-parity-${runtimeId}-`);
|
||
try {
|
||
process.chdir(tmpDir);
|
||
const result = install(false, runtimeId);
|
||
const settings = result && result.settings;
|
||
if (!settings) continue; // non-settings-json surface, skip
|
||
|
||
// Post-tool event assertions
|
||
const hasExpected = hasHooksFor(settings, expectedPostEvent);
|
||
const hasUnexpected = hooksForEvent(settings, unexpectedPostEvent)
|
||
.some(c => c && c.includes('msd-context-monitor'));
|
||
|
||
if (!hasExpected) {
|
||
failures.push(`${runtimeId}: expected context-monitor hook under ${expectedPostEvent} (hookEvents=${he}), but none found`);
|
||
}
|
||
if (hasUnexpected) {
|
||
failures.push(`${runtimeId}: must NOT register context-monitor under ${unexpectedPostEvent}, but it was found`);
|
||
}
|
||
|
||
// Pre-tool event assertions: prompt-guard must land under the dialect-correct key.
|
||
const preToolCmdsExpected = hooksForEvent(settings, expectedPreEvent);
|
||
const hasPromptGuardExpected = preToolCmdsExpected.some(c => c && c.includes('msd-prompt-guard'));
|
||
const preToolCmdsUnexpected = hooksForEvent(settings, unexpectedPreEvent);
|
||
const hasPromptGuardUnexpected = preToolCmdsUnexpected.some(c => c && c.includes('msd-prompt-guard'));
|
||
|
||
if (!hasPromptGuardExpected) {
|
||
failures.push(`${runtimeId}: expected prompt-guard hook under ${expectedPreEvent} (hookEvents=${he}), but none found; ${expectedPreEvent} cmds: ${JSON.stringify(preToolCmdsExpected)}`);
|
||
}
|
||
if (hasPromptGuardUnexpected) {
|
||
failures.push(`${runtimeId}: must NOT register prompt-guard under ${unexpectedPreEvent} (hookEvents=${he}), but it was found`);
|
||
}
|
||
} finally {
|
||
process.chdir(previousCwd);
|
||
cleanup(tmpDir);
|
||
}
|
||
}
|
||
|
||
assert.deepEqual(failures, [],
|
||
'Registry-parity failures (hookEvents descriptor must drive install dialect):\n' +
|
||
failures.join('\n'));
|
||
});
|
||
});
|
||
});
|
||
}
|
||
|
||
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
// Folded from tests/enh-788-qwen-hook-events.test.cjs — consolidation epic #1969 (B1 #1970)
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
{
|
||
const { describe: __foldDescribe } = require('node:test');
|
||
__foldDescribe("folded:enh-788-qwen-hook-events (consolidation epic #1969 B1 #1970)", () => {
|
||
'use strict';
|
||
|
||
process.env.MSD_TEST_MODE = '1';
|
||
|
||
/**
|
||
* Enhancement #788: Expand hook-event coverage.
|
||
*
|
||
* msd previously registered only SessionStart and PostToolUse. This suite
|
||
* asserts that an install registers the 3 new high-value events:
|
||
* - SubagentStop — subagent lifecycle finalisation (context tracking)
|
||
* - Stop — model stop / final-response hook (context tracking)
|
||
* - PreCompact — pre-compaction awareness (context tracking)
|
||
*
|
||
* All three are wired to msd-context-monitor.js — the same hook used for
|
||
* PostToolUse — so context headroom warnings surface at these moments too.
|
||
*
|
||
* Note: UserPromptSubmit is NOT wired — msd-prompt-guard exits unless
|
||
* tool_name is Write|Edit (PreToolUse shape), so it would be a no-op for
|
||
* the UserPromptSubmit payload. Deferred to a follow-on issue.
|
||
*/
|
||
|
||
const { test, describe, beforeEach, afterEach } = require('node:test');
|
||
const assert = require('node:assert/strict');
|
||
const fs = require('node:fs');
|
||
const path = require('node:path');
|
||
|
||
const { install } = require('../bin/install.js');
|
||
const { createTempDir, cleanup } = require('./helpers.cjs');
|
||
|
||
// ─── Helpers ─────────────────────────────────────────────────────────────────
|
||
|
||
/** Extract all hook commands registered under `eventName` from settings. */
|
||
function hooksForEvent(settings, eventName) {
|
||
if (!settings || !settings.hooks || !Array.isArray(settings.hooks[eventName])) return [];
|
||
return settings.hooks[eventName].flatMap(entry =>
|
||
(entry && Array.isArray(entry.hooks) ? entry.hooks : [])
|
||
.map(h => h && h.command)
|
||
.filter(Boolean)
|
||
);
|
||
}
|
||
|
||
// Stub JS hook files that the installer checks with fs.existsSync() so hook
|
||
// registration guards pass even when hooks/dist/ isn't built.
|
||
const HOOKS_SRC = path.join(__dirname, '..', 'hooks');
|
||
const STUB_HOOKS = [
|
||
'msd-context-monitor.js',
|
||
'msd-prompt-guard.js',
|
||
'msd-check-update.js',
|
||
'msd-config-reload.js', // Added in #770
|
||
];
|
||
|
||
function stubHooksIntoTarget(targetDir) {
|
||
const hooksDest = path.join(targetDir, 'hooks');
|
||
fs.mkdirSync(hooksDest, { recursive: true });
|
||
for (const hookFile of STUB_HOOKS) {
|
||
const src = path.join(HOOKS_SRC, hookFile);
|
||
const dest = path.join(hooksDest, hookFile);
|
||
if (fs.existsSync(src)) {
|
||
fs.copyFileSync(src, dest);
|
||
} else {
|
||
// Minimal stub so existsSync passes
|
||
fs.writeFileSync(dest, '#!/usr/bin/env node\n// stub\n');
|
||
}
|
||
try { fs.chmodSync(dest, 0o755); } catch { /* Windows */ }
|
||
}
|
||
}
|
||
|
||
// ─── Suite 2: Claude install DOES get the context events (since #770) ───────
|
||
// Note: #770 extended these events to Claude Code.
|
||
|
||
describe('enh-788 (updated by #770): Claude install registers context lifecycle events', () => {
|
||
let tmpDir;
|
||
let previousCwd;
|
||
let settings;
|
||
|
||
beforeEach(() => {
|
||
tmpDir = createTempDir('msd-788-claude-');
|
||
previousCwd = process.cwd();
|
||
process.chdir(tmpDir);
|
||
stubHooksIntoTarget(path.join(tmpDir, '.claude'));
|
||
|
||
const result = install(false, 'claude', { installerMigrations: [] });
|
||
settings = result && result.settings;
|
||
});
|
||
|
||
afterEach(() => {
|
||
process.chdir(previousCwd);
|
||
cleanup(tmpDir);
|
||
});
|
||
|
||
test('Claude install registers SubagentStop (since #770)', () => {
|
||
const cmds = hooksForEvent(settings, 'SubagentStop');
|
||
assert.ok(cmds.length > 0,
|
||
`Claude should have SubagentStop since #770; got: ${JSON.stringify(cmds)}`);
|
||
});
|
||
|
||
test('Claude install registers Stop (since #770)', () => {
|
||
const cmds = hooksForEvent(settings, 'Stop');
|
||
assert.ok(cmds.length > 0,
|
||
`Claude should have Stop since #770; got: ${JSON.stringify(cmds)}`);
|
||
});
|
||
|
||
test('Claude install registers PreCompact (since #770)', () => {
|
||
const cmds = hooksForEvent(settings, 'PreCompact');
|
||
assert.ok(cmds.length > 0,
|
||
`Claude should have PreCompact since #770; got: ${JSON.stringify(cmds)}`);
|
||
});
|
||
});
|
||
});
|
||
}
|
||
|
||
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
// Folded from tests/bug-3735-profiles-core-includes-surface.test.cjs — consolidation epic #1969 (B5 #1974)
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
{
|
||
const { describe: __foldDescribe } = require('node:test');
|
||
__foldDescribe("folded:bug-3735-profiles-core-includes-surface (consolidation epic #1969 B5 #1974)", () => {
|
||
'use strict';
|
||
/**
|
||
* Regression test for #3735: PROFILES.core must include 'surface' in its
|
||
* resolved closure so that --profile=core users can expand via
|
||
* /msd:surface enable <cluster> — the advertised use-case from ADR-0011.
|
||
*
|
||
* Stage 2 (RED): This test must fail before the fix is applied.
|
||
* Stage 3 (GREEN): This test must pass after 'surface' is added to PROFILES.core.
|
||
*/
|
||
|
||
const { test, describe } = require('node:test');
|
||
const assert = require('node:assert/strict');
|
||
const path = require('path');
|
||
|
||
const {
|
||
resolveProfile,
|
||
loadSkillsManifest,
|
||
} = require('../msd-core/bin/lib/install-profiles.cjs');
|
||
|
||
const REAL_COMMANDS_DIR = path.join(__dirname, '..', 'commands', 'msd');
|
||
|
||
describe('PROFILES.core — ADR-0011 expand contract', () => {
|
||
test("PROFILES.core includes 'surface' so users can expand via /msd:surface enable", () => {
|
||
const manifest = loadSkillsManifest(REAL_COMMANDS_DIR);
|
||
const result = resolveProfile({ modes: ['core'], manifest });
|
||
|
||
assert.ok(result.skills instanceof Set,
|
||
'resolveProfile must return a skills Set for core profile');
|
||
|
||
// The primary assertion: surface must be in the resolved closure.
|
||
// ADR-0011 documents that --profile=core users expand via /msd:surface enable <cluster>.
|
||
// That sub-command is only available if surface.md is staged — which requires it to be
|
||
// in the resolved set for the core profile.
|
||
assert.ok(result.skills.has('surface'),
|
||
`PROFILES.core resolved closure must include 'surface'; got: [${[...result.skills].sort().join(', ')}]`);
|
||
});
|
||
|
||
// Counter-test: 'forensics' is NOT in core — proves the assertion above is selective,
|
||
// not vacuously true for all skills.
|
||
test("PROFILES.core does NOT include 'forensics' (selective assertion counter-check)", () => {
|
||
const manifest = loadSkillsManifest(REAL_COMMANDS_DIR);
|
||
const result = resolveProfile({ modes: ['core'], manifest });
|
||
|
||
assert.ok(result.skills instanceof Set);
|
||
assert.ok(!result.skills.has('forensics'),
|
||
`'forensics' should NOT be in core closure — it is a specialist skill, not a core loop skill`);
|
||
});
|
||
});
|
||
});
|
||
}
|
||
|
||
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
// Folded from tests/enh-770-claude-hook-events.test.cjs — consolidation epic #1969 (B5 #1974)
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
{
|
||
const { describe: __foldDescribe } = require('node:test');
|
||
__foldDescribe("folded:enh-770-claude-hook-events (consolidation epic #1969 B5 #1974)", () => {
|
||
'use strict';
|
||
|
||
process.env.MSD_TEST_MODE = '1';
|
||
|
||
/**
|
||
* Enhancement #770: Register Claude Code lifecycle hooks (SubagentStop / Stop /
|
||
* PreCompact / FileChanged).
|
||
*
|
||
* Claude Code now supports the same SubagentStop, Stop, and PreCompact events
|
||
* that were wired in #788. This suite asserts:
|
||
*
|
||
* 1. Claude Code installs register SubagentStop, Stop, and PreCompact, each
|
||
* wired to msd-context-monitor.js.
|
||
* 2. Claude Code installs register a FileChanged hook for .planning/config.json
|
||
* wired to msd-config-reload.js (new hook; hot-reloads msd config).
|
||
* 3. All four registrations are idempotent (reinstall does not duplicate).
|
||
* 4. Uninstall removes all four event registrations.
|
||
* 5. The msd-config-reload.js hook script exists in hooks/ and has the
|
||
* expected structure (reads on stdin, emits additionalContext or exits 0).
|
||
* 6. The hooks/hooks.json plugin manifest includes the new events.
|
||
*
|
||
* Source: https://code.claude.com/docs/en/hooks
|
||
*/
|
||
|
||
const { test, describe, beforeEach, afterEach } = require('node:test');
|
||
const assert = require('node:assert/strict');
|
||
const fs = require('node:fs');
|
||
const path = require('node:path');
|
||
|
||
const { install, uninstall, validateHookFields } = require('../bin/install.js');
|
||
const { createTempDir, cleanup } = require('./helpers.cjs');
|
||
|
||
// ─── Helpers ─────────────────────────────────────────────────────────────────
|
||
|
||
/** Extract all hook commands registered under `eventName` from settings. */
|
||
function hooksForEvent(settings, eventName) {
|
||
if (!settings || !settings.hooks || !Array.isArray(settings.hooks[eventName])) return [];
|
||
return settings.hooks[eventName].flatMap(entry =>
|
||
(entry && Array.isArray(entry.hooks) ? entry.hooks : [])
|
||
.map(h => h && h.command)
|
||
.filter(Boolean)
|
||
);
|
||
}
|
||
|
||
/** Extract all matchers registered under `eventName` from settings. */
|
||
function matchersForEvent(settings, eventName) {
|
||
if (!settings || !settings.hooks || !Array.isArray(settings.hooks[eventName])) return [];
|
||
return settings.hooks[eventName]
|
||
.map(entry => entry && entry.matcher)
|
||
.filter(Boolean);
|
||
}
|
||
|
||
const HOOKS_SRC = path.join(__dirname, '..', 'hooks');
|
||
// Hooks the installer existsSync-checks before registering; must be present
|
||
// in targetDir/hooks/ so the registration guards pass.
|
||
const STUB_HOOKS = [
|
||
'msd-context-monitor.js',
|
||
'msd-prompt-guard.js',
|
||
'msd-check-update.js',
|
||
'msd-config-reload.js',
|
||
];
|
||
|
||
/**
|
||
* Pre-populate targetDir/hooks/ with stub hook files so the installer's
|
||
* fs.existsSync guards pass even when hooks/dist/ is absent (e.g. CI without
|
||
* a build step). Each test suite passes its own per-test tmpDir/.claude path
|
||
* so stubs are isolated to that test's temp directory — no shared filesystem
|
||
* state, no cross-test races.
|
||
*
|
||
* When hooks/dist/ DOES exist (local dev with npm run build:hooks), the
|
||
* installer copies real files over these stubs during install() — that is
|
||
* fine and correct.
|
||
*/
|
||
function stubHooksIntoTarget(targetDir) {
|
||
const hooksDest = path.join(targetDir, 'hooks');
|
||
fs.mkdirSync(hooksDest, { recursive: true });
|
||
for (const hookFile of STUB_HOOKS) {
|
||
const src = path.join(HOOKS_SRC, hookFile);
|
||
const dest = path.join(hooksDest, hookFile);
|
||
if (fs.existsSync(src)) {
|
||
fs.copyFileSync(src, dest);
|
||
} else {
|
||
// Minimal stub so existsSync passes
|
||
fs.writeFileSync(dest, '#!/usr/bin/env node\n// stub\n');
|
||
}
|
||
try { fs.chmodSync(dest, 0o755); } catch { /* Windows */ }
|
||
}
|
||
}
|
||
|
||
function persistSettings(settingsPath, settings) {
|
||
fs.mkdirSync(path.dirname(settingsPath), { recursive: true });
|
||
fs.writeFileSync(settingsPath, JSON.stringify(validateHookFields(settings), null, 2) + '\n', 'utf8');
|
||
}
|
||
|
||
// ─── Suite 1: Claude — new context monitor events are registered ──────────────
|
||
|
||
describe('enh-770: Claude install registers SubagentStop / Stop / PreCompact context hooks', () => {
|
||
let tmpDir;
|
||
let previousCwd;
|
||
let settings;
|
||
|
||
beforeEach(() => {
|
||
tmpDir = createTempDir('msd-770-claude-ctx-');
|
||
previousCwd = process.cwd();
|
||
process.chdir(tmpDir);
|
||
stubHooksIntoTarget(path.join(tmpDir, '.claude'));
|
||
|
||
const result = install(false, 'claude', { installerMigrations: [] });
|
||
settings = result && result.settings;
|
||
});
|
||
|
||
afterEach(() => {
|
||
process.chdir(previousCwd);
|
||
cleanup(tmpDir);
|
||
});
|
||
|
||
test('install returns a settings object (not null)', () => {
|
||
assert.ok(settings !== null && typeof settings === 'object',
|
||
'Claude install must return a non-null settings object');
|
||
});
|
||
|
||
test('SubagentStop event is registered with at least one hook', () => {
|
||
const cmds = hooksForEvent(settings, 'SubagentStop');
|
||
assert.ok(cmds.length > 0,
|
||
`Expected SubagentStop hooks; got hooks: ${JSON.stringify(settings && settings.hooks)}`);
|
||
});
|
||
|
||
test('Stop event is registered with at least one hook', () => {
|
||
const cmds = hooksForEvent(settings, 'Stop');
|
||
assert.ok(cmds.length > 0,
|
||
`Expected Stop hooks; got hooks: ${JSON.stringify(settings && settings.hooks)}`);
|
||
});
|
||
|
||
test('PreCompact event is registered with at least one hook', () => {
|
||
const cmds = hooksForEvent(settings, 'PreCompact');
|
||
assert.ok(cmds.length > 0,
|
||
`Expected PreCompact hooks; got hooks: ${JSON.stringify(settings && settings.hooks)}`);
|
||
});
|
||
|
||
test('SubagentStop / Stop / PreCompact all use msd-context-monitor', () => {
|
||
for (const event of ['SubagentStop', 'Stop', 'PreCompact']) {
|
||
const cmds = hooksForEvent(settings, event);
|
||
assert.ok(
|
||
cmds.some(c => c.includes('msd-context-monitor')),
|
||
`Event ${event} should use msd-context-monitor; got commands: ${JSON.stringify(cmds)}`
|
||
);
|
||
}
|
||
});
|
||
});
|
||
|
||
// ─── Suite 2: Claude — FileChanged hook for config hot-reload ─────────────────
|
||
|
||
describe('enh-770: Claude install registers FileChanged hook for .planning/config.json', () => {
|
||
let tmpDir;
|
||
let previousCwd;
|
||
let settings;
|
||
|
||
beforeEach(() => {
|
||
tmpDir = createTempDir('msd-770-filechanged-');
|
||
previousCwd = process.cwd();
|
||
process.chdir(tmpDir);
|
||
stubHooksIntoTarget(path.join(tmpDir, '.claude'));
|
||
|
||
const result = install(false, 'claude', { installerMigrations: [] });
|
||
settings = result && result.settings;
|
||
});
|
||
|
||
afterEach(() => {
|
||
process.chdir(previousCwd);
|
||
cleanup(tmpDir);
|
||
});
|
||
|
||
test('FileChanged event is registered with at least one hook', () => {
|
||
const cmds = hooksForEvent(settings, 'FileChanged');
|
||
assert.ok(cmds.length > 0,
|
||
`Expected FileChanged hooks; got hooks: ${JSON.stringify(settings && settings.hooks)}`);
|
||
});
|
||
|
||
test('FileChanged hook uses msd-config-reload', () => {
|
||
const cmds = hooksForEvent(settings, 'FileChanged');
|
||
assert.ok(
|
||
cmds.some(c => c.includes('msd-config-reload')),
|
||
`FileChanged should use msd-config-reload; got commands: ${JSON.stringify(cmds)}`
|
||
);
|
||
});
|
||
|
||
test('FileChanged hook has a matcher targeting .planning/config.json', () => {
|
||
const matchers = matchersForEvent(settings, 'FileChanged');
|
||
assert.ok(
|
||
matchers.some(m => m && m.includes('config.json')),
|
||
`FileChanged matcher should target config.json; got matchers: ${JSON.stringify(matchers)}`
|
||
);
|
||
});
|
||
});
|
||
|
||
// ─── Suite 3: Idempotency ─────────────────────────────────────────────────────
|
||
|
||
describe('enh-770: Claude install is idempotent for the new hook events', () => {
|
||
let tmpDir;
|
||
let previousCwd;
|
||
|
||
beforeEach(() => {
|
||
tmpDir = createTempDir('msd-770-idem-');
|
||
previousCwd = process.cwd();
|
||
process.chdir(tmpDir);
|
||
stubHooksIntoTarget(path.join(tmpDir, '.claude'));
|
||
});
|
||
|
||
afterEach(() => {
|
||
process.chdir(previousCwd);
|
||
cleanup(tmpDir);
|
||
});
|
||
|
||
test('re-running after persisted first install does not duplicate context monitor hooks', () => {
|
||
const result1 = install(false, 'claude', { installerMigrations: [] });
|
||
persistSettings(result1.settingsPath, result1.settings);
|
||
|
||
process.chdir(tmpDir);
|
||
const result2 = install(false, 'claude', { installerMigrations: [] });
|
||
const s2 = result2.settings;
|
||
|
||
for (const event of ['SubagentStop', 'Stop', 'PreCompact']) {
|
||
const cmds = hooksForEvent(s2, event);
|
||
assert.strictEqual(cmds.length, 1,
|
||
`Event ${event} should have exactly 1 hook after idempotent reinstall; got ${cmds.length}: ${JSON.stringify(cmds)}`);
|
||
}
|
||
});
|
||
|
||
test('re-running after persisted first install does not duplicate FileChanged hook', () => {
|
||
const result1 = install(false, 'claude', { installerMigrations: [] });
|
||
persistSettings(result1.settingsPath, result1.settings);
|
||
|
||
process.chdir(tmpDir);
|
||
const result2 = install(false, 'claude', { installerMigrations: [] });
|
||
const s2 = result2.settings;
|
||
|
||
const cmds = hooksForEvent(s2, 'FileChanged');
|
||
assert.strictEqual(cmds.length, 1,
|
||
`FileChanged should have exactly 1 hook after idempotent reinstall; got ${cmds.length}: ${JSON.stringify(cmds)}`);
|
||
});
|
||
});
|
||
|
||
// ─── Suite 4: Uninstall removes registrations ─────────────────────────────────
|
||
|
||
describe('enh-770: Uninstall removes new hook event entries', () => {
|
||
let tmpDir;
|
||
let previousCwd;
|
||
|
||
beforeEach(() => {
|
||
tmpDir = createTempDir('msd-770-uninstall-');
|
||
previousCwd = process.cwd();
|
||
process.chdir(tmpDir);
|
||
stubHooksIntoTarget(path.join(tmpDir, '.claude'));
|
||
|
||
const result = install(false, 'claude', { installerMigrations: [] });
|
||
persistSettings(result.settingsPath, result.settings);
|
||
});
|
||
|
||
afterEach(() => {
|
||
process.chdir(previousCwd);
|
||
cleanup(tmpDir);
|
||
});
|
||
|
||
test('settings.json hook entries are removed on uninstall', () => {
|
||
uninstall(false, 'claude', { installerMigrations: [] });
|
||
const settingsPath = path.join(tmpDir, '.claude', 'settings.json');
|
||
if (!fs.existsSync(settingsPath)) return; // file removed entirely is fine
|
||
const settings = JSON.parse(fs.readFileSync(settingsPath, 'utf8'));
|
||
for (const event of ['SubagentStop', 'Stop', 'PreCompact', 'FileChanged']) {
|
||
const cmds = hooksForEvent(settings, event);
|
||
assert.strictEqual(cmds.length, 0,
|
||
`After uninstall, ${event} should have 0 hooks; got: ${JSON.stringify(cmds)}`);
|
||
}
|
||
});
|
||
});
|
||
|
||
// ─── Suite 5: msd-config-reload.js hook script exists and has correct shape ───
|
||
|
||
describe('enh-770: msd-config-reload.js hook script', () => {
|
||
const reloadScript = path.join(__dirname, '..', 'hooks', 'msd-config-reload.js');
|
||
|
||
test('msd-config-reload.js exists in hooks/', () => {
|
||
assert.ok(fs.existsSync(reloadScript),
|
||
`msd-config-reload.js must exist at ${reloadScript}`);
|
||
});
|
||
|
||
test('msd-config-reload.js contains the msd-hook-version stamp', () => {
|
||
// allow-test-rule: source-text-is-the-product — the stamp template token (see #770)
|
||
// IS the product surface that the installer must find and replace with the
|
||
// real version at copy time; asserting its presence is required.
|
||
const content = fs.readFileSync(reloadScript, 'utf8');
|
||
assert.ok(
|
||
content.includes('msd-hook-version'),
|
||
'msd-config-reload.js must contain the msd-hook-version stamp for installer stamping'
|
||
);
|
||
});
|
||
|
||
test('msd-config-reload.js reads from stdin and emits JSON output', () => {
|
||
// allow-test-rule: source-text-is-the-product — the stdin-read and (see #770)
|
||
// JSON-emit pattern IS the hook contract; asserting its presence is required.
|
||
const content = fs.readFileSync(reloadScript, 'utf8');
|
||
assert.ok(
|
||
content.includes('process.stdin') && content.includes('JSON.stringify'),
|
||
'msd-config-reload.js must read stdin and emit JSON output per hook protocol'
|
||
);
|
||
});
|
||
|
||
test('msd-config-reload.js targets the FileChanged hook event', () => {
|
||
// allow-test-rule: source-text-is-the-product — the hookEventName is (see #770)
|
||
// the protocol surface; asserting its presence verifies the contract.
|
||
const content = fs.readFileSync(reloadScript, 'utf8');
|
||
assert.ok(
|
||
content.includes('FileChanged'),
|
||
'msd-config-reload.js must reference FileChanged in its hookSpecificOutput'
|
||
);
|
||
});
|
||
});
|
||
|
||
// ─── Suite 6: hooks.json plugin manifest includes new events ──────────────────
|
||
|
||
describe('enh-770: hooks/hooks.json plugin manifest includes new hook events', () => {
|
||
const hooksJsonPath = path.join(__dirname, '..', 'hooks', 'hooks.json');
|
||
|
||
test('hooks.json exists', () => {
|
||
assert.ok(fs.existsSync(hooksJsonPath), `hooks.json must exist at ${hooksJsonPath}`);
|
||
});
|
||
|
||
test('hooks.json contains SubagentStop event', () => {
|
||
// allow-test-rule: source-text-is-the-product — hooks.json IS the (see #770)
|
||
// plugin manifest surface that Claude Code reads at plugin load time.
|
||
const content = JSON.parse(fs.readFileSync(hooksJsonPath, 'utf8'));
|
||
assert.ok(
|
||
content.hooks && content.hooks.SubagentStop,
|
||
'hooks.json must contain SubagentStop'
|
||
);
|
||
});
|
||
|
||
test('hooks.json contains Stop event', () => {
|
||
// allow-test-rule: source-text-is-the-product — hooks.json IS the (see #770)
|
||
// plugin manifest surface that Claude Code reads at plugin load time.
|
||
const content = JSON.parse(fs.readFileSync(hooksJsonPath, 'utf8'));
|
||
assert.ok(
|
||
content.hooks && content.hooks.Stop,
|
||
'hooks.json must contain Stop'
|
||
);
|
||
});
|
||
|
||
test('hooks.json contains PreCompact event', () => {
|
||
// allow-test-rule: source-text-is-the-product — hooks.json IS the (see #770)
|
||
// plugin manifest surface that Claude Code reads at plugin load time.
|
||
const content = JSON.parse(fs.readFileSync(hooksJsonPath, 'utf8'));
|
||
assert.ok(
|
||
content.hooks && content.hooks.PreCompact,
|
||
'hooks.json must contain PreCompact'
|
||
);
|
||
});
|
||
|
||
test('hooks.json contains FileChanged event', () => {
|
||
// allow-test-rule: source-text-is-the-product — hooks.json IS the (see #770)
|
||
// plugin manifest surface that Claude Code reads at plugin load time.
|
||
const content = JSON.parse(fs.readFileSync(hooksJsonPath, 'utf8'));
|
||
assert.ok(
|
||
content.hooks && content.hooks.FileChanged,
|
||
'hooks.json must contain FileChanged'
|
||
);
|
||
});
|
||
});
|
||
|
||
// ─── Suite 7: managed-hooks-registry includes msd-config-reload.js ───────────
|
||
|
||
describe('enh-770: managed-hooks-registry includes msd-config-reload.js', () => {
|
||
test('MANAGED_HOOKS array includes msd-config-reload.js', () => {
|
||
const { MANAGED_HOOKS } = require('../hooks/managed-hooks-registry.cjs');
|
||
assert.ok(
|
||
MANAGED_HOOKS.includes('msd-config-reload.js'),
|
||
`MANAGED_HOOKS must include msd-config-reload.js; got: ${JSON.stringify(MANAGED_HOOKS)}`
|
||
);
|
||
});
|
||
});
|
||
});
|
||
}
|
||
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
// Folded from tests/bug-1834-sh-hooks-installed.test.cjs — consolidation epic #1969 (B6 #1975)
|
||
// ────────────────────────────────────────────────────────────────────────
|
||
{
|
||
const { describe: __foldDescribe } = require('node:test');
|
||
__foldDescribe("folded:bug-1834-sh-hooks-installed (consolidation epic #1969 B6 #1975)", () => {
|
||
// Consolidation #1969: this block spawns a REAL install and asserts side effects.
|
||
// The host suite sets MSD_TEST_MODE=1 at collection time, which the install child
|
||
// inherits via process.env and which suppresses hook/skill writes. Clear it for
|
||
// this block's duration (standalone had it unset); restore after.
|
||
const { before: __gtmBefore, after: __gtmAfter } = require('node:test');
|
||
let __savedMsdTestMode;
|
||
__gtmBefore(() => { __savedMsdTestMode = process.env.MSD_TEST_MODE; delete process.env.MSD_TEST_MODE; });
|
||
__gtmAfter(() => { if (__savedMsdTestMode === undefined) delete process.env.MSD_TEST_MODE; else process.env.MSD_TEST_MODE = __savedMsdTestMode; });
|
||
/**
|
||
* Regression tests for bug #1834
|
||
*
|
||
* The installer must copy all three .sh hook files to the target hooks/
|
||
* directory during installation. In v1.32.0, only .js hooks were deployed
|
||
* because the install loop did not handle non-.js files from hooks/dist/.
|
||
*
|
||
* This test runs the actual installer (not a simulation) and verifies that
|
||
* msd-session-state.sh, msd-validate-commit.sh, and msd-phase-boundary.sh
|
||
* are present and executable in the target hooks directory.
|
||
*
|
||
* Distinct from:
|
||
* #1656 — .sh files missing from build-hooks.js HOOKS_TO_COPY
|
||
* #1817 — settings.json registration ran even when .sh files were absent
|
||
*/
|
||
|
||
'use strict';
|
||
|
||
const { describe, test, before, beforeEach, afterEach } = require('node:test');
|
||
const assert = require('node:assert/strict');
|
||
const fs = require('fs');
|
||
const path = require('path');
|
||
const os = require('os');
|
||
const { runNode } = require('./helpers/process-seam.cjs');
|
||
const { throwIfFailed } = require('./helpers/git-fixture.cjs');
|
||
|
||
const INSTALL_SCRIPT = path.join(__dirname, '..', 'bin', 'install.js');
|
||
const BUILD_SCRIPT = path.join(__dirname, '..', 'scripts', 'build-hooks.js');
|
||
const isWindows = process.platform === 'win32';
|
||
|
||
// #3145: class-norm timeout, not a per-suite value — see helpers/timeouts.cjs.
|
||
const { BUILD_TIMEOUT_MS: BUILD_HOOKS_TIMEOUT_MS } = require('./helpers/timeouts.cjs');
|
||
|
||
const SH_HOOKS = [
|
||
'msd-session-state.sh',
|
||
'msd-validate-commit.sh',
|
||
'msd-phase-boundary.sh',
|
||
];
|
||
|
||
// ─── Ensure hooks/dist/ is populated before any install test ────────────────
|
||
|
||
before(() => {
|
||
throwIfFailed(runNode([BUILD_SCRIPT], { timeoutMs: BUILD_HOOKS_TIMEOUT_MS }), `node ${BUILD_SCRIPT}`);
|
||
});
|
||
|
||
// ─── Helpers ─────────────────────────────────────────────────────────────────
|
||
|
||
function createTempDir(prefix) {
|
||
return fs.mkdtempSync(path.join(os.tmpdir(), prefix));
|
||
}
|
||
|
||
function cleanup(dir) {
|
||
// eslint-disable-next-line local/no-raw-rmsync-in-tests -- local cleanup wrapper; try/catch swallows ENOENT so runInstaller teardown never fails the test
|
||
try { fs.rmSync(dir, { recursive: true, force: true }); } catch { /* ignore */ }
|
||
}
|
||
|
||
/**
|
||
* Run the installer targeting a temp directory.
|
||
* Uses CLAUDE_CONFIG_DIR to redirect the global install target.
|
||
* Returns the path to the installed hooks directory.
|
||
*/
|
||
function runInstaller(configDir) {
|
||
// --no-sdk: this test covers hook deployment only; skip SDK build to avoid
|
||
// flakiness and keep the test fast (SDK install path has dedicated coverage
|
||
// in install-smoke.yml).
|
||
throwIfFailed(
|
||
runNode([INSTALL_SCRIPT, '--claude', '--global', '--yes', '--no-sdk'], {
|
||
timeoutMs: INSTALL_TIMEOUT_MS,
|
||
env: {
|
||
...process.env,
|
||
CLAUDE_CONFIG_DIR: configDir,
|
||
},
|
||
}),
|
||
`node ${INSTALL_SCRIPT} --claude --global --yes --no-sdk`,
|
||
);
|
||
return path.join(configDir, 'hooks');
|
||
}
|
||
|
||
// ─────────────────────────────────────────────────────────────────────────────
|
||
// 1. End-to-end install: .sh hooks are deployed
|
||
// ─────────────────────────────────────────────────────────────────────────────
|
||
|
||
describe('#1834: installer deploys .sh hooks alongside .js hooks', () => {
|
||
let tmpDir;
|
||
|
||
beforeEach(() => {
|
||
tmpDir = createTempDir('msd-install-1834-');
|
||
});
|
||
|
||
afterEach(() => {
|
||
cleanup(tmpDir);
|
||
});
|
||
|
||
test('msd-session-state.sh, msd-validate-commit.sh, msd-phase-boundary.sh, and all SH_HOOKS are present after install', () => {
|
||
const hooksDir = runInstaller(tmpDir);
|
||
|
||
const sessionStateTarget = path.join(hooksDir, 'msd-session-state.sh');
|
||
assert.ok(
|
||
fs.existsSync(sessionStateTarget),
|
||
'msd-session-state.sh must be installed to hooks/ — missing file causes SessionStart hook errors'
|
||
);
|
||
|
||
const validateCommitTarget = path.join(hooksDir, 'msd-validate-commit.sh');
|
||
assert.ok(
|
||
fs.existsSync(validateCommitTarget),
|
||
'msd-validate-commit.sh must be installed to hooks/ — missing file causes PreToolUse hook errors'
|
||
);
|
||
|
||
const phaseBoundaryTarget = path.join(hooksDir, 'msd-phase-boundary.sh');
|
||
assert.ok(
|
||
fs.existsSync(phaseBoundaryTarget),
|
||
'msd-phase-boundary.sh must be installed to hooks/ — missing file causes PostToolUse hook errors'
|
||
);
|
||
|
||
for (const hook of SH_HOOKS) {
|
||
assert.ok(
|
||
fs.existsSync(path.join(hooksDir, hook)),
|
||
`${hook} must be present in hooks/ after install`
|
||
);
|
||
}
|
||
});
|
||
|
||
test('.sh hooks are executable after install', {
|
||
skip: isWindows ? 'Windows does not support POSIX file permissions' : false,
|
||
}, () => {
|
||
const hooksDir = runInstaller(tmpDir);
|
||
for (const hook of SH_HOOKS) {
|
||
const stat = fs.statSync(path.join(hooksDir, hook));
|
||
assert.ok(
|
||
(stat.mode & 0o111) !== 0,
|
||
`${hook} must be executable (chmod +x) after install — missing +x causes hook invocation failures`
|
||
);
|
||
}
|
||
});
|
||
});
|
||
});
|
||
}
|
||
|
||
// ─── #4087 / #4098: the Codex hook bundle must ship the helpers it requires ───
|
||
//
|
||
// CODEX_HOOKS_TO_COPY is a flat, hand-maintained filename allowlist that never
|
||
// recursed, and Codex is excluded from installSharedHooksBundle (the path that
|
||
// stages hooks/lib/ for full-bundle runtimes). Excluding hooks/lib/ was a
|
||
// correct, scoped decision for #3579 — until #3911 (2ea5efc15) gave
|
||
// msd-context-monitor.js a real `require('./lib/hook-exit.js')`. From then on a
|
||
// fresh --codex install staged the hook without its helper, and the hook died
|
||
// with MODULE_NOT_FOUND at module load — before its own try/catch — on every
|
||
// event Codex registers it for. The install still exited 0, so nothing surfaced
|
||
// it but the user's own broken session.
|
||
//
|
||
// These rows drive the REAL installer into a sandboxed config dir and then
|
||
// EXECUTE the installed hook. Asserting the files exist is not enough: the
|
||
// failure is at load, and a require chain one level deeper than the assertion
|
||
// looks identical to success on a file listing.
|
||
describe('#4087 regression: Codex install stages the hook helpers its hooks require', () => {
|
||
// These rows spawn a REAL install. The host suite sets MSD_TEST_MODE=1 at
|
||
// collection time, which the child inherits and which gates bin/install.js's
|
||
// whole main() block — the install then writes nothing at all and every
|
||
// assertion below fails on an absent hooks/ dir rather than on the defect.
|
||
// Same clear-and-restore the folded #1834 block uses for the same reason.
|
||
const { before: __gtmBefore, after: __gtmAfter } = require('node:test');
|
||
let __savedMsdTestMode;
|
||
__gtmBefore(() => { __savedMsdTestMode = process.env.MSD_TEST_MODE; delete process.env.MSD_TEST_MODE; });
|
||
__gtmAfter(() => { if (__savedMsdTestMode === undefined) delete process.env.MSD_TEST_MODE; else process.env.MSD_TEST_MODE = __savedMsdTestMode; });
|
||
|
||
let tmpDir;
|
||
|
||
beforeEach(() => {
|
||
tmpDir = createTempDir('msd-install-4087-');
|
||
});
|
||
|
||
afterEach(() => {
|
||
cleanup(tmpDir);
|
||
});
|
||
|
||
function installCodex(configDir) {
|
||
// HOME/USERPROFILE must be sandboxed for the CHILD, not just --config-dir.
|
||
// Codex's "skills" kind declares a global `home` override, so it resolves
|
||
// from os.homedir() rather than the configDir — and install/uninstall PRUNE
|
||
// MSD entries there. Without this the #3712 real-home guard refuses the call
|
||
// outright (correctly: it would otherwise write into and prune the
|
||
// developer's real ~/.agents/skills). sandboxHome() from helpers covers
|
||
// IN-PROCESS calls; this install is spawned, so the sandbox goes in the
|
||
// child's env.
|
||
throwIfFailed(
|
||
runNode([INSTALL_SCRIPT, '--codex', '--global', '--yes', '--no-sdk', '--config-dir', configDir], {
|
||
timeoutMs: INSTALL_TIMEOUT_MS,
|
||
env: { ...process.env, HOME: configDir, USERPROFILE: configDir },
|
||
}),
|
||
`node ${INSTALL_SCRIPT} --codex --global --config-dir ${configDir}`,
|
||
);
|
||
return path.join(configDir, 'hooks');
|
||
}
|
||
|
||
test('#2586: no longer staged, dependency closure empty, staged set equals closure', () => {
|
||
// Was: "the installed context-monitor hook LOADS AND RUNS, not merely
|
||
// exists" — that row's premise (Codex ships this hook) is exactly what
|
||
// #2586 removes: its only documented metrics source is Claude's own
|
||
// statusline hook, which Codex never installs, so every registered Codex
|
||
// event was a guaranteed silent no-op. The #4087 bug class this describe
|
||
// block guards (a staged hook requiring an unshipped hooks/lib/ helper)
|
||
// remains covered by the grammar-level rows below.
|
||
const hooksDir = installCodex(tmpDir);
|
||
const libDir = path.join(hooksDir, 'lib');
|
||
|
||
assert.strictEqual(fs.existsSync(path.join(hooksDir, 'msd-context-monitor.js')), false,
|
||
'msd-context-monitor.js must not be staged for Codex post-#2586');
|
||
assert.strictEqual(fs.existsSync(libDir), false,
|
||
'hooks/lib/ must not exist at all — nothing else Codex stages requires a lib/ helper');
|
||
|
||
// AC4: this proves the requirement graph derived from the SHIPPED files
|
||
// rather than restating today's helpers, so a Codex-bundled hook that
|
||
// grows a new lib dependency fails here instead of in a user's session.
|
||
//
|
||
// Seed from hook scripts: only the explicit './lib/X' spelling is a lib
|
||
// requirement. A bare './X' from a hook script is a sibling in hooks/
|
||
// (msd-check-update-worker.js requires './managed-hooks-registry.cjs'),
|
||
// which is NOT under lib/ — conflating the two demands the wrong file.
|
||
const seedRe = /require\(\s*['"]\.\/lib\/([A-Za-z0-9._-]+)['"]\s*\)/g;
|
||
// From inside lib/, a sibling is already local, so './X' IS a lib require.
|
||
const libRe = /require\(\s*['"]\.\/(?:lib\/)?([A-Za-z0-9._-]+)['"]\s*\)/g;
|
||
|
||
const required = new Set();
|
||
const scan = (source, re) => {
|
||
re.lastIndex = 0;
|
||
let m;
|
||
while ((m = re.exec(source)) !== null) required.add(m[1]);
|
||
};
|
||
|
||
for (const entry of fs.readdirSync(hooksDir)) {
|
||
const full = path.join(hooksDir, entry);
|
||
if (!fs.statSync(full).isFile()) continue;
|
||
if (!/\.(js|cjs)$/.test(entry)) continue;
|
||
scan(fs.readFileSync(full, 'utf8'), seedRe);
|
||
}
|
||
// #2586: msd-context-monitor.js was the only staged Codex hook requiring
|
||
// a ./lib/ helper; it is no longer staged for Codex at all, so the
|
||
// dependency closure is correctly empty. This row still proves the
|
||
// GRAMMAR holds (whatever IS required must be staged) — it is just that
|
||
// "whatever is required" is now the empty set for Codex specifically.
|
||
// The non-trivial case (closure size > 0) is covered by the grammar-level
|
||
// rows below.
|
||
assert.strictEqual(required.size, 0,
|
||
'no staged Codex hook should require a ./lib/ helper post-#2586 — if this becomes non-zero, '
|
||
+ 'extend this row (do not just raise the bar back to ">0") so the new dependency stays proven');
|
||
assert.strictEqual(fs.existsSync(libDir), false, 'hooks/lib/ must not exist when nothing requires it');
|
||
|
||
// Walk to a fixed point, exactly as the installer must.
|
||
const checked = new Set();
|
||
let next = [...required].find((f) => !checked.has(f));
|
||
while (next !== undefined) {
|
||
checked.add(next);
|
||
const staged = path.join(libDir, next);
|
||
assert.ok(
|
||
fs.existsSync(staged),
|
||
`hooks/lib/${next} is required (directly or transitively) by a staged Codex hook but was `
|
||
+ 'not installed. A Codex-bundled hook gained a helper the installer does not stage — the '
|
||
+ 'hook will throw MODULE_NOT_FOUND at load on every event (#4087, #4098).',
|
||
);
|
||
scan(fs.readFileSync(staged, 'utf8'), libRe);
|
||
next = [...required].find((f) => !checked.has(f));
|
||
}
|
||
|
||
// Was: "fewer staged than available, and graphify absent". That passes while
|
||
// over-staging (an extra git-cmd.js keeps the count below the total and
|
||
// leaves graphify absent), so it did not prove its own title — the #3579
|
||
// boundary is that helpers nothing requires must NOT ship (review of #4087).
|
||
// Now compared as SETS, with the difference asserted in both directions.
|
||
const stagedLibs = fs.existsSync(libDir) ? fs.readdirSync(libDir).sort() : [];
|
||
// #2586: Codex's closure is now legitimately empty (msd-context-monitor.js,
|
||
// the only staged Codex hook that ever required a helper, is no longer
|
||
// staged) — the deepStrictEqual below is still the real assertion and
|
||
// holds for the empty case too; the non-empty case remains covered by the
|
||
// grammar-level rows below.
|
||
assert.strictEqual(stagedLibs.length, 0, 'no helpers should be staged for Codex post-#2586');
|
||
|
||
// Derive the closure independently of the installer.
|
||
const seedRe3 = /require\(\s*['"]\.\/lib\/([A-Za-z0-9._-]+)['"]\s*\)/g;
|
||
const libRe3 = /require\(\s*['"]\.\/(?:lib\/)?([A-Za-z0-9._-]+)['"]\s*\)/g;
|
||
const srcLibDir = path.join(__dirname, '..', 'hooks', 'lib');
|
||
const required3 = new Set();
|
||
const scan3 = (source, re) => {
|
||
re.lastIndex = 0;
|
||
let m;
|
||
while ((m = re.exec(source)) !== null) {
|
||
if (/[A-Za-z0-9]/.test(m[1])) required3.add(m[1]);
|
||
}
|
||
};
|
||
const resolveName = (name) => [name, `${name}.js`, `${name}.cjs`]
|
||
.find((c) => fs.existsSync(path.join(srcLibDir, c)));
|
||
|
||
for (const entry of fs.readdirSync(hooksDir)) {
|
||
const full = path.join(hooksDir, entry);
|
||
if (!fs.statSync(full).isFile() || !/\.(js|cjs)$/.test(entry)) continue;
|
||
scan3(fs.readFileSync(full, 'utf8'), seedRe3);
|
||
}
|
||
const closure3 = new Set();
|
||
let next3 = [...required3].find((f) => !closure3.has(resolveName(f) || f));
|
||
while (next3 !== undefined) {
|
||
const resolved = resolveName(next3);
|
||
assert.ok(resolved, `hooks/lib/${next3} is required but absent from source — packaging bug`);
|
||
closure3.add(resolved);
|
||
scan3(fs.readFileSync(path.join(srcLibDir, resolved), 'utf8'), libRe3);
|
||
next3 = [...required3].find((f) => !closure3.has(resolveName(f) || f));
|
||
}
|
||
|
||
const expected3 = [...closure3].sort();
|
||
assert.deepStrictEqual(
|
||
stagedLibs, expected3,
|
||
'the staged helper set must equal the dependency closure exactly. Extra files violate the '
|
||
+ '#3579 boundary (helpers no Codex hook requires must not ship); missing files mean a hook '
|
||
+ `throws MODULE_NOT_FOUND at load. staged=${JSON.stringify(stagedLibs)} `
|
||
+ `expected=${JSON.stringify(expected3)}`,
|
||
);
|
||
// Non-vacuity: the source dir must hold MORE than the closure, or an
|
||
// over-staging bug would be undetectable by this comparison.
|
||
const available3 = fs.readdirSync(srcLibDir);
|
||
assert.ok(
|
||
available3.length > expected3.length,
|
||
`precondition: source must offer more helpers than the closure needs (available=${available3.length}, closure=${expected3.length})`,
|
||
);
|
||
});
|
||
|
||
// The #3579 boundary this fix must preserve: derive what is needed, do not
|
||
// dump the whole helper directory into the reduced bundle.
|
||
// ─── the grammar itself, unit-level (review of #4087) ───
|
||
//
|
||
// The install rows above prove today's three-helper chain. These pin the
|
||
// DISCOVERY GRAMMAR directly, which is what has to hold for the
|
||
// "future dependencies cannot silently regress" claim to mean anything.
|
||
describe('stageTransitiveHookLibs discovery grammar', () => {
|
||
const { stageTransitiveHookLibs } = require('../msd-core/bin/lib/runtime-hooks-surface.cjs');
|
||
let dir;
|
||
|
||
beforeEach(() => { dir = createTempDir('msd-stage-libs-'); });
|
||
afterEach(() => { cleanup(dir); });
|
||
|
||
function fixture(libFiles) {
|
||
const srcLibDir = path.join(dir, 'src', 'lib');
|
||
const destLibDir = path.join(dir, 'dest', 'lib');
|
||
fs.mkdirSync(srcLibDir, { recursive: true });
|
||
for (const [name, content] of Object.entries(libFiles)) {
|
||
fs.writeFileSync(path.join(srcLibDir, name), content);
|
||
}
|
||
return { srcLibDir, destLibDir };
|
||
}
|
||
|
||
test('an EXTENSIONLESS require resolves — valid CommonJS, was failing the install', () => {
|
||
const { srcLibDir, destLibDir } = fixture({ 'helper.js': '// no requires\n' });
|
||
const staged = stageTransitiveHookLibs({
|
||
seedSources: ["require('./lib/helper')"],
|
||
srcLibDir, destLibDir, runtimeLabel: 'Test',
|
||
});
|
||
assert.deepStrictEqual(staged, ['helper.js'],
|
||
"require('./lib/helper') must resolve to helper.js — matching only the extension-bearing "
|
||
+ 'spelling resolved "helper" literally and failed the install on a legitimate require');
|
||
assert.ok(fs.existsSync(path.join(destLibDir, 'helper.js')),
|
||
'and it must land under its RESOLVED name, or Node cannot resolve it at the destination');
|
||
});
|
||
|
||
test('a NESTED lib require is refused LOUDLY, never silently skipped', () => {
|
||
const { srcLibDir, destLibDir } = fixture({ 'helper.js': '' });
|
||
assert.throws(
|
||
() => stageTransitiveHookLibs({
|
||
seedSources: ["require('./lib/sub/helper.js')"],
|
||
srcLibDir, destLibDir, runtimeLabel: 'Test',
|
||
}),
|
||
/NESTED hooks\/lib path/,
|
||
'hooks/lib/ is flat and the scan cannot express a nested path, so a nested require would '
|
||
+ 'stage nothing and ship a hook that dies at load — it must fail the install instead',
|
||
);
|
||
});
|
||
|
||
test('prose that merely LOOKS like a require does not become a dependency', () => {
|
||
// hooks/lib/injection-patterns.js's own header documents this mechanism
|
||
// with the literal string require('./lib/...'), which captured `...` and
|
||
// sent the resolver hunting for hooks/lib/... — failing the install on a
|
||
// comment. Measured before the fix.
|
||
const { srcLibDir, destLibDir } = fixture({ 'helper.js': '' });
|
||
const staged = stageTransitiveHookLibs({
|
||
seedSources: ["/* the stager auto-discovers require('./lib/...') in staged scripts */"],
|
||
srcLibDir, destLibDir, runtimeLabel: 'Test',
|
||
});
|
||
assert.deepStrictEqual(staged, [],
|
||
'a capture with no alphanumeric character is prose, not a module name');
|
||
});
|
||
|
||
test('a genuinely missing helper still fails loudly (the guard must not be softened)', () => {
|
||
const { srcLibDir, destLibDir } = fixture({ 'other.js': '' });
|
||
assert.throws(
|
||
() => stageTransitiveHookLibs({
|
||
seedSources: ["require('./lib/absent.js')"],
|
||
srcLibDir, destLibDir, runtimeLabel: 'Test',
|
||
}),
|
||
/absent\.js is required by a staged Test hook/,
|
||
'the extension-fallback must not turn a real missing helper into a silent skip',
|
||
);
|
||
});
|
||
});
|
||
});
|
||
|
||
// ─── #3981: blocking PreToolUse guards must not fail open on a host stall ────
|
||
|
||
describe('bug #3981: blocking-guard timeout budget + migration', () => {
|
||
let targetDir;
|
||
beforeEach(() => { targetDir = createTempDir('msd-3981-'); });
|
||
afterEach(() => { cleanup(targetDir); });
|
||
|
||
// Local to this describe: the #1754 helpers above are scoped to their own
|
||
// describe, so re-require the seam and rebuild the runner here.
|
||
const { applySettingsJsonHooks } = require('../msd-core/bin/lib/runtime-hooks-surface.cjs');
|
||
const { captureConsole } = require('./helpers.cjs');
|
||
function runApplySettingsJsonHooks(dir, presentHooks) {
|
||
fs.mkdirSync(path.join(dir, 'hooks'), { recursive: true });
|
||
for (const hook of presentHooks) {
|
||
fs.writeFileSync(path.join(dir, 'hooks', hook), '// stub\n');
|
||
}
|
||
const settings = {};
|
||
const localCmd = (hookFile) => `node ${path.join(dir, 'hooks', hookFile)}`;
|
||
const localShellCmd = (hookFile) => `bash ${path.join(dir, 'hooks', hookFile)}`;
|
||
captureConsole(() => {
|
||
applySettingsJsonHooks(settings, {
|
||
runtime: 'claude',
|
||
isGlobal: false,
|
||
targetDir: dir,
|
||
postToolEvent: 'PostToolUse',
|
||
hookEvents: 'claude',
|
||
extendedHookEvents: [],
|
||
hooksSurface: 'settings-json',
|
||
updateCheckCommand: localCmd('msd-check-update.js'),
|
||
contextMonitorCommand: localCmd('msd-context-monitor.js'),
|
||
promptGuardCommand: localCmd('msd-prompt-guard.js'),
|
||
readGuardCommand: localCmd('msd-read-guard.js'),
|
||
readInjectionScannerCommand: localCmd('msd-read-injection-scanner.js'),
|
||
configReloadCommand: null,
|
||
hookOpts: { portableHooks: false, runtime: 'claude' },
|
||
localCmd,
|
||
localShellCmd,
|
||
});
|
||
});
|
||
return { settings };
|
||
}
|
||
|
||
const BLOCKING_GUARDS = [
|
||
'msd-prompt-guard.js',
|
||
'msd-workflow-guard.js',
|
||
'msd-worktree-path-guard.js',
|
||
'msd-agent-isolation-guard.js',
|
||
'msd-write-guard.js',
|
||
'msd-secret-read-guard.js',
|
||
'msd-validate-commit.sh',
|
||
];
|
||
|
||
test('blocking PreToolUse guards register with a host-stall-proof timeout (#3981)', () => {
|
||
const { settings } = runApplySettingsJsonHooks(targetDir, ['msd-prompt-guard.js']);
|
||
const entry = (settings.hooks.PreToolUse || []).find((e) =>
|
||
(e.hooks || []).some((h) => h.command && h.command.includes('msd-prompt-guard.js')));
|
||
assert.ok(entry, 'prompt guard should be registered on a fresh install');
|
||
const h = entry.hooks.find((x) => x.command.includes('msd-prompt-guard.js'));
|
||
assert.equal(h.timeout, 120,
|
||
`Claude Code treats a timed-out hook as non-blocking, so a 5 s budget silently disables the gate under host stalls; expected 120, got ${h.timeout}`);
|
||
});
|
||
|
||
test('managed timeout:5 blocking-guard entries are migrated to 120 (#3981)', () => {
|
||
// Same shape as the context-monitor backfill: raising the source constant
|
||
// alone never reaches an existing settings.json, because registration
|
||
// skips entries whose command is already referenced.
|
||
for (const guard of BLOCKING_GUARDS) {
|
||
const settings = {
|
||
hooks: {
|
||
PreToolUse: [{
|
||
matcher: 'Write|Edit',
|
||
hooks: [{ type: 'command', command: `node ${path.join(targetDir, 'hooks', guard)}`, timeout: FIXTURE_HOOK_TIMEOUT_SECONDS }],
|
||
}],
|
||
},
|
||
};
|
||
const localCmd = (hookFile) => `node ${path.join(targetDir, 'hooks', hookFile)}`;
|
||
captureConsole(() => {
|
||
applySettingsJsonHooks(settings, {
|
||
runtime: 'claude',
|
||
isGlobal: false,
|
||
targetDir,
|
||
postToolEvent: 'PostToolUse',
|
||
hookEvents: 'claude',
|
||
extendedHookEvents: [],
|
||
hooksSurface: 'settings-json',
|
||
updateCheckCommand: null,
|
||
contextMonitorCommand: null,
|
||
promptGuardCommand: null,
|
||
readGuardCommand: null,
|
||
readInjectionScannerCommand: null,
|
||
configReloadCommand: null,
|
||
hookOpts: { portableHooks: false, runtime: 'claude' },
|
||
localCmd,
|
||
localShellCmd: localCmd,
|
||
});
|
||
});
|
||
const h = settings.hooks.PreToolUse[0].hooks[0];
|
||
assert.equal(h.timeout, 120,
|
||
`existing managed ${guard} entry at timeout:5 must be migrated to 120, got ${h.timeout}`);
|
||
}
|
||
});
|
||
|
||
test('non-managed timeout:5 entries are left alone (#3981)', () => {
|
||
const mine = { type: 'command', command: 'node /usr/local/bin/my-own-hook.js', timeout: FIXTURE_HOOK_TIMEOUT_SECONDS };
|
||
const settings = { hooks: { PreToolUse: [{ matcher: 'Write', hooks: [mine] }] } };
|
||
const localCmd = (hookFile) => `node ${path.join(targetDir, 'hooks', hookFile)}`;
|
||
captureConsole(() => {
|
||
applySettingsJsonHooks(settings, {
|
||
runtime: 'claude', isGlobal: false, targetDir,
|
||
postToolEvent: 'PostToolUse', hookEvents: 'claude', extendedHookEvents: [],
|
||
hooksSurface: 'settings-json', updateCheckCommand: null, contextMonitorCommand: null,
|
||
promptGuardCommand: null, readGuardCommand: null, readInjectionScannerCommand: null,
|
||
configReloadCommand: null, hookOpts: { portableHooks: false, runtime: 'claude' },
|
||
localCmd, localShellCmd: localCmd,
|
||
});
|
||
});
|
||
assert.equal(mine.timeout, 5, 'the migration must only touch entries referencing managed MSD guards');
|
||
});
|
||
|
||
test('advisory hook budgets are unchanged (#3981)', () => {
|
||
const { settings } = runApplySettingsJsonHooks(targetDir, ['msd-read-guard.js', 'msd-context-monitor.js']);
|
||
const events = Object.values(settings.hooks).flat();
|
||
const findTimeout = (basename) => {
|
||
for (const entry of events) {
|
||
if (!Array.isArray(entry.hooks)) continue;
|
||
for (const h of entry.hooks) {
|
||
if (h.command && h.command.includes(basename)) return h.timeout;
|
||
}
|
||
}
|
||
return undefined;
|
||
};
|
||
assert.equal(findTimeout('msd-read-guard.js'), 5, 'advisory read guard keeps its 5 s budget');
|
||
assert.equal(findTimeout('msd-context-monitor.js'), 10, 'context monitor keeps its 10 s budget');
|
||
});
|
||
});
|