a9a7a328e6
Mechanical rename produced by scripts/msd-rename.cjs: gsd/Gsd/GSD -> msd/Msd/MSD across contents and paths, upstream package/repo coordinates -> @golem15/msd-core and golem15com/msd-core. Deep links into upstream history, sibling upstream packages, the GSD-2 import feature, CHANGELOG.md and .changeset/ are kept as-is. Hand edits on top: MSD block-letter banner and logos, LICENSE copyright line, package/plugin identity, regenerated lockfile, install-tree fixtures, derived registries and benchmark baseline; migration checksum baseline re-locked (MSD keeps its own install state, so no install had applied the old sums); sort-order and regex-escaped expectations in tests adjusted.
357 lines
15 KiB
JavaScript
357 lines
15 KiB
JavaScript
const { test, describe } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
describe('pause-work improvements', () => {
|
|
let pauseContent;
|
|
|
|
test('pause-work.md exists', () => {
|
|
const p = path.join(__dirname, '..', 'msd-core', 'workflows', 'pause-work.md');
|
|
assert.ok(fs.existsSync(p));
|
|
pauseContent = fs.readFileSync(p, 'utf-8');
|
|
});
|
|
|
|
test('#1489: pause-work detects non-phase contexts (spike, deliberation, research)', () => {
|
|
pauseContent = pauseContent || fs.readFileSync(
|
|
path.join(__dirname, '..', 'msd-core', 'workflows', 'pause-work.md'), 'utf-8'
|
|
);
|
|
assert.ok(pauseContent.includes('spike') || pauseContent.includes('Spike'),
|
|
'pause-work should handle spike context');
|
|
assert.ok(pauseContent.includes('deliberation') || pauseContent.includes('research'),
|
|
'pause-work should handle deliberation/research context');
|
|
});
|
|
|
|
test('#1489: pause-work writes to non-phase paths when appropriate', () => {
|
|
pauseContent = pauseContent || fs.readFileSync(
|
|
path.join(__dirname, '..', 'msd-core', 'workflows', 'pause-work.md'), 'utf-8'
|
|
);
|
|
assert.ok(pauseContent.includes('.planning/.continue-here') ||
|
|
pauseContent.includes('.planning/spikes') ||
|
|
pauseContent.includes('non-phase'),
|
|
'pause-work should write to root .planning/ when not in a phase');
|
|
});
|
|
|
|
test('#1490: continue-here template includes required-reading section', () => {
|
|
pauseContent = pauseContent || fs.readFileSync(
|
|
path.join(__dirname, '..', 'msd-core', 'workflows', 'pause-work.md'), 'utf-8'
|
|
);
|
|
assert.ok(pauseContent.includes('Required Reading') || pauseContent.includes('required-reading'),
|
|
'Template should include Required Reading section');
|
|
});
|
|
|
|
test('#1490: continue-here template includes anti-patterns section', () => {
|
|
pauseContent = pauseContent || fs.readFileSync(
|
|
path.join(__dirname, '..', 'msd-core', 'workflows', 'pause-work.md'), 'utf-8'
|
|
);
|
|
assert.ok(pauseContent.includes('Anti-Pattern') || pauseContent.includes('anti-pattern') ||
|
|
pauseContent.includes('do NOT repeat'),
|
|
'Template should include Anti-Patterns section');
|
|
});
|
|
|
|
test('#1490: continue-here template includes infrastructure-state section', () => {
|
|
pauseContent = pauseContent || fs.readFileSync(
|
|
path.join(__dirname, '..', 'msd-core', 'workflows', 'pause-work.md'), 'utf-8'
|
|
);
|
|
assert.ok(pauseContent.includes('Infrastructure') || pauseContent.includes('infrastructure'),
|
|
'Template should include Infrastructure State section');
|
|
});
|
|
|
|
test('#1487: pause-work documents pre-execution critique gate', () => {
|
|
pauseContent = pauseContent || fs.readFileSync(
|
|
path.join(__dirname, '..', 'msd-core', 'workflows', 'pause-work.md'), 'utf-8'
|
|
);
|
|
assert.ok(
|
|
pauseContent.includes('critique') || pauseContent.includes('design gate') ||
|
|
pauseContent.includes('Pre-Execution'),
|
|
'pause-work should document design critique gate for design→execution transitions'
|
|
);
|
|
});
|
|
});
|
|
|
|
|
|
// ────────────────────────────────────────────────────────────────────────
|
|
// Folded from tests/bug-3446-resume-continue-here-discovery.test.cjs — consolidation epic #1969 (B6 #1975)
|
|
// ────────────────────────────────────────────────────────────────────────
|
|
{
|
|
const { describe: __foldDescribe } = require('node:test');
|
|
__foldDescribe("folded:bug-3446-resume-continue-here-discovery (consolidation epic #1969 B6 #1975)", () => {
|
|
// allow-test-rule: source-text-is-the-product (see #3446)
|
|
// Workflow `.md` files are the runtime contract executed by Claude Code as
|
|
// embedded bash. This test extracts the actual `check_incomplete_work` bash
|
|
// block from resume-project.md and exercises it against a planted directory
|
|
// layout — that's a behavioral integration test of the workflow contract,
|
|
// not regex-on-source.
|
|
|
|
'use strict';
|
|
|
|
const { test, describe, before, after } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const { runHook: runHookSeam } = require('./helpers/process-seam.cjs');
|
|
const { toLegacyResult } = require('./helpers/git-fixture.cjs');
|
|
const { createTempDir, cleanup, readFileNormalized } = require('./helpers.cjs');
|
|
const { scanFencedBlocks } = require('../msd-core/bin/lib/markdown-sectionizer.cjs');
|
|
|
|
const WORKFLOW_PATH = path.join(__dirname, '..', 'msd-core', 'workflows', 'resume-project.md');
|
|
|
|
// Extract the first ```bash``` code block inside the
|
|
// `<step name="check_incomplete_work">` element. That's the snippet the
|
|
// runtime actually executes; it's what we want to validate.
|
|
//
|
|
// readFileNormalized() strips \r\n -> \n before the fence match below runs —
|
|
// the extracted snippet is spawned via spawnSync('bash', ...) in
|
|
// runSnippet(), so an un-normalized read on a Windows checkout would break
|
|
// bash mid-script (DEFECT.TEST-SHELL-PIPELINE-NONPORTABLE, #2650).
|
|
function extractCheckBlock() {
|
|
const md = readFileNormalized(WORKFLOW_PATH);
|
|
const stepStart = md.indexOf('<step name="check_incomplete_work">');
|
|
assert.ok(stepStart >= 0, 'resume-project.md must contain a check_incomplete_work step');
|
|
const stepEnd = md.indexOf('</step>', stepStart);
|
|
assert.ok(
|
|
stepEnd >= 0,
|
|
'check_incomplete_work step must have a closing </step> tag',
|
|
);
|
|
const stepBody = md.slice(stepStart, stepEnd);
|
|
const stepLines = stepBody.split('\n');
|
|
for (const block of scanFencedBlocks(stepLines)) {
|
|
if (block.closeLineIdx === -1) continue;
|
|
const info = (block.infoString || '').trim();
|
|
if (info !== 'bash' && info !== 'sh') continue;
|
|
return stepLines.slice(block.openLineIdx + 1, block.closeLineIdx).join('\n');
|
|
}
|
|
assert.fail('check_incomplete_work step must embed a ```bash code block');
|
|
}
|
|
|
|
function runSnippet(cwd, snippet) {
|
|
// has_interrupted_agent is a downstream-orchestrator variable; default it
|
|
// to "false" so the embedded `if` branch is a no-op during this test.
|
|
return toLegacyResult(runHookSeam('-c', [snippet], {
|
|
interpreter: 'bash',
|
|
cwd,
|
|
env: { ...process.env, has_interrupted_agent: 'false', interrupted_agent_id: '' },
|
|
}));
|
|
}
|
|
|
|
describe('bug #3446: resume-project detects non-phase and legacy continue-here handoffs', () => {
|
|
let tmpDir;
|
|
let snippet;
|
|
|
|
before(() => {
|
|
snippet = extractCheckBlock();
|
|
tmpDir = createTempDir('msd-bug-3446-');
|
|
|
|
// Plant the three discovery surfaces that bug #3446 was originally
|
|
// filed to cover.
|
|
fs.mkdirSync(path.join(tmpDir, '.planning'), { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(tmpDir, '.planning', '.continue-here.md'),
|
|
'---\ncontext: default\n---\nroot-of-.planning handoff\n',
|
|
'utf8',
|
|
);
|
|
|
|
fs.mkdirSync(path.join(tmpDir, '.planning', 'sketches', 'SKETCH-001'), { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(tmpDir, '.planning', 'sketches', 'SKETCH-001', '.continue-here.md'),
|
|
'---\ncontext: sketch\n---\nsketch handoff\n',
|
|
'utf8',
|
|
);
|
|
|
|
fs.writeFileSync(
|
|
path.join(tmpDir, '.continue-here.md'),
|
|
'---\ncontext: legacy\n---\nlegacy repo-root handoff\n',
|
|
'utf8',
|
|
);
|
|
});
|
|
|
|
after(() => {
|
|
cleanup(tmpDir);
|
|
});
|
|
|
|
test('check_incomplete_work surfaces .planning/.continue-here.md (depth 1 under .planning)', () => {
|
|
const result = runSnippet(tmpDir, snippet);
|
|
assert.equal(result.status, 0, `snippet exited ${result.status}; stderr=${result.stderr}`);
|
|
assert.match(
|
|
result.stdout,
|
|
/\.planning\/\.continue-here\.md/,
|
|
`expected .planning/.continue-here.md in stdout; got: ${JSON.stringify(result.stdout)}`,
|
|
);
|
|
});
|
|
|
|
test('check_incomplete_work surfaces .planning/sketches/SKETCH-001/.continue-here.md (depth 3 under .planning)', () => {
|
|
const result = runSnippet(tmpDir, snippet);
|
|
assert.equal(result.status, 0, `snippet exited ${result.status}; stderr=${result.stderr}`);
|
|
assert.match(
|
|
result.stdout,
|
|
/\.planning\/sketches\/SKETCH-001\/\.continue-here\.md/,
|
|
`expected sketch handoff in stdout; got: ${JSON.stringify(result.stdout)}`,
|
|
);
|
|
});
|
|
|
|
test('check_incomplete_work surfaces legacy repo-root .continue-here.md', () => {
|
|
const result = runSnippet(tmpDir, snippet);
|
|
assert.equal(result.status, 0, `snippet exited ${result.status}; stderr=${result.stderr}`);
|
|
assert.match(
|
|
result.stdout,
|
|
/(^|\n)\.\/\.continue-here\.md(\n|$)/,
|
|
`expected legacy ./.continue-here.md in stdout; got: ${JSON.stringify(result.stdout)}`,
|
|
);
|
|
});
|
|
});
|
|
});
|
|
}
|
|
|
|
|
|
// ────────────────────────────────────────────────────────────────────────
|
|
// Folded from tests/bug-3689-resume-glob-nomatch.test.cjs — consolidation epic #1969 (B6 #1975)
|
|
// ────────────────────────────────────────────────────────────────────────
|
|
{
|
|
const { describe: __foldDescribe } = require('node:test');
|
|
__foldDescribe("folded:bug-3689-resume-glob-nomatch (consolidation epic #1969 B6 #1975)", () => {
|
|
// allow-test-rule: source-text-is-the-product (see #3689)
|
|
// Workflow `.md` files are the runtime contract executed by Claude Code as
|
|
// embedded bash. Asserting on the staged text of resume-project.md and on the
|
|
// behavior of the embedded snippet under real shells is a behavioral test of
|
|
// the workflow itself, not source-grep theater.
|
|
|
|
/**
|
|
* Regression for #3689 — /msd-resume-work silently drops
|
|
* `.planning/.continue-here*.md` checkpoints under zsh's default NOMATCH.
|
|
*
|
|
* Root cause: the `check_incomplete_work` step in
|
|
* `msd-core/workflows/resume-project.md` used a chained `ls` with six
|
|
* bare-glob arguments. Under zsh's default `NOMATCH` setopt the first
|
|
* non-matching glob aborts the entire command during word-expansion — every
|
|
* pattern after that point is never evaluated, including the one that holds
|
|
* valid pause checkpoints (`.planning/.continue-here*.md`). `2>/dev/null ||
|
|
* true` only suppresses ls's own stderr / exit code; it has no effect on the
|
|
* shell's pre-exec abort.
|
|
*
|
|
* Fix: replace the chained `ls` with two `find` calls. `find` does not use
|
|
* shell glob expansion, and `find <missing-dir> -maxdepth N -name PATTERN
|
|
* -print 2>/dev/null` tolerates absent directories on both bash and zsh.
|
|
*
|
|
* This test covers:
|
|
* 1. zsh under `-o nomatch`: checkpoint at `.planning/.continue-here-*.md`
|
|
* is listed even when `.planning/spikes`, `.planning/sketches`,
|
|
* `.planning/deliberations` are absent (the common new-project layout).
|
|
* 2. bash default: same behavior.
|
|
* 3. zsh `-o nomatch` with no `.continue-here` files anywhere: exits 0,
|
|
* no output, no error.
|
|
* 4. Text invariant: resume-project.md no longer carries the brittle
|
|
* chained-ls pattern.
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const { describe, test, before, after } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
const { runHook: runHookSeam } = require('./helpers/process-seam.cjs');
|
|
const { toLegacyResult } = require('./helpers/git-fixture.cjs');
|
|
const { createTempDir, cleanup } = require('./helpers.cjs');
|
|
|
|
const REPO_ROOT = path.resolve(__dirname, '..');
|
|
const WORKFLOW_PATH = path.join(REPO_ROOT, 'msd-core', 'workflows', 'resume-project.md');
|
|
|
|
// The exact snippet the workflow now embeds. Keep in sync with
|
|
// resume-project.md `check_incomplete_work` step.
|
|
const FIND_SNIPPET = [
|
|
"find .planning -maxdepth 3 -name '.continue-here*.md' -print 2>/dev/null || true",
|
|
"find . -maxdepth 1 -name '.continue-here*.md' -print 2>/dev/null || true",
|
|
].join('\n');
|
|
|
|
function hasShell(name) {
|
|
const result = toLegacyResult(runHookSeam(name, [], { interpreter: 'which' }));
|
|
return result.status === 0 && result.stdout.trim().length > 0;
|
|
}
|
|
|
|
describe('bug #3689 — resume-project.md continue-here scan under zsh NOMATCH', () => {
|
|
let tmpDir;
|
|
|
|
before(() => {
|
|
tmpDir = createTempDir('msd-bug-3689-');
|
|
// Reproduce the common new-project layout: a `.planning/` with a
|
|
// suffixed continue-here file and *no* spike / sketch / deliberation
|
|
// subdirectories.
|
|
fs.mkdirSync(path.join(tmpDir, '.planning'), { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(tmpDir, '.planning', '.continue-here-AT-1234.md'),
|
|
'---\ncontext: default\n---\nhandoff body\n',
|
|
'utf8',
|
|
);
|
|
});
|
|
|
|
after(() => {
|
|
cleanup(tmpDir);
|
|
});
|
|
|
|
test('zsh -o nomatch lists the .planning/.continue-here-* checkpoint', { skip: !hasShell('zsh') }, () => {
|
|
const result = toLegacyResult(runHookSeam('-o', ['nomatch', '-c', FIND_SNIPPET], {
|
|
interpreter: 'zsh',
|
|
cwd: tmpDir,
|
|
}));
|
|
assert.equal(result.status, 0, `zsh exited ${result.status}; stderr=${result.stderr}`);
|
|
assert.match(
|
|
result.stdout,
|
|
/\.planning\/\.continue-here-AT-1234\.md/,
|
|
`expected checkpoint in stdout, got: ${JSON.stringify(result.stdout)}`,
|
|
);
|
|
});
|
|
|
|
test('bash default lists the .planning/.continue-here-* checkpoint', { skip: !hasShell('bash') }, () => {
|
|
const result = toLegacyResult(runHookSeam('-c', [FIND_SNIPPET], {
|
|
interpreter: 'bash',
|
|
cwd: tmpDir,
|
|
}));
|
|
assert.equal(result.status, 0, `bash exited ${result.status}; stderr=${result.stderr}`);
|
|
assert.match(
|
|
result.stdout,
|
|
/\.planning\/\.continue-here-AT-1234\.md/,
|
|
`expected checkpoint in stdout, got: ${JSON.stringify(result.stdout)}`,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe('bug #3689 — empty workspace exits cleanly', () => {
|
|
let tmpDir;
|
|
|
|
before(() => {
|
|
tmpDir = createTempDir('msd-bug-3689-');
|
|
// No .planning/ at all, no .continue-here files. Pure greenfield.
|
|
});
|
|
|
|
after(() => {
|
|
cleanup(tmpDir);
|
|
});
|
|
|
|
test('zsh -o nomatch with no checkpoints exits 0, empty output', { skip: !hasShell('zsh') }, () => {
|
|
const result = toLegacyResult(runHookSeam('-o', ['nomatch', '-c', FIND_SNIPPET], {
|
|
interpreter: 'zsh',
|
|
cwd: tmpDir,
|
|
}));
|
|
assert.equal(result.status, 0, `zsh exited ${result.status}; stderr=${result.stderr}`);
|
|
assert.equal(result.stdout.trim(), '', `expected no stdout, got: ${JSON.stringify(result.stdout)}`);
|
|
});
|
|
});
|
|
|
|
describe('bug #3689 — workflow text invariant', () => {
|
|
test('resume-project.md no longer chains bare globs through ls', () => {
|
|
const body = fs.readFileSync(WORKFLOW_PATH, 'utf8');
|
|
assert.doesNotMatch(
|
|
body,
|
|
/ls\s+\.planning\/spikes\/\*\/\.continue-here/,
|
|
'resume-project.md still contains the chained `ls .planning/spikes/*/.continue-here*.md` pattern that aborts under zsh NOMATCH; the find-based scan should replace it.',
|
|
);
|
|
assert.match(
|
|
body,
|
|
/find \.planning -maxdepth 3 -name '\.continue-here\*\.md'/,
|
|
'resume-project.md must use the find-based scan introduced by the #3689 fix.',
|
|
);
|
|
});
|
|
});
|
|
});
|
|
}
|