msd-core/tests/runtime-launcher-parity.test.cjs

'use strict';
/**
 * Parity test for bug #373: space-safe msd_run launcher
 *
 * Asserts:
 * (A) No retired MSD_SDK token remains in any workflow .md file.
 * (B) Each workflow .md that uses msd_run contains EXACTLY ONE canonical preamble
 *     (byte-equal to _runtime-launcher.snippet.sh), and it appears before the first
 *     msd_run call. NOT every bash block — exactly one per file (define once, use
 *     across blocks — original footprint).
 * (C) Space-safe behavioral: a RUNTIME_DIR path with spaces in it resolves
 *     and calls msd-tools.cjs correctly (no word-split, no {}).
 * (D) Loud guard behavioral: missing msd-tools.cjs exits non-zero and emits
 *     "not found" to stderr.
 * (E) PATH fallback behavioral: when no local msd-tools.cjs, the elif branch
 *     resolves to the msd_run binary on PATH (#3668).
 * (F) Regression locks: the snippet file contains no /msd-tools substring; and
 *     no line in workflows/do.md matches /\/msd[:-][a-z]/ (dispatcher-parity
 *     scanner must not read the preamble as a slash-command stub).
 * (H) Codex shim fallback: when PATH has no msd_run, $HOME/.codex/msd-core/bin
 *     can satisfy msd_run for Codex shim-only installs.
 */

// allow-test-rule: structural-regression-guard
// structural parity/drift guard — asserts literal presence/absence of the canonical msd_run launcher and the retired $MSD_SDK / `/msd-tools` tokens across workflow markdown; there is no typed IR for "this source file does not contain substring X".

const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const os = require('node:os');
const { runHook: runHookSeam } = require('./helpers/process-seam.cjs');
const { throwIfFailed } = require('./helpers/git-fixture.cjs');
const { cleanup, TEST_ENV_BASE } = require('./helpers.cjs');
const { escapeRegex } = require('../msd-core/bin/lib/pattern.cjs');

const WORKFLOWS_DIR = path.join(__dirname, '..', 'msd-core', 'workflows');
const AGENTS_DIR = path.join(__dirname, '..', 'agents');
const SNIPPET_FILE = path.join(WORKFLOWS_DIR, '_runtime-launcher.snippet.sh');

/**
 * Env for any fixture that sources the snippet (#4205).
 *
 * TEST_ENV_BASE is DERIVED from the same capability registry the resolver
 * reads (see tests/helpers.cjs, #2665), so a new runtime home cannot leave it
 * silently stale — the shape of #4205.
 *
 * Three keys the derived set cannot supply:
 *  - GEMINI_CONFIG_DIR: the gemini runtime is retired (#1928) so the registry
 *    no longer carries it, but the snippet still probes its arm.
 *  - CLAUDE_ENV_FILE: a WRITE sink, not a read path. Left ambient, every
 *    fixture that exits 0 appends `export PATH='<temp dir>'` to the
 *    developer's real env file, each line naming a /tmp dir the fixture has
 *    already deleted.
 *  - BASH_ENV: sourced by non-interactive bash BEFORE the script, which is
 *    after this scrub is applied — so one inherited var re-injects any of
 *    the others. Measured: a BASH_ENV exporting CODEX_HOME turns (H) red.
 */
const SNIPPET_SCRUB = { GEMINI_CONFIG_DIR: '', CLAUDE_ENV_FILE: '', BASH_ENV: '' };
function snippetEnv(overrides = {}) {
  const env = { ...process.env, ...TEST_ENV_BASE, ...SNIPPET_SCRUB, ...overrides };
  // Windows env vars are case-insensitive; a spread of process.env is not. The
  // host PATH enumerates as `Path` there, so `{ ...process.env, PATH: x }`
  // yields BOTH keys — and libuv's make_program_env sorts the child's block
  // case-insensitively but never drops duplicates, so the ambient twin of
  // anything scrubbed here still reaches the child and defeats the isolation
  // this whole file rests on. Every key this function sets wins over any other
  // casing of itself; keys it does not set are left alone, so a caller that
  // passes no PATH override still gets the host PATH.
  const canonical = new Map(
    [...Object.keys(TEST_ENV_BASE), ...Object.keys(SNIPPET_SCRUB), ...Object.keys(overrides)]
      .map((key) => [key.toUpperCase(), key]),
  );
  for (const key of Object.keys(env)) {
    const owner = canonical.get(key.toUpperCase());
    if (owner !== undefined && owner !== key) delete env[key];
  }
  return env;
}

/**
 * Run a bash script FILE via the process seam, preserving the throw-on-
 * nonzero-exit semantics of the execFileSync('bash', [path], ...) idiom
 * this replaces.
 */
function runBashFile(scriptPath, options = {}) {
  const r = runHookSeam(scriptPath, [], {
    interpreter: 'bash', ...options, env: snippetEnv(options.env),
  });
  throwIfFailed(r, `bash ${scriptPath}`);
  return r.stdout;
}

const NODE_BIN = process.platform === 'win32' ? 'node.exe' : 'node';

/**
 * Put an executable link to this interpreter in `dir` under `name`, and return
 * `dir` so a caller can prepend it to a PATH. Callers use it for both halves of
 * a fixture: the node the launcher needs, and the msd_run sentinel it must not
 * reach. The content never matters, only that the name resolves.
 *
 * Windows symlinks need elevation, so a hard link is used there instead: it
 * needs no privilege, but it cannot cross volumes, hence the copy fallback.
 */
function linkExecutable(dir, name) {
  fs.mkdirSync(dir, { recursive: true });
  const target = path.join(dir, name);
  if (process.platform !== 'win32') {
    fs.symlinkSync(process.execPath, target);
    return dir;
  }
  try {
    fs.linkSync(process.execPath, target);
  } catch (err) {
    if (err.code !== 'EXDEV') throw err;
    fs.copyFileSync(process.execPath, target);
  }
  return dir;
}

/**
 * Plant `dir/name` as a file an X_OK probe accepts, and return `dir`. For
 * fixtures that only need a name to be *found*: nothing ever executes these,
 * so they cost a zero-byte write instead of a link to (or, across volumes, a
 * copy of) the whole interpreter.
 */
function plantExecutable(dir, name) {
  fs.mkdirSync(dir, { recursive: true });
  fs.writeFileSync(path.join(dir, name), '', { mode: 0o755 });
  return dir;
}

/**
 * Every filename the launcher's `command -v msd_run` arm could resolve.
 *
 * The arm runs under bash, so this models bash's lookup, not cmd.exe's. The
 * Cygwin/msys rule is that `.exe` may be omitted from a command while ".bat and
 * .com ... you cannot omit the extension" — so `msd_run.exe` is reachable for a
 * bare `msd_run` and `msd_run.cmd`/`.ps1` are not, whatever PATHEXT says.
 *
 * Matching PATHEXT instead would drop more directories than bash can reach, and
 * that is not free: buildIsolatedPath() restores node to the isolated PATH but
 * nothing restores bash, which the fixtures spawn by name. A wider drop set is
 * a wider chance of removing the directory bash itself lives in and failing the
 * fixture with ENOENT instead of an assertion.
 */
const MSD_RUN_NAMES = process.platform === 'win32'
  ? ['msd_run', 'msd_run.exe']
  : ['msd_run'];

/** True when `dir` holds a msd_run the launcher's PATH arm could resolve. */
function hasMsdRun(dir) {
  return MSD_RUN_NAMES.some((name) => {
    try { fs.accessSync(path.join(dir, name), fs.constants.X_OK); return true; }
    catch { return false; }
  });
}

/**
 * Build a PATH the launcher's `command -v msd_run` arm cannot resolve anything
 * from, while a bare `node` lookup still succeeds — the precondition every
 * runtime-home fallback fixture needs.
 *
 * Directories holding a resolvable msd_run are dropped (#4205: the arm probes
 * `msd_run`, not `msd-tools`), then a dedicated dir carrying only node is
 * prepended. The prepend is unconditional because dropping the directory node
 * itself lives in is a normal outcome, not an exotic one: fnm, nvm, Homebrew
 * and Windows global installs all co-locate the two.
 *
 * The caller cleans up `result.nodeBinDir` (pass it to `cleanup()` in a
 * `t.after` or `finally` block).
 *
 * @param {string} [basePath] PATH to filter. Callers planting a leaked msd_run
 *   pass their own string rather than mutating `process.env.PATH`.
 * @returns {{ isolatedPath: string, nodeBinDir: string }}
 */
function buildIsolatedPath(basePath = process.env.PATH) {
  // Only absolute directories survive. An empty element means "the current
  // directory" to a POSIX shell and `.` says so explicitly, so either one puts
  // the child's cwd on PATH — and hasMsdRun cannot see what it would admit,
  // since `path.join('.', 'msd_run')` probes the *runner's* cwd instead of the
  // child's. Joining the survivors (rather than the filtered string) also keeps
  // a fully-filtered PATH from ending in a delimiter, which means the same
  // thing. Dropping a relative entry can only tighten the isolation, never
  // loosen it.
  const filteredDirs = (basePath ?? '')
    .split(path.delimiter)
    .filter((p) => path.isAbsolute(p) && !hasMsdRun(p));

  const nodeBinDir = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-node-'));
  try {
    linkExecutable(nodeBinDir, NODE_BIN);
  } catch (err) {
    cleanup(nodeBinDir);
    throw err;
  }

  return { isolatedPath: [nodeBinDir, ...filteredDirs].join(path.delimiter), nodeBinDir };
}

/**
 * Read the canonical preamble from the snippet file (all lines, no trailing newline).
 */
function expectedPreamble() {
  const raw = fs.readFileSync(SNIPPET_FILE, 'utf8');
  const lines = raw.split(/\r?\n/);
  // Strip trailing empty element produced by a trailing newline.
  const content = lines[lines.length - 1] === '' ? lines.slice(0, -1) : lines;
  assert.ok(content.length >= 1, `_runtime-launcher.snippet.sh must not be empty`);
  return content; // array of strings
}

/**
 * Extract all bash/sh/shell fenced blocks from markdown content.
 * Returns array of { index, lines } where index is 0-based block count,
 * and lines is the array of content lines (without the fence markers).
 *
 * Handles both column-0 fences (```bash) and indented fences (   ```bash).
 */
function extractShellBlocks(content) {
  const allLines = content.split(/\r?\n/);
  const blocks = [];
  let inBlock = false;
  let blockLang = null;
  let blockLines = [];
  let blockIndex = 0;
  let blockIndent = '';
  let closingPattern = null;

  for (let i = 0; i < allLines.length; i++) {
    const line = allLines[i];
    if (!inBlock) {
      const fenceOpen = line.match(/^(\s*)```(\w+)?\s*$/);
      if (fenceOpen) {
        inBlock = true;
        blockIndent = fenceOpen[1];
        blockLang = (fenceOpen[2] || '').toLowerCase();
        blockLines = [];
        // Closing pattern: same indent prefix + ```
        closingPattern = new RegExp('^' + escapeRegex(blockIndent) + '```\\s*$');
        continue;
      }
    } else {
      if (closingPattern.test(line)) {
        if (['bash', 'sh', 'shell', 'zsh', ''].includes(blockLang)) {
          blocks.push({ index: blockIndex, lang: blockLang, lines: blockLines });
          blockIndex++;
        }
        inBlock = false;
        blockLang = null;
        blockLines = [];
        blockIndent = '';
        closingPattern = null;
        continue;
      }
      blockLines.push(line);
    }
  }
  return blocks;
}

/**
 * Collect all workflow .md files recursively under WORKFLOWS_DIR.
 * Excludes _runtime-launcher.snippet.sh (not a markdown file).
 */
function collectWorkflowFiles() {
  const results = [];
  function walk(dir) {
    for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
      const full = path.join(dir, entry.name);
      if (entry.isDirectory()) {
        walk(full);
      } else if (entry.isFile() && entry.name.endsWith('.md')) {
        results.push(full);
      }
    }
  }
  walk(WORKFLOWS_DIR);
  return results;
}

/**
 * Collect all agent .md files under AGENTS_DIR (non-recursive — agents/ has no subdirs,
 * but collectFiles in the sync script is recursive-safe; we mirror that here).
 */
function collectAgentFiles() {
  const results = [];
  function walk(dir) {
    for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
      const full = path.join(dir, entry.name);
      if (entry.isDirectory()) {
        walk(full);
      } else if (entry.isFile() && entry.name.endsWith('.md')) {
        results.push(full);
      }
    }
  }
  walk(AGENTS_DIR);
  return results;
}

/**
 * A workflow/agent file "delegates to the shared resolver" when it pulls the
 * canonical msd_run preamble in from msd-core/references/msd-run-resolver.md via
 * an @-include instead of inlining the snippet (see onboard.md / issue #1990).
 *
 * Such files are exempt from the inline-preamble parity checks (B / G / H and the
 * runtime-home propagation checks): they intentionally do NOT inline the preamble
 * — onboard-command.test.cjs even asserts the absence of the inline form. Their
 * resolver correctness is guaranteed transitively by:
 *   (1) onboard-command.test.cjs asserting the @-include is present, and
 *   (2) the "resolver reference stays byte-equal to the snippet" guard (B2) below.
 */
function delegatesToResolverReference(content) {
  return content.includes('references/msd-run-resolver.md');
}

/**
 * Write the identity-proving LOCAL install stub shared by the #4834 fixtures:
 * a `msd-tools.cjs` at `<dir>/.claude/msd-core/bin/` that answers
 * `runtime-identity --raw` like a real same-package install and prints
 * `LOCAL:<args>` for every other verb. Returns the bin dir.
 */
function writeIdentityLocalStub(homeDir) {
  const localBin = path.join(homeDir, '.claude', 'msd-core', 'bin');
  fs.mkdirSync(localBin, { recursive: true });
  fs.writeFileSync(
    path.join(localBin, 'msd-tools.cjs'),
    '#!/usr/bin/env node\n' +
      'const a = process.argv.slice(2);\n' +
      'if (a[0] === "runtime-identity" && a[1] === "--raw") {\n' +
      '  console.log(\'{"packageName":"@golem15/msd-core","version":"1.14.0-test"}\');\n' +
      '} else {\n' +
      '  console.log("LOCAL:" + a.join(","));\n' +
      '}\n',
  );
  fs.chmodSync(path.join(localBin, 'msd-tools.cjs'), 0o755);
  return localBin;
}

/**
 * Write a FOREIGN/older `msd_run` stub (no `runtime-identity` verb) into
 * `dir` — the #4834 hijacker. Returns `dir` for PATH construction.
 */
function writeForeignMsdRun(dir) {
  fs.mkdirSync(dir, { recursive: true });
  fs.writeFileSync(path.join(dir, 'msd_run'), '#!/bin/sh\necho "FOREIGN:$*"\n');
  fs.chmodSync(path.join(dir, 'msd_run'), 0o755);
  return dir;
}

describe('runtime-launcher-parity (#373)', () => {
  // ─── (#3146) Deliberate bootstrap-only preamble placement is preserved ────
  test('sync preserves a deliberate bootstrap-only preamble placement (#3146)', () => {
    // msd-core/workflows/explore.md deliberately places the preamble in a
    // Step 1 block that DEFINES msd_run but never CALLS it — its own comment
    // explains why: "Placed in Step 1 rather than Step 3 so declining the
    // research offer cannot leave Step 5's commit call unbootstrapped."
    // transformFile strips all blocks before re-inserting the preamble, so a
    // naive "first block that CALLS msd_run" target would silently relocate
    // the preamble into the second block, breaking define-before-use. This
    // fixture reproduces that shape with two blocks: the first containing
    // ONLY the preamble (no msd_run call), the second containing a msd_run
    // call.
    const preamble = expectedPreamble();
    const preambleText = preamble.join('\n');

    const fixture =
      '# Fixture\n\n' +
      '```bash\n' +
      preambleText + '\n' +
      '```\n\n' +
      '```bash\n' +
      'msd_run query something\n' +
      '```\n';

    const { transformFile } = require('../scripts/sync-runtime-launcher.cjs');
    const result = transformFile(fixture, preamble);

    // transformFile returns null when no changes are needed (already correct
    // and idempotent); otherwise the transformed content.
    const finalContent = result === null ? fixture : result;

    const markerIdx = finalContent.indexOf('_MSD_SHIM_NAME=');
    const useIdx = finalContent.indexOf('msd_run query something');

    assert.ok(markerIdx >= 0, 'expected the preamble marker to be present in the transformed fixture');
    assert.ok(useIdx >= 0, 'expected the msd_run call to be present in the transformed fixture');
    assert.ok(
      markerIdx < useIdx,
      `expected preamble (index ${markerIdx}) to remain in the FIRST block, before the msd_run call ` +
        `(index ${useIdx}) — the sync script must not relocate a deliberately-placed bootstrap-only preamble`,
    );
  });

  // ─── (A) No retired MSD_SDK token ────────────────────────────────────────
  test('(A) no MSD_SDK token in any workflow .md file', () => {
    const files = collectWorkflowFiles();
    assert.ok(files.length > 0, 'expected at least one workflow .md file');

    const offending = [];
    for (const f of files) {
      const content = fs.readFileSync(f, 'utf8');
      if (content.includes('MSD_SDK')) {
        offending.push(path.relative(WORKFLOWS_DIR, f));
      }
    }

    assert.deepStrictEqual(
      offending,
      [],
      'Found MSD_SDK (retired token) in workflow files — run `node scripts/sync-runtime-launcher.cjs` to fix:\n' +
        offending.join('\n'),
    );
  });

  // ─── (A2) Snippet's ${VAR:-default} surface is fully covered by the scrub lists (#4424) ──
  // SNIPPET_SCRUB above is hand-maintained for vars TEST_ENV_BASE cannot derive.
  // Nothing previously asserted the union actually covers every fallback arm in
  // the snippet, so a new runtime-home arm with no scrub entry could drift
  // silently — the same shape as #4205, arriving through the hand-listed half.
  test('(A2) every ${VAR:-default} arm in the snippet is covered by TEST_ENV_BASE, SNIPPET_SCRUB, or a caller-supplied var', () => {
    // RUNTIME_DIR: an external input the snippet reads, never assigns — every
    // fixture that sources the snippet sets it in-script before doing so.
    // MSD_TOOLS: the snippet assigns this one itself, before this arm's
    // ${MSD_TOOLS:-} check runs.
    // Any addition here must justify, in a comment like the two above, why the
    // var is genuinely caller-supplied/self-assigned — not a real coverage gap
    // silenced by exemption. When in doubt, add a SNIPPET_SCRUB entry instead.
    const CALLER_OR_SELF_ASSIGNED = new Set(['RUNTIME_DIR', 'MSD_TOOLS']);
    const snippetContent = fs.readFileSync(SNIPPET_FILE, 'utf8');
    const covered = new Set([...Object.keys(TEST_ENV_BASE), ...Object.keys(SNIPPET_SCRUB), ...CALLER_OR_SELF_ASSIGNED]);
    const extracted = [...new Set(
      [...snippetContent.matchAll(/\$\{([A-Z_][A-Z0-9_]*):-/g)].map((m) => m[1]),
    )];
    // Guards the guard: a truncated/renamed/unreadable snippet would make
    // `extracted` empty, and an empty `uncovered` below would pass vacuously.
    assert.ok(
      extracted.length >= 8,
      `expected the snippet to yield many distinct \${VAR:-default} arms, got ${extracted.length}`,
    );
    const uncovered = extracted.filter((name) => !covered.has(name));

    assert.deepStrictEqual(
      uncovered,
      [],
      'Snippet fallback arm(s) not covered by TEST_ENV_BASE, SNIPPET_SCRUB, or a caller-supplied var — ' +
        'add a SNIPPET_SCRUB entry (or confirm the capability registry should carry it):\n' +
        uncovered.join('\n'),
    );
  });

  // ─── (B) Exactly ONE canonical preamble per using file ───────────────────
  test('(B) each workflow .md using msd_run contains exactly ONE canonical preamble, before the first msd_run call', () => {
    const preamble = expectedPreamble();
    const preambleStr = preamble.join('\n');
    const files = collectWorkflowFiles();
    assert.ok(files.length > 0, 'expected at least one workflow .md file');

    const violations = [];

    for (const f of files) {
      const rel = path.relative(WORKFLOWS_DIR, f);
      const content = fs.readFileSync(f, 'utf8');
      // Files that delegate to the shared resolver reference (@-include) do not
      // inline the preamble — exempt them (see delegatesToResolverReference / (B2)).
      if (delegatesToResolverReference(content)) continue;
      const blocks = extractShellBlocks(content);

      // Collect all block lines in document order for flat analysis
      const allBlockLines = [];
      for (const blk of blocks) {
        allBlockLines.push(...blk.lines);
      }

      // Does this file use msd_run at all?
      const fileHasMsdRun = allBlockLines.some((l) => /\bmsd_run\b/.test(l));
      if (!fileHasMsdRun) continue;

      // Count preamble occurrences across all shell content of this file
      // Flatten all block lines with a separator so multi-block boundary doesn't create false match
      const allContent = allBlockLines.join('\n');
      let preambleCount = 0;
      let searchPos = 0;
      while (true) {
        const idx = allContent.indexOf(preambleStr, searchPos);
        if (idx === -1) break;
        preambleCount++;
        searchPos = idx + preambleStr.length;
      }

      if (preambleCount !== 1) {
        violations.push(
          `${rel}: expected exactly 1 canonical preamble occurrence in bash blocks, found ${preambleCount}. ` +
            `Run \`node scripts/sync-runtime-launcher.cjs\` to fix.`,
        );
        continue;
      }

      // Verify preamble appears BEFORE the first msd_run call (in document order)
      // Find the line index of the preamble start vs the first msd_run call in the flat content
      const preamblePos = allContent.indexOf(preambleStr);
      const firstMsdRunPos = allContent.search(/\bmsd_run\b/);

      // The first msd_run WITHIN the preamble itself (the function definition) is fine.
      // We need to verify that no msd_run CALL (i.e. msd_run used as a command, not in a
      // function definition body) appears before the preamble starts.
      // Simple check: preamble starts at or before the first msd_run occurrence
      if (preamblePos > firstMsdRunPos) {
        violations.push(
          `${rel}: preamble appears AFTER the first msd_run reference — it must precede all msd_run calls.`,
        );
      }
    }

    assert.deepStrictEqual(
      violations,
      [],
      'Files with msd_run calls have wrong preamble count or ordering:\n' +
        violations.join('\n---\n'),
    );
  });

  // ─── (B2) Shared resolver reference stays byte-equal to the snippet ───────
  // Workflows may delegate to msd-core/references/msd-run-resolver.md instead of
  // inlining the preamble (see delegatesToResolverReference). That delegation is
  // only safe if the reference's bash block is byte-equal to the canonical
  // snippet — otherwise a delegating workflow (e.g. onboard.md) would silently
  // ship a drifted resolver. This guard replaces the inline-preamble checks for
  // those files.
  test('(B2) references/msd-run-resolver.md preamble is byte-equal to the canonical snippet', () => {
    const preambleStr = expectedPreamble().join('\n');
    const refPath = path.join(__dirname, '..', 'msd-core', 'references', 'msd-run-resolver.md');
    const refContent = fs.readFileSync(refPath, 'utf8');
    const refPreamble = extractShellBlocks(refContent)
      .map((b) => b.lines.join('\n'))
      .join('\n')
      .trim();
    assert.equal(
      refPreamble,
      preambleStr,
      'msd-core/references/msd-run-resolver.md must contain the canonical msd_run preamble ' +
        'byte-equal to _runtime-launcher.snippet.sh. Re-copy the snippet into the reference so ' +
        'workflows that delegate to it via @-include ship the current resolver.',
    );
  });

  // ─── (C) Space-safe behavioral test ──────────────────────────────────────
  test('(C) msd_run works with a RUNTIME_DIR path containing spaces', () => {
    // Create temp dir whose path contains a space
    const base = fs.mkdtempSync(path.join(os.tmpdir(), 'msd 373 '));
    try {
      const binDir = path.join(base, 'msd-core', 'bin');
      fs.mkdirSync(binDir, { recursive: true });

      // Stub msd-tools.cjs that prints its argv
      const stub = path.join(binDir, 'msd-tools.cjs');
      fs.writeFileSync(stub, '#!/usr/bin/env node\nconsole.log("STUB:" + process.argv.slice(2).join(","));\n');
      fs.chmodSync(stub, 0o755);

      // Build a shell script: set RUNTIME_DIR, source preamble, run msd_run
      const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
      const scriptContent =
        `export RUNTIME_DIR=${JSON.stringify(base)}\n` +
        snippet +
        `\nmsd_run query state.json\n`;

      const scriptPath = path.join(base, 'test-space.sh');
      fs.writeFileSync(scriptPath, scriptContent);

      const stdout = runBashFile(scriptPath);
      assert.ok(
        stdout.includes('STUB:query,state.json'),
        `Expected stdout to contain "STUB:query,state.json" but got: ${stdout.trim()}`,
      );
    } finally {
      cleanup(base);
    }
  });

  // ─── (D) Loud guard: missing runtime is fatal ─────────────────────────────
  test('(D) missing msd-tools.cjs and no PATH msd_run causes loud non-zero exit with "not found" on stderr', (t) => {
    // Create temp dir with a space in the name, but NO msd-tools.cjs.
    // We ensure msd_run is not on PATH by prepending a dir that has no
    // msd_run binary (system binaries remain on PATH so bash/node work).
    const base = fs.mkdtempSync(path.join(os.tmpdir(), 'msd 373 notools '));
    // Place a no-op dir first in PATH; no msd_run stub there.
    const noToolsBin = path.join(base, 'nobin');
    fs.mkdirSync(noToolsBin, { recursive: true });
    try {
      const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
      // The script must also unset any MSD_TOOLS env var that might leak in
      const scriptContent =
        `unset MSD_TOOLS\n` +
        `export RUNTIME_DIR=${JSON.stringify(base)}\n` +
        snippet +
        `\nmsd_run query state.json\n`;

      const scriptPath = path.join(base, 'test-guard.sh');
      fs.writeFileSync(scriptPath, scriptContent);

      // noToolsBin first (no msd_run stub there), then a PATH no msd_run is
      // resolvable from.
      const isolated = buildIsolatedPath();
      t.after(() => cleanup(isolated.nodeBinDir));
      const isolatedPath = [noToolsBin, isolated.isolatedPath].join(path.delimiter);

      const r = runHookSeam(scriptPath, [], {
        interpreter: 'bash',
        // Loud-guard requires every runtime-home arm to genuinely miss, not
        // just PATH (#4205 class: an ambient config-dir var pointing at a
        // real install would resolve here instead of the hard error).
        env: snippetEnv({ PATH: isolatedPath, HOME: base }),
      });
      const threw = r.exitCode !== 0;
      const stderrOutput = r.stderr || '';

      assert.ok(threw, 'Expected the script to exit non-zero when msd-tools.cjs is missing and msd_run is not on PATH');
      // Match the launcher's own diagnostic, not a bare "not found": when node
      // itself is missing from the isolated PATH, bash's own
      // `bash: node: command not found` satisfies the loose form and a
      // regressed guard passes.
      assert.ok(
        stderrOutput.includes('ERROR: msd-tools.cjs not found'),
        `Expected stderr to contain "ERROR: msd-tools.cjs not found", got: ${stderrOutput.trim()}`,
      );
    } finally {
      cleanup(base);
    }
  });

  // ─── (E) PATH fallback behavioral (#3668, identity-gated since #4834) ─────
  test('(E) PATH fallback: uses installed msd_run when no local msd-tools.cjs present', () => {
    // Create a temp dir with NO local msd-core/bin/msd-tools.cjs.
    // Place an executable msd_run stub on a dedicated PATH dir.
    // RUNTIME_DIR points somewhere that has no msd-tools.cjs.
    //
    // #3146: the PATH-fallback target changed from `msd-tools` to `msd_run`.
    // The predecessor package `get-shit-done-cc` publishes a colliding
    // `msd-tools` bin, so the launcher resolves `msd_run`, which only this
    // package publishes.
    //
    // #4834: the PATH arm is gated on runtime-identity proof, so the stub must
    // answer `runtime-identity --raw` the way a real same-package install does
    // — a stub without the verb now falls through to the hard error ((D2)
    // pins that side). HOME is pinned to an empty fake home so the reorder
    // (config homes ahead of PATH) cannot resolve through the runner's real
    // $HOME before the PATH arm is reached.
    const base = fs.mkdtempSync(path.join(os.tmpdir(), 'msd 373 pathfb '));
    const emptyHome = fs.mkdtempSync(path.join(os.tmpdir(), 'msd 373 pathfb home '));
    try {
      const pathBinDir = path.join(base, 'bin');
      fs.mkdirSync(pathBinDir, { recursive: true });

      // Stub installed msd_run binary: proves identity, then prints a marker
      const stubPath = path.join(pathBinDir, 'msd_run');
      fs.writeFileSync(
        stubPath,
        '#!/bin/sh\n' +
          'if [ "$1" = "runtime-identity" ] && [ "$2" = "--raw" ]; then\n' +
          '  echo \'{"packageName":"@golem15/msd-core","version":"installed-test"}\'\n' +
          'else\n' +
          '  echo "installed:$*"\n' +
          'fi\n',
      );
      fs.chmodSync(stubPath, 0o755);

      // RUNTIME_DIR points to base — no msd-core/bin/msd-tools.cjs there
      const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
      const scriptContent =
        `unset MSD_TOOLS\n` +
        `export RUNTIME_DIR=${JSON.stringify(base)}\n` +
        snippet +
        `\nprintf "MSD_TOOLS=%s\\n" "$MSD_TOOLS"\n` +
        `msd_run query state.json\n`;

      const scriptPath = path.join(base, 'test-pathfb.sh');
      fs.writeFileSync(scriptPath, scriptContent);

      const stdout = runBashFile(scriptPath, {
        env: {
          PATH: `${pathBinDir}${path.delimiter}${process.env.PATH || ''}`,
          HOME: emptyHome,
        },
      });

      // The PATH fallback must have resolved MSD_TOOLS to the stub binary.
      // Normalize backslashes → forward slashes so the assertion works on Windows
      // (git-bash emits POSIX paths while Node's os.tmpdir() returns the Windows form).
      // Assert by suffix (/bin/msd_run, no .cjs extension) rather than absolute prefix
      // because the prefix differs between Windows and POSIX.
      // Use .+ (not \S*) to tolerate paths that contain spaces.
      const normStdout = stdout.replace(/\\/g, '/');
      assert.match(
        normStdout,
        /MSD_TOOLS=.+\/bin\/msd_run(?:\s|$)/m,
        `Expected MSD_TOOLS to resolve to the installed PATH stub (suffix /bin/msd_run), got: ${stdout.trim()}`,
      );
      assert.doesNotMatch(
        normStdout,
        /MSD_TOOLS=.+\.cjs/m,
        `Expected MSD_TOOLS NOT to point to a .cjs file in PATH fallback, got: ${stdout.trim()}`,
      );
      // The stub must have been invoked with the query arguments
      assert.ok(
        stdout.includes('installed:query state.json'),
        `Expected stdout to contain "installed:query state.json" (PATH stub output), got: ${stdout.trim()}`,
      );
    } finally {
      cleanup(base);
      cleanup(emptyHome);
    }
  });

  // ─── (K) foreign PATH msd_run cannot hijack a local install (#4834) ───────
  test('(K) a foreign msd_run on PATH cannot hijack a runtime-config-home install (#4834)', (t) => {
    // The issue's shape: a local install (here at the $HOME/.claude config
    // home, the same arm 3 the installed-copy path bakes an absolute prefix
    // into) plus an older foreign msd_run earlier on PATH. The PATH arm must
    // prove identity before it may win; a tool without the runtime-identity
    // verb falls through so the local install resolves instead.
    const fakeHome = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4834-home-'));
    const fakeRuntime = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4834-rt-'));
    const foreignBin = writeForeignMsdRun(fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4834-foreign-')));
    writeIdentityLocalStub(fakeHome);
    t.after(() => { cleanup(fakeHome); cleanup(fakeRuntime); cleanup(foreignBin); });

    const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
    const scriptContent =
      `unset MSD_TOOLS\n` +
      `export RUNTIME_DIR=${JSON.stringify(fakeRuntime)}\n` +
      `export HOME=${JSON.stringify(fakeHome)}\n` +
      snippet +
      `\nprintf "MSD_TOOLS=%s\\n" "$MSD_TOOLS"\n` +
      `msd_run query git.base-branch --is-protected master\n`;

    const scriptPath = path.join(fakeRuntime, 'test-4834-hijack.sh');
    fs.writeFileSync(scriptPath, scriptContent);

    const { isolatedPath, nodeBinDir } = buildIsolatedPath();
    t.after(() => cleanup(nodeBinDir));
    const testPath = [foreignBin, isolatedPath].join(path.delimiter);

    const stdout = runBashFile(scriptPath, {
      env: { PATH: testPath, HOME: fakeHome },
    });

    const normStdout = stdout.replace(/\\/g, '/');
    assert.ok(
      normStdout.includes('.claude/msd-core/bin/'),
      `Expected MSD_TOOLS to resolve into the local install at .claude/msd-core/bin/, got:\n${stdout.trim()}`,
    );
    // The issue's downstream contract: the LOCAL tool is what answers
    // `query git.base-branch --is-protected` (a real 1.14.0 tool then honors
    // git.allow_default_branch_commits — pinned end to end by (K2)).
    assert.ok(
      stdout.includes('LOCAL:query,git.base-branch,--is-protected,master'),
      `Expected the local tool to answer the query, got:\n${stdout.trim()}`,
    );
    assert.ok(
      !stdout.includes('FOREIGN:'),
      `Expected the foreign PATH stub never to be invoked, got:\n${stdout.trim()}`,
    );
  });

  // ─── (K2) end-to-end: the resolved local tool honors the override (#4834) ──
  test('(K2) end-to-end: the resolved local tool honors git.allow_default_branch_commits (#4834)', (t) => {
    // The issue's console repro with the REAL msd-tools: a foreign msd_run
    // first on PATH, the real binary installed at the config home, a temp
    // project on its default branch `master`. With the override set, the
    // launcher must reach the real local tool and report `master` as NOT
    // protected; without the override the same tool reports it protected —
    // the control that keeps the assertion from passing vacuously. Before
    // #4834 the FOREIGN tool answered here, predating the override, and the
    // executor's pre-commit guard refused the commit.
    const { createTempGitProject, cleanup: cleanupDir } = require('./helpers.cjs');
    const project = createTempGitProject('msd-4834-k2-');
    const projectControl = createTempGitProject('msd-4834-k2c-');
    const fakeHome = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4834-k2-home-'));
    const foreignBin = writeForeignMsdRun(fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4834-k2-path-')));
    const fakeRuntime = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4834-k2-rt-'));
    t.after(() => {
      cleanupDir(project); cleanupDir(projectControl);
      cleanup(fakeHome); cleanup(foreignBin); cleanup(fakeRuntime);
    });

    // Install the REAL tool in the full install shape: msd-tools.cjs resolves
    // ensure-runtime-build.cjs and lib/ beside itself, and lib modules reach
    // repo-root-relative `scripts/` helpers (`../../../scripts/...` from
    // bin/lib) — so the fixture root plays the repo root: msd-core/bin plus
    // the tracked scripts tree beside it.
    const fixtureRoot = path.join(fakeHome, '.claude');
    fs.cpSync(path.join(__dirname, '..', 'msd-core', 'bin'), path.join(fixtureRoot, 'msd-core', 'bin'), { recursive: true });
    fs.cpSync(path.join(__dirname, '..', 'scripts'), path.join(fixtureRoot, 'scripts'), { recursive: true });

    fs.writeFileSync(
      path.join(project, '.planning', 'config.json'),
      JSON.stringify({ git: { branching_strategy: 'none', allow_default_branch_commits: true } }),
    );
    fs.writeFileSync(
      path.join(projectControl, '.planning', 'config.json'),
      JSON.stringify({ git: { branching_strategy: 'none' } }),
    );

    const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
    const runQuery = (cwd) => {
      const scriptPath = path.join(cwd, 'test-4834-e2e.sh');
      fs.writeFileSync(
        scriptPath,
        `unset MSD_TOOLS\n` +
          `export RUNTIME_DIR=${JSON.stringify(fakeRuntime)}\n` +
          `export HOME=${JSON.stringify(fakeHome)}\n` +
          `cd ${JSON.stringify(cwd)}\n` +
          snippet +
          `\nmsd_run query git.base-branch --is-protected master\n`,
      );
      const { isolatedPath, nodeBinDir: nodeDir } = buildIsolatedPath();
      t.after(() => cleanup(nodeDir));
      const testPath = [foreignBin, isolatedPath].join(path.delimiter);
      return runHookSeam(scriptPath, [], {
        interpreter: 'bash',
        env: snippetEnv({ PATH: testPath, HOME: fakeHome }),
      });
    };

    const withOverride = runQuery(project);
    assert.equal(withOverride.exitCode, 0, `launcher must resolve and run the local tool: ${(withOverride.stderr || '').trim()}`);
    const withoutOverride = runQuery(projectControl);
    assert.equal(withoutOverride.exitCode, 0, `control run must also resolve: ${(withoutOverride.stderr || '').trim()}`);

    // The real tool's own stdout is exactly `false` / `true` (the override is
    // honored, then the control proves the query can go the other way).
    assert.equal(
      withOverride.stdout.trim().split('\n').pop(),
      'false',
      `Expected the local tool to honor git.allow_default_branch_commits, got:\n${withOverride.stdout.trim()}`,
    );
    assert.equal(
      withoutOverride.stdout.trim().split('\n').pop(),
      'true',
      `Expected the control project to report master as protected, got:\n${withoutOverride.stdout.trim()}`,
    );
  });

  // ─── (D2) identity-gated PATH arm fails closed (#4834) ────────────────────
  test('(D2) a foreign msd_run on PATH with no local install still hard-errors (#4834)', (t) => {
    // Without the gate, the foreign tool is accepted silently (warning only)
    // and the verb runs against it. With the gate, resolution falls through
    // every remaining arm and lands in the hard error — the fail-closed
    // terminal the #3146 design names.
    const fakeHome = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4834-nohome-'));
    const fakeRuntime = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4834-nort-'));
    const foreignBin = writeForeignMsdRun(fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4834-nofx-')));
    t.after(() => { cleanup(fakeHome); cleanup(fakeRuntime); cleanup(foreignBin); });

    const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
    const scriptContent =
      `unset MSD_TOOLS\n` +
      `export RUNTIME_DIR=${JSON.stringify(fakeRuntime)}\n` +
      `export HOME=${JSON.stringify(fakeHome)}\n` +
      snippet +
      `\nmsd_run ping test\n`;

    const scriptPath = path.join(fakeRuntime, 'test-4834-allfail.sh');
    fs.writeFileSync(scriptPath, scriptContent);

    const isolated = buildIsolatedPath();
    t.after(() => cleanup(isolated.nodeBinDir));
    const testPath = [foreignBin, isolated.isolatedPath].join(path.delimiter);

    const r = runHookSeam(scriptPath, [], {
      interpreter: 'bash',
      env: snippetEnv({ PATH: testPath, HOME: fakeHome }),
    });

    assert.ok(r.exitCode !== 0, 'Expected non-zero exit when only a foreign msd_run resolves and no local install exists');
    assert.ok(
      (r.stderr || '').includes('ERROR: msd-tools.cjs not found'),
      `Expected stderr to contain "ERROR: msd-tools.cjs not found", got: ${(r.stderr || '').trim()}`,
    );
  });

  // ─── (L) config-home install outranks an identity-proving PATH msd_run (#4834) ──
  test('(L) a runtime-config-home install outranks an identity-proving msd_run on PATH (#4834)', (t) => {
    // Reorder semantics: installer-managed config-home installs win even when
    // the PATH entry is genuine (identity-proving) — a stale-but-real global
    // must not shadow the local install the same way the pre-1.7.0 one did.
    const fakeHome = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4834-l-home-'));
    const fakeRuntime = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4834-l-rt-'));
    const pathBinDir = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4834-l-path-'));
    writeIdentityLocalStub(fakeHome);
    fs.mkdirSync(pathBinDir, { recursive: true });
    fs.writeFileSync(
      path.join(pathBinDir, 'msd_run'),
      '#!/bin/sh\n' +
        'if [ "$1" = "runtime-identity" ] && [ "$2" = "--raw" ]; then\n' +
        '  echo \'{"packageName":"@golem15/msd-core","version":"1.13.0-global"}\'\n' +
        'else\n' +
        '  echo "PATHSTUB:$*"\n' +
        'fi\n',
    );
    fs.chmodSync(path.join(pathBinDir, 'msd_run'), 0o755);
    t.after(() => { cleanup(fakeHome); cleanup(fakeRuntime); cleanup(pathBinDir); });

    const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
    const scriptContent =
      `unset MSD_TOOLS\n` +
      `export RUNTIME_DIR=${JSON.stringify(fakeRuntime)}\n` +
      `export HOME=${JSON.stringify(fakeHome)}\n` +
      snippet +
      `\nprintf "MSD_TOOLS=%s\\n" "$MSD_TOOLS"\n` +
      `msd_run query state.json\n`;

    const scriptPath = path.join(fakeRuntime, 'test-4834-local-wins.sh');
    fs.writeFileSync(scriptPath, scriptContent);

    const { isolatedPath, nodeBinDir } = buildIsolatedPath();
    t.after(() => cleanup(nodeBinDir));
    const testPath = [pathBinDir, isolatedPath].join(path.delimiter);

    const stdout = runBashFile(scriptPath, {
      env: { PATH: testPath, HOME: fakeHome },
    });

    const normStdout = stdout.replace(/\\/g, '/');
    assert.ok(
      normStdout.includes('.claude/msd-core/bin/'),
      `Expected the config-home install to outrank the PATH entry, got:\n${stdout.trim()}`,
    );
    assert.ok(
      stdout.includes('LOCAL:query,state.json'),
      `Expected the local tool to answer the query, got:\n${stdout.trim()}`,
    );
    assert.ok(
      !stdout.includes('PATHSTUB:'),
      `Expected the identity-proving PATH stub not to be invoked, got:\n${stdout.trim()}`,
    );
  });

  // ─── (M) arm order and gate structure (#4834) ─────────────────────────────
  test('(M) snippet arms: config homes precede the PATH arm, and the PATH arm is identity-gated (#4834)', () => {
    // Structural companion to (K)/(L): the behavioral fixtures pin WHAT
    // resolves; this pins the arm ORDER and the gate so a future edit cannot
    // silently re-hoist PATH above the config homes or drop the identity
    // proof. Shipped-text-is-the-product: the snippet's text IS the deployed
    // resolver for every workflow that inlines it.
    //
    // allow-test-rule: structural-regression-guard (#4834)
    const snippetContent = fs.readFileSync(SNIPPET_FILE, 'utf8');
    const helperDefPos = snippetContent.indexOf('_msd_homes() {');
    const homesArmPos = snippetContent.indexOf('elif _msd_homes;');
    const pathArmPos = snippetContent.indexOf('command -v msd_run');
    const gatePos = snippetContent.indexOf('_msd_id_ok "$_G"');

    assert.ok(helperDefPos !== -1, 'snippet must define the _msd_homes helper (shared config-home candidate list)');
    assert.ok(homesArmPos !== -1, 'snippet must probe config homes through _msd_homes in the elif chain');
    assert.ok(pathArmPos !== -1, 'snippet must keep the PATH fallback arm');
    assert.ok(gatePos !== -1, 'snippet must gate the PATH arm on _msd_id_ok "$_G"');
    assert.ok(
      homesArmPos < pathArmPos,
      `config-home arm (at ${homesArmPos}) must precede the PATH arm (at ${pathArmPos}) — local installs outrank PATH`,
    );
    const acceptPos = snippetContent.indexOf('MSD_TOOLS="$_G"', gatePos);
    assert.ok(
      acceptPos !== -1,
      'the PATH arm must still assign MSD_TOOLS="$_G" after the gate',
    );
  });

  // ─── (N) delegation roster: the size-capped files load the shared resolver ──
  test('(N) the #4834 delegation roster loads the resolver by @-include, not inline (#4834)', () => {
    // The LARGE agents and the ceiling-capped workflows sat within 3-73 bytes
    // of their hard caps, so no snippet growth could ship inline. These files
    // delegate instead (the onboard.md pattern): the @-include loads
    // msd-run-resolver.md — byte-equal to the snippet per (B2) — and the sync
    // script neither requires nor inserts an inline preamble for them. Pin
    // the roster so a future edit cannot silently re-inline (blowing the
    // caps) or drop the @-include (dropping the launcher).
    //
    // allow-test-rule: structural-regression-guard (#4834)
    const DELEGATION_ROSTER = [
      'msd-executor.md',
      'msd-plan-checker.md',
      'msd-verifier.md',
      'msd-planner.md',
    ];
    const WORKFLOW_DELEGATION_ROSTER = [
      'execute-phase.md',
      'execute-plan.md',
    ];
    const problems = [];
    for (const name of DELEGATION_ROSTER) {
      const content = fs.readFileSync(path.join(AGENTS_DIR, name), 'utf8');
      if (!content.includes('references/msd-run-resolver.md')) {
        problems.push(`${name}: missing the msd-run-resolver.md @-include`);
      }
      if (content.includes('_MSD_SHIM_NAME=')) {
        problems.push(`${name}: carries an inline preamble — re-inline it only if its size cap has real headroom`);
      }
    }
    for (const rel of WORKFLOW_DELEGATION_ROSTER) {
      const content = fs.readFileSync(path.join(WORKFLOWS_DIR, rel), 'utf8');
      if (!content.includes('references/msd-run-resolver.md')) {
        problems.push(`${rel}: missing the msd-run-resolver.md @-include`);
      }
      if (content.includes('_MSD_SHIM_NAME=')) {
        problems.push(`${rel}: carries an inline preamble — re-inline it only if its size cap has real headroom`);
      }
    }
    assert.deepStrictEqual(problems, [], 'delegation roster violations:\n' + problems.join('\n'));
  });

  // ─── (G) ~/.claude fallback arm is present (#211) ───────────────────────────
  test('(G) snippet and all propagated workflow .md files contain the $HOME/.claude fallback arm between PATH check and hard error', () => {
    // The resolution order must be:
    //   (1) local/RUNTIME_DIR  →  (2) runtime config homes  →  (3) identity-gated PATH  →  (4) hard error
    // (#4834 moved the config homes ahead of PATH and gated PATH on
    // runtime-identity proof; the probe itself still sits between the
    // `command -v msd_run` elif and the hard-error else branch.)
    // We probe for .claude/msd-core/bin (using ${_MSD_SHIM_NAME} indirection)
    // between the `command -v msd_run` elif and the hard-error else branch.
    const CLAUDE_HOME_PROBE = '.claude/msd-core/bin/';

    // Assert snippet itself contains the probe
    const snippetContent = fs.readFileSync(SNIPPET_FILE, 'utf8');
    assert.ok(
      snippetContent.includes(CLAUDE_HOME_PROBE),
      `_runtime-launcher.snippet.sh must contain the $HOME/.claude fallback arm (probing "${CLAUDE_HOME_PROBE}"). ` +
        `Add an elif arm that checks $HOME/.claude/msd-core/bin/\${_MSD_SHIM_NAME} before the hard-error else.`,
    );

    // Assert the probe appears BEFORE the hard-error text in the snippet
    const probePos = snippetContent.indexOf(CLAUDE_HOME_PROBE);
    const errorPos = snippetContent.indexOf('exit 1');
    assert.ok(
      probePos < errorPos,
      `The $HOME/.claude fallback arm (at index ${probePos}) must appear before "exit 1" (at index ${errorPos}) in the snippet.`,
    );

    // Assert every propagated workflow .md file that uses msd_run also contains the probe
    const files = collectWorkflowFiles();
    const missing = [];
    for (const f of files) {
      const content = fs.readFileSync(f, 'utf8');
      const blocks = extractShellBlocks(content);
      const allBlockLines = blocks.flatMap((b) => b.lines);
      if (delegatesToResolverReference(content)) continue;
      const fileHasMsdRun = allBlockLines.some((l) => /\bmsd_run\b/.test(l));
      if (!fileHasMsdRun) continue;
      const allContent = allBlockLines.join('\n');
      if (!allContent.includes(CLAUDE_HOME_PROBE)) {
        missing.push(path.relative(WORKFLOWS_DIR, f));
      }
    }
    assert.deepStrictEqual(
      missing,
      [],
      `These workflow files use msd_run but are missing the $HOME/.claude fallback arm ("${CLAUDE_HOME_PROBE}"). ` +
        `Run \`node scripts/sync-runtime-launcher.cjs\` to propagate:\n` +
        missing.join('\n'),
    );
  });

  // ─── (H) Codex shim fallback behavioral ------------------------------------
  test('(H) msd_run resolves $HOME/.codex/msd-core/bin/ shim when PATH has no msd_run', (t) => {
    const CODEX_HOME_PROBE = '.codex/msd-core/bin/';

    const snippetContent = fs.readFileSync(SNIPPET_FILE, 'utf8');
    assert.ok(
      snippetContent.includes(CODEX_HOME_PROBE),
      `_runtime-launcher.snippet.sh must contain the Codex fallback arm (probing "${CODEX_HOME_PROBE}").`,
    );

    const missing = [];
    for (const f of collectWorkflowFiles()) {
      const content = fs.readFileSync(f, 'utf8');
      const blocks = extractShellBlocks(content);
      const allBlockLines = blocks.flatMap((b) => b.lines);
      if (delegatesToResolverReference(content)) continue;
      const fileHasMsdRun = allBlockLines.some((l) => /\bmsd_run\b/.test(l));
      if (!fileHasMsdRun) continue;
      if (!allBlockLines.join('\n').includes(CODEX_HOME_PROBE)) {
        missing.push(path.relative(WORKFLOWS_DIR, f));
      }
    }
    assert.deepStrictEqual(
      missing,
      [],
      `These workflow files use msd_run but are missing the Codex fallback arm ("${CODEX_HOME_PROBE}"). ` +
        `Run \`node scripts/sync-runtime-launcher.cjs\` to propagate:\n` +
        missing.join('\n'),
    );

    const fakeHome = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-codex-home-'));
    const fakeRuntime = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-codex-rt-'));
    try {
      const codexBinDir = path.join(fakeHome, '.codex', 'msd-core', 'bin');
      fs.mkdirSync(codexBinDir, { recursive: true });
      const stubPath = path.join(codexBinDir, 'msd-tools.cjs');
      fs.writeFileSync(
        stubPath,
        '#!/usr/bin/env node\nconsole.log("CODEX_HOME_STUB:" + process.argv.slice(2).join(","));\n',
      );
      fs.chmodSync(stubPath, 0o755);

      const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
      const scriptContent =
        `unset MSD_TOOLS\n` +
        `export RUNTIME_DIR=${JSON.stringify(fakeRuntime)}\n` +
        `export HOME=${JSON.stringify(fakeHome)}\n` +
        snippet +
        `\nprintf "MSD_TOOLS=%s\\n" "$MSD_TOOLS"\n` +
        `msd_run query init.quick\n`;

      const scriptPath = path.join(fakeRuntime, 'test-codex-home-fb.sh');
      fs.writeFileSync(scriptPath, scriptContent);

      const { isolatedPath, nodeBinDir } = buildIsolatedPath();
      t.after(() => cleanup(nodeBinDir));

      const stdout = runBashFile(scriptPath, {
        // Ambient CLAUDE_CONFIG_DIR/HERMES_HOME/CURSOR_CONFIG_DIR resolve arms
        // checked before CODEX_HOME, and an ambient CODEX_HOME overrides the
        // $HOME/.codex default this test asserts (#4205 class: same env-leak
        // bug, this time via config-dir vars rather than PATH). snippetEnv()'s
        // derived TEST_ENV_BASE clears all four, so only HOME's default
        // $HOME/.codex fallback can win.
        env: { PATH: isolatedPath, HOME: fakeHome },
      });

      const normStdout = stdout.replace(/\\/g, '/');
      assert.ok(
        normStdout.includes('.codex/msd-core/bin/'),
        `Expected MSD_TOOLS to resolve into .codex/msd-core/bin/, got:\n${stdout.trim()}`,
      );
      assert.ok(
        stdout.includes('CODEX_HOME_STUB:query,init.quick'),
        `Expected Codex shim stub output, got:\n${stdout.trim()}`,
      );
    } finally {
      cleanup(fakeHome);
      cleanup(fakeRuntime);
    }
  });

  // ─── (F0) Brace balance — the preamble is inlined into brace-counted files ──
  //
  // Regression for the #3841 red matrix run. The preamble is inlined into 112
  // shipped files, and several downstream guards balance braces by scanning raw
  // TEXT with no string-context awareness — tests/new-project-mvp-prompt.test.cjs's
  // "balanced braces" guard (mirroring #3784 bd53925f) counts every `{` and `}`
  // across new-project.md plus its steps/. new-project.md and
  // new-project/steps/auto-mode-config.md each carry one preamble copy, so a
  // snippet that is off by one reports a combined net depth of TWO, in a test whose
  // name mentions neither the launcher nor this issue.
  //
  // The identity assertion's `case` pattern legitimately contains a `{` inside a
  // single-quoted shell literal. It is paired by requiring the payload to be a
  // CLOSED object (`*'}'`) — which is also a real strengthening, since a truncated
  // payload then fails. Pin the balance HERE, at the snippet, so the next edit to
  // that pattern fails on the file it broke rather than three files downstream.
  test('(F0) the snippet has balanced braces (#3841 — inlined into brace-counted files)', () => {
    const snippetContent = fs.readFileSync(SNIPPET_FILE, 'utf8');
    let depth = 0;
    let minDepth = 0;
    for (const ch of snippetContent) {
      if (ch === '{') depth++;
      if (ch === '}') depth--;
      if (depth < minDepth) minDepth = depth;
    }
    assert.equal(
      depth,
      0,
      `_runtime-launcher.snippet.sh has unbalanced braces: net depth ${depth}. ` +
        `The preamble is inlined into 112 shipped files, and downstream guards ` +
        `(tests/new-project-mvp-prompt.test.cjs) balance braces over raw text with no ` +
        `awareness of shell quoting — an unpaired brace here fails there instead, ` +
        `multiplied by the number of inlined copies in the scanned file set. ` +
        `Pair the brace in the snippet; do not relax the downstream guard.`,
    );
    // Never dips below zero: a `}` that precedes its `{` would still net to 0 while
    // being unbalanced at every prefix, which is what a text scanner actually reports.
    assert.equal(minDepth, 0, `brace depth went negative (min ${minDepth}) — a closing brace precedes its opener`);
  });

  // ─── (F) Regression locks: no /msd-tools substring; no do.md dispatcher false-positive ──
  test('(F) snippet has no /msd-tools substring; do.md has no /msd[:-][a-z] matches', () => {
    // (F1) The snippet must not contain the literal substring /msd-tools.
    // The _MSD_SHIM_NAME indirection ensures bin/${_MSD_SHIM_NAME} instead of
    // bin/msd-tools.cjs — so the do.md dispatcher regex /\/msd[:-]([a-z]...)/ never
    // misreads a preamble line as a slash-command stub.
    const snippetContent = fs.readFileSync(SNIPPET_FILE, 'utf8');
    assert.ok(
      !snippetContent.includes('/msd-tools'),
      `_runtime-launcher.snippet.sh must not contain the literal "/msd-tools" substring. ` +
        `Use bin/\${_MSD_SHIM_NAME} indirection to keep the /msd[:-] scanner from ` +
        `misreading it as a slash-command stub. Found in snippet:\n` +
        snippetContent.split(/\r?\n/).filter((l) => l.includes('/msd-tools')).join('\n'),
    );

    // (F2) workflows/do.md must not contain the literal substring /msd-tools
    // (the specific path that leaks when _MSD_SHIM_NAME indirection is bypassed).
    // The bug-2954 dispatcher scanner /\/msd[:-]([a-z]...)/ would misread
    // /msd-tools as a slash-command stub named "tools" — which is not shipped.
    // Note: /msd:command references (with colon) in the dispatch table are
    // legitimate and are NOT checked here.
    const doMdPath = path.join(WORKFLOWS_DIR, 'do.md');
    const doMdContent = fs.readFileSync(doMdPath, 'utf8');
    const offendingLines = doMdContent
      .split(/\r?\n/)
      .filter((l) => /\/msd-tools/.test(l));
    assert.deepStrictEqual(
      offendingLines,
      [],
      `workflows/do.md contains the literal "/msd-tools" substring which the dispatcher-parity ` +
        `scanner (bug-2954) misreads as a slash-command stub. Use \${_MSD_SHIM_NAME} indirection. ` +
        `Offending lines:\n` +
        offendingLines.join('\n'),
    );
  });
});

// ─── Issue #381: standalone msd_run executable + CLAUDE_ENV_FILE persistence ──
describe('runtime-launcher-parity — standalone executable (#381)', () => {
  const BIN_DIR = path.join(__dirname, '..', 'msd-core', 'bin');
  const MSD_RUN_SRC = path.join(BIN_DIR, 'msd_run');

  // ─── (I) msd_run executable delegates to msd-tools.cjs beside it ──────────
  test('(I) msd_run executable delegates to msd-tools.cjs beside it', () => {
    const base = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-381-I-'));
    try {
      const binDir = path.join(base, 'msd-core', 'bin');
      fs.mkdirSync(binDir, { recursive: true });

      // Copy the real msd_run executable into the temp bin dir
      fs.copyFileSync(MSD_RUN_SRC, path.join(binDir, 'msd_run'));
      fs.chmodSync(path.join(binDir, 'msd_run'), 0o755);

      // Write a stub msd-tools.cjs that echoes its args
      fs.writeFileSync(
        path.join(binDir, 'msd-tools.cjs'),
        `console.log('MSD_TOOLS_STUB:' + process.argv.slice(2).join(' '))`,
      );

      const msdRunPath = path.join(binDir, 'msd_run');
      const r = runHookSeam(msdRunPath, ['query', 'x'], { interpreter: 'sh' });
      throwIfFailed(r, `sh ${msdRunPath} query x`);
      const stdout = r.stdout;
      assert.ok(
        stdout.includes('MSD_TOOLS_STUB:query x'),
        `Expected stdout to contain "MSD_TOOLS_STUB:query x", got: ${stdout.trim()}`,
      );
    } finally {
      cleanup(base);
    }
  });

  // ─── (J) preamble persists bin dir to CLAUDE_ENV_FILE ─────────────────────
  test('(J) preamble persists bin dir to CLAUDE_ENV_FILE so a fresh shell resolves msd_run', () => {
    // Use a RUNTIME_DIR whose path contains a SPACE to prove single-quote safety.
    const baseParent = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-381-J-'));
    const base = path.join(baseParent, 'has space');
    try {
      const binDir = path.join(base, 'msd-core', 'bin');
      fs.mkdirSync(binDir, { recursive: true });

      // msd_run stub that prints MSD_RUN_STUB:<args>
      const msdRunStub = path.join(binDir, 'msd_run');
      fs.writeFileSync(msdRunStub, '#!/bin/sh\necho "MSD_RUN_STUB:$*"\n');
      fs.chmodSync(msdRunStub, 0o755);

      // msd-tools.cjs stub (must exist for preamble first arm to win)
      fs.writeFileSync(path.join(binDir, 'msd-tools.cjs'), '// stub');

      const envFile = path.join(baseParent, 'envfile');
      const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');

      // Script: just source the preamble with RUNTIME_DIR + CLAUDE_ENV_FILE set
      const preambleScript = path.join(baseParent, 'run-preamble.sh');
      fs.writeFileSync(preambleScript, snippet);

      runBashFile(preambleScript, {
        env: {
          RUNTIME_DIR: base,
          CLAUDE_ENV_FILE: envFile,
          PATH: process.env.PATH,
        },
      });

      // Assert envfile exists and the persisted line is single-quoted
      assert.ok(fs.existsSync(envFile), `Expected CLAUDE_ENV_FILE (${envFile}) to be created after preamble runs`);
      const envFileContent = fs.readFileSync(envFile, 'utf8');
      // The persisted line must single-quote the directory (neutralising $, spaces, etc.)
      // and keep "$PATH" expanding at source time.
      // Expected form: export PATH='<dir>':"$PATH"
      assert.ok(
        envFileContent.includes("export PATH='"),
        `Expected envfile to contain single-quoted export PATH line, got: ${envFileContent.trim()}`,
      );
      assert.ok(
        envFileContent.includes('has space/msd-core/bin'),
        `Expected envfile to contain the spaced bin dir, got: ${envFileContent.trim()}`,
      );
      assert.ok(
        envFileContent.includes(':"$PATH"'),
        `Expected envfile to contain :"$PATH" (double-quoted, expands at source time), got: ${envFileContent.trim()}`,
      );

      // Windows Git Bash (msys2) does not honor Node's chmod exec bit for PATH-executing
      // extension-less scripts; the env-file persistence above is the cross-platform proof.
      // Global installs on Windows are covered by npm's generated bin shim.
      if (process.platform !== 'win32') {
        // Simulate a LATER fresh block that SOURCES the env file to get msd_run on PATH.
        // The later shell does NOT have the bin dir on PATH beforehand — it only gets it
        // by sourcing the env file.  We use a minimal PATH (no temp bin dir pre-injected).
        const inlineResult = runHookSeam('-c', ['. "$CLAUDE_ENV_FILE"; msd_run hello'], {
          interpreter: 'bash',
          env: {
            CLAUDE_ENV_FILE: envFile,
            PATH: process.env.PATH,
          },
        });
        throwIfFailed(inlineResult, 'bash -c <source env file; msd_run hello>');
        const stdout = inlineResult.stdout;
        assert.ok(
          stdout.includes('MSD_RUN_STUB:hello'),
          `Expected stdout to contain "MSD_RUN_STUB:hello" after sourcing env file, got: ${stdout.trim()}`,
        );
      }
    } finally {
      cleanup(baseParent);
    }
  });
});

// ─── Agent parity — runtime-launcher-parity — agents (#1041) ─────────────────
describe('runtime-launcher-parity — agents (#1041)', () => {
  // ─── (B-agents) Exactly ONE canonical preamble per using agent file ────────
  test('(B-agents) each agent .md using msd_run contains exactly ONE canonical preamble, before the first msd_run call', () => {
    const preamble = expectedPreamble();
    const preambleStr = preamble.join('\n');
    const files = collectAgentFiles();
    assert.ok(files.length > 0, 'expected at least one agent .md file');

    const violations = [];

    for (const f of files) {
      const rel = path.relative(AGENTS_DIR, f);
      const content = fs.readFileSync(f, 'utf8');
      // Files that delegate to the shared resolver reference (@-include) do not
      // inline the preamble — exempt them, mirroring (B)'s workflow-side skip
      // (#4834: the size-capped LARGE agents delegate; their resolver comes
      // from the byte-equal reference pinned by (B2) and the (N) roster).
      if (delegatesToResolverReference(content)) continue;
      const blocks = extractShellBlocks(content);

      // Collect all block lines in document order for flat analysis
      const allBlockLines = [];
      for (const blk of blocks) {
        allBlockLines.push(...blk.lines);
      }

      // Does this file use msd_run at all?
      const fileHasMsdRun = allBlockLines.some((l) => /\bmsd_run\b/.test(l));
      if (!fileHasMsdRun) continue; // agents without msd_run are not checked

      // Count preamble occurrences across all shell content of this file
      const allContent = allBlockLines.join('\n');
      let preambleCount = 0;
      let searchPos = 0;
      while (true) {
        const idx = allContent.indexOf(preambleStr, searchPos);
        if (idx === -1) break;
        preambleCount++;
        searchPos = idx + preambleStr.length;
      }

      if (preambleCount !== 1) {
        violations.push(
          `${rel}: expected exactly 1 canonical preamble occurrence in bash blocks, found ${preambleCount}. ` +
            `Run \`node scripts/sync-runtime-launcher.cjs\` to fix.`,
        );
        continue;
      }

      // Verify preamble appears BEFORE the first msd_run call (in document order)
      const preamblePos = allContent.indexOf(preambleStr);
      const firstMsdRunPos = allContent.search(/\bmsd_run\b/);

      // The first msd_run WITHIN the preamble itself (the function definition) is fine.
      // Simple check: preamble starts at or before the first msd_run occurrence.
      if (preamblePos > firstMsdRunPos) {
        violations.push(
          `${rel}: preamble appears AFTER the first msd_run reference — it must precede all msd_run calls.`,
        );
      }
    }

    assert.deepStrictEqual(
      violations,
      [],
      'Agent files with msd_run calls have wrong preamble count or ordering:\n' +
        violations.join('\n---\n'),
    );
  });
});


// ────────────────────────────────────────────────────────────────────────
// Folded from tests/bug-211-launcher-home-fallback.test.cjs — consolidation epic #1969 (B6 #1975)
// ────────────────────────────────────────────────────────────────────────
{
  const { describe: __foldDescribe } = require('node:test');
  __foldDescribe("folded:bug-211-launcher-home-fallback (consolidation epic #1969 B6 #1975)", () => {
'use strict';
/**
 * Regression test for bug #211: msd_run launcher must probe
 * $HOME/.claude/msd-core/bin/msd-tools.cjs before emitting the hard error.
 *
 * Asserts:
 * (A) The canonical snippet file contains the ~/.claude fallback arm.
 * (B) A representative propagated workflow file contains the ~/.claude fallback arm.
 * (C) Behavioral: when RUNTIME_DIR misses and msd_run is NOT on PATH,
 *     a stub at $HOME/.claude/msd-core/bin/msd-tools.cjs is resolved and invoked.
 * (D) All arms miss -> hard error (#4834 reordered: local -> config homes ->
 *     identity-gated PATH -> hard error). When all of them miss, exit non-zero.
 */

// allow-test-rule: structural-regression-guard (see #211)
// structural/behavioral regression for the ~/.claude fallback arm in
// the msd_run launcher snippet -- asserts literal substring presence and exercises the
// bash resolution path via execFileSync; there is no typed IR for "snippet contains arm X".

const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const os = require('node:os');
const { runHook: runHookSeam } = require('./helpers/process-seam.cjs');
const { cleanup } = require('./helpers.cjs');

const WORKFLOWS_DIR = path.join(__dirname, '..', 'msd-core', 'workflows');
const SNIPPET_FILE = path.join(WORKFLOWS_DIR, '_runtime-launcher.snippet.sh');
// Representative propagated workflow file (has a msd_run call):
const REPRESENTATIVE_FILE = path.join(WORKFLOWS_DIR, 'add-backlog.md');


const CLAUDE_HOME_PROBE = '.claude/msd-core/bin/';

describe('bug-211: launcher ~/.claude home fallback', () => {
  // --- (A) Snippet contains the arm ----------------------------------------
  test('(A) snippet file contains the $HOME/.claude fallback arm', () => {
    const content = fs.readFileSync(SNIPPET_FILE, 'utf8');
    assert.ok(
      content.includes(CLAUDE_HOME_PROBE),
      `_runtime-launcher.snippet.sh must contain "${CLAUDE_HOME_PROBE}" (the ~/.claude fallback arm). ` +
        `Found snippet content:\n${content.trim()}`,
    );
  });

  // --- (B) Representative propagated file contains the arm ------------------
  test('(B) add-backlog.md (representative propagated file) contains the $HOME/.claude fallback arm', () => {
    const content = fs.readFileSync(REPRESENTATIVE_FILE, 'utf8');
    assert.ok(
      content.includes(CLAUDE_HOME_PROBE),
      `add-backlog.md must contain "${CLAUDE_HOME_PROBE}" after propagation. ` +
        `Run \`node scripts/sync-runtime-launcher.cjs\` to propagate the updated snippet.`,
    );
  });

  // --- (C) Behavioral: ~/.claude stub is resolved when local and PATH both miss
  test('(C) msd_run resolves $HOME/.claude/msd-core/bin/ stub when no local install and msd_run not on PATH', (t) => {
    // Build a fake $HOME with a stub at .claude/msd-core/bin/msd-tools.cjs
    const fakeHome = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-211-home-'));
    // RUNTIME_DIR points to a directory with no msd-tools.cjs
    const fakeRuntime = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-211-rt-'));
    try {
      const claudeBinDir = path.join(fakeHome, '.claude', 'msd-core', 'bin');
      fs.mkdirSync(claudeBinDir, { recursive: true });

      // Stub msd-tools.cjs that prints a marker
      const stubPath = path.join(claudeBinDir, 'msd-tools.cjs');
      fs.writeFileSync(
        stubPath,
        '#!/usr/bin/env node\nconsole.log("CLAUDE_HOME_STUB:" + process.argv.slice(2).join(","));\n',
      );
      fs.chmodSync(stubPath, 0o755);

      const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
      const scriptContent =
        `unset MSD_TOOLS\n` +
        `export RUNTIME_DIR=${JSON.stringify(fakeRuntime)}\n` +
        `export HOME=${JSON.stringify(fakeHome)}\n` +
        snippet +
        `\nprintf "MSD_TOOLS=%s\\n" "$MSD_TOOLS"\n` +
        `msd_run ping test\n`;

      const scriptPath = path.join(fakeRuntime, 'test-home-fb.sh');
      fs.writeFileSync(scriptPath, scriptContent);

      // A PATH with no resolvable msd_run, to force the ~/.claude arm. The
      // helper also supplies node, which the stub's #!/usr/bin/env node needs.
      const { isolatedPath, nodeBinDir } = buildIsolatedPath();
      t.after(() => cleanup(nodeBinDir));

      const stdout = runBashFile(scriptPath, {
        // Ambient CLAUDE_CONFIG_DIR would override the $HOME/.claude default
        // this test relies on (#4205 class: env-leak, not PATH-leak).
        env: { PATH: isolatedPath, HOME: fakeHome },
      });

      // MSD_TOOLS must point into the fake ~/.claude dir
      const normStdout = stdout.replace(/\\/g, '/');
      assert.ok(
        normStdout.includes('.claude/msd-core/bin/'),
        `Expected MSD_TOOLS to resolve into .claude/msd-core/bin/, got:\n${stdout.trim()}`,
      );
      // The stub must have been invoked
      assert.ok(
        stdout.includes('CLAUDE_HOME_STUB:ping,test'),
        `Expected stub output "CLAUDE_HOME_STUB:ping,test", got:\n${stdout.trim()}`,
      );
    } finally {
      cleanup(fakeHome);
      cleanup(fakeRuntime);
    }
  });

  // --- (D) All three miss -> hard error -------------------------------------
  test('(D) hard error when local, PATH, and ~/.claude all miss', (t) => {
    const fakeHome = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-211-nohome-'));
    const fakeRuntime = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-211-nort-'));
    // noToolsBin so PATH check finds nothing
    const noToolsBin = path.join(fakeHome, 'nobin');
    fs.mkdirSync(noToolsBin, { recursive: true });
    // NO .claude/msd-core/bin stub created in fakeHome
    try {
      const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
      const scriptContent =
        `unset MSD_TOOLS\n` +
        `export RUNTIME_DIR=${JSON.stringify(fakeRuntime)}\n` +
        `export HOME=${JSON.stringify(fakeHome)}\n` +
        snippet +
        `\nmsd_run ping test\n`;

      const scriptPath = path.join(fakeRuntime, 'test-allfail.sh');
      fs.writeFileSync(scriptPath, scriptContent);

      const isolated = buildIsolatedPath();
      t.after(() => cleanup(isolated.nodeBinDir));
      const isolatedPath = [noToolsBin, isolated.isolatedPath].join(path.delimiter);

      const r = runHookSeam(scriptPath, [], {
        interpreter: 'bash',
        // "All three miss" requires every runtime-home arm to genuinely miss,
        // not just the first (#4205 class: an ambient config-dir var pointing
        // at a real install would resolve here instead of the hard error).
        env: snippetEnv({ PATH: isolatedPath, HOME: fakeHome }),
      });
      const threw = r.exitCode !== 0;
      const stderrOutput = r.stderr || '';

      assert.ok(threw, 'Expected non-zero exit when all three resolution arms miss');
      // Match the launcher's own diagnostic, not a bare "not found": when node
      // itself is missing from the isolated PATH, bash's own
      // `bash: node: command not found` satisfies the loose form and a
      // regressed guard passes.
      assert.ok(
        stderrOutput.includes('ERROR: msd-tools.cjs not found'),
        `Expected stderr to contain "ERROR: msd-tools.cjs not found", got: ${stderrOutput.trim()}`,
      );
    } finally {
      cleanup(fakeHome);
      cleanup(fakeRuntime);
    }
  });
});
  });
}


// ────────────────────────────────────────────────────────────────────────
// Folded from tests/bug-891-non-claude-runtime-home-fallback.test.cjs — consolidation epic #1969 (B6 #1975)
// ────────────────────────────────────────────────────────────────────────
{
  const { describe: __foldDescribe } = require('node:test');
  __foldDescribe("folded:bug-891-non-claude-runtime-home-fallback (consolidation epic #1969 B6 #1975)", () => {
'use strict';
/**
 * Regression test for bug #891: msd_run launcher must probe non-Claude
 * runtime homes before emitting the hard error.
 *
 * The last-resort $HOME/.claude/msd-core branch is Claude Code-specific.
 * Every non-Claude runtime (Cursor, Codex, OpenCode, Antigravity, …)
 * installs msd-core into a *different* directory that the shim never tried,
 * causing a false-positive fatal ERROR on all non-Claude runtimes when
 * RUNTIME_DIR is not set and msd_run is not on PATH.
 *
 * Asserts:
 * (A) Snippet contains all expected non-Claude runtime home probes (structural).
 * (B0) buildIsolatedPath() co-location invariant (see below).
 * (B) CODEX_HOME behavioral: when RUNTIME_DIR misses and msd_run is NOT on
 *     PATH, the stub at ${CODEX_HOME}/msd-core/bin/msd-tools.cjs is invoked.
 *     It plants a leaked msd_run on PATH first (#4205), on every platform,
 *     which is what makes it fail on a clean machine as well as a leaking one.
 * (C) Default Codex path behavioral: stub at $HOME/.codex/msd-core/bin/
 *     msd-tools.cjs is invoked when CODEX_HOME is not set.
 * (D) Resolution order: non-Claude homes are probed BEFORE the hard error,
 *     and AFTER the $HOME/.claude branch.
 * (E) Propagation: all workflow .md files using msd_run contain each probe
 *     (sync-runtime-launcher.cjs was re-run after editing the snippet).
 */

// allow-test-rule: structural-regression-guard (see #891)
// structural/behavioral regression for non-Claude runtime-home
// fallback arms in the msd_run launcher snippet -- asserts literal substring
// presence for each runtime-home probe and exercises the bash resolution paths
// via execFileSync; there is no typed IR for "snippet contains arm X".

const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const os = require('node:os');
const { cleanup } = require('./helpers.cjs');

const WORKFLOWS_DIR = path.join(__dirname, '..', 'msd-core', 'workflows');
const SNIPPET_FILE = path.join(WORKFLOWS_DIR, '_runtime-launcher.snippet.sh');


// Every non-Claude runtime home probe the snippet must contain.
// Key: runtime name (for diagnostics). Value: the substring that must appear
// in the snippet (the env-var-with-default expansion that probes that runtime's
// msd-core install location). Mirrors src/runtime-homes.cts getGlobalConfigDir().
const EXPECTED_RUNTIME_PROBES = {
  cursor:      '.cursor}/msd-core/bin/',
  codex:       '.codex}/msd-core/bin/',
  gemini:      '.gemini}/msd-core/bin/',
  grok:        '.agents}/msd-core/bin/',
  antigravity: '.gemini/antigravity}/msd-core/bin/',
  opencode:    'opencode}/msd-core/bin/',
};


describe('bug-891: non-Claude runtime home fallback arms', () => {

  // ── (A) Structural: snippet contains all expected non-Claude probes ───────
  test('(A) snippet contains all non-Claude runtime home probes', () => {
    const snippetContent = fs.readFileSync(SNIPPET_FILE, 'utf8');

    const missing = [];
    for (const [runtime, probe] of Object.entries(EXPECTED_RUNTIME_PROBES)) {
      if (!snippetContent.includes(probe)) {
        missing.push(`${runtime}: expected snippet to contain "${probe}"`);
      }
    }

    assert.deepStrictEqual(
      missing,
      [],
      `_runtime-launcher.snippet.sh is missing fallback probes for non-Claude runtimes:\n` +
        missing.join('\n') +
        `\n\nAdd elif arms for each runtime home (e.g. "\${CODEX_HOME:-$HOME/.codex}/msd-core/bin/...")` +
        ` before the hard-error else. Current snippet:\n${snippetContent.trim()}`,
    );
  });

  // ── (A2) Structural: probes appear AFTER .claude arm but BEFORE hard error ─
  test('(A2) non-Claude probes appear after .claude/msd-core arm and before hard error', () => {
    const snippetContent = fs.readFileSync(SNIPPET_FILE, 'utf8');
    const claudePos = snippetContent.indexOf('.claude/msd-core/bin/');
    const errorPos  = snippetContent.indexOf('exit 1');

    assert.ok(claudePos !== -1, 'Snippet must still contain .claude/msd-core/bin/ arm (regression guard)');
    assert.ok(errorPos  !== -1, 'Snippet must contain exit 1 (hard-error guard)');

    for (const [runtime, probe] of Object.entries(EXPECTED_RUNTIME_PROBES)) {
      const probePos = snippetContent.indexOf(probe);
      assert.ok(
        probePos !== -1,
        `Snippet must contain probe for ${runtime} ("${probe}")`,
      );
      assert.ok(
        probePos < errorPos,
        `${runtime} probe must appear before "exit 1" in snippet (found at ${probePos}, exit 1 at ${errorPos})`,
      );
    }
  });

  // ── (B0) Regression: buildIsolatedPath keeps node resolvable when node and ──
  //        msd_run co-locate in the same PATH directory.                       ─
  //
  // Machine-independence guarantee: the filtered PATH is ONLY two controlled
  // dirs — fakeBinDir (holds both fake msd_run AND node) plus a fresh empty dir
  // (no executables at all). The real system PATH is NOT appended.
  //
  // Filtering fakeBinDir out is correct and unavoidable, so the only thing that
  // keeps node reachable is the nodeBinDir buildIsolatedPath() prepends. This
  // test is that prepend's guard: make it conditional again — as it was on
  // Windows, where the helper returned `nodeBinDir: null` — and (ii) goes red.
  test(
    '(B0) buildIsolatedPath invariants: node survives, every reachable msd_run name and every relative dir does not',
    (t) => {
      // Build a fake bin dir that contains BOTH a msd_run executable and node,
      // simulating a dev setup (fnm/nvm/Homebrew) where both land in the same
      // bin directory.
      const fakeBinDir = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-891-colocated-'));
      // A second fresh empty dir — contains neither msd_run nor node.
      const emptyDir   = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-891-empty-'));
      t.after(() => cleanup(fakeBinDir));
      t.after(() => cleanup(emptyDir));

      // msd_run co-located with node — the fnm/nvm/Homebrew layout, and the
      // Windows global-install layout the same helper has to survive. Both are
      // probed, never run.
      plantExecutable(fakeBinDir, 'msd_run');
      plantExecutable(fakeBinDir, NODE_BIN);

      // Filter ONLY the two controlled dirs (no real system dirs). This makes
      // the test machine-independent: on any machine, the only place node
      // *could* come from before the fix is fakeBinDir — which gets filtered.
      const result = buildIsolatedPath(fakeBinDir + path.delimiter + emptyDir);
      t.after(() => cleanup(result.nodeBinDir));

      const returnedDirs = result.isolatedPath.split(path.delimiter);

      // (i) msd_run must NOT be resolvable on the returned PATH
      const msdRunResolvable = returnedDirs.some(hasMsdRun);
      assert.equal(
        msdRunResolvable,
        false,
        'msd_run must not be resolvable on the isolated PATH (home-fallback would be bypassed)',
      );

      // (ii) node must BE resolvable on the returned PATH (the new nodeBinDir makes it so)
      const nodeResolvable = returnedDirs.some((dir) => {
        try { fs.accessSync(path.join(dir, NODE_BIN), fs.constants.X_OK); return true; }
        catch { return false; }
      });
      assert.equal(
        nodeResolvable,
        true,
        'node must be resolvable on the isolated PATH (launcher runs: node "$MSD_TOOLS" "$@")',
      );

      // (iii) every name the launcher's PATH arm can resolve must be filtered,
      // not just the extensionless one — a msd_run.exe-only directory is the
      // reachable Windows leak an extensionless probe misses (#4344). The list
      // is written out rather than taken from MSD_RUN_NAMES: sweeping the
      // constant under test with itself cannot catch that constant being wrong.
      const reachableNames = process.platform === 'win32'
        ? ['msd_run', 'msd_run.exe']
        : ['msd_run'];
      const survived = reachableNames.filter((name) => {
        const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-891-ext-'));
        t.after(() => cleanup(dir));
        plantExecutable(dir, name);
        const probe = buildIsolatedPath(dir);
        t.after(() => cleanup(probe.nodeBinDir));
        return probe.isolatedPath.split(path.delimiter).includes(dir);
      });
      assert.deepStrictEqual(
        survived,
        [],
        'every name bash can resolve for a bare msd_run must be filtered out of the isolated PATH',
      );

      // (iv) every surviving element is absolute. A shell resolves an empty
      // element, `.`, or any relative entry against the *child's* working
      // directory, so each one is a way to put a cwd msd_run back on PATH —
      // and hasMsdRun cannot see any of them, because it probes relative to the
      // runner's cwd instead. Four ways one arrives: an ambient `::`, an
      // explicit `.`, a relative entry, and a PATH every entry of which was
      // filtered (which used to leave a trailing delimiter, meaning the same
      // thing).
      // Each case names the dirs that must survive, so the assertion has an
      // oracle of its own rather than re-running the implementation's filter.
      const relativeElementCases = {
        emptyElement: [`${emptyDir}${path.delimiter}${path.delimiter}${emptyDir}`, [emptyDir, emptyDir]],
        dotElement: [`${emptyDir}${path.delimiter}.${path.delimiter}${emptyDir}`, [emptyDir, emptyDir]],
        relativeElement: [`${emptyDir}${path.delimiter}sub/dir`, [emptyDir]],
        fullyFiltered: [fakeBinDir, []],
      };
      for (const [label, [basePath, expected]] of Object.entries(relativeElementCases)) {
        const probe = buildIsolatedPath(basePath);
        t.after(() => cleanup(probe.nodeBinDir));
        assert.deepStrictEqual(
          probe.isolatedPath.split(path.delimiter),
          [probe.nodeBinDir, ...expected],
          `${label}: only absolute, msd_run-free dirs may survive (a relative one resolves the child's cwd), got: ${probe.isolatedPath}`,
        );
      }
    },
  );


  // ── (B) Behavioral: CODEX_HOME stub is resolved, even past a leaked PATH ──
  //
  // #4205 regression, and the reason this asserts the sentinel rather than just
  // the stub: on a CLEAN machine the bare CODEX_HOME assertion passes whether
  // buildIsolatedPath() filters msd_run or msd-tools, so it only catches the bug
  // on a machine that already has the leak. Planting the sentinel makes it fail
  // on any machine, and on either platform: the sentinel is planted in the one
  // form that platform's shell resolves — the extensionless shim npm installs
  // on POSIX, `msd_run.exe` alone on Windows (see below for why alone). Note
  // that only the POSIX sentinel can print SENTINEL_INVOKED; on Windows the
  // basename assertion is what carries the guarantee (#4344).
  test('(B) buildIsolatedPath strips a leaked PATH msd_run; the ${CODEX_HOME} stub wins', (t) => {
    const fakeHome       = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-891-home-b-'));
    const fakeCodexHome = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-891-codex-'));
    const fakeRuntime    = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-891-rt-'));
    t.after(() => cleanup(fakeHome));
    t.after(() => cleanup(fakeCodexHome));
    t.after(() => cleanup(fakeRuntime));

    const sentinelBinDir = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-4205-sentinel-'));
    t.after(() => cleanup(sentinelBinDir));
    if (process.platform === 'win32') {
      // What msys bash resolves for a bare `msd_run`: it appends `.exe` during
      // PATH lookup. Planted ALONE, so the leak this fixture proves is the
      // extension-only one — an extensionless sibling would let an
      // extension-blind filter strip the directory for the wrong reason and
      // pass. It cannot print SENTINEL_INVOKED (it is this interpreter under
      // another name), which is what the MSD_TOOLS assertion below is for.
      linkExecutable(sentinelBinDir, 'msd_run.exe');
    } else {
      const sentinelPath = path.join(sentinelBinDir, 'msd_run');
      fs.writeFileSync(sentinelPath, '#!/bin/sh\necho "SENTINEL_INVOKED:$*"\n');
      fs.chmodSync(sentinelPath, 0o755);
    }

    // Simulate the reported leak: a real msd_run reachable on PATH. Passed in
    // rather than assigned to process.env.PATH — the runner's own environment
    // stays untouched, so no other fixture can observe the leak.
    const { isolatedPath, nodeBinDir } = buildIsolatedPath(
      `${sentinelBinDir}${path.delimiter}${process.env.PATH}`,
    );
    t.after(() => cleanup(nodeBinDir));

    // Leak assertion that needs no subprocess: a filter probing the wrong name
    // leaves sentinelBinDir on the isolated PATH. Deterministic on both
    // platforms, so it stays red even where the stdout assertions below depend
    // on the mount's exec heuristics rather than on the filter under test.
    assert.ok(
      !isolatedPath.split(path.delimiter).includes(sentinelBinDir),
      `Expected buildIsolatedPath to strip the leaked ${sentinelBinDir}, got:\n${isolatedPath}`,
    );

    const codexBinDir = path.join(fakeCodexHome, 'msd-core', 'bin');
    fs.mkdirSync(codexBinDir, { recursive: true });

    const stubPath = path.join(codexBinDir, 'msd-tools.cjs');
    fs.writeFileSync(
      stubPath,
      '#!/usr/bin/env node\nconsole.log("CODEX_HOME_STUB:" + process.argv.slice(2).join(","));\n',
    );
    fs.chmodSync(stubPath, 0o755);

    const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
    // HOME points at an isolated temp dir with no .claude install, so the
    // $HOME/.claude arm misses and the CODEX_HOME arm is the one under test.
    const scriptContent =
      `unset MSD_TOOLS\n` +
      `export HOME=${JSON.stringify(fakeHome)}\n` +
      `export RUNTIME_DIR=${JSON.stringify(fakeRuntime)}\n` +
      `export CODEX_HOME=${JSON.stringify(fakeCodexHome)}\n` +
      snippet +
      `\nprintf "MSD_TOOLS=%s\\n" "$MSD_TOOLS"\n` +
      `msd_run ping test\n`;

    const scriptPath = path.join(fakeRuntime, 'test-codex-home.sh');
    fs.writeFileSync(scriptPath, scriptContent);

    const stdout = runBashFile(scriptPath, {
      env: { PATH: isolatedPath, HOME: fakeHome, CODEX_HOME: fakeCodexHome },
    });

    const normStdout = stdout.replace(/\\/g, '/');
    assert.ok(
      !normStdout.includes('SENTINEL_INVOKED'),
      `Expected the leaked PATH msd_run to never be invoked, got:\n${stdout.trim()}`,
    );
    // The same claim without depending on the sentinel producing output:
    // whatever the resolver picked, it did not come from the leaked directory.
    // Matched by basename, not by absolute path — git-bash prints `/c/Users/…`
    // where os.tmpdir() gives `C:\Users\…` (see the note above the (E) PATH
    // fallback assertion), so an absolute-path comparison never matches on
    // Windows and would assert nothing there. The mkdtemp suffix keeps the
    // basename unique.
    assert.ok(
      !normStdout.includes(path.basename(sentinelBinDir)),
      `Expected MSD_TOOLS to resolve outside the leaked ${sentinelBinDir}, got:\n${stdout.trim()}`,
    );
    // Assert the codex dir itself: every arm of the resolver ends in
    // msd-core/bin/, so that substring alone cannot tell them apart.
    assert.ok(
      normStdout.includes(fakeCodexHome.replace(/\\/g, '/')),
      `Expected MSD_TOOLS to resolve into ${fakeCodexHome}, got:\n${stdout.trim()}`,
    );
    assert.ok(
      normStdout.includes('CODEX_HOME_STUB:ping,test'),
      `Expected stub output "CODEX_HOME_STUB:ping,test", got:\n${stdout.trim()}`,
    );
  });

  // ── (C) Behavioral: default .codex path used when CODEX_HOME not set ────
  test('(C) msd_run resolves $HOME/.codex/msd-core/bin/ stub when CODEX_HOME is unset', () => {
    const fakeHome    = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-891-home-'));
    const fakeRuntime = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-891-rt2-'));
    const { isolatedPath, nodeBinDir } = buildIsolatedPath();
    try {
      const codexBinDir = path.join(fakeHome, '.codex', 'msd-core', 'bin');
      fs.mkdirSync(codexBinDir, { recursive: true });

      const stubPath = path.join(codexBinDir, 'msd-tools.cjs');
      fs.writeFileSync(
        stubPath,
        '#!/usr/bin/env node\nconsole.log("CODEX_DEFAULT_STUB:" + process.argv.slice(2).join(","));\n',
      );
      fs.chmodSync(stubPath, 0o755);

      const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
      const scriptContent =
        `unset MSD_TOOLS CODEX_HOME\n` +
        `export RUNTIME_DIR=${JSON.stringify(fakeRuntime)}\n` +
        `export HOME=${JSON.stringify(fakeHome)}\n` +
        snippet +
        `\nprintf "MSD_TOOLS=%s\\n" "$MSD_TOOLS"\n` +
        `msd_run status\n`;

      const scriptPath = path.join(fakeRuntime, 'test-codex-default.sh');
      fs.writeFileSync(scriptPath, scriptContent);

      const stdout = runBashFile(scriptPath, {
        // CLAUDE_CONFIG_DIR resolves before the CODEX_HOME arm under test
        // (#4205 class, env vector); script-level `unset CODEX_HOME` above
        // already handles that var, and snippetEnv()'s derived TEST_ENV_BASE
        // clears CLAUDE_CONFIG_DIR before bash ever sees it.
        env: { PATH: isolatedPath, HOME: fakeHome },
      });

      const normStdout = stdout.replace(/\\/g, '/');
      assert.ok(
        normStdout.includes('.codex/msd-core/bin/'),
        `Expected MSD_TOOLS to resolve into .codex/msd-core/bin/, got:\n${stdout.trim()}`,
      );
      assert.ok(
        stdout.includes('CODEX_DEFAULT_STUB:status'),
        `Expected stub output "CODEX_DEFAULT_STUB:status", got:\n${stdout.trim()}`,
      );
    } finally {
      cleanup(fakeHome);
      cleanup(fakeRuntime);
      cleanup(nodeBinDir);
    }
  });

  // ── (D) Resolution order: claude < codex < hard-error ───────────────────
  test('(D) resolution order: .claude probe comes before codex probe, codex before hard error', () => {
    const snippetContent = fs.readFileSync(SNIPPET_FILE, 'utf8');
    // #4834 folded the config-home probes into the _msd_homes() helper defined
    // ahead of the if-chain, so raw first-occurrence positions no longer
    // express arm order — compare the probes WITHIN the helper, and the
    // helper's arm against the hard error.
    const helperStart = snippetContent.indexOf('_msd_homes() {');
    assert.ok(helperStart !== -1, 'Snippet must define the _msd_homes helper');
    const helperEnd = snippetContent.indexOf('; };', helperStart);
    assert.ok(helperEnd !== -1, 'Snippet _msd_homes helper must close');
    const homesBody = snippetContent.slice(helperStart, helperEnd);

    // The helper's claude arm reads `${CLAUDE_CONFIG_DIR:-$HOME/.claude}/...` —
    // the closing brace sits between `.claude` and the slash, so probe for the
    // arm text as it is actually spelled (same style as the codex probe below).
    const claudePos  = homesBody.indexOf('$HOME/.claude}/msd-core/bin/');
    const codexPos  = homesBody.indexOf('.codex}/msd-core/bin/');
    const errorPos   = snippetContent.indexOf('exit 1');

    assert.ok(claudePos  !== -1, 'Snippet must contain the claude config-home arm');
    assert.ok(codexPos  !== -1, 'Snippet must contain .codex}/msd-core/bin/ arm');
    assert.ok(errorPos   !== -1, 'Snippet must contain exit 1 hard-error');

    assert.ok(
      claudePos < codexPos,
      `Expected .claude probe (at ${claudePos}) before .codex probe (at ${codexPos}) among the config-home probes`,
    );
    assert.ok(
      helperEnd < errorPos,
      `Expected the config-home arm (ending at ${helperEnd}) before exit 1 (at ${errorPos})`,
    );
  });

  // ── (E) Propagation: workflow .md files using msd_run contain codex probe ─
  test('(E) all workflow .md files using msd_run contain the codex runtime home probe', () => {
    const CODEX_PROBE = '.codex}/msd-core/bin/';
    const files = collectWorkflowFiles();
    assert.ok(files.length > 0, 'expected at least one workflow .md file');

    const missing = [];
    for (const f of files) {
      const content = fs.readFileSync(f, 'utf8');
      const blocks = extractShellBlocks(content);
      const allBlockLines = blocks.flatMap((b) => b.lines);
      if (delegatesToResolverReference(content)) continue;
      const fileHasMsdRun = allBlockLines.some((l) => /\bmsd_run\b/.test(l));
      if (!fileHasMsdRun) continue;
      const allContent = allBlockLines.join('\n');
      if (!allContent.includes(CODEX_PROBE)) {
        missing.push(path.relative(WORKFLOWS_DIR, f));
      }
    }

    assert.deepStrictEqual(
      missing,
      [],
      `These workflow files use msd_run but are missing the codex runtime home probe ("${CODEX_PROBE}"). ` +
        `Run \`node scripts/sync-runtime-launcher.cjs\` to propagate:\n` +
        missing.join('\n'),
    );
  });
});
  });
}


// ────────────────────────────────────────────────────────────────────────
// Folded from tests/bug-3668-workflow-runtime-resolution.test.cjs — consolidation epic #1969 (B6 #1975)
// ────────────────────────────────────────────────────────────────────────
{
  const { describe: __foldDescribe } = require('node:test');
  __foldDescribe("folded:bug-3668-workflow-runtime-resolution (consolidation epic #1969 B6 #1975)", () => {
/**
 * Bug #3668: workflow resolver snippets must run from installed user projects.
 *
 * A user project normally does not contain msd-core/bin/msd-tools.cjs.
 * The snippets should still prefer RUNTIME_DIR for local/dev installs, then
 * fall back to the installed msd_run binary on PATH.
 */
'use strict';

const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const os = require('node:os');
const path = require('node:path');
const { runHook: runHookSeam } = require('./helpers/process-seam.cjs');
const { throwIfFailed } = require('./helpers/git-fixture.cjs');
const { readFileNormalized } = require('./helpers.cjs');

const WORKFLOW_PATH = path.join(__dirname, '..', 'msd-core', 'workflows', 'next.md');

/**
 * Extract the canonical runtime resolver snippet from next.md.
 *
 * Supports two forms:
 * - One-line form (canonical): the entire launcher is a single line starting with
 *   `_MSD_SHIM_NAME="msd-tools.cjs";` — return that line directly.
 * - Multi-line form (legacy): starts with a `# Runtime launcher:` comment or a
 *   `_MSD_SHIM_NAME=` line followed by separate MSD_TOOLS= and if/elif/else/fi
 *   lines — scan to the closing `fi`.
 */
function extractResolverSnippet() {
  const content = readFileNormalized(WORKFLOW_PATH);
  const lines = content.split('\n');

  // Find the canonical preamble — prefer _MSD_SHIM_NAME= line (handles both forms)
  let start = lines.findIndex((line) => /^_MSD_SHIM_NAME=/.test(line.trim()));
  if (start === -1) {
    // Fallback: canonical preamble comment (multi-line legacy form)
    start = lines.findIndex((line) =>
      /^\s*#\s*Runtime launcher:.*prefer local msd-tools\.cjs.*installed msd-tools on PATH/.test(line)
    );
  }
  if (start === -1) {
    // Last fallback: MSD_TOOLS= with RUNTIME_DIR
    start = lines.findIndex((line) => line.includes('MSD_TOOLS="${RUNTIME_DIR:-'));
  }
  assert.notEqual(
    start,
    -1,
    'next.md must contain the canonical runtime preamble ' +
    '(_MSD_SHIM_NAME= line, # Runtime launcher: comment, or MSD_TOOLS= line with RUNTIME_DIR)'
  );

  // One-line form: the entire launcher (including `if` and `fi`) is on a single line.
  // Detect by checking whether the start line contains a semicolon-separated `if` and `fi`.
  const startLine = lines[start].trim();
  if (/^_MSD_SHIM_NAME=.*;\s*if\s+\[.*\bfi$/.test(startLine)) {
    // Single-line canonical launcher — return it as-is
    return startLine;
  }

  // Multi-line form: scan forward from start to the closing `fi`, tracking if-depth
  let depth = 0;
  let end = -1;
  for (let i = start; i < lines.length; i++) {
    const t = lines[i].trim();
    if (/^if\s+/.test(t)) depth++;
    if (/^fi(\s|$)/.test(t)) {
      depth--;
      if (depth === 0) {
        end = i;
        break;
      }
    }
  }
  assert.notEqual(end, -1, 'runtime preamble must end with a closing `fi`');

  return lines.slice(start, end + 1).join('\n');
}

function makeTempDir() {
  return fs.mkdtempSync(path.join(os.tmpdir(), 'msd-runtime-resolution-'));
}

function runResolver({ cwd, runtimeDir, pathDir, home }) {
  // RUNTIME_DIR='' is INDISTINGUISHABLE from unset to the resolver's
  // ${RUNTIME_DIR:-$(git rev-parse --show-toplevel)} — an empty value silently
  // falls back to the real repo root and resolves its real install. Fail loudly
  // instead; every caller passes one.
  if (!runtimeDir) throw new Error('runResolver requires runtimeDir: an empty value resolves the real repo root');
  // #4834: callers reaching the config-home arm must pass an empty `home` —
  // with the homes arm ahead of PATH, an ambient $HOME install would win.
  const script = [
    'set -e',
    extractResolverSnippet(),
    'printf "MSD_TOOLS=%s\\n" "$MSD_TOOLS"',
    'msd_run query state.json',
  ].join('\n');

  // Consolidation #1969: POSIX-shell resolver. These tests create an
  // extension-less `msd_run` PATH stub (mode 0o755) and exec it via `bash -c`;
  // Windows Git Bash ignores the exec bit for extension-less PATH scripts, so the
  // suite is guarded to POSIX (matches the host suite's own bash -c guard).
  if (process.platform === 'win32') return '';

  const envOverrides = {
    PATH: `${pathDir}${path.delimiter}${process.env.PATH || ''}`,
    RUNTIME_DIR: runtimeDir,
  };
  if (home !== undefined) envOverrides.HOME = home;
  const r = runHookSeam('-c', [script], {
    interpreter: 'bash',
    cwd,
    env: snippetEnv(envOverrides),
  });
  throwIfFailed(r, 'bash -c <runtime resolver snippet>');
  return r.stdout;
}

function writeExecutable(file, content) {
  fs.mkdirSync(path.dirname(file), { recursive: true });
  fs.writeFileSync(file, content, { mode: 0o755 });
}

describe('bug-3668: workflow SDK resolver supports installed user projects', { skip: process.platform === 'win32' }, () => {
  test('falls back to installed msd_run when project-local runtime copy is absent', (t) => {
    // Bug #3668: when a user project has no local msd-core/bin/msd-tools.cjs,
    // the elif branch must resolve to the msd_run binary on PATH.
    // RUNTIME_DIR points to a dir that has no msd-tools.cjs.
    //
    // #3146: the PATH-fallback target changed from `msd-tools` to `msd_run`.
    // The predecessor package `get-shit-done-cc` publishes a colliding
    // `msd-tools` bin, so the launcher resolves `msd_run`, which only this
    // package publishes.
    const tmp = makeTempDir();
    const project = path.join(tmp, 'user-project');
    const runtimeNoLocal = path.join(tmp, 'runtime-no-local');
    const pathBin = path.join(tmp, 'bin');
    fs.mkdirSync(project, { recursive: true });
    fs.mkdirSync(runtimeNoLocal, { recursive: true });

    // Place msd_run stub on PATH (installed binary). #4834: the PATH arm is
    // identity-gated, so the stub must answer `runtime-identity --raw` the
    // way a real same-package install does — a bare stub now falls through
    // to the hard error (that side is pinned by (D2) above).
    // HOME is pinned to an empty fake home: #4834 evaluates the config-home
    // arm before PATH, and an ambient $HOME/.claude install would resolve
    // there first on machines that have one.
    writeExecutable(
      path.join(pathBin, 'msd_run'),
      '#!/bin/sh\n' +
        'if [ "$1" = "runtime-identity" ] && [ "$2" = "--raw" ]; then\n' +
        '  echo \'{"packageName":"@golem15/msd-core","version":"installed-test"}\'\n' +
        'else\n' +
        '  printf "installed:%s %s\\n" "$1" "$2"\n' +
        'fi\n',
    );
    const fakeHome = makeTempDir();
    t.after(() => cleanup(fakeHome));

    // NO msd-core/bin/msd-tools.cjs in runtimeNoLocal
    const output = runResolver({ cwd: project, runtimeDir: runtimeNoLocal, pathDir: pathBin, home: fakeHome });

    // MSD_TOOLS must have been reassigned to the PATH binary (not the missing .cjs)
    assert.match(output, /MSD_TOOLS=.+msd_run(?:\s|$)/m);
    // The PATH stub must have been invoked
    assert.match(output, /installed:query state\.json/);
  });

  test('preserves RUNTIME_DIR local msd-tools.cjs preference over PATH fallback', () => {
    // #3146: the PATH-fallback target changed from `msd-tools` to `msd_run`
    // (the predecessor package `get-shit-done-cc` publishes a colliding
    // `msd-tools` bin, so the launcher resolves `msd_run` instead), but the
    // point of this test is unchanged: a RUNTIME_DIR-local msd-tools.cjs must
    // win over the PATH stub, and the PATH stub must never be invoked.
    const tmp = makeTempDir();
    const project = path.join(tmp, 'user-project');
    const runtime = path.join(tmp, 'runtime');
    const pathBin = path.join(tmp, 'bin');
    fs.mkdirSync(project, { recursive: true });
    writeExecutable(path.join(pathBin, 'msd_run'), '#!/bin/sh\nprintf "path-installed:%s %s\\n" "$1" "$2"\n');
    writeExecutable(
      path.join(runtime, 'msd-core', 'bin', 'msd-tools.cjs'),
      '#!/usr/bin/env node\nconsole.log(`runtime:${process.argv[2]} ${process.argv[3]}`);\n',
    );

    const output = runResolver({ cwd: project, runtimeDir: runtime, pathDir: pathBin });

    // Normalize separators so the assertion works on Windows (Git bash emits POSIX paths)
    const norm = output.replace(/\\/g, '/');
    // The resolved bin is the RUNTIME_DIR local runtime (suffix /msd-core/bin/msd-tools.cjs)
    // Use .+ instead of \S* to handle paths with spaces (e.g. /Volumes/Mini Me/...)
    assert.match(norm, /MSD_TOOLS=.+\/msd-core\/bin\/msd-tools\.cjs(?:\s|$)/m);
    assert.match(output, /runtime:query state\.json/);
    assert.doesNotMatch(output, /path-installed:query state\.json/);
  });
});
  });
}


// ────────────────────────────────────────────────────────────────────────
// Folded from tests/bug-444-resolver-local-claude-install.test.cjs — consolidation epic #1969 (B6 #1975)
// ────────────────────────────────────────────────────────────────────────
{
  const { describe: __foldDescribe } = require('node:test');
  __foldDescribe("folded:bug-444-resolver-local-claude-install (consolidation epic #1969 B6 #1975)", () => {
'use strict';
/**
 * Regression test for bug #444: msd_run resolver must probe
 * <repo-root>/.claude/msd-core/bin/msd-tools.cjs (the project-local
 * `--claude --local` install location) BEFORE checking $HOME/.claude and PATH.
 *
 * Asserts:
 * (A) The canonical snippet file contains the repo-local .claude/ check.
 * (B) Behavioral: when RUNTIME_DIR/msd-core/bin/ misses, but a stub
 *     exists ONLY at <repo-root>/.claude/msd-core/bin/msd-tools.cjs,
 *     msd_run resolves to that stub (no PATH stub, no HOME stub).
 * (C) Precedence: repo-local .claude/ wins over $HOME/.claude/ when both exist.
 */

// allow-test-rule: structural-regression-guard (see #444)
// structural/behavioral regression for the repo-local .claude/ install
// arm in the msd_run launcher snippet -- asserts literal substring presence and exercises
// the bash resolution path via execFileSync; there is no typed IR for "snippet contains arm X".

const { describe, test } = require('node:test');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
const os = require('node:os');
const { cleanup } = require('./helpers.cjs');

const WORKFLOWS_DIR = path.join(__dirname, '..', 'msd-core', 'workflows');
const SNIPPET_FILE = path.join(WORKFLOWS_DIR, '_runtime-launcher.snippet.sh');


// The probe string that must appear in the snippet for the new repo-local check.
// The snippet uses _MSD_RUNTIME_ROOT as the intermediate variable.
const LOCAL_CLAUDE_PROBE = '_MSD_RUNTIME_ROOT}/.claude/msd-core/bin/';

/**
 * Return the full system PATH with extra bin dirs prepended. Deliberately does
 * NOT filter msd_run — unlike buildIsolatedPath() above, which does.
 *
 * The isolation here comes from resolution ORDER, not from the PATH contents.
 * Callers give RUNTIME_DIR a .claude/msd-core/bin/ stub, and the resolver
 * checks RUNTIME_DIR/msd-core/bin/ then RUNTIME_DIR/.claude/msd-core/bin/
 * before it ever reaches `command -v msd_run`, so an ambient msd_run on PATH
 * is unreachable for these tests. Keeping PATH whole is what keeps node
 * resolvable when node co-locates with a global msd_run (e.g. /opt/homebrew/bin).
 *
 * That makes this helper safe ONLY for tests whose stub wins before the PATH
 * arm. Any test that must prove the PATH arm itself misses needs
 * buildIsolatedPath(), which excludes msd_run-bearing directories outright.
 *
 * For B and C: the stub sits at RUNTIME_DIR/.claude/..., picked at elif-1.
 */
function makeIsolatedPath(extraBefore = []) {
  // Keep full system PATH so node remains accessible.
  // Tests B and C exercise only the RUNTIME_DIR/.claude arm which fires
  // before command -v msd_run — so the real msd_run on PATH is never reached.
  const systemPaths = (process.env.PATH || '/usr/bin:/bin').split(path.delimiter);
  return [...extraBefore, ...systemPaths].join(path.delimiter);
}

describe('bug-444: resolver finds repo-local .claude install', () => {
  // --- (A) Snippet contains the repo-local .claude arm ----------------------
  test('(A) snippet file contains the repo-local .claude/ check arm before $HOME/.claude/', () => {
    const content = fs.readFileSync(SNIPPET_FILE, 'utf8');

    // Must contain the repo-local .claude/ check (via _MSD_RUNTIME_ROOT variable)
    const localClaudeIdx = content.indexOf(LOCAL_CLAUDE_PROBE);
    assert.ok(
      localClaudeIdx !== -1,
      `_runtime-launcher.snippet.sh must contain the repo-local .claude check ` +
        `('${LOCAL_CLAUDE_PROBE}'). ` +
        `Found snippet content:\n${content.trim()}`,
    );

    // Must still contain the $HOME/.claude fallback arm (#1865: now carried as
    // the ${CLAUDE_CONFIG_DIR:-$HOME/.claude} fallback, so match the stem).
    const homeClaudeIdx = content.indexOf('$HOME/.claude');
    assert.ok(
      homeClaudeIdx !== -1,
      `Snippet must still contain the $HOME/.claude fallback arm.`,
    );

    // #1865: the Claude arm must honor CLAUDE_CONFIG_DIR (the installer writes
    // there when it is set), with $HOME/.claude as the fallback.
    assert.ok(
      content.includes('${CLAUDE_CONFIG_DIR:-$HOME/.claude}/msd-core/bin/'),
      `Snippet's Claude arm must honor CLAUDE_CONFIG_DIR via \${CLAUDE_CONFIG_DIR:-$HOME/.claude}.`,
    );

    // Repo-local check must run BEFORE the config-home arm (local overrides
    // global). #4834 folded the $HOME/.claude probe into the _msd_homes()
    // helper defined ahead of the chain, so raw first-occurrence positions no
    // longer express arm order — compare the chain positions instead: the
    // repo-local `if _msd_at` arm must precede the `elif _msd_homes` arm.
    // Behavioral precedence (repo-local wins when both exist) is pinned by
    // this suite's (C).
    const chainStartIdx = content.indexOf('if _msd_at "${_MSD_RUNTIME_ROOT}/msd-core/bin/');
    const homesArmIdx = content.indexOf('elif _msd_homes;');
    assert.ok(chainStartIdx !== -1, 'Snippet must contain the repo-local if _msd_at arm');
    assert.ok(homesArmIdx !== -1, 'Snippet must contain the elif _msd_homes config-home arm');
    assert.ok(
      chainStartIdx < homesArmIdx,
      `Repo-local .claude/ arm (idx ${chainStartIdx}) must run BEFORE ` +
        `the config-home arm (idx ${homesArmIdx}) in the elif chain (local overrides global).`,
    );
  });

  // --- (B) Behavioral: repo-local .claude stub resolved when only location ---
  test('(B) msd_run resolves repo-local .claude/msd-core/bin/ stub when no other locations present', () => {
    // Create a fake repo root with a stub ONLY at .claude/msd-core/bin/msd-tools.cjs
    // NO stub at msd-core/bin/, NOT on PATH, NOT in $HOME/.claude
    const fakeRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-444-root-'));
    const fakeHome = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-444-home-'));
    const noToolsBin = path.join(fakeRoot, 'nobin');
    fs.mkdirSync(noToolsBin, { recursive: true });

    try {
      // Create the stub at the repo-local .claude path ONLY
      const localClaudeBinDir = path.join(fakeRoot, '.claude', 'msd-core', 'bin');
      fs.mkdirSync(localClaudeBinDir, { recursive: true });
      const stubPath = path.join(localClaudeBinDir, 'msd-tools.cjs');
      fs.writeFileSync(
        stubPath,
        '#!/usr/bin/env node\nconsole.log("LOCAL_CLAUDE_STUB:" + process.argv.slice(2).join(","));\n',
      );
      fs.chmodSync(stubPath, 0o755);

      const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
      // Set RUNTIME_DIR to fakeRoot so the resolver uses it as the repo root.
      const scriptContent =
        `unset MSD_TOOLS\n` +
        `export RUNTIME_DIR=${JSON.stringify(fakeRoot)}\n` +
        `export HOME=${JSON.stringify(fakeHome)}\n` +
        snippet +
        `\nprintf "MSD_TOOLS=%s\\n" "$MSD_TOOLS"\n` +
        `msd_run ping test\n`;

      const scriptPath = path.join(fakeRoot, 'test-local-claude.sh');
      fs.writeFileSync(scriptPath, scriptContent);

      // Keep node in PATH (needed to run the .cjs stub); the .claude arm
      // resolves before the PATH arm, so msd_run is never probed here.
      const isolatedPath = makeIsolatedPath([noToolsBin]);

      const stdout = runBashFile(scriptPath, {
        env: { PATH: isolatedPath, HOME: fakeHome },
      });

      // Must have resolved to the local .claude stub
      const normStdout = stdout.replace(/\\/g, '/');
      assert.ok(
        normStdout.includes('.claude/msd-core/bin/msd-tools.cjs'),
        `Expected MSD_TOOLS to resolve to .claude/msd-core/bin/msd-tools.cjs, got:\n${stdout.trim()}`,
      );
      // The stub must have been invoked with the correct arguments
      assert.ok(
        stdout.includes('LOCAL_CLAUDE_STUB:ping,test'),
        `Expected stub output "LOCAL_CLAUDE_STUB:ping,test" but got:\n${stdout.trim()}`,
      );
    } finally {
      cleanup(fakeRoot);
      cleanup(fakeHome);
    }
  });

  // --- (C) Precedence: repo-local .claude/ wins over $HOME/.claude/ ----------
  test('(C) repo-local .claude/ install wins over $HOME/.claude/ when both exist', () => {
    const fakeRoot = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-444-prec-root-'));
    const fakeHome = fs.mkdtempSync(path.join(os.tmpdir(), 'msd-444-prec-home-'));
    const noToolsBin = path.join(fakeRoot, 'nobin');
    fs.mkdirSync(noToolsBin, { recursive: true });

    try {
      // Stub at repo-local .claude/ path (should be picked)
      const localClaudeBinDir = path.join(fakeRoot, '.claude', 'msd-core', 'bin');
      fs.mkdirSync(localClaudeBinDir, { recursive: true });
      const localStubPath = path.join(localClaudeBinDir, 'msd-tools.cjs');
      fs.writeFileSync(
        localStubPath,
        '#!/usr/bin/env node\nconsole.log("LOCAL_WINS:" + process.argv.slice(2).join(","));\n',
      );
      fs.chmodSync(localStubPath, 0o755);

      // Stub at $HOME/.claude/ path (must NOT be picked)
      const homeClaudeBinDir = path.join(fakeHome, '.claude', 'msd-core', 'bin');
      fs.mkdirSync(homeClaudeBinDir, { recursive: true });
      const homeStubPath = path.join(homeClaudeBinDir, 'msd-tools.cjs');
      fs.writeFileSync(
        homeStubPath,
        '#!/usr/bin/env node\nconsole.log("HOME_WINS:" + process.argv.slice(2).join(","));\n',
      );
      fs.chmodSync(homeStubPath, 0o755);

      const snippet = fs.readFileSync(SNIPPET_FILE, 'utf8');
      const scriptContent =
        `unset MSD_TOOLS\n` +
        `export RUNTIME_DIR=${JSON.stringify(fakeRoot)}\n` +
        `export HOME=${JSON.stringify(fakeHome)}\n` +
        snippet +
        `\nprintf "MSD_TOOLS=%s\\n" "$MSD_TOOLS"\n` +
        `msd_run check\n`;

      const scriptPath = path.join(fakeRoot, 'test-precedence.sh');
      fs.writeFileSync(scriptPath, scriptContent);

      const isolatedPath = makeIsolatedPath([noToolsBin]);

      const stdout = runBashFile(scriptPath, {
        env: { PATH: isolatedPath, HOME: fakeHome },
      });

      assert.ok(
        stdout.includes('LOCAL_WINS:check'),
        `Expected repo-local .claude stub to be invoked ("LOCAL_WINS:check") ` +
          `but got:\n${stdout.trim()}`,
      );
      assert.ok(
        !stdout.includes('HOME_WINS'),
        `Expected $HOME/.claude stub NOT to be invoked, but got:\n${stdout.trim()}`,
      );
    } finally {
      cleanup(fakeRoot);
      cleanup(fakeHome);
    }
  });
});
  });
}