fix(14): WR-05 import every key of an object-shaped models repeater
A repeater saved with non-sequential keys was read only at keys 0 to len-1, so a model at a higher key was dropped while the import reported success and refused to run again. Every key is now read, numeric keys in ascending order.
This commit is contained in:
@@ -151,6 +151,22 @@ func TestGolemImportCommand(t *testing.T) {
|
||||
if err := db.Exec(`DELETE FROM golem15_golem_models`).Error; err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
// A repeater whose middle item was deleted keeps every remaining key,
|
||||
// in numeric order (WR-05).
|
||||
sparse := write("sparse.json", `{"models":{"10":{"name":"Ten","model":"m10","api_key":"k10"},"0":{"name":"Zero","model":"m0","api_key":"k0"},"2":{"name":"Two","model":"m2","api_key":"k2"}}}`)
|
||||
if out, err := run(app, sparse); err != nil || !strings.Contains(out, "Imported 3 AI models.") {
|
||||
t.Fatalf("sparse import = %q %v", out, err)
|
||||
}
|
||||
rows = nil
|
||||
if err := db.Order("sort_order").Find(&rows).Error; err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if len(rows) != 3 || rows[0].Name != "Zero" || rows[1].Name != "Two" || rows[2].Name != "Ten" {
|
||||
t.Fatalf("sparse rows = %+v", rows)
|
||||
}
|
||||
if err := db.Exec(`DELETE FROM golem15_golem_models`).Error; err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
for name, body := range map[string]string{"empty.json": `{"models":[]}`, "null.json": `{"models":null}`} {
|
||||
if out, err := run(app, write(name, body)); err != nil || !strings.Contains(out, "no AI models") {
|
||||
t.Errorf("%s = %q %v", name, out, err)
|
||||
|
||||
Reference in New Issue
Block a user