golem15/sm-seo-plugin
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: the CSV round trip keeps values that start with an apostrophe before a formula character (WR-21)

Browse Source 
escapeCell left '=x as it was and unescapeCell then dropped its
apostrophe on import. A value of apostrophes followed by a formula
character now gets one more apostrophe on export, and the import drops
exactly one, so unescapeCell is the inverse of escapeCell.
This commit is contained in:
Jakub Zych
2026-10-27 15:39:23 +01:00
parent 882d4ee05f
commit ed2d919aee
3 changed files with 18 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
classes/csv_test.go
View File

@@ -23,6 +23,9 @@ func TestCSV(t *testing.T) {
{"/tab", "/x", "\tlead"},
{"/cr", "/x", "\rlead"},
{"/ok", "/x", "a=b"},
{"/ap", "/x", "'=x"},
{"/ap2", "/x", "''-)"},
{"/ap3", "/x", "'plain"},
}
t.Run("round trip with each delimiter", func(t *testing.T) {
@@ -63,7 +66,7 @@ func TestCSV(t *testing.T) {
if lines[1] != "'=1+1" || lines[2] != "'+x" || lines[3] != "'-x" || lines[4] != "'@x" || lines[5] != "a=b" {
t.Fatalf("export = %q", lines)
}
for in, want := range map[string]string{"'=x": "=x", "'+x": "+x", "'abc": "'abc", "''=x": "''=x", "plain": "plain", "'": "'"} {
for in, want := range map[string]string{"'=x": "=x", "'+x": "+x", "'abc": "'abc", "''=x": "'=x", "plain": "plain", "'": "'"} {
if got := unescapeCell(in); got != want {
t.Errorf("unescapeCell(%q) = %q, want %q", in, got, want)
}