fix(17): CR-01 refuse non-http sitemap URLs on save, import and output
A url item stored as javascript://%0aalert(1)%0a//x passed Url::to and reached <loc>, which sitemap.xsl renders as a link on the site origin. - The definitions form refuses, per row, a url that is not a path or an http(s) URL (classes.AllowedItemURL) and a urlPattern that is not a path (signpost.ValidItemPattern), keyed data.<i>.url / .urlPattern. - Generator.addItem drops a loc or alternate that is not http(s). - sitemap:import-winter drops such url items and clears such patterns with a report line; sitemap:import refuses such an entry.
This commit is contained in:
@@ -531,3 +531,36 @@ func URLPath(raw string) string {
|
||||
}
|
||||
return u.path
|
||||
}
|
||||
|
||||
// schemePrefix matches a URL that starts with a scheme and its colon.
|
||||
var schemePrefix = regexp.MustCompile(`^[A-Za-z][A-Za-z0-9+.\-]*:`)
|
||||
|
||||
// AllowedItemURL reports whether a url item's address may be stored: empty,
|
||||
// a path (relative or starting with a single "/"), or an absolute http or
|
||||
// https URL. Any other scheme (javascript:, data:, mailto: and the like), a
|
||||
// protocol-relative "//host" or "/\host", a bare fragment, surrounding
|
||||
// whitespace and control characters are refused. Url::to keeps any URL
|
||||
// FILTER_VALIDATE_URL accepts, so without this a javascript: URL reached
|
||||
// <loc>, which sitemap.xsl renders as a link.
|
||||
func AllowedItemURL(u string) bool {
|
||||
if u == "" {
|
||||
return true
|
||||
}
|
||||
if strings.TrimSpace(u) != u || strings.ContainsFunc(u, func(r rune) bool { return r < 0x20 || r == 0x7f }) {
|
||||
return false
|
||||
}
|
||||
if httpURL(u) {
|
||||
return true
|
||||
}
|
||||
if schemePrefix.MatchString(u) || u[0] == '#' || u[0] == '\\' {
|
||||
return false
|
||||
}
|
||||
return !strings.HasPrefix(u, "//") && !strings.HasPrefix(u, `/\`)
|
||||
}
|
||||
|
||||
// httpURL reports whether u starts with http:// or https://
|
||||
// (case-insensitive).
|
||||
func httpURL(u string) bool {
|
||||
lower := strings.ToLower(u)
|
||||
return strings.HasPrefix(lower, "http://") || strings.HasPrefix(lower, "https://")
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user