From 09fd4d071202fbf63db306cbd140cb78215c14e5 Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Wed, 21 Oct 2026 02:04:31 +0200 Subject: [PATCH] docs(phase-19.8): record post-research decisions D-23..D-30 --- .../19.8-console-commands-overhaul/19.8-CONTEXT.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.planning/phases/19.8-console-commands-overhaul/19.8-CONTEXT.md b/.planning/phases/19.8-console-commands-overhaul/19.8-CONTEXT.md index f6b46d66..b969af37 100644 --- a/.planning/phases/19.8-console-commands-overhaul/19.8-CONTEXT.md +++ b/.planning/phases/19.8-console-commands-overhaul/19.8-CONTEXT.md @@ -127,6 +127,16 @@ The phase was added as Phase 32 on 2026-10-20 and renumbered to 19.8 on 2026-10- - **D-21:** The Artisan checklist applies where it fits, not uniformly: `--force` confirmation on destructive commands, `--pretend` on migrate-like and bulk writers, `--json` on commands whose output scripts read (lists, tokens, status), progress for bulk loops. The plan records each command's checklist result so the gaps are explicit. - **D-22:** One-shot commands end with a result line and a meaningful exit code. +### Settled after research (2026-10-21) +- **D-23:** Amends D-11. The `http` request log records the **route pattern** (e.g. `/share/{token}`), never the raw path, because share/invite tokens travel in paths. It is on by default at INFO (method, route pattern, status, duration, request id), and `components.http: warn` silences it. The `http.access_log` default flips accordingly. +- **D-24:** The sweep also covers `sm-golem-plugin` and `sm-feedback-plugin`, in addition to the D-20 list. +- **D-25:** `summer dev` starts the application binary with `serve` (today it runs the binary with no arguments, which prints help and exits). This is the one logic fix allowed in the sweep, together with the D-07 shutdown report for `dev`. +- **D-26:** Release order: plan 3 reaches a human checkpoint before tagging and pushing the framework (plus the same-day changelog post). Plugin commits and pushes, then app pointer bumps, follow after the go-ahead. Nothing is pushed or tagged without it. +- **D-27:** `-q` suppresses decoration and info, but still prints the data a command exists to produce (tokens, keys, `--json` output) and errors. +- **D-28:** Production confirmation prompts appear only on an interactive TTY. Non-TTY runs (deploys over SSH) proceed as they do today and never block. Existing `--force` meanings (importers, `pg:update-currencies`: "replace existing data") are not changed; where `--force` is already taken, confirmation is skipped with `-n`. +- **D-29:** A graceful Ctrl+C/SIGTERM shutdown of `serve`/`dev`/`queue:work` exits 0. A drain error exits 1. +- **D-30:** SSU's multi-select selector is not ported in this phase (no command needs it). Port spinner, process view, progress, single selector and confirm. + ### Claude's Discretion - Exact palette, symbols and spacing, as long as they match SSU's styles and stay consistent between `list`, help, widgets and log lines. - Console handler choice inside `diary` (lipgloss-styled handler of our own, or `charmbracelet/log`), to be settled in the dependency decision note.