From 0b0cae5b5347baa6efd01dfd389a2a94b7f65887 Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Fri, 23 Oct 2026 20:39:37 +0200 Subject: [PATCH] docs(19.7): defer the remaining lane B re-review items --- .../19.7-generic-mcp-module/deferred-items.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.planning/phases/19.7-generic-mcp-module/deferred-items.md b/.planning/phases/19.7-generic-mcp-module/deferred-items.md index 148cfc67..4ac642d8 100644 --- a/.planning/phases/19.7-generic-mcp-module/deferred-items.md +++ b/.planning/phases/19.7-generic-mcp-module/deferred-items.md @@ -199,6 +199,19 @@ was changed by the plan that recorded it. that token keeps its stream until its next request or re-check. Same shape as before plan 07. Fix: call the same helper from the command after its transaction. + **Re-review (RB-IN-03):** kept deferred. Calling `fireTokenRevoked` from + the command is not enough: the command runs in its own process, which + mounts no MCP endpoint, so no pier listener receives the event and nothing + reaches the store a running server reads. Closing it needs the command to + publish into pier's store directly (a cross-module seam). 4d7eb9d + documents in the cabana README that only the My account revoke fires the + event. +- RB-IN-04 optional narrowing: a focused widget host also mutes Esc, / and ? (found in the gap-closure re-review) + status: open + **What:** 89b85f5 documents the trade-off in `admin/src/app/hotkeys.ts`. + The optional narrowing to plugin field types (a `data-field-type` marker) + was not made: a `type: widget` element with an input in a closed shadow + root would then let Esc leave the form while the admin types in it. - OIDC grants on a ban or a password reset (decided during 19.7-08) status: resolved **What:** the user decided on 2026-10-23 that a ban, a password reset, an