From 0bbbce6d27ab9bb1bc3081d2ee0279341ecc8758 Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Tue, 29 Sep 2026 10:10:45 +0200 Subject: [PATCH] docs(10.1): record code review disposition --- .../10.1-REVIEW-DISPOSITION.md | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/.planning/phases/10.1-runtime-admin-extension-point/10.1-REVIEW-DISPOSITION.md b/.planning/phases/10.1-runtime-admin-extension-point/10.1-REVIEW-DISPOSITION.md index 5fb9f3c..c9ecdf2 100644 --- a/.planning/phases/10.1-runtime-admin-extension-point/10.1-REVIEW-DISPOSITION.md +++ b/.planning/phases/10.1-runtime-admin-extension-point/10.1-REVIEW-DISPOSITION.md @@ -5,31 +5,31 @@ titles: json findings: - id: CR-01 severity: critical - disposition: open + disposition: fixed title: "A fractional, exponent or overflowing number for an integer column is a 500, not a validation error" - id: WR-01 severity: warning - disposition: open + disposition: fixed title: "A late schema response re-activates the previous controller's stylesheets over the current view" - id: WR-02 severity: warning - disposition: open + disposition: fixed title: "Plugin stylesheets stay enabled on views that are not controller views" - id: WR-03 severity: warning - disposition: open + disposition: fixed title: "The partial view-model guard (T-10.1-09) is shallow and easy to bypass" - id: WR-04 severity: warning - disposition: open + disposition: fixed title: "`isJSONScalar` trusts `reflect.Kind`, not the JSON the value encodes to" - id: WR-05 severity: warning - disposition: open + disposition: fixed title: "Form schema shows widgets the admin is not allowed to run" - id: WR-06 severity: warning - disposition: open + disposition: fixed title: "The widget action route ignores the field's `context`" - id: IN-01 severity: info @@ -59,22 +59,22 @@ findings: severity: info disposition: open title: "The `compilePartials` escape check has false positives" -open: 14 +open: 7 total: 14 -recorded: 2026-09-29T01:29:52.513Z +recorded: 2026-09-29T08:10:44.662Z --- # Phase 10.1: Code Review Disposition | Finding | Severity | Disposition | Source | |---------|----------|-------------|--------| -| CR-01 | critical | open | - | -| WR-01 | warning | open | - | -| WR-02 | warning | open | - | -| WR-03 | warning | open | - | -| WR-04 | warning | open | - | -| WR-05 | warning | open | - | -| WR-06 | warning | open | - | +| CR-01 | critical | fixed | 10.1-REVIEW-FIX.md | +| WR-01 | warning | fixed | 10.1-REVIEW-FIX.md | +| WR-02 | warning | fixed | 10.1-REVIEW-FIX.md | +| WR-03 | warning | fixed | 10.1-REVIEW-FIX.md | +| WR-04 | warning | fixed | 10.1-REVIEW-FIX.md | +| WR-05 | warning | fixed | 10.1-REVIEW-FIX.md | +| WR-06 | warning | fixed | 10.1-REVIEW-FIX.md | | IN-01 | info | open | - | | IN-02 | info | open | - | | IN-03 | info | open | - |