From 0c24e0e656c7bbb218e97abeeb8b1ccc43bbc97b Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Mon, 16 Nov 2026 08:19:09 +0100 Subject: [PATCH] test(35): re-verify after quick 261115-cha - 23/23 truths, human_needed (inbox check) --- .../35-VERIFICATION.md | 288 +++++++++--------- 1 file changed, 136 insertions(+), 152 deletions(-) diff --git a/.planning/phases/35-mail-templates-and-layouts-editor/35-VERIFICATION.md b/.planning/phases/35-mail-templates-and-layouts-editor/35-VERIFICATION.md index 6d0791e7..a130dc3c 100644 --- a/.planning/phases/35-mail-templates-and-layouts-editor/35-VERIFICATION.md +++ b/.planning/phases/35-mail-templates-and-layouts-editor/35-VERIFICATION.md @@ -1,8 +1,8 @@ --- phase: 35-mail-templates-and-layouts-editor -verified: 2026-11-14T17:43:56Z +verified: 2026-11-16T07:16:15Z status: human_needed -score: 22/22 must-haves verified +score: 23/23 must-haves verified covered_files: - .planning/phases/35-mail-templates-and-layouts-editor/35-01-PLAN.md - .planning/phases/35-mail-templates-and-layouts-editor/35-01-SUMMARY.md @@ -24,6 +24,8 @@ covered_files: - .planning/phases/35-mail-templates-and-layouts-editor/35-09-SUMMARY.md - .planning/quick/261114-p5m-fix-cr-02-residual-quoted-end-tags-in-ra/261114-p5m-PLAN.md - .planning/quick/261114-p5m-fix-cr-02-residual-quoted-end-tags-in-ra/261114-p5m-SUMMARY.md + - .planning/quick/261115-cha-let-a-mail-template-use-another-plugin-s/261115-cha-PLAN.md + - .planning/quick/261115-cha-let-a-mail-template-use-another-plugin-s/261115-cha-SUMMARY.md - admin/openapi/admin.json - admin/package-lock.json - admin/package.json @@ -184,6 +186,7 @@ covered_files: - modules/postcard/editor_test.go - modules/postcard/inline.go - modules/postcard/inline_test.go + - modules/postcard/layout_ref_test.go - modules/postcard/layouts_test.go - modules/postcard/locale_postgres_test.go - modules/postcard/locale_test.go @@ -207,175 +210,171 @@ covered_files: - modules/surf/serve.go - modules/surf/store_lookup_test.go - scripts/check-phase35.sh -covered_digest: "v2:sha256:0946027fa67264b1d8b7f9fe4210f2674311daed071f1a2bd629ef1b91566579" +covered_digest: "v2:sha256:b413e9cd2855f94de7e18bdd280605c598352dbcbe3c3d75eaa4160791f5a57d" behavior_unverified: 0 overrides_applied: 0 re_verification: - previous_status: gaps_found - previous_score: 21/22 + previous_status: human_needed + previous_score: 22/22 + stale_reason: "covered_changed: quick 261115-cha (1fb42542, b8487b02) changed modules/postcard/templates.go, mailer.go (comment), README.md, docs/services/mail.md and added layout_ref_test.go" gaps_closed: - - "CR-02 residual (truth 18): a raw-text end tag or '-->' inside a quoted attribute no longer hides the rest of the tag. unsafeMarkupAt now runs a second, quote-aware tag reading (unsafeTagReading: NextIsNotRawText after raw-text start tags, '` inside an attribute) is now refused (`refuse/conditional_comment_end_in_attr`), and 35-REVIEW-DISPOSITION.md frontmatter now marks CR-01/CR-02/WR-01 `fixed` (d8137c17). +Closed since the previous report: +- The over-refusal advisory: the human accepted the tag-reading risk in UAT row 12, and `--consumers` passes after 261114-p5n. +- The "rows 1 and 8 still read issue" advisory: row 8 passed on the re-test, and row 1's remaining issue is G-35-9's plugin part. ### Required Artifacts | Artifact | Expected | Status | Details | | -------- | -------- | ------ | ------- | -| `modules/postcard/safety.go` | `unsafeMarkupAt` = depth guard, `unsafeHTMLReading` (old loop), `unsafeTagReading` (quote-aware); shared `unsafeAttrs` | ✓ VERIFIED | Read in full diff. The tag reading tokenizes a same-length copy with `` inside | -------- | ------- | ------ | ------ | | vet | `go vet ./...` | clean | ✓ PASS | | Full short suite (once) | `go test -short -count=1 ./...` | exit 0, 47 packages ok | ✓ PASS | -| postcard named tests | `go test -short ./modules/postcard -run '^(TestURLSchemeCheck\|TestSiteNameSend\|TestUnsafeSiteNameDropped\|TestUnsafeText\|TestFooterSiteNameLiteral\|TestInlineUnsafeOutput\|TestMailSafetySmoke\|TestInlineCSS\|TestInlineFailure\|TestOverride\|TestFallback\|TestTemplateFor\|TestSendLocaleFallback\|TestBuiltinLayoutsLogo\|TestHeaderFooterPartials\|TestButtonPartial\|TestSiteName)$' -v` | 17 PASS | ✓ PASS | -| New CR-02 residual subtests | `go test -short ./modules/postcard -run '^TestURLSchemeCheck$' -v` | 23 matching subtests PASS, 0 FAIL in the whole test | ✓ PASS | -| postcard Docker smoke | `go test -count=1 ./modules/postcard -run '^TestMailOverrideSmoke$' -v` | 11 subtests PASS incl. `fallback`, `locale_fallback` | ✓ PASS | -| cabana Postgres (Docker) | `go test -count=1 ./modules/cabana -run '^(TestMailSiteNameSafety\|TestMailBrandSiteName\|TestMailLocaleGroups\|TestMailLayoutInlineOptOut)$' -v` | 4 PASS | ✓ PASS | -| Gate stages | `check-phase35.sh --self-test`, `--docs`, `--marker`, `--additive`, `--consumers` | all exit 0 | ✓ PASS | -| Probe 1 (re-run) | `go test -short -overlay .../probe/overlay.json ./modules/postcard -run TestZZ -v` | CR-01 sends `err=`; CR-02 payloads refused; noscript layout falls back | ✓ PASS | -| Probe 2 (re-run, the open gap) | `-overlay .../probe/overlay2.json -run 'TestZZV2'` | `validateHTML` refuses 8/8 (was 0/8); noscript ×2 and svg/style layouts `fallback=true` with inlining on and off; svg title/textarea sent as escaped text. Body overrides carry no raw HTML (goldmark) | ✓ PASS (gap closed) | -| Probe 2 `liveJS=true` lines (svg title/textarea, opt-out) | sent HTML `<a title="" href="javascript:alert(1)">x` | The probe's regex matches a substring. The text after `` is a text node, and no `