docs(19.6): record code review disposition and the WR-05 todo
This commit is contained in:
@@ -0,0 +1,16 @@
|
||||
---
|
||||
title: Require re-authentication to change two-factor factors (review finding WR-05)
|
||||
date: 2026-10-26
|
||||
priority: normal
|
||||
area: sm-mfa-plugin
|
||||
g15office: krt3vrts
|
||||
---
|
||||
|
||||
Phase 19.6 code review WR-05 (19.6-REVIEW.md, 19.6-REVIEW-FIX.md): changing second factors needs only a session JWT. PHP and the frontends send no password on `DELETE /2fa/totp`, `DELETE /2fa/email`, `DELETE /2fa/webauthn/{id}`, `POST /2fa/totp/confirm` (when TOTP is already on) and `POST /2fa/webauthn/register`, so a stolen session can change factors while it lasts.
|
||||
|
||||
Partial mitigation shipped in sm-mfa-plugin v0.1.2 (463c750): a password change demotes passkeys to second-factor keys, so a passkey registered from a stolen session does not outlive the victim's password change.
|
||||
|
||||
Full fix (a contract change, user deferred it on 2026-10-26):
|
||||
- Require a `password` field (or a current factor) on those routes, refused with the existing 403 `{"error":"Password confirmation required."}` and counted in the login throttle like the recovery-code routes (WR-06, 0a08070).
|
||||
- Update the frontends that call them (sm-demo-app's vue-demo-app `pages/account/security.vue` and any app frontend) to ask for the password.
|
||||
- Release sm-mfa-plugin as a minor/patch together with the frontend change, and bump the apps in separate commits.
|
||||
Reference in New Issue
Block a user