From 19f2e27500af75fce60be565adb9b8c85ee88e63 Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Tue, 6 Oct 2026 16:36:35 +0200 Subject: [PATCH] docs(14.2.1): record code review disposition after gap closure --- .../14.2.1-REVIEW-DISPOSITION.md | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) create mode 100644 .planning/phases/14.2.1-translate-plugin/14.2.1-REVIEW-DISPOSITION.md diff --git a/.planning/phases/14.2.1-translate-plugin/14.2.1-REVIEW-DISPOSITION.md b/.planning/phases/14.2.1-translate-plugin/14.2.1-REVIEW-DISPOSITION.md new file mode 100644 index 0000000..26cbe17 --- /dev/null +++ b/.planning/phases/14.2.1-translate-plugin/14.2.1-REVIEW-DISPOSITION.md @@ -0,0 +1,58 @@ +--- +phase: 14.2.1 +review: 14.2.1-REVIEW.md +titles: json +findings: + - id: CR-01 + severity: critical + disposition: fixed + title: "Admin ML fields never surface enabled locales on create, load, or save" + - id: WR-01 + severity: warning + disposition: deferred + title: "Default-locale flip is racy; ML lift reads default outside the save transaction" + - id: WR-02 + severity: warning + disposition: fixed + title: "Relation-child saves drop nested ML maps" + - id: WR-03 + severity: warning + disposition: deferred + title: "Enabled locale code backend strips the admin prefix for every request" + - id: IN-01 + severity: info + disposition: deferred + title: "URL-prefix locale switch sets cookies on GET (no CSRF)" + - id: IN-02 + severity: info + disposition: deferred + title: "prefixDefaultLocale is configured and never read" + - id: IN-03 + severity: info + disposition: deferred + title: "Locale form shows is_default but Fillable cannot set it" + - id: IN-04 + severity: info + disposition: deferred + title: "Markdown SPA preview is source text, not RenderMarkdown" +open: 0 +total: 8 +recorded: 2026-10-06T15:00:00Z +--- + +# Phase 14.2.1: Code Review Disposition + +| Finding | Severity | Disposition | Source | +|---------|----------|-------------|--------| +| CR-01 | critical | fixed | gap-closure 14.2.1-05; confirmed closed in 2026-10-06 re-review | +| WR-01 | warning | deferred | out of gap-closure scope (not in current review) | +| WR-02 | warning | fixed | gap-closure 14.2.1-06; confirmed closed in 2026-10-06 re-review | +| WR-03 | warning | deferred | out of gap-closure scope (not in current review) | +| IN-01 | info | deferred | out of gap-closure scope (not in current review) | +| IN-02 | info | deferred | out of gap-closure scope (not in current review) | +| IN-03 | info | deferred | out of gap-closure scope (not in current review) | +| IN-04 | info | deferred | out of gap-closure scope (not in current review) | + +Dispositions: `open` (recorded, not yet triaged), `fixed`, `skipped`, `deferred`. +Set `deferred` by hand and put the reason in the Source cell; both are preserved. +The 2026-10-06 re-review after gap closure was `status: clean` (0 findings). CR-01 and WR-02 were the gap-closure targets and are closed in source. Remaining prior findings were not in this review's scope.