feat(04-03): select memory, log, and SMTP mail drivers from config
- Load mail.* and SUMMER_MAIL__ overrides to pick memory, log, or smtp - Log headers and text without credentials; SMTP uses explicit TLS and go-mail - Reject CR/LF headers and invalid addresses and surface driver errors once Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Jakub Zych
@@ -1,10 +1,19 @@
|
||||
package postcard
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"context"
|
||||
"errors"
|
||||
"log/slog"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
"testing/fstest"
|
||||
"time"
|
||||
|
||||
"git.golem15.com/golem15/summercms/backpack"
|
||||
"git.golem15.com/golem15/summercms/compass"
|
||||
)
|
||||
|
||||
func TestMailRenderSmoke(t *testing.T) {
|
||||
@@ -173,3 +182,196 @@ Body **{{ .Name }}**.
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
func TestMailDriverSmoke(t *testing.T) {
|
||||
cat := smokeCatalog(t)
|
||||
ctx := context.Background()
|
||||
msg := Message{
|
||||
Template: "golem15.hello::mail.hello",
|
||||
To: []string{"ada@example.test"},
|
||||
Cc: []string{"cc@example.test"},
|
||||
Bcc: []string{"bcc@example.test"},
|
||||
ReplyTo: "reply@example.test",
|
||||
Vars: map[string]any{"Name": "Ada", "URL": "https://example.test"},
|
||||
}
|
||||
|
||||
t.Run("config selects memory log smtp and env override", func(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
writeFile(t, filepath.Join(dir, "mail.yaml"), "driver: memory\nfrom: from@example.test\n")
|
||||
d, opts, err := driverFromApp(backpack.New(loadMailCfg(t, dir, nil)))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, ok := d.(*MemoryDriver); !ok || opts.From != "from@example.test" {
|
||||
t.Fatalf("memory: %T from=%q", d, opts.From)
|
||||
}
|
||||
|
||||
writeFile(t, filepath.Join(dir, "mail.yaml"), "driver: log\nfrom: from@example.test\n")
|
||||
d, _, err = driverFromApp(backpack.New(loadMailCfg(t, dir, nil)))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, ok := d.(*LogDriver); !ok {
|
||||
t.Fatalf("log: %T", d)
|
||||
}
|
||||
|
||||
writeFile(t, filepath.Join(dir, "mail.yaml"), "driver: smtp\nfrom: from@example.test\nsmtp:\n host: 127.0.0.1\n port: 1025\n tls: none\n")
|
||||
d, _, err = driverFromApp(backpack.New(loadMailCfg(t, dir, nil)))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, ok := d.(*SMTPDriver); !ok {
|
||||
t.Fatalf("smtp: %T", d)
|
||||
}
|
||||
|
||||
d, _, err = driverFromApp(backpack.New(loadMailCfg(t, dir, []string{"SUMMER_MAIL__DRIVER=log"})))
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if _, ok := d.(*LogDriver); !ok {
|
||||
t.Fatalf("SUMMER_MAIL__DRIVER override: %T", d)
|
||||
}
|
||||
|
||||
writeFile(t, filepath.Join(dir, "mail.yaml"), "driver: fax\n")
|
||||
_, _, err = driverFromApp(backpack.New(loadMailCfg(t, dir, nil)))
|
||||
if err == nil || !strings.Contains(err.Error(), "fax") {
|
||||
t.Fatalf("unknown driver error = %v", err)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("log driver writes headers and text without credentials", func(t *testing.T) {
|
||||
var buf bytes.Buffer
|
||||
mail := NewMailer(cat, NewLogDriver(slog.New(slog.NewTextHandler(&buf, nil))), Options{From: "from@example.test"})
|
||||
if err := mail.Send(ctx, msg); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
out := buf.String()
|
||||
for _, want := range []string{"from@example.test", "ada@example.test", "Witaj Ada", "Witaj **Ada**."} {
|
||||
if !strings.Contains(out, want) {
|
||||
t.Fatalf("log missing %q:\n%s", want, out)
|
||||
}
|
||||
}
|
||||
if strings.Contains(out, "password") || strings.Contains(out, "secret") {
|
||||
t.Fatalf("log leaked credentials:\n%s", out)
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("failing driver surfaces error without retry", func(t *testing.T) {
|
||||
want := errors.New("driver down")
|
||||
fail := &FailDriver{Err: want}
|
||||
mail := NewMailer(cat, fail, Options{From: "from@example.test"})
|
||||
err := mail.Send(ctx, msg)
|
||||
if !errors.Is(err, want) {
|
||||
t.Fatalf("Send error = %v", err)
|
||||
}
|
||||
if fail.sendCount() != 1 {
|
||||
t.Fatalf("sends = %d, want 1 (no retry)", fail.sendCount())
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("unsafe headers and addresses are rejected", func(t *testing.T) {
|
||||
drv := NewMemoryDriver()
|
||||
mail := NewMailer(cat, drv, Options{From: "from@example.test"})
|
||||
err := mail.Send(ctx, Message{
|
||||
Template: "golem15.hello::mail.hello",
|
||||
To: []string{"ada@example.test"},
|
||||
Subject: "Hi\r\nBcc: evil@example.test",
|
||||
Vars: map[string]any{"Name": "Ada", "URL": "https://example.test"},
|
||||
})
|
||||
if err == nil || !strings.Contains(err.Error(), "CR/LF") {
|
||||
t.Fatalf("CR/LF error = %v", err)
|
||||
}
|
||||
err = mail.Send(ctx, Message{
|
||||
Template: "golem15.hello::mail.hello",
|
||||
To: []string{"not-an-email"},
|
||||
Vars: map[string]any{"Name": "Ada", "URL": "https://example.test"},
|
||||
})
|
||||
if err == nil || !strings.Contains(err.Error(), "invalid to address") {
|
||||
t.Fatalf("invalid address error = %v", err)
|
||||
}
|
||||
if len(drv.Messages()) != 0 {
|
||||
t.Fatal("rejected messages must not be stored")
|
||||
}
|
||||
})
|
||||
|
||||
t.Run("smtp constructs a message and propagates errors", func(t *testing.T) {
|
||||
gm, err := buildSMTPMessage(RenderedMessage{
|
||||
From: "from@example.test",
|
||||
To: []string{"ada@example.test"},
|
||||
Cc: []string{"cc@example.test"},
|
||||
Bcc: []string{"bcc@example.test"},
|
||||
ReplyTo: "reply@example.test",
|
||||
Subject: "Hi Ada",
|
||||
Text: "text body",
|
||||
HTML: "<p>html body</p>",
|
||||
})
|
||||
if err != nil || gm == nil {
|
||||
t.Fatalf("buildSMTPMessage: %v", err)
|
||||
}
|
||||
d, err := NewSMTPDriver(SMTPConfig{
|
||||
Host: "127.0.0.1",
|
||||
Port: 1,
|
||||
Username: "user",
|
||||
Password: "secretpass",
|
||||
TLS: "none",
|
||||
Timeout: 80 * time.Millisecond,
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
mail := NewMailer(cat, d, Options{From: "from@example.test"})
|
||||
err = mail.Send(ctx, msg)
|
||||
if err == nil {
|
||||
t.Fatal("expected smtp failure")
|
||||
}
|
||||
if !strings.Contains(err.Error(), "smtp") {
|
||||
t.Fatalf("error %q should mention smtp", err)
|
||||
}
|
||||
if strings.Contains(err.Error(), "secretpass") || strings.Contains(err.Error(), "text body") {
|
||||
t.Fatalf("smtp error leaked secrets or body: %v", err)
|
||||
}
|
||||
_, err = NewSMTPDriver(SMTPConfig{Host: "127.0.0.1", TLS: "maybe"})
|
||||
if err == nil || !strings.Contains(err.Error(), "mail.smtp.tls") {
|
||||
t.Fatalf("unknown tls error = %v", err)
|
||||
}
|
||||
_, err = NewSMTPDriver(SMTPConfig{TLS: "none"})
|
||||
if err == nil || !strings.Contains(err.Error(), "mail.smtp.host") {
|
||||
t.Fatalf("empty host error = %v", err)
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
func smokeCatalog(t *testing.T) *Catalog {
|
||||
t.Helper()
|
||||
cat := NewCatalog()
|
||||
err := cat.Register("golem15.hello", fstest.MapFS{
|
||||
"views/mail/hello.htm": {Data: []byte(`subject = "Witaj {{ .Name }}"
|
||||
layout = "default"
|
||||
==
|
||||
Witaj **{{ .Name }}**.
|
||||
`)},
|
||||
}, []string{"golem15.hello::mail.hello"}, nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
return cat
|
||||
}
|
||||
|
||||
func writeFile(t *testing.T, path, body string) {
|
||||
t.Helper()
|
||||
if err := os.WriteFile(path, []byte(body), 0o644); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
}
|
||||
|
||||
func loadMailCfg(t *testing.T, dir string, environ []string) *compass.Config {
|
||||
t.Helper()
|
||||
if environ == nil {
|
||||
environ = []string{}
|
||||
}
|
||||
cfg, err := compass.Open(compass.Options{Dir: dir, Env: "development", Environ: environ})
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
return cfg
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user