diff --git a/.planning/phases/35-mail-templates-and-layouts-editor/35-UAT.md b/.planning/phases/35-mail-templates-and-layouts-editor/35-UAT.md index 4f60f1fb..a67529e9 100644 --- a/.planning/phases/35-mail-templates-and-layouts-editor/35-UAT.md +++ b/.planning/phases/35-mail-templates-and-layouts-editor/35-UAT.md @@ -1,12 +1,13 @@ --- -status: testing +status: complete phase: 35-mail-templates-and-layouts-editor source: [35-VERIFICATION.md] started: 2026-11-13T13:46:04.193Z -updated: 2026-11-14T17:46:34.025Z +updated: 2026-11-15T08:20:00.000Z --- ## Current Test + [testing complete] @@ -14,14 +15,14 @@ updated: 2026-11-14T17:46:34.025Z ### 1. Template list expected: Settings → Mail → Mail templates lists the templates from user, mfa, paymentgateway and quizzes. -result: [pending] -retest_reason: "G-35-1 fixed by 35-05/35-07 (one entry per template, locale tabs); previous result: issue" -reported: "fact that each locale is a separate entry in backend is absolute disaster, why was it planned like that? imagine site with 50 locales." -severity: major +result: issue +reported: "only paymentgateway and user emails, both correct. mfa e-mail uses Default template and no \"mfa\" template is provided. if it depends on User plugin (i think it is) it can use User template" +severity: minor +note: "quizzes registers no templates (MailTemplates returns nil); listing it in the expectation was a test-writing error, not a defect. Previous G-35-1 (one row per locale) confirmed fixed." ### 2. Customize and save a template expected: Open the user plugin's activate template (the row without a locale suffix), change the subject to "UAT subject", Save. Reopen it: the subject is "UAT subject" and the row shows as customized. -result: [pending] +result: pass previous_result: pass retest_reason: "the save-time safety check changed after the UAT pass (2026-11-13T21:09:53Z): modules/postcard/safety.go (35-08 tokenizer check, CR-02 raw-text/comment re-check, WR-01 whitespace stripping, then the quote-aware tag reading of quick 261114-p5m, d6ac0aeb) and modules/postcard/templates.go (WR-02 removed the handler regex)" @@ -35,32 +36,33 @@ result: pass ### 5. Layout editor expected: Settings → Mail → Mail layouts, open "user". HTML, plain text and CSS tabs each show a code editor with syntax highlighting; typing works and Save persists after reload. -result: [pending] +result: pass previous_result: pass retest_reason: "layout validation in modules/postcard/safety.go and templates.go changed after the UAT pass (2026-11-13T21:09:53Z), including the 'nests raw-text elements or comments too deeply' refusal and the second, quote-aware tag reading (d6ac0aeb)" ### 6. Insert image into layout expected: In the layout HTML tab, use the insert-image button, pick or upload an image. The inserted is a full URL starting with http://127.0.0.1:8097/. -result: [pending] +result: pass previous_result: pass retest_reason: "the src/href check that validates the inserted img was rewritten after the UAT pass (2026-11-13T21:09:53Z): tokenizer check in 35-08, stripURLSpace refactor in WR-01, shared unsafeAttrs and a second tag reading in d6ac0aeb" ### 7. Branding expected: Mail branding: change a colour and set a logo, Save, reload. Values persist; the preview of any template uses the new colour/logo. -result: [pending] +result: pass previous_result: pass retest_reason: "modules/cabana/mail_admin.go BeforeValidate now calls postcard.UnsafeText (35-08), whose rule changed again in CR-01 (printContext), WR-03 (data-URL shape) and d6ac0aeb (validateHTML gained the tag reading); modules/cabana/settings.go error localization and modules/postcard/editor.go brand preview changed after the UAT pass (2026-11-13T21:09:53Z)" ### 8. Preview expected: On a template, the HTML preview renders the mail with its layout; the plain-text tab shows the text version. -result: [pending] +result: pass retest_reason: "G-35-8 fixed by 35-06/35-07 (built-in layouts) and quick 261114-p5n (plugin layouts); previous result: issue" reported: "logo doesn't appear, only kind of proper layout is System layout (logo doesn't show, Aktywuj konto on activate email doesn't seem to be a button, totally unstyled), other layouts sucks, I expect beautiful and working out of box layouts after this phase." severity: major ### 9. Send test to me expected: Click "Send test to me". ../sm-demo-app/logs/go.log gets a mail entry addressed to the signed-in admin's email (no other recipient can be entered). -result: [pending] +result: pass +note: "go.log entry to=[admin@example.test], subject Ustaw nowe hasło (restore). Text part still shows the user layout text wrapper (-- ... --) and raw Markdown: the known plugin follow-up after the framework tag (fix user.htm text wrapper)." previous_result: pass retest_reason: "modules/postcard/mailer.go (site name selection), templates.go and safety.go (send-time validateHTML, handler regex removed, tag reading added) and the default/system layouts and footer partial changed after the UAT pass (2026-11-13T21:09:53Z)" @@ -71,31 +73,51 @@ note: "User accepted the lagoon/attach import as intentional." ### 11. Branding refusal on the demo instance expected: On the demo app: Site name 'javascript:alert(1)' and 'data:text/html,x' are refused with the translated message under Site name (en and pl, copy without 'text such as onclick='); 'Online=Shop', 'Data:Lab' and 'Big Data: Summit' save and appear in the preview header and footer -result: [pending] +result: pass ### 12. Review the CR-01, CR-02 and WR-02 safety-rule changes, including the CR-02 residual fix expected: Accept or reject the rule changes that 35-REVIEW-FIX.md marks 'requires human verification': (CR-01) UnsafeText checks the name where the layouts print it; (CR-02) raw-text element and comment content is re-checked as markup with an 8-level depth limit; (CR-02 residual, quick 261114-p5m) every tag is read a second time with attribute quoting alone deciding where it ends, which can over-refuse after an unbalanced quote in a comment or style element; (WR-02) text shaped like an event handler is sent, and only attributes count as handlers. The decision note .planning/notes/2026-11-14-mail-url-scheme-check.md was amended twice to match -result: [pending] +result: pass ### 13. Inlined mail in a real inbox expected: Test-send a template in the default layout to a real webmail/Outlook inbox; the button and card keep their colours with the style block stripped -result: [pending] +result: skipped +reason: "Demo uses the log mail driver; no real mailer on the VPN-run instance. Re-check on an instance with working SMTP." ### 14. Confirm judgment-tier prohibitions of 35-05..35-09, the review fix round and quick 261114-p5m expected: Accept: no sibling repository changed by this phase (sm-user-plugin and sm-paymentgateway-plugin clean before and after the verifier's --consumers run; the concurrent restyle there is quick 261114-p5n, not this phase); nothing pushed or tagged (master is 113 commits ahead of origin/master, newest tag v0.6.4 predates the gap closures); framework code, docs and tests name no consuming application (--marker passed) -result: [pending] +result: pass ## Summary total: 14 -passed: 3 -issues: 2 -pending: 9 -skipped: 0 +passed: 12 +issues: 1 +pending: 0 +skipped: 1 blocked: 0 ## Gaps +- gap_id: G-35-9 + truth: "The mfa plugin's two-factor code mail renders in the user plugin's layout (mfa requires golem15.user), not the bare Default layout." + status: failed + reason: "User reported: mfa e-mail uses Default template and no \"mfa\" template is provided. if it depends on User plugin (i think it is) it can use User template" + severity: minor + test: 1 + root_cause: "sm-mfa-plugin views/mail/two_factor_code{,-en}.htm set no layout key and MailLayouts() returns nil, so postcard falls back to the default alias. postcard cannot reference another plugin's layout: Catalog.resolveLayoutLocked looks a layout up only in the registering plugin's own aliases (c.aliases[pluginID]) and the built-in aliases, so layout = \"user\" in mfa is an unknown layout at boot." + artifacts: + - path: "modules/postcard/templates.go" + issue: "resolveLayoutLocked resolves only own-plugin aliases and built-ins; no full-code (vendor.plugin::mail.layouts.x) reference to a layout another plugin registered" + - path: "../sm-mfa-plugin/views/mail/two_factor_code.htm, two_factor_code-en.htm" + issue: "no layout key" + - path: "../sm-mfa-plugin/mail.go" + issue: "MailLayouts returns nil" + missing: + - "postcard: accept a full layout code in a template's layout key when that layout is already registered (plugin Requires ordering guarantees golem15.user registers first); README/docs updated" + - "sm-mfa-plugin: layout = \"golem15.user::mail.layouts.user\" in both templates, after the framework requirement that supports it (or, to stay on v0.6.0, ship its own copy of the user layout)" + debug_session: "" + - gap_id: G-35-1 truth: "Locale variants of one mail template are managed as a single backend entry (per-locale tabs/switcher), so a site with many locales does not get one list row per locale." status: resolved