diff --git a/.planning/phases/35-mail-templates-and-layouts-editor/35-UAT.md b/.planning/phases/35-mail-templates-and-layouts-editor/35-UAT.md index 45cbf143..4f60f1fb 100644 --- a/.planning/phases/35-mail-templates-and-layouts-editor/35-UAT.md +++ b/.planning/phases/35-mail-templates-and-layouts-editor/35-UAT.md @@ -1,9 +1,9 @@ --- -status: diagnosed +status: testing phase: 35-mail-templates-and-layouts-editor source: [35-VERIFICATION.md] started: 2026-11-13T13:46:04.193Z -updated: 2026-11-13T15:15:00.000Z +updated: 2026-11-14T17:46:34.025Z --- ## Current Test @@ -14,13 +14,16 @@ updated: 2026-11-13T15:15:00.000Z ### 1. Template list expected: Settings → Mail → Mail templates lists the templates from user, mfa, paymentgateway and quizzes. -result: issue +result: [pending] +retest_reason: "G-35-1 fixed by 35-05/35-07 (one entry per template, locale tabs); previous result: issue" reported: "fact that each locale is a separate entry in backend is absolute disaster, why was it planned like that? imagine site with 50 locales." severity: major ### 2. Customize and save a template expected: Open the user plugin's activate template (the row without a locale suffix), change the subject to "UAT subject", Save. Reopen it: the subject is "UAT subject" and the row shows as customized. -result: pass +result: [pending] +previous_result: pass +retest_reason: "the save-time safety check changed after the UAT pass (2026-11-13T21:09:53Z): modules/postcard/safety.go (35-08 tokenizer check, CR-02 raw-text/comment re-check, WR-01 whitespace stripping, then the quote-aware tag reading of quick 261114-p5m, d6ac0aeb) and modules/postcard/templates.go (WR-02 removed the handler regex)" ### 3. Reset to file version expected: On the same template click "Reset to file version" and confirm. The subject is back to the file's subject and the row no longer shows as customized. @@ -32,37 +35,62 @@ result: pass ### 5. Layout editor expected: Settings → Mail → Mail layouts, open "user". HTML, plain text and CSS tabs each show a code editor with syntax highlighting; typing works and Save persists after reload. -result: pass +result: [pending] +previous_result: pass +retest_reason: "layout validation in modules/postcard/safety.go and templates.go changed after the UAT pass (2026-11-13T21:09:53Z), including the 'nests raw-text elements or comments too deeply' refusal and the second, quote-aware tag reading (d6ac0aeb)" ### 6. Insert image into layout expected: In the layout HTML tab, use the insert-image button, pick or upload an image. The inserted is a full URL starting with http://127.0.0.1:8097/. -result: pass +result: [pending] +previous_result: pass +retest_reason: "the src/href check that validates the inserted img was rewritten after the UAT pass (2026-11-13T21:09:53Z): tokenizer check in 35-08, stripURLSpace refactor in WR-01, shared unsafeAttrs and a second tag reading in d6ac0aeb" ### 7. Branding expected: Mail branding: change a colour and set a logo, Save, reload. Values persist; the preview of any template uses the new colour/logo. -result: pass +result: [pending] +previous_result: pass +retest_reason: "modules/cabana/mail_admin.go BeforeValidate now calls postcard.UnsafeText (35-08), whose rule changed again in CR-01 (printContext), WR-03 (data-URL shape) and d6ac0aeb (validateHTML gained the tag reading); modules/cabana/settings.go error localization and modules/postcard/editor.go brand preview changed after the UAT pass (2026-11-13T21:09:53Z)" ### 8. Preview expected: On a template, the HTML preview renders the mail with its layout; the plain-text tab shows the text version. -result: issue +result: [pending] +retest_reason: "G-35-8 fixed by 35-06/35-07 (built-in layouts) and quick 261114-p5n (plugin layouts); previous result: issue" reported: "logo doesn't appear, only kind of proper layout is System layout (logo doesn't show, Aktywuj konto on activate email doesn't seem to be a button, totally unstyled), other layouts sucks, I expect beautiful and working out of box layouts after this phase." severity: major ### 9. Send test to me expected: Click "Send test to me". ../sm-demo-app/logs/go.log gets a mail entry addressed to the signed-in admin's email (no other recipient can be entered). -result: pass +result: [pending] +previous_result: pass +retest_reason: "modules/postcard/mailer.go (site name selection), templates.go and safety.go (send-time validateHTML, handler regex removed, tag reading added) and the default/system layouts and footer partial changed after the UAT pass (2026-11-13T21:09:53Z)" ### 10. Confirm judgment-tier prohibition: postcard imports modules/lagoon/attach for AbsolutePublicURL. expected: Accept as intentional (D-24 / 35-01 SUMMARY threat_flag dependency-surface) or request a follow-up to move AbsolutePublicURL out of lagoon. result: pass note: "User accepted the lagoon/attach import as intentional." +### 11. Branding refusal on the demo instance +expected: On the demo app: Site name 'javascript:alert(1)' and 'data:text/html,x' are refused with the translated message under Site name (en and pl, copy without 'text such as onclick='); 'Online=Shop', 'Data:Lab' and 'Big Data: Summit' save and appear in the preview header and footer +result: [pending] + +### 12. Review the CR-01, CR-02 and WR-02 safety-rule changes, including the CR-02 residual fix +expected: Accept or reject the rule changes that 35-REVIEW-FIX.md marks 'requires human verification': (CR-01) UnsafeText checks the name where the layouts print it; (CR-02) raw-text element and comment content is re-checked as markup with an 8-level depth limit; (CR-02 residual, quick 261114-p5m) every tag is read a second time with attribute quoting alone deciding where it ends, which can over-refuse after an unbalanced quote in a comment or style element; (WR-02) text shaped like an event handler is sent, and only attributes count as handlers. The decision note .planning/notes/2026-11-14-mail-url-scheme-check.md was amended twice to match +result: [pending] + +### 13. Inlined mail in a real inbox +expected: Test-send a template in the default layout to a real webmail/Outlook inbox; the button and card keep their colours with the style block stripped +result: [pending] + +### 14. Confirm judgment-tier prohibitions of 35-05..35-09, the review fix round and quick 261114-p5m +expected: Accept: no sibling repository changed by this phase (sm-user-plugin and sm-paymentgateway-plugin clean before and after the verifier's --consumers run; the concurrent restyle there is quick 261114-p5n, not this phase); nothing pushed or tagged (master is 113 commits ahead of origin/master, newest tag v0.6.4 predates the gap closures); framework code, docs and tests name no consuming application (--marker passed) +result: [pending] + ## Summary -total: 10 -passed: 8 +total: 14 +passed: 3 issues: 2 -pending: 0 +pending: 9 skipped: 0 blocked: 0