feat(03-02): add allow-listed database-default order helper
- Reject identifiers and directions outside the caller allow-list - Emit ordinary ORDER BY without COLLATE so ICU pl-PL applies Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
39
lagoon/order_test.go
Normal file
39
lagoon/order_test.go
Normal file
@@ -0,0 +1,39 @@
|
||||
package lagoon
|
||||
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestOrderClauseAllowList(t *testing.T) {
|
||||
allowed := []string{"golem15_fonoteka_genres.name", "items.title"}
|
||||
|
||||
got, err := orderClause("golem15_fonoteka_genres.name", "asc", allowed)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got != "golem15_fonoteka_genres.name ASC" {
|
||||
t.Fatalf("got %q", got)
|
||||
}
|
||||
if strings.Contains(strings.ToLower(got), "collate") {
|
||||
t.Fatalf("must not emit COLLATE: %q", got)
|
||||
}
|
||||
|
||||
got, err = orderClause("items.title", "DESC", allowed)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if got != "items.title DESC" {
|
||||
t.Fatalf("got %q", got)
|
||||
}
|
||||
|
||||
if _, err := orderClause("golem15_fonoteka_genres.name;drop table x", "asc", allowed); err == nil {
|
||||
t.Fatal("want reject unknown column")
|
||||
}
|
||||
if _, err := orderClause("golem15_fonoteka_genres.name", "ascending", allowed); err == nil {
|
||||
t.Fatal("want reject unknown direction")
|
||||
}
|
||||
if _, err := OrderBy(nil, "items.title", "asc", allowed); err == nil {
|
||||
t.Fatal("want nil db error")
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user