golem15/summercms
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(02-03): treat null foreign keys as valid masked ids

Browse Source 
PHP album payloads leave discogs_id null. The id mask required an
integer and failed PHP self-replay on otherwise identical bodies.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Jakub Zych
2026-09-17 12:52:06 +02:00
parent 591a0d4681
commit 5b947c7454
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tide/normalize.go
View File

@@ -81,6 +81,9 @@ func maskDate(path string, val any, diffs *[]Diff) any {
} }
func maskIDValue(path string, val any, diffs *[]Diff) any { func maskIDValue(path string, val any, diffs *[]Diff) any {
if val == nil {
return nil
}
n, ok := val.(json.Number) n, ok := val.(json.Number)
if !ok { if !ok {
*diffs = append(*diffs, Diff{Path: path, Expected: "integer id", Actual: formatValue(val)}) *diffs = append(*diffs, Diff{Path: path, Expected: "integer id", Actual: formatValue(val)})

4
tide/normalize_test.go
View File

@@ -16,6 +16,10 @@ func TestNormalizeDateIDAndDisable(t *testing.T) {
if diffs := compareBodies(Response{Headers: jsonCT(), Body: Body(want)}, Response{Headers: jsonCT(), Body: Body(gotOK)}, step); len(diffs) != 0 { if diffs := compareBodies(Response{Headers: jsonCT(), Body: Body(want)}, Response{Headers: jsonCT(), Body: Body(gotOK)}, step); len(diffs) != 0 {
t.Fatalf("masked date/id should pass: %+v", diffs) t.Fatalf("masked date/id should pass: %+v", diffs)
} }
nullID := []byte(`{"id":1,"discogs_id":null,"created_at":"2026-01-01T00:00:00+00:00","slug":"keep-me"}`)
if diffs := compareBodies(Response{Headers: jsonCT(), Body: Body(nullID)}, Response{Headers: jsonCT(), Body: Body(nullID)}, step); len(diffs) != 0 {
t.Fatalf("null *_id must pass: %+v", diffs)
}
zdiffs := compareBodies(Response{Headers: jsonCT(), Body: Body(want)}, Response{Headers: jsonCT(), Body: Body(gotZ)}, step) zdiffs := compareBodies(Response{Headers: jsonCT(), Body: Body(want)}, Response{Headers: jsonCT(), Body: Body(gotZ)}, step)
if len(zdiffs) == 0 { if len(zdiffs) == 0 {
t.Fatal("Z date must fail") t.Fatal("Z date must fail")