diff --git a/scripts/check-phase10.1.sh b/scripts/check-phase10.1.sh index 5f00605..015e3f3 100755 --- a/scripts/check-phase10.1.sh +++ b/scripts/check-phase10.1.sh @@ -21,10 +21,9 @@ APP_PLUGINS=(./plugins/golem15/fonoteka/... ./plugins/golem15/user/...) KNOWN_APP_FAILURES="" # Phase 11 (11-06) records the created/updated broadcast goldens from PHP and # reports them as skipped until Phase 12 asserts them; check-phase11.sh -# requires exactly these skips with this text. Phase 12 (12-04) asserts the -# created golden through the album store handler; updated stays pending -# until the update handler lands. -APP_PENDING_SKIPS="TestBroadcastGoldens/updated" +# requires exactly these skips with this text. Phase 12 (12-04) asserts all +# four goldens through the album handlers, so no skip is expected any more. +APP_PENDING_SKIPS="" APP_PENDING_TEXT="pending: Phase 12" usage() { diff --git a/scripts/check-phase10.sh b/scripts/check-phase10.sh index 16d0d0f..5ec61fe 100755 --- a/scripts/check-phase10.sh +++ b/scripts/check-phase10.sh @@ -20,10 +20,9 @@ APP_PLUGINS=(./plugins/golem15/fonoteka/... ./plugins/golem15/user/...) KNOWN_APP_FAILURES="" # Phase 11 (11-06) records the created/updated broadcast goldens from PHP and # reports them as skipped until Phase 12 asserts them; check-phase11.sh -# requires exactly these skips with this text. Phase 12 (12-04) asserts the -# created golden through the album store handler; updated stays pending -# until the update handler lands. -APP_PENDING_SKIPS="TestBroadcastGoldens/updated" +# requires exactly these skips with this text. Phase 12 (12-04) asserts all +# four goldens through the album handlers, so no skip is expected any more. +APP_PENDING_SKIPS="" APP_PENDING_TEXT="pending: Phase 12" usage() { diff --git a/scripts/check-phase11.sh b/scripts/check-phase11.sh index 6f35e28..91103bc 100755 --- a/scripts/check-phase11.sh +++ b/scripts/check-phase11.sh @@ -26,9 +26,8 @@ VALIDATION="$PHASE_DIR/11-VALIDATION.md" APP_PLUGINS=(./plugins/golem15/fonoteka/... ./plugins/golem15/user/...) KNOWN_APP_FAILURES="" # The broadcast goldens recorded from PHP but asserted only in Phase 12. -# 12-04 asserts created through the album store handler; updated stays -# pending until the update handler lands. -GOLDEN_SKIPS="TestBroadcastGoldens/updated" +# 12-04 asserts all four through the album handlers: no skip is expected. +GOLDEN_SKIPS="" GOLDEN_SKIP_TEXT="pending: Phase 12" RIVER_VERSION="v0.47.0" @@ -661,7 +660,7 @@ run_named() { phase11_tests "$ROOT" ./modules/tide TestCentrifugoRecorder TestNormalizePublications TestDiffPublications phase11_tests "$APP" ./plugins/golem15/fonoteka TestWsAuthorizer TestAlbumBroadcastBinding TestAlbumSearchable \ TestFonotekaScheduleSkipsUnregisteredPrune TestRealtimeSubscribeProxy TestAlbumBroadcastSmoke TestAlbumSearchSmoke - PHASE11_REQUIRE="TestBroadcastGoldens TestBroadcastGoldens/deleted TestBroadcastGoldens/bulk" \ + PHASE11_REQUIRE="TestBroadcastGoldens TestBroadcastGoldens/deleted TestBroadcastGoldens/bulk TestBroadcastGoldens/created TestBroadcastGoldens/updated" \ PHASE11_EXPECT_SKIP="$GOLDEN_SKIPS" PHASE11_SKIP_TEXT="$GOLDEN_SKIP_TEXT" \ phase11_go "$APP" ./parity -run '^TestBroadcastGoldens$' echo "phase11 named passed"