diff --git a/.planning/phases/14.2-local-fonoteka-frontend-on-local-summercms-backend/14.2-REVIEW-DISPOSITION.md b/.planning/phases/14.2-local-fonoteka-frontend-on-local-summercms-backend/14.2-REVIEW-DISPOSITION.md index 66f3bb6..4804e78 100644 --- a/.planning/phases/14.2-local-fonoteka-frontend-on-local-summercms-backend/14.2-REVIEW-DISPOSITION.md +++ b/.planning/phases/14.2-local-fonoteka-frontend-on-local-summercms-backend/14.2-REVIEW-DISPOSITION.md @@ -5,15 +5,15 @@ titles: json findings: - id: WR-01 severity: warning - disposition: open + disposition: fixed title: "Access log writes share and invitation tokens for 405 and 404 responses on token routes" - id: WR-02 severity: warning - disposition: open + disposition: fixed title: "499 remap hides real server errors whenever the client has gone away" - id: WR-03 severity: warning - disposition: open + disposition: fixed title: "Uploads route serves the stored content type verbatim on the app origin (stored XSS via text/html)" - id: WR-04 severity: warning @@ -21,23 +21,23 @@ findings: title: "`storage.uploads.public_path_prefix` is not validated: a non-path prefix either fails boot or silently 404s every upload" - id: WR-05 severity: warning - disposition: open + disposition: fixed title: "`fonoteka:dev-seed` takes over existing accounts and tokens behind a single environment-name gate" - id: WR-06 severity: warning - disposition: open + disposition: fixed title: "Minted API token secret persisted to a group/world-readable file and echoed into Playwright output" - id: WR-07 severity: warning - disposition: open + disposition: fixed title: "Phase gate `--e2e` can verify a stale binary" - id: WR-08 severity: warning - disposition: open + disposition: fixed title: "go.log 5xx scan passes when the access log is off" - id: WR-09 severity: warning - disposition: open + disposition: fixed title: "Realtime spec accepts any publication on the channel, including another spec's" - id: IN-01 severity: info @@ -83,24 +83,24 @@ findings: severity: info disposition: open title: "Test cleanups ignore errors; `goDir` mis-resolves a relative `E2E_GO_BIN`" -open: 20 +open: 12 total: 20 -recorded: 2026-10-11T22:18:52.299Z +recorded: 2026-10-12T10:23:09.664Z --- # Phase 14.2: Code Review Disposition | Finding | Severity | Disposition | Source | |---------|----------|-------------|--------| -| WR-01 | warning | open | - | -| WR-02 | warning | open | - | -| WR-03 | warning | open | - | +| WR-01 | warning | fixed | 14.2-REVIEW-FIX.md | +| WR-02 | warning | fixed | 14.2-REVIEW-FIX.md | +| WR-03 | warning | fixed | 14.2-REVIEW-FIX.md | | WR-04 | warning | open | - | -| WR-05 | warning | open | - | -| WR-06 | warning | open | - | -| WR-07 | warning | open | - | -| WR-08 | warning | open | - | -| WR-09 | warning | open | - | +| WR-05 | warning | fixed | 14.2-REVIEW-FIX.md | +| WR-06 | warning | fixed | 14.2-REVIEW-FIX.md | +| WR-07 | warning | fixed | 14.2-REVIEW-FIX.md | +| WR-08 | warning | fixed | 14.2-REVIEW-FIX.md | +| WR-09 | warning | fixed | 14.2-REVIEW-FIX.md | | IN-01 | info | open | - | | IN-02 | info | open | - | | IN-03 | info | open | - |