From 7ac6c05ab39669998395bef89645b2d38a4a14db Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Fri, 2 Oct 2026 14:01:32 +0200 Subject: [PATCH] chore(12-04): expect only the updated broadcast golden to skip The album store handler asserts the created golden now; updated stays pending until the update handler lands. --- scripts/check-phase10.1.sh | 6 ++++-- scripts/check-phase10.sh | 6 ++++-- scripts/check-phase11.sh | 4 +++- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/scripts/check-phase10.1.sh b/scripts/check-phase10.1.sh index d2c074e..5f00605 100755 --- a/scripts/check-phase10.1.sh +++ b/scripts/check-phase10.1.sh @@ -21,8 +21,10 @@ APP_PLUGINS=(./plugins/golem15/fonoteka/... ./plugins/golem15/user/...) KNOWN_APP_FAILURES="" # Phase 11 (11-06) records the created/updated broadcast goldens from PHP and # reports them as skipped until Phase 12 asserts them; check-phase11.sh -# requires exactly these skips with this text. -APP_PENDING_SKIPS="TestBroadcastGoldens/created TestBroadcastGoldens/updated" +# requires exactly these skips with this text. Phase 12 (12-04) asserts the +# created golden through the album store handler; updated stays pending +# until the update handler lands. +APP_PENDING_SKIPS="TestBroadcastGoldens/updated" APP_PENDING_TEXT="pending: Phase 12" usage() { diff --git a/scripts/check-phase10.sh b/scripts/check-phase10.sh index 2ea4114..16d0d0f 100755 --- a/scripts/check-phase10.sh +++ b/scripts/check-phase10.sh @@ -20,8 +20,10 @@ APP_PLUGINS=(./plugins/golem15/fonoteka/... ./plugins/golem15/user/...) KNOWN_APP_FAILURES="" # Phase 11 (11-06) records the created/updated broadcast goldens from PHP and # reports them as skipped until Phase 12 asserts them; check-phase11.sh -# requires exactly these skips with this text. -APP_PENDING_SKIPS="TestBroadcastGoldens/created TestBroadcastGoldens/updated" +# requires exactly these skips with this text. Phase 12 (12-04) asserts the +# created golden through the album store handler; updated stays pending +# until the update handler lands. +APP_PENDING_SKIPS="TestBroadcastGoldens/updated" APP_PENDING_TEXT="pending: Phase 12" usage() { diff --git a/scripts/check-phase11.sh b/scripts/check-phase11.sh index 65ffc7f..6f35e28 100755 --- a/scripts/check-phase11.sh +++ b/scripts/check-phase11.sh @@ -26,7 +26,9 @@ VALIDATION="$PHASE_DIR/11-VALIDATION.md" APP_PLUGINS=(./plugins/golem15/fonoteka/... ./plugins/golem15/user/...) KNOWN_APP_FAILURES="" # The broadcast goldens recorded from PHP but asserted only in Phase 12. -GOLDEN_SKIPS="TestBroadcastGoldens/created TestBroadcastGoldens/updated" +# 12-04 asserts created through the album store handler; updated stays +# pending until the update handler lands. +GOLDEN_SKIPS="TestBroadcastGoldens/updated" GOLDEN_SKIP_TEXT="pending: Phase 12" RIVER_VERSION="v0.47.0"