From 7c43820afe1177230e0e07f08fcf222ecfdaad96 Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Fri, 23 Oct 2026 12:44:09 +0200 Subject: [PATCH] docs(19.7): cabana subject-event bug resolved --- .planning/phases/19.7-generic-mcp-module/deferred-items.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.planning/phases/19.7-generic-mcp-module/deferred-items.md b/.planning/phases/19.7-generic-mcp-module/deferred-items.md index bcddacc4..45c6a45f 100644 --- a/.planning/phases/19.7-generic-mcp-module/deferred-items.md +++ b/.planning/phases/19.7-generic-mcp-module/deferred-items.md @@ -45,7 +45,7 @@ was changed by the plan that recorded it. stored `initialized` flag would close the gap; not needed for the single-instance demo. - cabana's backend subject events never reach pier (found during 19.7-03 Task 2) - status: open + status: resolved **What:** `modules/cabana/subject_events.go` fires `pact.MCPSubjectChanged` as a value (`app.Events.Fire(ctx, pact.MCPSubjectChanged{...})`), while `modules/pier/events.go` listens for a pointer @@ -59,3 +59,7 @@ was changed by the plan that recorded it. pier does receive. Fix in the framework: fire `&pact.MCPSubjectChanged{}` from cabana and defer it with `lagoon.AfterCommit`, with a pier test that a cabana save reaches `handleEvent`. Must be fixed before v0.5.0. + **Resolved:** cabana now fires `&pact.MCPSubjectChanged{}` through + `lagoon.AfterCommit` (immediately outside a transaction); + `subject_events_test.go` pins delivery to a pointer listener, no firing + before commit and none after a rollback.