golem15/summercms
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(11.1-06): record the gate cleanup fix in the plan summary

Browse Source
This commit is contained in:
Jakub Zych
2026-10-01 00:23:43 +02:00
parent 85ce154640
commit 7ede3e03b3
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
.planning/phases/11.1-summercms-documentation-for-humans-and-ai-agents/11.1-06-SUMMARY.md
View File

@@ -68,9 +68,9 @@ estimate_ref: "tokens 120000, tasks 3, confidence low"
actuals: actuals:
tokens: 38500 tokens: 38500
tasks: 3 tasks: 3
commits: 4 commits: 6
plan_head_before: 4c68d3186206b93e5d1c9c18ee35b3711682c938 plan_head_before: 4c68d3186206b93e5d1c9c18ee35b3711682c938
plan_head_after: 9419d5d5e7600218846f3a24729c5a9645b8cbe3 plan_head_after: 85ce154640bab43572973d5c996d4e213eecb019
coverage: coverage:
- id: D1 - id: D1
@@ -158,8 +158,9 @@ status: complete
1. **Task 1: Tracer: planted fixture per rule, run by the gate:** `1d38e73` (test) 1. **Task 1: Tracer: planted fixture per rule, run by the gate:** `1d38e73` (test)
2. **Task 2: Branch-level tests to 94.8% coverage, with three fixes:** `28afd4d` (test) 2. **Task 2: Branch-level tests to 94.8% coverage, with three fixes:** `28afd4d` (test)
3. **Task 3: Acceptance subtests and the final gate:** `c1c9a9f` (test); VALIDATION.md: `9419d5d` (docs) 3. **Task 3: Acceptance subtests and the final gate:** `c1c9a9f` (test); VALIDATION.md: `9419d5d` (docs)
4. **Gate scratch cleanup on refusal, found in the final sweep:** `85ce154` (fix)
**Plan metadata:** the docs(11.1-06) commit that adds this file **Plan metadata:** `f2413f6` added this file with STATE, ROADMAP and REQUIREMENTS; a second docs(11.1-06) commit records the cleanup fix
## Files Created/Modified ## Files Created/Modified
@@ -208,7 +209,14 @@ See `key-decisions` in the frontmatter.
- The plan's "go doc fallback accepting a promoted member" cannot be tested as worded: `go doc` does not resolve promotion (plan 11.1-02 found this), and the index handles promotion itself. `TestIdentifierGoDocFallback` shows that the fallback accepts a declared member, caches answers and never passes a non-identifier to the argv. It also shows that a member promoted from another package is still a problem after the fallback runs. - The plan's "go doc fallback accepting a promoted member" cannot be tested as worded: `go doc` does not resolve promotion (plan 11.1-02 found this), and the index handles promotion itself. `TestIdentifierGoDocFallback` shows that the fallback accepts a declared member, caches answers and never passes a non-identifier to the argv. It also shows that a member promoted from another package is still a problem after the fallback runs.
- `testdata/violations/snippet-unparsable-go/lib/lib.go` does not parse on purpose, so a repository-wide `gofmt -l` lists it. No gate runs gofmt, and the go tool ignores `testdata`. - `testdata/violations/snippet-unparsable-go/lib/lib.go` does not parse on purpose, so a repository-wide `gofmt -l` lists it. No gate runs gofmt, and the go tool ignores `testdata`.
**Total deviations:** 4 auto-fixed (1 blocking, 3 bugs), each fix landed with its failing-then-passing test. **Impact:** none on scope. **5. [Rule 1 - Bug] The docs gate left its scratch copy in /tmp on a refusal**
- **Found during:** the final cleanup sweep (two 48 MB `/tmp/tmp.*` directories from the Task 1 baseline refusals)
- **Issue:** Every stage removed its `mktemp` directory with a RETURN trap, but a refusal exits from inside the stage, so the trap never ran.
- **Fix:** An EXIT trap removes every stage's scratch paths. The self-test now copies `examples/` with `tar --exclude='examples/*/bin'` instead of `git ls-files`, so a `PHASE11_1_ROOT` copy without `.git` works. A planted refusal against a scratch copy left the `/tmp/tmp.*` count unchanged (29 before and after), and the two leaked directories were removed.
- **Files modified:** scripts/check-phase11.1.sh
- **Commit:** 85ce154
**Total deviations:** 5 auto-fixed (1 blocking, 4 bugs). The three Go fixes each landed with a test that failed before the fix and passed after it. **Impact:** none on scope.
## Mutation and refusal checks (run once by hand) ## Mutation and refusal checks (run once by hand)
@@ -228,7 +236,7 @@ See `key-decisions` in the frontmatter.
- Coverage of `go test ./internal/docsite -count=1 -coverprofile` is 94.8%. - Coverage of `go test ./internal/docsite -count=1 -coverprofile` is 94.8%.
- `go test ./internal/docsite -run '^TestPlantedViolations$' -count=1 -v` prints 68 `--- PASS: TestPlantedViolations/` lines. - `go test ./internal/docsite -run '^TestPlantedViolations$' -count=1 -v` prints 68 `--- PASS: TestPlantedViolations/` lines.
- `go test ./cmd/summer -run '^TestPhase11_1Acceptance$' -count=1 -v` prints 5 `--- PASS: TestPhase11_1Acceptance/SC` lines. - `go test ./cmd/summer -run '^TestPhase11_1Acceptance$' -count=1 -v` prints 5 `--- PASS: TestPhase11_1Acceptance/SC` lines.
- `scripts/check-phase11.1.sh --all` prints `phase11.1 all passed` in 2m39s. - `scripts/check-phase11.1.sh --all` prints `phase11.1 all passed` (2m39s, and again in 1m49s after the cleanup fix).
- Every automated row command in 11.1-VALIDATION.md for plans 01 to 06 exits 0. - Every automated row command in 11.1-VALIDATION.md for plans 01 to 06 exits 0.
- `grep -rniE 'fonoteka|p(l|ł)ytarium' internal/docsite/testdata internal/docsite/violations_test.go` finds nothing. - `grep -rniE 'fonoteka|p(l|ł)ytarium' internal/docsite/testdata internal/docsite/violations_test.go` finds nothing.
@@ -246,4 +254,4 @@ Phase 11.1 is ready for `/gsd-verify-work`. The two manual UAT rows (search, and
## Self-Check: PASSED ## Self-Check: PASSED
All 10 key created files exist, 63 case directories are present, and commits 1d38e73, 28afd4d, c1c9a9f and 9419d5d are in the log. All 10 key created files exist, 63 case directories are present, and commits 1d38e73, 28afd4d, c1c9a9f, 9419d5d, f2413f6 and 85ce154 are in the log.