From 80fae5c2796fed003e0fb451fe9e3634bd64abbb Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Wed, 21 Oct 2026 12:13:29 +0200 Subject: [PATCH] docs(19.8): close the duplicate command names todo --- .../todos/{pending => done}/bonfire-duplicate-command-names.md | 2 ++ 1 file changed, 2 insertions(+) rename .planning/todos/{pending => done}/bonfire-duplicate-command-names.md (80%) diff --git a/.planning/todos/pending/bonfire-duplicate-command-names.md b/.planning/todos/done/bonfire-duplicate-command-names.md similarity index 80% rename from .planning/todos/pending/bonfire-duplicate-command-names.md rename to .planning/todos/done/bonfire-duplicate-command-names.md index 27791127..7697b0e6 100644 --- a/.planning/todos/pending/bonfire-duplicate-command-names.md +++ b/.planning/todos/done/bonfire-duplicate-command-names.md @@ -11,3 +11,5 @@ g15office: u4rtpcl1 Found while writing `docs/console/writing-commands.md` (Phase 11.1 plan 03). The page describes the current behaviour: names are not checked for duplicates, so keep commands in the plugin's own namespace. Suggested fix: make `bonfire.NewRoot` fail with an error naming the duplicated command when two commands share a name. `bonfire.NewCatalog`, which the scheduler calls through, has no error return, but the generated `main` calls `bonfire.NewRoot` before it runs any command, so that check stops the binary before a duplicate can run. Update the bonfire README and the docs page in the same change (the D-13 docs rule). The API change is outside the docs phase boundary, so it is not made in Phase 11.1. + +Done in Phase 19.8 plan 02, commit 8d4d7ce: `bonfire.NewRoot` fails with `bonfire.ErrDuplicateCommand` naming the command (also for commands named `list` or `help`), and with `bonfire.ErrReservedFlag` for flags that reuse a global option; the bonfire README and `docs/console/writing-commands.md` describe it.