From 8751f922307fe476961a5e97e1525b8bbff84c52 Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Sat, 14 Nov 2026 15:32:25 +0100 Subject: [PATCH] docs(35-08): record plan completion in state and roadmap --- .planning/ROADMAP.md | 4 ++-- .planning/STATE.md | 29 +++++++++++++++++------------ 2 files changed, 19 insertions(+), 14 deletions(-) diff --git a/.planning/ROADMAP.md b/.planning/ROADMAP.md index 3d46e008..639cd5db 100644 --- a/.planning/ROADMAP.md +++ b/.planning/ROADMAP.md @@ -1936,7 +1936,7 @@ Plans: **Requirements**: TBD **Depends on:** Phase 34 **Context:** postcard already loads plugin templates and layouts from `views/mail/` (`pact.HasMailTemplates`, `postcard.BootPlugin`); this phase adds the editable database layer, admin screens and image handling on top. To confirm in discussion: partials (WinterCMS mail partials), preview and test send, per-locale variants, and whether the screens live in cabana or in a plugin. -**Plans:** 7/9 plans executed +**Plans:** 8/9 plans executed Plans: **Wave 1** @@ -1961,7 +1961,7 @@ Plans: - [x] 35-07-PLAN.md — unit tests for both gaps and `scripts/check-phase35.sh` with a read-only scratch-modfile consumers stage **Wave 8** *(gap closure CR-01, blocked on Wave 7 completion)* -- [ ] 35-08-PLAN.md — URL-scheme check on decoded attribute values instead of the whole document, a site name never stops a send (dropped with a warning) and an unsafe one is refused on the Branding form, the inlined result never stops mail, literal footer (CR-01, WR-01, WR-05), decision note +- [x] 35-08-PLAN.md — URL-scheme check on decoded attribute values instead of the whole document, a site name never stops a send (dropped with a warning) and an unsafe one is refused on the Branding form, the inlined result never stops mail, literal footer (CR-01, WR-01, WR-05), decision note **Wave 9** *(gap closure tests, blocked on Wave 8 completion)* - [ ] 35-09-PLAN.md — regression and unit tests for CR-01, WR-01 and WR-05, new names required by `scripts/check-phase35.sh` (plus the IN-03 self-test fix), validation map diff --git a/.planning/STATE.md b/.planning/STATE.md index 5afa8689..db3ec006 100644 --- a/.planning/STATE.md +++ b/.planning/STATE.md @@ -2,18 +2,18 @@ msd_state_version: "1.0" milestone: v1.0 current_phase: 35 -current_phase_name: mail-templates-and-layouts-editor +current_phase_name: Mail templates and layouts editor status: executing -stopped_at: Completed 35-07-PLAN.md -last_updated: "2026-11-14T14:02:34.272Z" -last_activity: 2026-11-13 +stopped_at: Completed 35-08-PLAN.md +last_updated: "2026-11-14T14:32:00.743Z" +last_activity: 2026-11-14 last_activity_desc: Phase 35 execution started -state_head: 6e8cead959c42abe21a0899cb47a8e593f7fd348 +state_head: c4d0bbecc42a90f9d6c33ede91ea02c56f6b9884 progress: total_phases: 52 completed_phases: 37 total_plans: 304 - completed_plans: 291 + completed_plans: 292 gsd_state_version: "1.0" milestone_name: milestone --- @@ -25,14 +25,14 @@ milestone_name: milestone See: .planning/PROJECT.md (updated 2026-10-22) **Core value:** An existing WinterCMS-shaped app can be ported plugin by plugin to a single Go binary without its frontend noticing: the PHP version's API contract is the acceptance test. -**Current focus:** Phase 35 — mail-templates-and-layouts-editor +**Current focus:** Phase 35 — Mail templates and layouts editor ## Current Position -Phase: 35 (mail-templates-and-layouts-editor) — READY TO EXECUTE -Plan: 4 of 4 +Phase: 35 (Mail templates and layouts editor) — EXECUTING +Plan: 2 of 9 Status: Ready to execute -Last activity: 2026-11-13 — Phase 35 execution started +Last activity: 2026-11-14 — Phase 35 execution started Progress: [████████░░] 82% @@ -320,6 +320,7 @@ Progress: [████████░░] 82% | Phase 35 P05 | 28 min | 3 tasks | 29 files | | Phase 35 P06 | 33 min | 3 tasks | 34 files | | Phase 35 P07 | 49 min | 3 tasks | 11 files | +| Phase 35 P08 | 24 min | 3 tasks | 22 files | ## Accumulated Context @@ -1124,6 +1125,10 @@ Recent decisions affecting current work: - [Phase 35]: 35-07: check-phase35.sh consumers run each core plugin through a scratch -modfile (sibling go.sum merged with the framework's, GOWORK=off, GOPROXY=off) and refuse a sibling that is dirty before or after - [Phase 35]: 35-07: G-35-8 recorded as framework-closed with the plugin part deferred; UAT test 8 re-run scoped to the built-in layouts (default, system) with logo, site name and the button partial - [Phase 35]: 35-07: Branding site name with a URL scheme stays an open item; TestMailBrandSiteName pins the current behaviour (saved, preview refused) +- [Phase 35]: 35-08: postcard checks URL schemes only in decoded URL-bearing attributes, CSS, comments and meta content (x/net/html tokenizer); text is not a URL, so prose site names no longer stop mail (CR-01) +- [Phase 35]: 35-08: postcard.UnsafeText (new exported API) drops unsafe site names at render with a value-free rate-limited warning and backs the Branding 422 on site_name (mail.brand.site_name_unsafe) +- [Phase 35]: 35-08: an inlined result that fails the safety check is sent un-inlined with the inline: warning; the footer partial's text argument prints the site name literally +- [Phase 35]: 35-08: cabana settings Put localizes BeforeValidate refusal phrase keys, as controller saves do ### Pending Todos @@ -1271,6 +1276,6 @@ Items acknowledged and carried forward from previous milestone close: ## Session Continuity -Last session: 2026-11-13T21:11:20.401Z -Stopped at: Completed 35-07-PLAN.md +Last session: 2026-11-14T14:31:37.513Z +Stopped at: Completed 35-08-PLAN.md Resume file: None