docs(quick-batch-261105-oc4): security hardening batch, 5 items, 12 todos closed

This commit is contained in:
Jakub Zych
2026-11-05 18:46:35 +01:00
parent 27c98bf22a
commit 895248eef2
23 changed files with 2470 additions and 0 deletions

View File

@@ -17,3 +17,7 @@ To fix later:
- Add a test in sm-user-plugin (a gate that challenges, then activate-by-code answers the challenge) and an end-to-end case in sm-mfa-plugin's `TestEveryLoginPathIsGated`, and update its `tokenMints` reason.
- Release sm-user-plugin as a patch and bump sm-demo-app, sm-bm-app and fonoteka.go in separate commits (D-17 order).
- Until then, `TestEveryLoginPathIsGated/mint_sites` lists `ActivateByCode` with a pointer to F-1, so any change to the mint sites fails until the list is updated.
## Closed 2026-11-05
Fixed in quick 261105-oc5: sm-user-plugin b179e6b (activate-by-code asks the login gates). Untagged; release sm-user-plugin v0.1.20 and bump the apps.

View File

@@ -14,3 +14,7 @@ Full fix (a contract change, user deferred it on 2026-10-26):
- Require a `password` field (or a current factor) on those routes, refused with the existing 403 `{"error":"Password confirmation required."}` and counted in the login throttle like the recovery-code routes (WR-06, 0a08070).
- Update the frontends that call them (sm-demo-app's vue-demo-app `pages/account/security.vue` and any app frontend) to ask for the password.
- Release sm-mfa-plugin as a minor/patch together with the frontend change, and bump the apps in separate commits.
## Closed 2026-11-05
Fixed in quick 261105-oc5: sm-mfa-plugin 3aa52c6 (golem15.mfa.factor_changes_require_password, default true), vue-demo-app 848ee1e, sm-demo-app 7b75d2c. Untagged; release sm-mfa-plugin v0.2.0.

View File

@@ -19,3 +19,7 @@ Follow-up from quick 261028-rqe (ba8432c, 4957e5c). `attach.Store` saves `Conten
- Make both handlers send the stored disposition (and `X-Content-Type-Options: nosniff`), additive.
- Blob writers that bypass `attach.Store` can adopt `attach.IsInlineContentType`: fonoteka.go `storeUpload`/`StorePublicFile` (see `2026-10-28-fonoteka-uploads-use-disk-extension.md`), the sm-user-plugin avatar writer, the sm-feedback-plugin screenshot writer.
- Adding the disposition to objects already in a bucket stays an operator task (documented in `docs/services/storage.md#deploy-note`).
## Closed 2026-11-05
Fixed in quick 261105-oc8: summercms.go 27c98bf. Writers that bypass attach.Store (fonoteka.go, sm-user avatar, sm-feedback screenshot) remain follow-ups.

View File

@@ -19,3 +19,7 @@ chatchannels gates PinMessage and UnpinMessage only with channel access, which t
Additively in chatchannels: PinMessage and UnpinMessage require CanManageContext, or an optional contracts.PinPolicy the host implements; the demo answers it from its moderator group. Verify message.conversation_id equals the channel's conversation before creating the pin. Meanwhile the demo layer can hide pin actions for non-moderators, but the server must enforce the rule.
Source: phase 20 code review (20-REVIEW.md WR-02).
## Closed 2026-11-05
Fixed in quick 261105-oc6: sm-chatchannels-plugin a042536, sm-demo-app ce800f2/7e4b9d3/11d3afc. Untagged; sm-bm-app needs CanPin before it bumps.

View File

@@ -18,3 +18,7 @@ The server has no DM-only rule; channel calls are refused today only because the
Add an optional host hook in chatvideo (for example CanStartCall(conversationType)), or check conversation.type == dm in the demo, so the rule does not depend on seed data.
Source: phase 20 code review (20-REVIEW.md IN-01).
## Closed 2026-11-05
Fixed in quick 261105-oc7: sm-chatvideo-plugin 11a9607 (contracts.CallPolicy, DMOnly), sm-demo-app fbfdcf6.

View File

@@ -17,3 +17,7 @@ Two video:call:incoming events for the same session, both pending in subscribe,
Keep a sequence number per watchSession and close the handle unless it is the latest.
Source: phase 20 code review (20-REVIEW.md IN-07).
## Closed 2026-11-05
Fixed in quick 261105-oc7: vue-chatvideo-layer 6d5784d. Untagged.

View File

@@ -18,3 +18,7 @@ chatvideo checks participant rows only. A ban revokes the user's JWTs, but an al
Have chatvideo honour LiveMembership (through chat's Service.IsParticipant) in requireParticipant and the authorizer, and remove the participant from the LiveKit room on a ban.
Source: phase 20 code review (20-REVIEW.md IN-02).
## Closed 2026-11-05
Fixed in quick 261105-oc7: sm-chatvideo-plugin f996156. Untagged.

View File

@@ -17,3 +17,7 @@ check-local still puts member JWTs into -H "Authorization: Bearer ..." arguments
Give request() an optional JWT that it writes as header = "Authorization: Bearer ..." into a curl config on stdin (curl -K -), as check-moderation.sh does, and drop every -H Authorization argument.
Source: phase 20 code review (20-REVIEW.md IN-03).
## Closed 2026-11-05
Fixed in quick 261105-oc9: sm-demo-app 55620dc.

View File

@@ -17,3 +17,7 @@ The GET assigns handles to members that lack one (two concurrent first loads rac
Select with the memberWhere subquery (WHERE id <> ? AND <memberWhere>) instead of an id list, and assign missing handles at registration or in demo:seed, not in a GET.
Source: phase 20 code review (20-REVIEW.md IN-09).
## Closed 2026-11-05
Fixed in quick 261105-oc9: sm-demo-app 9595606.

View File

@@ -18,3 +18,7 @@ Browsers need only /rtc and /rtc/validate, but the /livekit/ location also expos
Use location ^~ /livekit/rtc { proxy_pass http://127.0.0.1:7890/rtc; ... } and answer 404 for the rest of /livekit/; adjust check-deploy and check-live. A vhost change on rome needs its own go-ahead.
Source: phase 20 code review (20-REVIEW.md IN-06).
## Closed 2026-11-05
Fixed in quick 261105-oc9: sm-demo-app 6c52514. Committed only; installing the vhost on rome needs its own go-ahead.

View File

@@ -17,3 +17,7 @@ seedModerationLists refills both lists whenever both are empty, and every releas
Seed only once: insert the lists when the settings row is created, or record a seeded flag.
Source: phase 20 code review (20-REVIEW.md IN-05).
## Closed 2026-11-05
Fixed in quick 261105-oc9: sm-demo-app 5630d92 (golem15.demo migration).

View File

@@ -17,3 +17,7 @@ The remote script uses set -e without pipefail. If herald:vapid-generate fails,
Use set -eo pipefail, generate into a variable first, check both keys are non-empty, then append all three lines in one tee.
Source: phase 20 code review (20-REVIEW.md IN-08).
## Closed 2026-11-05
Fixed in quick 261105-oc9: sm-demo-app 054cda5.