golem15/summercms
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(03-03): add typed path params and per-plugin rollback

Browse Source 
Compile regex and enum constraints at route registration so malformed and unknown IDs share a 404, and named rollback errors isolate one plugin's history.

Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
Jakub Zych
2026-09-17 20:19:59 +02:00
parent a9c3e7690f
commit 8e3bf266d8
10 changed files with 354 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
examples/hello/hello_test.go
View File

@@ -127,8 +127,23 @@ func TestTypedItemRoute(t *testing.T) {
t.Fatalf("malformed id status = %d", rec.Code)
}
rec = httptest.NewRecorder()
h.ServeHTTP(rec, httptest.NewRequest(http.MethodGet, "/items/12", nil))
if rec.Code != http.StatusOK || rec.Body.String() != `{"id":12}` {
h.ServeHTTP(rec, httptest.NewRequest(http.MethodGet, "/items/99", nil))
if rec.Code != http.StatusNotFound {
t.Fatalf("unknown id status = %d", rec.Code)
}
rec = httptest.NewRecorder()
h.ServeHTTP(rec, httptest.NewRequest(http.MethodGet, "/items/1", nil))
if rec.Code != http.StatusOK || rec.Body.String() != `{"id":1}` {
t.Fatalf("got %d %s", rec.Code, rec.Body.String())
}
rec = httptest.NewRecorder()
h.ServeHTTP(rec, httptest.NewRequest(http.MethodGet, "/kinds/other", nil))
if rec.Code != http.StatusNotFound {
t.Fatalf("enum reject status = %d", rec.Code)
}
rec = httptest.NewRecorder()
h.ServeHTTP(rec, httptest.NewRequest(http.MethodGet, "/kinds/widget", nil))
if rec.Code != http.StatusOK || rec.Body.String() != `{"kind":"widget"}` {
t.Fatalf("got %d %s", rec.Code, rec.Body.String())
}
}

8
examples/hello/plugins/greeter/plugin.go
View File

@@ -59,13 +59,19 @@ func (p *Plugin) Boot(app *backpack.App) error {
func (p *Plugin) Routes(r pact.Router) error {
r.Get("/items/{id}", func(w http.ResponseWriter, req *http.Request) {
id, ok := surf.IntParam(req, "id")
if !ok {
if !ok || id != 1 {
http.NotFound(w, req)
return
}
w.Header().Set("Content-Type", "application/json")
fmt.Fprintf(w, `{"id":%d}`, id)
})
r.Where("id", `[0-9]+`)
r.Get("/kinds/{kind}", func(w http.ResponseWriter, req *http.Request) {
w.Header().Set("Content-Type", "application/json")
fmt.Fprintf(w, `{"kind":%q}`, req.PathValue("kind"))
})
r.WhereIn("kind", "widget", "gadget")
return nil
}