From 9550fe0a9f566d943d515bc47928725feb986317 Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Fri, 23 Oct 2026 12:56:08 +0200 Subject: [PATCH] docs(19.7-04): deferred items from the oauthserver, Journal and demo MCP wiring --- .../19.7-generic-mcp-module/deferred-items.md | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/.planning/phases/19.7-generic-mcp-module/deferred-items.md b/.planning/phases/19.7-generic-mcp-module/deferred-items.md index 45c6a45f..dad73633 100644 --- a/.planning/phases/19.7-generic-mcp-module/deferred-items.md +++ b/.planning/phases/19.7-generic-mcp-module/deferred-items.md @@ -63,3 +63,29 @@ was changed by the plan that recorded it. `lagoon.AfterCommit` (immediately outside a transaction); `subject_events_test.go` pins delivery to a pointer listener, no firing before commit and none after a rollback. +- pier publishes `*pier.Pier` once per application (found during 19.7-04 Task 1) + status: open + **What:** `pier.Mount` publishes the mounted endpoint on the app, so a + second `surf.BuildRouter`/`surf.Assemble` on the same `*backpack.App` + with `mcp.enabled: true` fails with `backpack: duplicate provider for + *pier.Pier`. A binary builds its router once, so serving is unaffected; + tests that build twice on one app (sm-demo-app `TestRealtimeRoutes`, + `socialServer`) now set `mcp.enabled: false`. A find-or-replace publish + (or skipping the publish when the same app already carries one) in pier + would lift it. +- MCP grants are not in the authorized-apps list (found during 19.7-04 Task 2) + status: open + **What:** the MCP flow (wristband `IssueCode`, sm-oauthserver-plugin's + `MCPStore`) stamps the client's `consented_at` but writes no row to + `golem15_oauthserver_consents`, so `GET /oauth/authorizations` does not + list an MCP client and `DELETE /oauth/authorizations/{client_id}` answers + 404 for it. The access token itself can still be revoked (row + `revoked_at`, refused by the verifier at once) and the user cascade + removes every grant, but a user has no self-service "disconnect this + agent" for MCP yet. A consent row per MCP grant (written at `IssueCode`) + would make the existing list and revocation (which already fires the + `revoked` event) cover MCP clients; plan 05's revoke matrix should decide. +- Pre-existing `gofmt` drift in sm-journal-plugin (found during 19.7-04 Task 3) + status: open + **What:** `gofmt -l` lists `classes/blog_editor_test.go` before this plan + touched the repository. Left as is.