From 9563bc836a73e78fc3a051868570f2c3408f0b95 Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Thu, 22 Oct 2026 03:19:33 +0200 Subject: [PATCH] docs(19.8): record code review disposition --- .../19.8-REVIEW-DISPOSITION.md | 106 ++++++++++++++---- 1 file changed, 83 insertions(+), 23 deletions(-) diff --git a/.planning/phases/19.8-console-commands-overhaul/19.8-REVIEW-DISPOSITION.md b/.planning/phases/19.8-console-commands-overhaul/19.8-REVIEW-DISPOSITION.md index 2c5fe5bb..f0de037b 100644 --- a/.planning/phases/19.8-console-commands-overhaul/19.8-REVIEW-DISPOSITION.md +++ b/.planning/phases/19.8-console-commands-overhaul/19.8-REVIEW-DISPOSITION.md @@ -3,6 +3,54 @@ phase: 19.8 review: 19.8-REVIEW.md titles: json findings: + - id: WR-09 + severity: warning + disposition: open + title: "Lines printed through a live view after its context is cancelled are silently dropped" + - id: WR-10 + severity: warning + disposition: open + title: "A delegate killed by a signal prints its full argv, including a --password value, and exits 1" + - id: WR-11 + severity: warning + disposition: open + title: "The wrong-directory hint leaves secret values that start with \"-\" unmasked" + - id: WR-12 + severity: warning + disposition: open + title: "migrate:status --json still drops the framework sets that migrate applies" + - id: WR-13 + severity: warning + disposition: open + title: "migrate reports failure after a successful Migrate when the follow-up read fails" + - id: WR-14 + severity: warning + disposition: open + title: "Process's plain path prints item names without Sanitize" + - id: IN-10 + severity: info + disposition: open + title: "console.Error during a live view writes straight to the terminal and tears the view" + - id: IN-11 + severity: info + disposition: open + title: "A blank line printed during a live view is dropped" + - id: IN-12 + severity: info + disposition: open + title: "Signal relay edge cases: a signal during view start-up, and Windows" + - id: IN-13 + severity: info + disposition: open + title: "A delegate's stderr always goes to os.Stderr, bypassing the root's error writer" + - id: IN-14 + severity: info + disposition: open + title: "The ErrReported doc comment still says the exit code is 1" + - id: IN-15 + severity: info + disposition: open + title: "runLive builds the bubbletea program before it knows it may run" - id: CR-01 severity: critical disposition: fixed @@ -83,35 +131,47 @@ findings: severity: info disposition: deferred title: "The phase gate names consuming applications" -open: 0 -total: 20 -recorded: 2026-10-21T22:35:50.040Z +open: 12 +total: 32 +recorded: 2026-10-22T01:19:33.337Z --- # Phase 19.8: Code Review Disposition | Finding | Severity | Disposition | Source | |---------|----------|-------------|--------| -| CR-01 | critical | fixed | fix b077dc3 (19.8-05) | -| CR-02 | critical | fixed | fix 323413c (19.8-05) | -| CR-03 | critical | fixed | fix 9c89705 (19.8-05) | -| WR-01 | warning | fixed | fix d151a25 (19.8-05) | -| WR-02 | warning | fixed | fix 86e4e27 (19.8-05) | -| WR-03 | warning | fixed | fix fc7706d (19.8-05) | -| WR-04 | warning | fixed | fix c586c6f (19.8-05) | -| WR-05 | warning | fixed | fix a9025c0 (19.8-05) | -| WR-06 | warning | fixed | fix 39677f1 (19.8-05) | -| WR-07 | warning | fixed | fix 020fe83 (19.8-05) | -| WR-08 | warning | fixed | fix 9b62285 (19.8-05) | -| IN-01 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md | -| IN-02 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md | -| IN-03 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md | -| IN-04 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md | -| IN-05 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md | -| IN-06 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md | -| IN-07 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md | -| IN-08 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md | -| IN-09 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md | +| WR-09 | warning | open | - | +| WR-10 | warning | open | - | +| WR-11 | warning | open | - | +| WR-12 | warning | open | - | +| WR-13 | warning | open | - | +| WR-14 | warning | open | - | +| IN-10 | info | open | - | +| IN-11 | info | open | - | +| IN-12 | info | open | - | +| IN-13 | info | open | - | +| IN-14 | info | open | - | +| IN-15 | info | open | - | +| CR-01 | critical | fixed | fix b077dc3 (19.8-05) (not in the current review) | +| CR-02 | critical | fixed | fix 323413c (19.8-05) (not in the current review) | +| CR-03 | critical | fixed | fix 9c89705 (19.8-05) (not in the current review) | +| WR-01 | warning | fixed | fix d151a25 (19.8-05) (not in the current review) | +| WR-02 | warning | fixed | fix 86e4e27 (19.8-05) (not in the current review) | +| WR-03 | warning | fixed | fix fc7706d (19.8-05) (not in the current review) | +| WR-04 | warning | fixed | fix c586c6f (19.8-05) (not in the current review) | +| WR-05 | warning | fixed | fix a9025c0 (19.8-05) (not in the current review) | +| WR-06 | warning | fixed | fix 39677f1 (19.8-05) (not in the current review) | +| WR-07 | warning | fixed | fix 020fe83 (19.8-05) (not in the current review) | +| WR-08 | warning | fixed | fix 9b62285 (19.8-05) (not in the current review) | +| IN-01 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md (not in the current review) | +| IN-02 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md (not in the current review) | +| IN-03 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md (not in the current review) | +| IN-04 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md (not in the current review) | +| IN-05 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md (not in the current review) | +| IN-06 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md (not in the current review) | +| IN-07 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md (not in the current review) | +| IN-08 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md (not in the current review) | +| IN-09 | info | deferred | todo .planning/todos/pending/2026-10-22-console-review-info-findings.md (not in the current review) | Dispositions: `open` (recorded, not yet triaged), `fixed`, `skipped`, `deferred`. Set `deferred` by hand and put the reason in the Source cell; both are preserved. A `|` in the reason is kept as prose and escaped on the next run.