diff --git a/.planning/phases/35-mail-templates-and-layouts-editor/35-VERIFICATION.md b/.planning/phases/35-mail-templates-and-layouts-editor/35-VERIFICATION.md index 086a7fd8..c04b4f4c 100644 --- a/.planning/phases/35-mail-templates-and-layouts-editor/35-VERIFICATION.md +++ b/.planning/phases/35-mail-templates-and-layouts-editor/35-VERIFICATION.md @@ -1,8 +1,8 @@ --- phase: 35-mail-templates-and-layouts-editor -verified: 2026-11-13T21:30:50Z +verified: 2026-11-14T15:23:23Z status: gaps_found -score: 13/14 must-haves verified +score: 18/22 must-haves verified covered_files: - .planning/phases/35-mail-templates-and-layouts-editor/35-01-PLAN.md - .planning/phases/35-mail-templates-and-layouts-editor/35-01-SUMMARY.md @@ -18,6 +18,10 @@ covered_files: - .planning/phases/35-mail-templates-and-layouts-editor/35-06-SUMMARY.md - .planning/phases/35-mail-templates-and-layouts-editor/35-07-PLAN.md - .planning/phases/35-mail-templates-and-layouts-editor/35-07-SUMMARY.md + - .planning/phases/35-mail-templates-and-layouts-editor/35-08-PLAN.md + - .planning/phases/35-mail-templates-and-layouts-editor/35-08-SUMMARY.md + - .planning/phases/35-mail-templates-and-layouts-editor/35-09-PLAN.md + - .planning/phases/35-mail-templates-and-layouts-editor/35-09-SUMMARY.md - admin/openapi/admin.json - admin/package-lock.json - admin/package.json @@ -137,6 +141,7 @@ covered_files: - modules/cabana/mail_permissions_postgres_test.go - modules/cabana/mail_routes.go - modules/cabana/mail_screens_smoke_test.go + - modules/cabana/mail_site_name_postgres_test.go - modules/cabana/mail_test_send_postgres_test.go - modules/cabana/mail_unit_test.go - modules/cabana/messages.go @@ -187,8 +192,12 @@ covered_files: - modules/postcard/partials.go - modules/postcard/partials_smoke_test.go - modules/postcard/partials_test.go + - modules/postcard/safety.go + - modules/postcard/safety_smoke_test.go + - modules/postcard/safety_test.go - modules/postcard/samples.go - modules/postcard/samples_test.go + - modules/postcard/sitename_test.go - modules/postcard/store.go - modules/postcard/store_postgres_test.go - modules/postcard/templates.go @@ -196,284 +205,284 @@ covered_files: - modules/surf/serve.go - modules/surf/store_lookup_test.go - scripts/check-phase35.sh -covered_digest: "v2:sha256:f4b2434769c05675324d4203048de747593a6027ea0f5084450f9ea23790f146" +covered_digest: "v2:sha256:621fe9f6410fdd232b5b21c9b7b8b25050f32f17f113fa8f2ef654e1b2707c49" behavior_unverified: 0 overrides_applied: 0 re_verification: - previous_status: human_needed - previous_score: 12/12 + previous_status: gaps_found + previous_score: 13/14 gaps_closed: - - "G-35-1: locale variants of one mail template are one admin record with a locale switcher (35-05, tests in 35-07); automated evidence green, visual re-run of UAT test 1 still owed" - - "G-35-8 (framework part): built-in default/system/minimal layouts with logo-or-name header, card, footer, Branding site name, button partial, CSS inlining with opt-out (35-06, tests in 35-07); scoped visual re-run of UAT test 8 still owed" - gaps_remaining: [] + - "CR-01 colon class: a site name with ordinary colon prose ('Metadata: Weekly' from mail.from, 'Big Data: Summit' from Branding) now renders in header and footer and sends on the default and system layouts on every render path (TestSiteNameSend PASS; verifier probe UnsafeText false for both)" + - "CR-01 script-URL class: a site name holding javascript:/vbscript:/data: is dropped at render with a rate-limited warning, refused on the Branding form (422 on site_name, en/pl), and stored ones do not block saves or sends (TestUnsafeSiteNameDropped, TestMailSiteNameSafety PASS)" + - "WR-01 (prior advisory): footer prints the site name literally (TestFooterSiteNameLiteral PASS)" + - "WR-05 (prior advisory), contradiction part: an inlined result that fails the check is sent as its style-block version (TestInlineUnsafeOutput PASS); encoded href=\"javascript:...\" is refused with inlining on and off (TestURLSchemeCheck PASS)" + gaps_remaining: + - "Mail that already works keeps working / no Branding value stops mail on the built-in layouts: still FAILED for site names that begin with on= (CR-01 residual, reproduced by the verifier)" regressions: - - "CR-01 (new in 35-06): a site name containing javascript:/vbscript:/data: (Branding Site name, or the display name of mail.from with no admin action) makes every send on the default and system layouts fail, including the file-version fallback; reproduced by the verifier" + - "CR-02 (new in 35-08): replacing the whole-document scheme regex with a tokenizer-only walk lets javascript: URLs inside