feat(surf): branded HTML error pages for browser navigations
A browser navigation (Sec-Fetch-Mode navigate, or GET/HEAD without it; no X-Requested-With; Accept naming text/html above every JSON type; not /api, /_<name> or the admin prefix) that hits a framework-generated 404, 405 or 500 gets a self-contained SummerCMS page: unmatched routes and wrong methods at the ServeMux, failed Where/WhereIn constraints, overlap-family misses, the unpublished uploads route and recovered panics. Every other request keeps the exact stdlib text, wire's opaque JSON 500 or the bare raw-group 500. Details (method, path, X-Request-Id) only with app.debug or outside production. Applications replace the page with a published surf.ErrorPageRenderer; http.error_pages.enabled false turns it off.
This commit is contained in:
@@ -168,19 +168,19 @@ func TestAccessLogClientClosedRequest(t *testing.T) {
|
||||
})
|
||||
}, outcome{200, true}},
|
||||
{"5xx through the JSON recovery after the client went away", func(cancel context.CancelFunc) http.Handler {
|
||||
return recordPattern("GET /blog/posts/{id}", recoverJSON(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
||||
return recordPattern("GET /blog/posts/{id}", recoverJSON(nil, http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
|
||||
cancel()
|
||||
w.WriteHeader(http.StatusInternalServerError)
|
||||
})))
|
||||
}, outcome{499, true}},
|
||||
{"panic after the client went away (JSON group)", func(cancel context.CancelFunc) http.Handler {
|
||||
return recordPattern("GET /blog/posts/{id}", recoverJSON(http.HandlerFunc(func(http.ResponseWriter, *http.Request) {
|
||||
return recordPattern("GET /blog/posts/{id}", recoverJSON(nil, http.HandlerFunc(func(http.ResponseWriter, *http.Request) {
|
||||
cancel()
|
||||
panic("blog: broken")
|
||||
})))
|
||||
}, outcome{500, true}},
|
||||
{"panic after the client went away (raw group)", func(cancel context.CancelFunc) http.Handler {
|
||||
return recordPattern("GET /blog/posts/{id}", recoverBare(http.HandlerFunc(func(http.ResponseWriter, *http.Request) {
|
||||
return recordPattern("GET /blog/posts/{id}", recoverBare(nil, http.HandlerFunc(func(http.ResponseWriter, *http.Request) {
|
||||
cancel()
|
||||
panic("blog: broken")
|
||||
})))
|
||||
|
||||
Reference in New Issue
Block a user