docs(09): record approved review decisions and close UAT

This commit is contained in:
Jakub Zych
2026-10-01 23:13:02 +02:00
parent 2da8112dbb
commit ba1aaefa01
2 changed files with 15 additions and 16 deletions

View File

@@ -1,39 +1,38 @@
---
status: testing
status: complete
phase: 09-backend-admin-authentication-and-schema-pipeline
source: [09-VERIFICATION.md]
started: 2026-09-27T22:03:21Z
updated: 2026-09-27T22:03:21Z
updated: 2026-10-01T22:30:00Z
---
## Current Test
number: 1
name: Decide CR-01 (admin CRUD cannot save a writable number field; type mismatches return 500 instead of 422)
expected: |
Either fix it before closing Phase 9 (normalize json.Number before lagoon.Fill or teach convertValue about it, map conversion failures to a per-field 422, add a CRUD test writing a non-protected number field bound to an int column), or record an explicit deferral or override with a reason.
awaiting: user response
[testing complete]
## Tests
### 1. Decide CR-01 (admin CRUD cannot save a writable number field; type mismatches return 500 instead of 422)
expected: Fixed before closing Phase 9, or an explicit deferral/override with a reason is recorded.
result: [pending]
result: pass
note: Fixed in Phase 10.1 (c3efbc3, e60e697); `TestCRUDFillTypeIsValidation` passes. Recorded as already fixed in 09-REVIEW-FIX.md.
### 2. Triage the 19 open code-review warnings (priority: WR-01, WR-02, WR-14, WR-17 for AUTH-08 Winter permission semantics)
expected: Each warning set to fixed, deferred (with reason) or skipped in 09-REVIEW-DISPOSITION.md; none left open.
result: [pending]
result: pass
note: WR-01 to WR-19 are all fixed (09-REVIEW-FIX.md, ledger 2ecc85e). The three follow-up choices were approved by the user on 2026-10-01: WR-11 index added (2da8112), WR-03 and WR-17 kept as Winter.
### 3. Review the 24 judgment-tier prohibitions in 09-VERIFICATION.md
expected: Verdicts accepted or rejected; the two qualified ones (09-11 #1 navigation reveals albums target to a genres-only admin, WR-02; 09-12 #1 zero-test detection per invocation, not per package, WR-18) are resolved.
result: [pending]
result: pass
note: Verdicts accepted by the user on 2026-10-01. 09-11 #1 (WR-02) and 09-12 #1 (WR-18) are no longer violated after the fixes. 09-03 #1 (`type: partial` refused) is confirmed as superseded by Phase 10.1 D-09, which allows only a bare-name, sanitized html/template partial; the path-less Winter partial is still refused.
## Summary
total: 3
passed: 0
passed: 3
issues: 0
pending: 3
pending: 0
skipped: 0
blocked: 0