From c1e8e57e2969f3a1224f18761a975188bbc0e565 Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Sat, 14 Nov 2026 18:01:32 +0100 Subject: [PATCH] docs(35): re-verify after review fixes - CR-02 quoted end-tag residual open --- .../35-VERIFICATION.md | 294 +++++++++--------- 1 file changed, 149 insertions(+), 145 deletions(-) diff --git a/.planning/phases/35-mail-templates-and-layouts-editor/35-VERIFICATION.md b/.planning/phases/35-mail-templates-and-layouts-editor/35-VERIFICATION.md index c04b4f4c..56816068 100644 --- a/.planning/phases/35-mail-templates-and-layouts-editor/35-VERIFICATION.md +++ b/.planning/phases/35-mail-templates-and-layouts-editor/35-VERIFICATION.md @@ -1,8 +1,8 @@ --- phase: 35-mail-templates-and-layouts-editor -verified: 2026-11-14T15:23:23Z +verified: 2026-11-14T16:58:10Z status: gaps_found -score: 18/22 must-haves verified +score: 21/22 must-haves verified covered_files: - .planning/phases/35-mail-templates-and-layouts-editor/35-01-PLAN.md - .planning/phases/35-mail-templates-and-layouts-editor/35-01-SUMMARY.md @@ -205,67 +205,54 @@ covered_files: - modules/surf/serve.go - modules/surf/store_lookup_test.go - scripts/check-phase35.sh -covered_digest: "v2:sha256:621fe9f6410fdd232b5b21c9b7b8b25050f32f17f113fa8f2ef654e1b2707c49" +covered_digest: "v2:sha256:f7c3f2115a39b52bac7bbc970599c28a13b09b580c1289a09fb07f222deff9c4" behavior_unverified: 0 overrides_applied: 0 re_verification: previous_status: gaps_found - previous_score: 13/14 + previous_score: 18/22 gaps_closed: - - "CR-01 colon class: a site name with ordinary colon prose ('Metadata: Weekly' from mail.from, 'Big Data: Summit' from Branding) now renders in header and footer and sends on the default and system layouts on every render path (TestSiteNameSend PASS; verifier probe UnsafeText false for both)" - - "CR-01 script-URL class: a site name holding javascript:/vbscript:/data: is dropped at render with a rate-limited warning, refused on the Branding form (422 on site_name, en/pl), and stored ones do not block saves or sends (TestUnsafeSiteNameDropped, TestMailSiteNameSafety PASS)" - - "WR-01 (prior advisory): footer prints the site name literally (TestFooterSiteNameLiteral PASS)" - - "WR-05 (prior advisory), contradiction part: an inlined result that fails the check is sent as its style-block version (TestInlineUnsafeOutput PASS); encoded href=\"javascript:...\" is refused with inlining on and off (TestURLSchemeCheck PASS)" + - "CR-01 residual: Branding 'Online=Shop'/'onboarding=team' and mail.from '\"Online=Shop\" ' now send on the default and system layouts (verifier probe: all 8 sends err=; TestSiteNameSend, TestUnsafeSiteNameDropped PASS); Editor.Validate of a template under Branding 'Online=Shop' is accepted; body text 'Ada, buy one = get one free' sends (WR-02, handler regex removed from templates.go)" + - "CR-02, the payloads it named: javascript:/onerror inside