From c96001abc128108296d250fc4dded40a4da3b781 Mon Sep 17 00:00:00 2001 From: Jakub Zych Date: Tue, 13 Oct 2026 18:00:49 +0200 Subject: [PATCH] docs(18): record code review disposition --- .../18-REVIEW-DISPOSITION.md | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 .planning/phases/18-payment-gateway/18-REVIEW-DISPOSITION.md diff --git a/.planning/phases/18-payment-gateway/18-REVIEW-DISPOSITION.md b/.planning/phases/18-payment-gateway/18-REVIEW-DISPOSITION.md new file mode 100644 index 0000000..a98ee37 --- /dev/null +++ b/.planning/phases/18-payment-gateway/18-REVIEW-DISPOSITION.md @@ -0,0 +1,19 @@ +--- +phase: 18 +review: 18-REVIEW.md +titles: json +findings: +open: 0 +total: 0 +unparsed: 48 +recorded: 2026-10-13T16:00:48.989Z +--- + +# Phase 18: Code Review Disposition + +| Finding | Severity | Disposition | Source | +|---------|----------|-------------|--------| + +Dispositions: `open` (recorded, not yet triaged), `fixed`, `skipped`, `deferred`. +Set `deferred` by hand and put the reason in the Source cell; both are preserved. A `|` in the reason is kept as prose and escaped on the next run. +Re-running the gate keeps every row it can. A row the current review no longer reports is kept and its Source cell flagged, so a finding does not leave this record silently. ONE exception: when a finding id is REUSED by a different finding, the earlier decision cannot keep a row — the id is taken — and it is dropped. A RECORDED decision (anything but `open`) is named on the console when that happens; a row still at `open` is replaced silently, because `open` records no decision to lose.