golem15/summercms
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(14): record code review disposition

Browse Source
This commit is contained in:
Jakub Zych
2026-10-04 08:13:17 +02:00
parent 5d3299b26f
commit d5a8ef7834
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
.planning/phases/14-domain-jobs-and-external-integrations/14-REVIEW-DISPOSITION.md
View File

@@ -13,7 +13,7 @@ findings:
title: "A stale CSV match pass can cancel, advance or fork a remapped import (the race D-10 claims to close)" title: "A stale CSV match pass can cancel, advance or fork a remapped import (the race D-10 claims to close)"
- id: WR-02 - id: WR-02
severity: warning severity: warning
disposition: open disposition: fixed
title: "The anonymous feedback upload keeps an attacker-chosen file extension in public storage" title: "The anonymous feedback upload keeps an attacker-chosen file extension in public storage"
- id: WR-03 - id: WR-03
severity: warning severity: warning
@@ -21,15 +21,15 @@ findings:
title: "Credential-test routes are unthrottled oracles for third-party keys (parity security hole)" title: "Credential-test routes are unthrottled oracles for third-party keys (parity security hole)"
- id: WR-04 - id: WR-04
severity: warning severity: warning
disposition: open disposition: fixed
title: "The \"write-only\" admin AI key can be redirected to any host by changing base_url" title: "The \"write-only\" admin AI key can be redirected to any host by changing base_url"
- id: WR-05 - id: WR-05
severity: warning severity: warning
disposition: open disposition: fixed
title: "`golem:import-settings` silently drops models from a repeater saved with non-sequential keys" title: "`golem:import-settings` silently drops models from a repeater saved with non-sequential keys"
- id: WR-06 - id: WR-06
severity: warning severity: warning
disposition: open disposition: fixed
title: "The G15Office sync job is not idempotent, and a retry files duplicate tasks" title: "The G15Office sync job is not idempotent, and a retry files duplicate tasks"
- id: IN-01 - id: IN-01
severity: info severity: info
@@ -63,9 +63,9 @@ findings:
severity: info severity: info
disposition: open disposition: open
title: "`wishlistReleaseMatchRules` aliases `releaseMatchRules`' backing array" title: "`wishlistReleaseMatchRules` aliases `releaseMatchRules`' backing array"
open: 15 open: 11
total: 15 total: 15
recorded: 2026-10-04T01:05:31.197Z recorded: 2026-10-04T06:13:17.500Z
--- ---
# Phase 14: Code Review Disposition # Phase 14: Code Review Disposition
@@ -74,11 +74,11 @@ recorded: 2026-10-04T01:05:31.197Z
|---------|----------|-------------|--------| |---------|----------|-------------|--------|
| CR-01 | critical | open | - | | CR-01 | critical | open | - |
| WR-01 | warning | open | - | | WR-01 | warning | open | - |
| WR-02 | warning | open | - | | WR-02 | warning | fixed | 14-REVIEW-FIX.md |
| WR-03 | warning | open | - | | WR-03 | warning | open | - |
| WR-04 | warning | open | - | | WR-04 | warning | fixed | 14-REVIEW-FIX.md |
| WR-05 | warning | open | - | | WR-05 | warning | fixed | 14-REVIEW-FIX.md |
| WR-06 | warning | open | - | | WR-06 | warning | fixed | 14-REVIEW-FIX.md |
| IN-01 | info | open | - | | IN-01 | info | open | - |
| IN-02 | info | open | - | | IN-02 | info | open | - |
| IN-03 | info | open | - | | IN-03 | info | open | - |
@@ -89,3 +89,5 @@ recorded: 2026-10-04T01:05:31.197Z
| IN-08 | info | open | - | | IN-08 | info | open | - |
Dispositions: `open` (recorded, not yet triaged), `fixed`, `skipped`, `deferred`. Dispositions: `open` (recorded, not yet triaged), `fixed`, `skipped`, `deferred`.
Set `deferred` by hand and put the reason in the Source cell; both are preserved. A `|` in the reason is kept as prose and escaped on the next run.
Re-running the gate keeps every row it can. A row the current review no longer reports is kept and its Source cell flagged, so a finding does not leave this record silently. ONE exception: when a finding id is REUSED by a different finding, the earlier decision cannot keep a row — the id is taken — and it is dropped. A RECORDED decision (anything but `open`) is named on the console when that happens; a row still at `open` is replaced silently, because `open` records no decision to lose.