docs(35-01): complete mail domain layer plan
This commit is contained in:
@@ -0,0 +1,307 @@
|
||||
---
|
||||
phase: 35-mail-templates-and-layouts-editor
|
||||
plan: 01
|
||||
subsystem: mail
|
||||
tags: [postcard, mail, gorm, gormigrate, goldmark, html-template, pact, attach, postgres]
|
||||
|
||||
# Dependency graph
|
||||
requires:
|
||||
- phase: 04-cli-scaffolding-i18n-and-mail
|
||||
provides: postcard Catalog, Mailer, drivers and pact.HasMailTemplates
|
||||
- phase: lagoon attach (system_files, public URLs)
|
||||
provides: attach.Migrations, attach.BlobKey, storage.uploads.* config keys
|
||||
provides:
|
||||
- "postcard-owned mail tables (system_mail_templates, _layouts, _partials, _brand_settings, _image_library) as the framework migration set summercms.postcard"
|
||||
- "per-send override lookup (OverrideSource, NewDBSource) with fallback to the file version"
|
||||
- "pact.HasMailPartials, the partial template func, built-in partials button/panel/table/subcopy and layouts system/minimal"
|
||||
- "sample.<path> header keys and the placeholder walker"
|
||||
- "file hashes, the catalog read API, SyncIndex and ResetOverride"
|
||||
- "postcard.Editor: Validate, Preview and SendDraft for template, layout, partial and Branding drafts"
|
||||
- "Branding: Brand, DefaultBrand, CompileBrandCSS, the logoUrl layout key"
|
||||
- "attach.AbsolutePublicURL and attach.ErrNoAbsoluteURL"
|
||||
- "pact.RowStateCustomized and pact.RowStateOutdated"
|
||||
affects: [35-02, 35-03, 35-04, cabana, admin-spa]
|
||||
|
||||
# Actuals (#2632)
|
||||
actuals:
|
||||
tokens: 69814 # chars/4 over this plan's realized diff (modules/ and docs/, 279256 chars)
|
||||
tasks: 5 # the Task 1 decision checkpoint and Tasks 2-5
|
||||
commits: 6 # MEASURED: git rev-list --count; 5 are this plan's, 1 (f8fa0f1 docs(31)) is another session's
|
||||
plan_head_before: 3198bbe1aa96781b18398a3651b7de6d37939fba
|
||||
plan_head_after: 2bf9081c1bd8385b45210ead8524eda5512b3ca1
|
||||
|
||||
# Tech tracking
|
||||
tech-stack:
|
||||
added: []
|
||||
patterns:
|
||||
- "A module that lagoon must migrate but that cannot import lagoon ships its own gormigrate set and reads the *gorm.DB through backpack per call"
|
||||
- "Template funcs that must survive Markdown return a per-render random alphanumeric token, swapped after conversion"
|
||||
- "Drafts are rendered by the send path with the draft injected as an override, so previews and save checks cannot drift from sends"
|
||||
|
||||
key-files:
|
||||
created:
|
||||
- modules/postcard/store.go
|
||||
- modules/postcard/partials.go
|
||||
- modules/postcard/samples.go
|
||||
- modules/postcard/editor.go
|
||||
- modules/postcard/brand.go
|
||||
- modules/postcard/assets/system.htm
|
||||
- modules/postcard/assets/minimal.htm
|
||||
- modules/postcard/assets/sample.htm
|
||||
- modules/postcard/assets/brand.css.tmpl
|
||||
- modules/postcard/assets/partials/button.htm
|
||||
- modules/postcard/assets/partials/panel.htm
|
||||
- modules/postcard/assets/partials/table.htm
|
||||
- modules/postcard/assets/partials/subcopy.htm
|
||||
- modules/postcard/override_smoke_test.go
|
||||
- modules/postcard/partials_smoke_test.go
|
||||
- modules/postcard/editor_smoke_test.go
|
||||
- modules/postcard/brand_smoke_test.go
|
||||
- modules/lagoon/attach/absolute.go
|
||||
modified:
|
||||
- modules/postcard/mailer.go
|
||||
- modules/postcard/templates.go
|
||||
- modules/postcard/README.md
|
||||
- modules/pact/capabilities.go
|
||||
- modules/pact/README.md
|
||||
- modules/lagoon/migrations.go
|
||||
- modules/lagoon/pending_test.go
|
||||
- modules/lagoon/README.md
|
||||
- docs/services/mail.md
|
||||
- docs/services/storage.md
|
||||
- docs/plugins/registration.md
|
||||
- docs/database/migrations.md
|
||||
|
||||
key-decisions:
|
||||
- "35-01 Task 1 answered as-planned: P35-01 schema, P35-02 partial syntax and built-ins, P35-03 sample.* keys, P35-04 layout CSS slot and logoUrl, P35-05 names adopted without changes"
|
||||
- "35-01: postcard logs 'override failed, sending the file version' only when the file version then renders; when both fail, the file version's error is returned as before"
|
||||
- "35-01: a partial call in a body leaves the token MAILPARTIAL + 32 hex nonce + X<n>X, swapped in one pass after goldmark; raw HTML stays disabled for bodies"
|
||||
- "35-01: Editor.Validate refuses a template body whose source holds a script, iframe, object or embed tag, because Markdown would drop it silently at send"
|
||||
- "35-01: Branding (compiled CSS and logoUrl) also applies to the file version sent after a failing override; an invalid stored colour keeps mail.brandCss with a warning"
|
||||
- "35-01: pact has five row states; cabana keeps only three until 35-02 updates rowStateOrder and docs/backend/lists-and-filters.md"
|
||||
|
||||
patterns-established:
|
||||
- "Override source per send: Send asks OverrideSource once, renders with the result, and renders the files alone when the lookup or the override fails"
|
||||
- "Typed render errors (part, template, unsafe snippet) keep send error texts unchanged and let the editor report field and rule"
|
||||
|
||||
requirements-completed: [D-01, D-04, D-05, D-06, D-07, D-08, D-10, D-11, D-12, D-13, D-14, D-15, D-16, D-17, D-19, D-22, D-23, D-24, D-25]
|
||||
|
||||
coverage:
|
||||
- id: D1
|
||||
description: "A customized row in system_mail_templates changes the subject, body and layout of the mail a process sends with only postcard.Activate and a published *gorm.DB; no row, no database, missing tables or a failing override send the file version"
|
||||
requirement: "D-22"
|
||||
verification:
|
||||
- kind: integration
|
||||
ref: "modules/postcard/override_smoke_test.go#TestMailOverrideSmoke (override, override_layout, layouts_and_partials, file, fallback, caller_subject, missing_table, no_db, unknown_template, migrations_roll_back)"
|
||||
status: pass
|
||||
- kind: integration
|
||||
ref: "modules/lagoon/pending_test.go#TestMigrateStatusJSON"
|
||||
status: pass
|
||||
human_judgment: false
|
||||
- id: D2
|
||||
description: "Plugins declare partials through pact.HasMailPartials; bodies and layouts call them with {{ partial ... }}; built-in partials and the system and minimal layouts; layout and partial overrides apply at send"
|
||||
requirement: "D-12"
|
||||
verification:
|
||||
- kind: unit
|
||||
ref: "modules/postcard/partials_smoke_test.go#TestMailPartialsSmoke (capability, partials_only_plugin, body, forged_token, errors, built_in_layouts, layout_partials, overrides)"
|
||||
status: pass
|
||||
- kind: other
|
||||
ref: "go doc ./modules/pact HasMailTemplates (three methods, unchanged)"
|
||||
status: pass
|
||||
human_judgment: false
|
||||
- id: D3
|
||||
description: "sample.<path> header keys, the placeholder walker, file hashes, the catalog read API, TemplateLocale, SyncIndex, ResetOverride, and Editor Validate, Preview and SendDraft for template, layout and partial drafts"
|
||||
requirement: "D-13"
|
||||
verification:
|
||||
- kind: integration
|
||||
ref: "modules/postcard/editor_smoke_test.go#TestMailEditorSmoke (samples, walker, validate, preview, send_draft, hash, locale, sync, reset)"
|
||||
status: pass
|
||||
human_judgment: false
|
||||
- id: D4
|
||||
description: "attach.AbsolutePublicURL builds an absolute public URL from configuration alone"
|
||||
requirement: "D-19"
|
||||
verification:
|
||||
- kind: unit
|
||||
ref: "modules/postcard/brand_smoke_test.go#TestMailBrandSmoke/absolute_url"
|
||||
status: pass
|
||||
human_judgment: false
|
||||
- id: D5
|
||||
description: "Branding: compiled brand CSS replaces mail.brandCss once the settings row exists, mail.css still follows, layouts get logoUrl built at send time, and the editor previews and validates a Branding draft"
|
||||
requirement: "D-11"
|
||||
verification:
|
||||
- kind: integration
|
||||
ref: "modules/postcard/brand_smoke_test.go#TestMailBrandSmoke (defaults, compile, preview, precedence, logo)"
|
||||
status: pass
|
||||
human_judgment: false
|
||||
- id: D6
|
||||
description: "Existing mail renders unchanged when no override exists: the default layout file is untouched and the consumer plugins' mail tests pass against this checkout"
|
||||
verification:
|
||||
- kind: unit
|
||||
ref: "go test -short ./modules/postcard (TestMailRenderSmoke, TestMailLayoutSmoke, TestMailRecipientsAndSafety unchanged)"
|
||||
status: pass
|
||||
- kind: other
|
||||
ref: "(cd ../sm-user-plugin && go test -run 'TestMail|TestPolishMailSubjects' ./...) and (cd ../sm-paymentgateway-plugin && go test -run 'TestMailCatalog|TestMailTracer|TestMailersMatrixSmoke' ./...)"
|
||||
status: pass
|
||||
- kind: other
|
||||
ref: "git diff a024280 --stat -- modules/postcard/assets/default.htm (empty)"
|
||||
status: pass
|
||||
human_judgment: false
|
||||
- id: D7
|
||||
description: "READMEs and docs pages describe the new API, the mail tables, partials, sample values, the editor and Branding accurately and readably"
|
||||
verification:
|
||||
- kind: other
|
||||
ref: "go test ./cmd/summer -run 'TestCommandsDocumented|TestDocsTree' and summer docs:build --check (identifiers, links, anchors)"
|
||||
status: pass
|
||||
human_judgment: true
|
||||
rationale: "The docs checker proves identifiers and links exist, not that the prose is correct and clear; config keys are reviewed by hand per CLAUDE.md"
|
||||
|
||||
# Metrics
|
||||
duration: 55 min
|
||||
completed: 2026-11-13
|
||||
status: complete
|
||||
---
|
||||
|
||||
# Phase 35 Plan 01: Mail domain layer in postcard Summary
|
||||
|
||||
**postcard now owns the mail tables and reads template, layout, partial and Branding overrides from Postgres on every send, with file fallback, a partials capability, sample-value placeholders and an Editor that validates, previews and test-sends drafts through the send path**
|
||||
|
||||
## Performance
|
||||
|
||||
- **Duration:** 55 min (this continuation; the Task 1 checkpoint was handled by the previous agent)
|
||||
- **Started:** 2026-11-13T09:15:32Z
|
||||
- **Completed:** 2026-11-13T10:10:00Z
|
||||
- **Tasks:** 5 of 5 (Task 1 decision checkpoint, Tasks 2-5 executed)
|
||||
- **Files modified:** 30 (18 created, 12 modified)
|
||||
|
||||
## Task 1 answer (recorded verbatim)
|
||||
|
||||
The user's response to the Task 1 decision checkpoint: **"as-planned (Recommended)"**
|
||||
|
||||
Adopted without adjustment: P35-01 (schema), P35-02 (partial call syntax; built-in partials button, panel, table, subcopy; built-in layouts default, system, minimal), P35-03 (`sample.*` dotted header keys), P35-04 (layout CSS slot and `logoUrl`), P35-05 (permission codes, controller IDs, row states, routes, test-send limit, image picker upload rule) and the reset semantics as written in the plan's objective.
|
||||
|
||||
## Accomplishments
|
||||
|
||||
- **Database overrides with file fallback (Task 2, tracer).** `postcard.Migrations` creates the five `system_mail_*` tables; lagoon runs it as the framework set `summercms.postcard` after `summercms.attach`. `Mailer.Send` asks an `OverrideSource` once per message; `NewDBSource` looks the `*gorm.DB` up on the app per call and caches nothing. No database, missing tables, a failed lookup or an override that does not render or fails the safety checks sends the file version.
|
||||
- **Partials and built-in layouts (Task 3).** `pact.HasMailPartials` (additive; `HasMailTemplates` is byte-identical), `Catalog.RegisterPartials`, the `partial` template func in bodies and layouts, `markdown` inside partials, built-in partials and the `system` and `minimal` layouts. Customized and database-only layouts and customized partials apply at send.
|
||||
- **Samples, hashes, index rows and the Editor (Task 4).** `sample.<path>` header keys, a parse-tree walker that fills every other variable with `[path]`, sha256 hashes of CRLF-normalized files, `SyncIndex`, `ResetOverride`, and `Editor.Validate`, `Preview` and `SendDraft`.
|
||||
- **Branding (Task 5).** `attach.AbsolutePublicURL`, `Brand`, `DefaultBrand`, `CompileBrandCSS`, the `logoUrl` layout key, the D-11 precedence over `mail.brandCss`, and the Branding draft in the Editor.
|
||||
|
||||
## Task Commits
|
||||
|
||||
1. **Task 1: decision checkpoint**: no commit (answer recorded above)
|
||||
2. **Task 2: database overrides (tracer)**: `7e5d2c7` (feat)
|
||||
3. **Task 3: partials, built-in layouts, layout and partial overrides**: `5df1ec2` (feat)
|
||||
4. **Task 4: samples, hashes, index sync, draft editor**: `495319e` (feat)
|
||||
5. **Task 5: Branding**: `935e4bf` (feat(attach)), then `2bf9081` (feat(postcard))
|
||||
|
||||
**Plan metadata:** committed together with this summary (docs).
|
||||
|
||||
Commit subjects are the ones the plan's "Execution units" table fixes; each body ends with "Plan 35-01, task N". The measured commit count since the plan's base is 6: `f8fa0f1 docs(31): capture phase context` was committed on master by another session during this run and is not part of this plan.
|
||||
|
||||
## Verification results
|
||||
|
||||
| Check | Result |
|
||||
|-------|--------|
|
||||
| `go vet ./... && go test -short ./...` | pass (after every commit) |
|
||||
| `go test ./modules/postcard/... ./modules/lagoon/... ./modules/pact/...` (Docker) | pass |
|
||||
| `TestMailOverrideSmoke`, `TestMailPartialsSmoke`, `TestMailEditorSmoke`, `TestMailBrandSmoke` | pass, no skips without `-short` |
|
||||
| `go test ./cmd/summer -run 'TestCommandsDocumented\|TestDocsTree'`, `summer docs:build --check` | pass ("no problems found") |
|
||||
| `cd examples/hello && go test ./...` | pass |
|
||||
| sm-user-plugin `TestMail\|TestPolishMailSubjects` | pass, working tree unchanged |
|
||||
| sm-paymentgateway-plugin `TestMailCatalog\|TestMailTracer\|TestMailersMatrixSmoke` | pass, working tree unchanged |
|
||||
| Every task's acceptance criteria | pass |
|
||||
| Tracer gate after Task 2 (interactive, end-of-phase, automated-only verify) | re-run, pass, continued without a checkpoint |
|
||||
|
||||
Not committed, run once as a scratch check: the placeholder walker rendered all 172 real template files found in the sibling plugin repositories without error (research Pitfall 3).
|
||||
|
||||
## Names for 35-02, 35-03 and 35-04
|
||||
|
||||
Every name fixed by P35-01..P35-05 is as the plan states. Names and behaviours the plan left open, or where the code is more specific than the plan's text:
|
||||
|
||||
- **Partial token:** `MAILPARTIAL` + 32 upper-case hex digits + `X<n>X` (the plan wrote `MAILPARTIAL<nonce><n>`); the terminator keeps one token from being a prefix of another.
|
||||
- **Index on templates:** `system_mail_templates_layout_id_index`.
|
||||
- **`postcard.Kind` values:** `"template"`, `"layout"`, `"partial"`, `"brand"`.
|
||||
- **`DraftError.Rule` values:** `parse`, `render`, `unsafe`, `subject_line`, `layout`, `partial`, `no_content`, `colour`. A `partial` call with an odd argument count or a non-string key is `render`, not `partial`; `partial` is only "no such partial" and sets `Name`.
|
||||
- **`DraftError.Field` for Branding:** the colour's column name (`body_bg` ... `table_border_color`); `Message` is empty for `colour`, `layout`, `no_content` and `subject_line`.
|
||||
- **`Draft`:** `Layout` empty on a template draft keeps the file's layout. A layout draft with an empty `Name` is rendered under the code `draft`. A Branding draft uses `Draft.Brand`; nil is the default brand.
|
||||
- **Template drafts need a catalog template:** `Validate` and `Preview` of a `KindTemplate` draft whose `Name` is not registered return rule `render` on `body`.
|
||||
- **`TemplateLocale`:** matches the longest listed locale after a dash in the last dotted segment, ignoring case, and returns it as spelled in `locales` (so `-pt-BR` works).
|
||||
- **`FormatLayout`:** a non-empty `css` is appended as a fourth `==` section, for display and comparison only (layout files have no CSS section).
|
||||
- **`SyncIndex`:** serialized by `pg_advisory_xact_lock(hashtext('summercms.postcard.sync'))`; a row that already matches is not written, so `updated_at` does not move. It returns an error when the tables are missing (35-02 retries on the first list request, as planned).
|
||||
- **`ResetOverride`:** returns an error for a code the catalog does not hold, for a database-only layout, for `KindBrand`, and when no file-backed row has that code.
|
||||
- **Layout name:** `SyncIndex` always sets `name` from the file header for file layouts and partials, as the plan says, so `name` is not an override column for them.
|
||||
- **Sample message:** `assets/sample.htm`, parsed as `postcard::mail.sample`; it is not registered in the catalog and cannot be sent by name.
|
||||
- **Smoke test names:** `TestMailOverrideSmoke`, `TestMailPartialsSmoke`, `TestMailEditorSmoke`, `TestMailBrandSmoke`. The `-run` patterns in 35-VALIDATION.md (`TestOverride`, `TestStore`, `TestPartial`, `TestSample`, `TestValidateDraft`, `TestBrand`, `TestSync`) match none of them; 35-04 either adds tests under those names or updates the map.
|
||||
- **Test helper:** `mailPostgres(t)` in `override_smoke_test.go` gives each caller a fresh migrated database on one shared container.
|
||||
|
||||
## Decisions Made
|
||||
|
||||
- **The override-failure log is written only when the file version then renders.** The plan orders "log, then render the file version". When both renders fail (a caller subject with a line break, for example) the cause is the caller's, so the file version's error is returned and nothing claims a file version was sent.
|
||||
- **`Validate` checks a template body's source for script, iframe, object and embed tags** in addition to the rendered output. Markdown drops such a tag silently at send, so without the source check the behaviour the plan lists ("`<script>` gives rule unsafe") could not occur for a template body.
|
||||
- **Branding is part of the file version.** `Overrides.empty()` ignores `Brand`, and the fallback render keeps the compiled CSS and logo.
|
||||
- **Logo problems travel as warnings on `Overrides`** (an unexported field) and are logged by the mailer through its rate limiter, so the source needs no logger. The files table is read under a savepoint, so a failure there does not lose the other overrides.
|
||||
- **`NewDBSource` silences GORM's logger for its own queries.** The mailer reports a failed lookup once a minute; GORM's line per send would repeat it.
|
||||
- **Typed errors keep send texts unchanged.** `renderError`, `tmplError`, `unsafeError` and `partialError` print what the old `fmt.Errorf` calls printed.
|
||||
|
||||
## Deviations from Plan
|
||||
|
||||
### Auto-fixed Issues
|
||||
|
||||
None. No bug, missing critical piece or blocker outside the plan's text came up.
|
||||
|
||||
### CLAUDE.md-driven adjustments
|
||||
|
||||
**1. [Rule 2 - CLAUDE.md] No separate RED commits for the `tdd="true"` tasks**
|
||||
- **Found during:** Tasks 3, 4 and 5
|
||||
- **Issue:** The MSD TDD flow commits a failing test first. CLAUDE.md requires `go vet` and `go test` green at every commit, and the plan's "Execution units" table fixes one commit per task.
|
||||
- **Adjustment:** Tests were written before the implementation and each task was committed once, green.
|
||||
- **What was and was not observed:** For Task 3 and Task 5 the test was run against signature-only stubs first and every target subtest failed on its assertions. For **Task 4 no RED run was observed**: the implementation was written straight after the test file and passed on the first run. To check that those tests can fail, five mutations were applied afterwards (placeholder format, sync overwriting a customized subject, sync always writing, hash without CRLF normalization, editor keeping the stored template override); each was caught by the expected subtest and reverted. No `tdd-red-evidence` records were persisted.
|
||||
|
||||
### Plan inconsistencies (reported, not changed)
|
||||
|
||||
- **`key_links` names `modules/postcard/brand.go` for `attach.AbsolutePublicURL`.** The Task 5 action and its acceptance criterion put the call in `NewDBSource`, so it is in `modules/postcard/store.go`. `brand.go` does not contain the pattern; a mechanical key-link check will report it.
|
||||
- **`pact.ListRowStates` doc comment now says five constants are kept**, as the plan instructs. cabana's `rowStateOrder` still lists three and drops the two new ones until 35-02 changes it; `docs/backend/lists-and-filters.md` still describes three and is 35-02's to update.
|
||||
|
||||
---
|
||||
|
||||
**Total deviations:** 1 CLAUDE.md-driven adjustment (commit shape of TDD tasks), 0 auto-fixes.
|
||||
**Impact on plan:** None on scope or API. The TDD evidence is weaker than the MSD reference asks for on Task 4.
|
||||
|
||||
## Issues Encountered
|
||||
|
||||
- **One unrelated test failure under load.** `modules/pier` `TestStatelessFanOut` failed once in the first full `go test -short ./...` run and passed alone and in five later full runs. Logged in `deferred-items.md`; not investigated.
|
||||
- **A hung background command of my own.** A mutation-check script stalled on the shell's interactive `cp` alias while `modules/postcard/samples.go` held a deliberate mutation. I stopped that script (my own two processes), restored the file from the backup taken at the start of the script, confirmed all four backed-up files were identical to their backups, and re-ran the checks non-interactively. Nothing mutated was committed.
|
||||
- **A concurrent commit on master.** Another session committed `f8fa0f1` between Task 4 and Task 5. It touches only Phase 31 planning files.
|
||||
|
||||
## Threat Flags
|
||||
|
||||
| Flag | File | Description |
|
||||
|------|------|-------------|
|
||||
| threat_flag: mail-relay | modules/postcard/editor.go | `Editor.SendDraft` delivers to whatever single address it is given and applies no recipient rule or rate limit. The plan assigns both to the caller (35-02: the admin's own address, 5 per 10 minutes); until that route exists nothing calls it. |
|
||||
| threat_flag: dependency-surface | modules/postcard/store.go | postcard now imports `modules/lagoon/attach` (as the plan specifies), which brings gocloud blob and the imaging packages into postcard's import graph. No new module in go.mod. |
|
||||
|
||||
The threat register's mitigations are in place: validateHTML on bodies, partial outputs and the final HTML (T-35-01); per-render crypto/rand nonce (T-35-02); CR/LF refusal and rule `subject_line` (T-35-03); strict hex colours and the closing-style check on layout CSS (T-35-04); file version on any lookup error (T-35-05); scrubbed `DraftError.Message` (T-35-06); logo URL from operator config only (T-35-07); no cache (T-35-08).
|
||||
|
||||
## Known Stubs
|
||||
|
||||
None.
|
||||
|
||||
## User Setup Required
|
||||
|
||||
None. No external service or new configuration key. An application picks up the new tables with its next `migrate`.
|
||||
|
||||
## Next Phase Readiness
|
||||
|
||||
- 35-02 can build on the API as listed in its `<interfaces>` block; its precondition (`feat(postcard): mail branding and the logo URL` in the log, `func EditorFrom` in `editor.go`) holds.
|
||||
- 35-02 owns: cabana's `rowStateOrder`, messages and `docs/backend/lists-and-filters.md` for the two new row states; the serve-start `SyncIndex` call; the recipient rule and rate limit around `SendDraft`.
|
||||
- Nothing was pushed or tagged. No file in a sibling repository was changed.
|
||||
|
||||
## Self-Check: PASSED
|
||||
|
||||
- All 18 created files exist on disk.
|
||||
- Commits `7e5d2c7`, `5df1ec2`, `495319e`, `935e4bf`, `2bf9081` are in `git log`.
|
||||
- `must_haves.artifacts` patterns are present in their files; of the four `key_links`, three match and the `brand.go` one does not (see "Plan inconsistencies").
|
||||
|
||||
---
|
||||
*Phase: 35-mail-templates-and-layouts-editor*
|
||||
*Completed: 2026-11-13*
|
||||
@@ -0,0 +1,10 @@
|
||||
# Phase 35: deferred items
|
||||
|
||||
Out-of-scope discoveries made while executing Phase 35 plans. Not fixed here.
|
||||
|
||||
## Deferred Items
|
||||
|
||||
- `modules/pier` `TestStatelessFanOut` failed once under the full `go test -short ./...` run during 35-01
|
||||
status: open
|
||||
**What:** subtest "a stateless-only instance applies a revocation from the other instance" reported "B never evicted its stateless server: the revocation did not reach it" after its 10 s wait. It passed when the package was run alone and in every later full run (five more). It looks timing-sensitive under parallel package load.
|
||||
**Why deferred:** pier is unrelated to the mail work; 35-01 changed nothing it uses at run time.
|
||||
Reference in New Issue
Block a user