diff --git a/.planning/phases/16.3-backend-admin-personal-api-tokens-with-scopes/16.3-REVIEW-DISPOSITION.md b/.planning/phases/16.3-backend-admin-personal-api-tokens-with-scopes/16.3-REVIEW-DISPOSITION.md new file mode 100644 index 0000000..e560b93 --- /dev/null +++ b/.planning/phases/16.3-backend-admin-personal-api-tokens-with-scopes/16.3-REVIEW-DISPOSITION.md @@ -0,0 +1,38 @@ +--- +phase: 16.3 +review: 16.3-REVIEW.md +titles: json +findings: + - id: WR-01 + severity: warning + disposition: open + title: "TestPhase10Coverage golden list omits account token routes" + - id: WR-02 + severity: warning + disposition: open + title: "Create dialog Submit enabled with zero scopes selected" + - id: IN-01 + severity: info + disposition: open + title: "last_used_at in-process debounce stores success before the DB write" + - id: IN-02 + severity: info + disposition: open + title: "Create-dialog scope checkboxes lack associated accessible names beyond the wrapping label" +open: 4 +total: 4 +recorded: 2026-10-11T11:48:56.057Z +--- + +# Phase 16.3: Code Review Disposition + +| Finding | Severity | Disposition | Source | +|---------|----------|-------------|--------| +| WR-01 | warning | open | - | +| WR-02 | warning | open | - | +| IN-01 | info | open | - | +| IN-02 | info | open | - | + +Dispositions: `open` (recorded, not yet triaged), `fixed`, `skipped`, `deferred`. +Set `deferred` by hand and put the reason in the Source cell; both are preserved. A `|` in the reason is kept as prose and escaped on the next run. +Re-running the gate keeps every row it can. A row the current review no longer reports is kept and its Source cell flagged, so a finding does not leave this record silently. ONE exception: when a finding id is REUSED by a different finding, the earlier decision cannot keep a row — the id is taken — and it is dropped. A RECORDED decision (anything but `open`) is named on the console when that happens; a row still at `open` is replaced silently, because `open` records no decision to lose.