test(06-14): fetchguard IANA boundary and zoned dial tests, surf edge coverage

surf/bodylimit_test.go

@@ -267,3 +267,17 @@ func TestBodyLimitBoundsBodyConsumingMiddleware(t *testing.T) {
 		}
 	})
 }
+
+func TestBodyLimitInvalidParamFailsBoot(t *testing.T) {
+	for _, param := range []string{"abc", "0", "-5", ""} {
+		t.Run(param, func(t *testing.T) {
+			cfg := writeHTTPConfig(t, "body_limits:\n  default_bytes: 4\n  upload_bytes: 8\n")
+			_, err := Assemble(backpack.New(cfg), []party.Plugin{bodyProbePlugin{
+				id: "golem15.probe", use: []string{"body.limit:" + param},
+			}})
+			if err == nil || !strings.Contains(err.Error(), "body.limit") {
+				t.Fatalf("err = %v", err)
+			}
+		})
+	}
+}

surf/limiter_test.go

@@ -471,3 +471,22 @@ func TestMiddlewareFailsClosed(t *testing.T) {
 		})
 	}
 }
+
+func TestRegisterBucketRejectsNilLimiterEmptyNameAndDuplicate(t *testing.T) {
+	key := func(*http.Request) string { return "k" }
+	good := Bucket{Max: 1, Decay: time.Minute, Key: key}
+	var nilLim *FixedWindowLimiter
+	if err := nilLim.RegisterBucket("p", "n", good); err == nil {
+		t.Fatal("nil limiter accepted")
+	}
+	l := NewFixedWindowLimiter(NewMemoryStore(time.Minute), nil)
+	if err := l.RegisterBucket("p", "", good); err == nil {
+		t.Fatal("empty name accepted")
+	}
+	if err := l.RegisterBucket("p", "n", good); err != nil {
+		t.Fatal(err)
+	}
+	if err := l.RegisterBucket("q", "n", good); err == nil || !strings.Contains(err.Error(), "p") {
+		t.Fatalf("duplicate: %v", err)
+	}
+}