fix(09): WR-12 time a missing admin login at the configured bcrypt cost
This commit is contained in:
@@ -9,6 +9,7 @@ import (
|
||||
"net"
|
||||
"net/http"
|
||||
"strings"
|
||||
"sync"
|
||||
"time"
|
||||
|
||||
"git.golem15.com/golem15/summercms/modules/backpack"
|
||||
@@ -142,7 +143,7 @@ func (s *service) login(w http.ResponseWriter, r *http.Request) {
|
||||
WriteError(w, http.StatusInternalServerError, "error", msgServerError)
|
||||
return
|
||||
}
|
||||
hash := dummyPasswordHash
|
||||
hash := s.missingUserHash()
|
||||
if found && user.Password != "" {
|
||||
hash = user.Password
|
||||
}
|
||||
@@ -496,11 +497,23 @@ func adminIssuer(app *backpack.App, prefix string) string {
|
||||
return base + prefix + adminAPIVersion + "/auth/login"
|
||||
}
|
||||
|
||||
// dummyPasswordHash keeps a missing-user login on the bcrypt path.
|
||||
var dummyPasswordHash = func() string {
|
||||
hash, err := bouncer.HashPassword(10, "cabana-invalid-credentials")
|
||||
if err != nil {
|
||||
return ""
|
||||
// missingHashes caches the unknown-login hash per bcrypt cost.
|
||||
var missingHashes sync.Map
|
||||
|
||||
// missingUserHash is the hash a login for an unknown (or ambiguous) identifier
|
||||
// is checked against, so it costs the same bcrypt work as a real admin's. It is
|
||||
// built once per cost at the service's configured cost, the cost stored hashes
|
||||
// are rehashed to on login.
|
||||
func (s *service) missingUserHash() string {
|
||||
cost := s.bcryptCost
|
||||
if cached, ok := missingHashes.Load(cost); ok {
|
||||
return cached.(string)
|
||||
}
|
||||
return hash
|
||||
}()
|
||||
hash, err := bouncer.HashPassword(cost, "cabana-invalid-credentials")
|
||||
if err != nil {
|
||||
// An unusable cost: fall back to the default, still on the bcrypt path.
|
||||
hash, _ = bouncer.HashPassword(10, "cabana-invalid-credentials")
|
||||
}
|
||||
actual, _ := missingHashes.LoadOrStore(cost, hash)
|
||||
return actual.(string)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user