golem15/summercms
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(05): WR-03 numeric between/min/max without omitempty or length tags

Browse Source
This commit is contained in:
Jakub Zych
2026-09-19 15:33:16 +02:00
parent e54f9d7f10
commit fb12b2237d
2 changed files with 91 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
lagoon/validate_test.go
View File

@@ -35,9 +35,10 @@ func TestValidateIntegerPointerAndJSONNumber(t *testing.T) {
year := 1991
var nilYear *int
pass := map[string]any{
"*int": &year,
"nil *int": nilYear,
"float64": float64(1991),
"*int": &year,
"nil *int": nilYear,
"float64": float64(1991),
"digit string": "1991",
}
for name, val := range pass {
errs, err := Validate(t.Context(), nil, nil, rules, map[string]any{"year": val}, nil)
@@ -48,12 +49,17 @@ func TestValidateIntegerPointerAndJSONNumber(t *testing.T) {
t.Fatalf("%s must pass, got %v", name, errs)
}
}
zero := 0
early := 1700
fail := map[string]any{
"fractional float": 1991.5,
"out of range *int": &early,
"bool": true,
"non-digit string": "19x1",
"int 0": 0,
"float64 0": float64(0),
"*int 0": &zero,
"string 0": "0",
}
for name, val := range fail {
errs, err := Validate(t.Context(), nil, nil, rules, map[string]any{"year": val}, nil)
@@ -100,6 +106,13 @@ func TestValidateMoneyRange(t *testing.T) {
if len(errs) != 0 {
t.Fatalf("25.0000 = %v", errs)
}
errs, err = Validate(t.Context(), nil, nil, rules, map[string]any{"market_price_stored": 0}, nil)
if err != nil {
t.Fatal(err)
}
if len(errs) != 0 {
t.Fatalf("numeric 0 must pass min:0, got %v", errs)
}
errs, err = Validate(t.Context(), nil, nil, rules, map[string]any{"market_price_stored": nil}, nil)
if err != nil {
t.Fatal(err)